This example has dependency with the following bug fix:
https://patches.linaro.org/46130/
Regards,
Bala
On 20 March 2015 at 12:37, bala.manoha...@linaro.org wrote:
From: Balasubramanian Manoharan bala.manoha...@linaro.org
ODP Classifier example
This programs gets pmr rules as command-line
From: Balasubramanian Manoharan bala.manoha...@linaro.org
Fix for incorrect pmr_term_value update in odp_pmr_create_match() and
odp_pmr_create_range() functions.
Fixes https://bugs.linaro.org/show_bug.cgi?id=1381
Signed-off-by: Balasubramanian Manoharan bala.manoha...@linaro.org
---
From: Balasubramanian Manoharan bala.manoha...@linaro.org
ODP Classifier example
This programs gets pmr rules as command-line parameter and configures the
classification engine
in the system.
This initial version supports the following
* ODP_PMR_SIP_ADDR pmr term
* PMR term MATCH and RANGE
On 11 March 2015 at 18:31, Ciprian Barbu ciprian.ba...@linaro.org wrote:
So after a little chat we had, Maxim suggested I remove the ioctl code
that needs struct ifreq. There is a USE_MAC_ADDR_HACK define in
odp_ipsec that is now set to 1, removing all that code should fix the
problem.
The
Reviewed-by: Balasubramanian Manoharan bala.manoha...@linaro.org
On 10 March 2015 at 00:49, Mike Holmes mike.hol...@linaro.org wrote:
On 8 March 2015 at 18:52, Bill Fischofer bill.fischo...@linaro.org wrote:
Signed-off-by: Bill Fischofer bill.fischo...@linaro.org
For the series
From: Balasubramanian Manoharan bala.manoha...@linaro.org
Destroys pktio default inqueue for a clean odp_classification_term_global()
Fixes https://bugs.linaro.org/show_bug.cgi?id=1281
Signed-off-by: Balasubramanian Manoharan bala.manoha...@linaro.org
---
From: Balasubramanian Manoharan bala.manoha...@linaro.org
odp_pktio_skip_set() value is reset to zero as the validation suite expects
the skip value to be zero.
Fixes https://bugs.linaro.org/show_bug.cgi?id=1230
Signed-off-by: Balasubramanian Manoharan bala.manoha...@linaro.org
---
On 26 February 2015 at 03:43, Anders Roxell anders.rox...@linaro.org wrote:
why does it say linux-generic: classification: ...
should say: api: classification: ...
This is not an api change just adds documentation for PMR_INVAL and
PMR_SET_INVAL macros
Not sure if this should be also api:
On 26 February 2015 at 03:40, Mike Holmes mike.hol...@linaro.org wrote:
Why is this merged - I have undressed comments ?
/**
+ * @def ODP_PMR_INVAL
+ * Invalid odp_pmr_t value.
+ * This value is returned from odp_pmr_create_match() and
+ * odp_pmr_create_range() functions on failure.
From: Balasubramanian Manoharan bala.manoha...@linaro.org
Fix for return value checking of odp_pool_destroy() function reported by
Coverity.
https://bugs.linaro.org/show_bug.cgi?id=1142
Signed-off-by: Balasubramanian Manoharan bala.manoha...@linaro.org
---
From: Balasubramanian Manoharan bala.manoha...@linaro.org
Fixes uninitialized scalar variable qos_tbl in configure_cos_with_l2_priority()
function reported by Coverity.
https://bugs.linaro.org/show_bug.cgi?id=1143
Signed-off-by: Balasubramanian Manoharan bala.manoha...@linaro.org
---
From: Balasubramanian Manoharan bala.manoha...@linaro.org
Fixes an issue where ipv4 checksum field was not updated after modifying the src
addr of the packet.
https://bugs.linaro.org/show_bug.cgi?id=1231
Signed-off-by: Balasubramanian Manoharan bala.manoha...@linaro.org
---
v2: updates review
From: Balasubramanian Manoharan bala.manoha...@linaro.org
Fixes an issue where ipv4 checksum field was not updated after modifying the src
addr of the packet.
Signed-off-by: Balasubramanian Manoharan bala.manoha...@linaro.org
---
test/validation/classification/odp_classification_tests.c | 10
From: Balasubramanian Manoharan bala.manoha...@linaro.org
odp_pmr_match_count() API related to statistics count of PMR has been moved out
of ODP 1.0
version and the same will be incorporated once an ODP level common statistics
counter design has
been achieved.
Signed-off-by: Balasubramanian
From: Balasubramanian Manoharan bala.manoha...@linaro.org
odp_pmr_match_count() API related to statistics count of PMR has been moved out
of ODP 1.0
version and the same will be incorporated once an ODP level common statistics
counter design has
been achieved.
Signed-off-by: Balasubramanian
From: Balasubramanian Manoharan bala.manoha...@linaro.org
Classification validation consists of two suites
* classification basic
This suite tests the basic classification APIs for creation and
deletion of various PMRs and CoS.
* classification test
This suite tests
From: Balasubramanian Manoharan bala.manoha...@linaro.org
This validation consists of two suites
* classification basic
This suite tests the basic classification APIs for creation and
deletion of various PMRs and CoS.
* classification test
This suite tests behavious of
From: Balasubramanian Manoharan bala.manoha...@linaro.org
Fixes the error in vlan qos calculation due to missing convertion of
odp_be_to_cpu_16()
Signed-off-by: Balasubramanian Manoharan bala.manoha...@linaro.org
---
platform/linux-generic/odp_classification.c | 4 ++--
1 file changed, 2
Thanks Shmulik!
Reviewed-by: Bala Manoharan bala.manoha...@linaro.org
On 11 January 2015 at 23:02, Bill Fischofer bill.fischo...@linaro.org
wrote:
Thanks!
On Sun, Jan 11, 2015 at 4:15 AM, Shmulik Ladkani
shmulik.ladk...@gmail.com wrote:
ODP_{BIG,LITTLE}_ENDIAN_BITFIELD were always
On Wed, Dec 10, 2014 at 12:54:38PM +0200, Ciprian Barbu wrote:
On Tue, Dec 9, 2014 at 7:53 PM, Bill Fischofer
bill.fischo...@linaro.org wrote:
If you've already received the packet there's not much point in classifying
it since the output of classification is the queue that the packet should
Hi,
In case of synchronous crypto operation the completion event is need only
in case of an error hence the application can check the return code for
failure and get info from completion event buffer only during that
scenario. This will greatly optimize the performance in synchronous crypto
I have only a few minor comments for this patch.
One major query is that Currently this patch does not integrate
headroom/tailroom at segment level
is the feature available in 1.0?
if it is needed to be supported then we need some modifications in segment
handling.
Regards,
Bala
On Tue, Dec 02,
Hi,
I agree with Victor's concern, implementation needs a mechanism to know
what is the amount of valid memory available in the mac_addr pointer.
If I am not wrong the idea of defining the ODP_PKTIO_MAC_ADDR_MAX_LEN was
initially discussed but the same was dropped as there were concerns since
Ping
On 26 November 2014 at 11:07, Bala Manoharan bala.manoha...@linaro.org
wrote:
Hi,
Pls let me know if there are any additional comments for this patch.
If otherwise please provide reviewed-by
Regards,
Bala
On 25 November 2014 03:24, Anders Roxell anders.rox...@linaro.org wrote
Yes. But for testing the basic pktio APIs which I believe is Maxim's
requirement it can be done using loopback interface (configuring a HW
interface as loop is an implementation detail) so that there is no need for
any HW configuration as such while running the validation suite.
Packet classifier
Hi Mike,
As you know these classification patches was submitted as being
interdependent on each other.
But sure I can redo this specific patch to be independently compilable unit.
Also it would be great if I could get review comments on classification
implementation patches so that I can fix any
wrote:
On 11/25/2014 12:34 AM, Mike Holmes wrote:
This no longer applies, can you rebase it ?
git am -3
helps?
On 21 November 2014 08:30, Bala Manoharan bala.manoha...@linaro.org
wrote:
Hi Maxim,
As discussed, as per the current API a pktio can exist without
Hi,
The concern I had with the above testing scenario is that IMO this scenario
does not match perfectly with an application usecase. The testing for
ORDERED queue in my opinion could be,
1. Dequeue work W1-W10 from ORDERED queue Q1
2. Enqueue work W1-W5 to ORDERED queue Q2
3. Enqueue work
On 21 November 2014 17:41, Maxim Uvarov maxim.uva...@linaro.org wrote:
On 11/21/2014 11:53 AM, Balasubramanian Manoharan wrote:
+cos_t *pktio_select_cos(pktio_entry_t *entry, uint8_t *pkt_addr,
+ odp_packet_hdr_t *pkt_hdr)
+{
+ pmr_t *pmr;
+ cos_t *cos =
November 2014 18:18, Maxim Uvarov maxim.uva...@linaro.org wrote:
On 11/21/2014 03:32 PM, Bala Manoharan wrote:
Hi Maxim,
Can we have those as separate patches.
I would like to keep this patch as specific for linking pktio with
classification.
I have created this patch from the current odp
Few points,
* Inorder to check ordered state of buffers from second queue they should
be dequeued by a single thread
as scheduler will despatch the buffers from ORDERED queue in initial order
but more than one thread can get the buffer from the same queue at the same
time.
Begards,
Bala
On 21
Thanks Ciprian.
Regards,
Bala
On 19 November 2014 18:36, Ciprian Barbu ciprian.ba...@linaro.org wrote:
Hi,
I used this tool for sending packets in batch mode, used it during OVS
work.
Here is a link:
http://packeth.sourceforge.net/packeth/Home.html
I believe it's going to be really
inlining?
On Fri, Oct 31, 2014 at 2:08 AM, Bala Manoharan
bala.manoha...@linaro.org wrote:
Hi Anders,
Yesterday in Scheduler meeting we had a discussion regarding moving
typedefs in ODP API files into a separate file.
Taras mentioned that you had previously spent some time on the same.
Can
Hi,
odp_packet_offset_map() API should be used generally if the application
wants to read a specific byte in a packet or
maybe to read any byte in a custom protocol.
odp_packet_l2_map() and odp_packet_l3_map() will be used to get the start
address of l2 and l3 layer.
Regards,
Bala
On 29
...@lists.linaro.org [mailto:lng-odp-
boun...@lists.linaro.org] On Behalf Of Ciprian Barbu
Sent: Tuesday, October 14, 2014 3:32 PM
To: Bala Manoharan
Cc: Savolainen, Petri (NSN - FI/Espoo); lng-odp@lists.linaro.org
Subject: Re: [lng-odp] [ODP/PATCH v6] API support for querying mac
address
On Mon
Hi,
We have followed the syntax of defining the opaque handles as typedefs
uint32_t (eg odp_cos_t ) and it seemed to create
a misunderstanding when defining odp_pmr_t and odp_pmr_set_t as structures
when the same are also opaque handles.
I believe this creates a uniform syntax across the whole
at 2:45 AM, Bala Manoharan bala.manoha...@linaro.org
wrote:
Hi,
We have followed the syntax of defining the opaque handles as typedefs
uint32_t (eg odp_cos_t ) and it seemed to create
a misunderstanding when defining odp_pmr_t and odp_pmr_set_t as
structures when the same are also opaque
, Bala Manoharan bala.manoha...@linaro.org
wrote:
Sounds Fair. Just a suggestion from my side should we replace typedef
... odp_objtype_t with typedef platform_handle odp_objtype_t. I am ok
with both approach whichever fits best.
Regards,
Bala
On 17 October 2014 15:50, Bill Fischofer
Yes. I will take this as part during the implementation patch.
We may need to fix the same for odp_queue.h and odp_packet_io.h files also.
Regards,
Bala
On 16 October 2014 23:15, Mike Holmes mike.hol...@linaro.org wrote:
On 16 October 2014 11:26, Balasubramanian Manoharan
Hi,
I have resent this patch with UTF-8 encoding.
Regards,
Bala
On 17 October 2014 16:50, Maxim Uvarov maxim.uva...@linaro.org wrote:
On 10/16/2014 07:26 PM, Balasubramanian Manoharan wrote:
+ * @param[in] val_sz Size of the ‘val’ and ‘mask’ arguments,
+ * that must
Hi,
Pls find my comments inline.
Regards,
Bala
On 12 October 2014 23:06, Anders Roxell anders.rox...@linaro.org wrote:
Couple of nits see comments inline.
On 2014-10-07 21:45, Balasubramanian Manoharan wrote:
v2: This patch incorporates mike's review comments
This shouldn't be here
.
-Petri
*From:* lng-odp-boun...@lists.linaro.org [mailto:
lng-odp-boun...@lists.linaro.org] *On Behalf Of *ext Bala Manoharan
*Sent:* Friday, October 10, 2014 10:00 AM
*To:* Maxim Uvarov
*Cc:* lng-odp@lists.linaro.org
*Subject:* Re: [lng-odp] [ODP/PATCH v6] API support for querying mac
address
is returned (e.g.
-1).
-- Ola
ETH_ALEN is 6. So looks like patch needed to be update.
Maxim.
On 8 October 2014 19:08, Maxim Uvarov maxim.uva...@linaro.org mailto:
maxim.uva...@linaro.org wrote:
On 10/07/2014 11:47 AM, Bala Manoharan wrote:
On 7 October 2014 12:43
include/api-internal to move these items into?
-Petri
*From:* lng-odp-boun...@lists.linaro.org [mailto:
lng-odp-boun...@lists.linaro.org] *On Behalf Of *ext Bala Manoharan
*Sent:* Tuesday, October 07, 2014 8:41 PM
*To:* Bill Fischofer
*Cc:* lng-odp@lists.linaro.org
*Subject:* Re
On 7 October 2014 12:43, Savolainen, Petri (NSN - FI/Espoo)
petri.savolai...@nsn.com wrote:
-Original Message-
From: lng-odp-boun...@lists.linaro.org [mailto:lng-odp-
boun...@lists.linaro.org] On Behalf Of ext Balasubramanian Manoharan
Sent: Monday, October 06, 2014 7:16 PM
Hi,
Pls see my comments inline.
Regards,
Bala
On 6 October 2014 18:44, Anders Roxell anders.rox...@linaro.org wrote:
On 2014-10-06 15:52, Balasubramanian Manoharan wrote:
This patch provides API support for querying mac address using
odp_pktio_t handle.
This patch incorporates the changes
Hi Mike,
Comments inline.
Regards,
Bala
On 6 October 2014 23:34, Mike Holmes mike.hol...@linaro.org wrote:
On 6 October 2014 12:05, Balasubramanian Manoharan
bala.manoha...@linaro.org wrote:
This patch contains ODP Classification API Header Files.
The intent of this patch is to port
as a
separate discussion if required
* Should I add ODP_UNIMPLEMENTED as part of my current patch?
Regards,
Bala
On 7 October 2014 00:16, Mike Holmes mike.hol...@linaro.org wrote:
On 6 October 2014 14:33, Bala Manoharan bala.manoha...@linaro.org wrote:
Hi Mike,
Comments inline.
Regards
Hi,
IMO, both are fine also I would like to see some guideline as to when to
use destroy and delete accordingly.
So if you create() an entity then its corresponding should be destroy() (ie
in case of BUFFER_POOL)
and if you alloc() an entity then its corresponding should be free() (i.e
in case
Hi Mike,
I would not prefer LOG functions to call abort() on behalf of the
application, this design prevents the applications from calling its
specific clean-up code. coz applications can be written in a way in which
clean-up can be done in a single place at the end of the main function
combining
Yes. I would prefer ODP_ABORT(message) this call can be used by the
application so that there is no need to provide two separate calls for
ODP_ERR and abort().
Regards,
Bala
On 22 September 2014 09:14, Mike Holmes mike.hol...@linaro.org wrote:
On 22 September 2014 11:54, Bala Manoharan
Hi Prashant,
The issue is due to not adding -march=octeon2 which needs to be added
into CFLAGS for compiling for Octeon.
Pls use the following steps for compilation
1. /*Update toolchain in shell PATH variable */
PATH=$toolchain_path/bin:$PATH
2. ./bootstrap
Hi Team,
We will have a Demo dry run on Wednesday afternoon after SC meeting.
Just to make sure things are fine :)
Regards,
Bala
___
lng-odp mailing list
lng-odp@lists.linaro.org
http://lists.linaro.org/mailman/listinfo/lng-odp
] *On Behalf Of *ext Ola Liljedahl
*Sent:* Thursday, September 04, 2014 4:01 PM
*To:* Bala Manoharan; lng-odp@lists.linaro.org
*Subject:* Re: [lng-odp] [PATCH v3 1/1] API support for querying mac
address
I think the prototype should include the size of the buffer as well.
Other types of network
but not for ARMv8.
On platforms with HW queues, the ODP implementation probably has to
perform the barriers explicitly.
On 2 September 2014 17:09, Bala Manoharan bala.manoha...@linaro.org
wrote:
Hi,
IMO, the synchronization can be called by the application as if the
application does it then it can
Hi,
IMO, the synchronization can be called by the application as if the
application does it then it can decide to call sync only when a thread
writes to the shared buffer. whereas if implementation has to do the sync
then it will have to call it every time before scheduler despatches the
buffer.
Reviewed-by: Bala Manoharan bala.manoha...@linaro.org
On 26 August 2014 20:11, Taras Kondratiuk taras.kondrat...@linaro.org
wrote:
On 08/25/2014 11:47 PM, Robbie King wrote:
Hello all,
Here is the refactored IPsec example application.
V1: Changes from the existing github version
Hi,
Few points from my side,
1. We are creating pktio and then assigning the created queue to the pktio.
IMO we should abstract the PKTIO, since it is up to the implementation to
either support IPC through dummy interface or shared memory. Lets say if an
implementation does IPC through shared
Thanks for bringing it up Mike. One queue per process is still kept as a
question in the document.
If we agree we need to update the document.
Regards,
Bala
On 26 August 2014 17:58, Mike Holmes mike.hol...@linaro.org wrote:
On 26 August 2014 08:21, Bala Manoharan bala.manoha...@linaro.org
Hi Alex,
I had the same thought while implementing this API.
The reason I decided to go ahead with getting mac address only though
odp_pktio_t is because if we have this API to get mac address directly with
the device name then the user can try to get mac address of a device even
without creating
401 - 460 of 460 matches
Mail list logo
