Re: [lng-odp] [PATCH] test: bench_packet: fix headroom/tailroom test return values

2017-03-30 Thread Bill Fischofer
On Thu, Mar 30, 2017 at 2:41 AM, Matias Elo <matias@nokia.com> wrote: > Zero is a valid return value from the packet headroom/tailroom functions. > > Signed-off-by: Matias Elo <matias@nokia.com> Reviewed-by: Bill Fischofer <bill.fischo...@linaro.org> > --- &

Re: [lng-odp] [PATCH] validation: packet: do assert on newly created pkt reference

2017-03-29 Thread Bill Fischofer
On Wed, Mar 29, 2017 at 3:15 AM, Balakrishna Garapati <balakrishna.garap...@linaro.org> wrote: > Signed-off-by: Balakrishna Garapati <balakrishna.garap...@linaro.org> Reviewed-by: Bill Fischofer <bill.fischo...@linaro.org> > --- > test/common_plat/validation/api/p

Re: [lng-odp] Sequence requirments for odp_schedule_order_lock()

2017-03-29 Thread Bill Fischofer
On Wed, Mar 29, 2017 at 7:18 AM, Radosław Biernacki wrote: > Hi all, > > The documentation for odp_schedule_order_lock(unsigned lock_index) does not > specify the sequence in which the lock_index need to be given. That's because there is no such required sequence. Each lock

Re: [lng-odp] [API-NEXT PATCH] api: packet: add per packet checksum control

2017-03-29 Thread Bill Fischofer
va...@linaro.org] > >> Sent: Wednesday, March 29, 2017 10:26 AM > >> To: Savolainen, Petri (Nokia - FI/Espoo) > >> <petri.savolai...@nokia-bell-labs.com> > >> Cc: Bill Fischofer <bill.fischo...@linaro.org>; lng-odp-forward > >> <lng-odp@lists.l

Re: [lng-odp] 32b support in ODP-Cloud

2017-03-29 Thread Bill Fischofer
On Wed, Mar 29, 2017 at 7:29 AM, Ola Liljedahl <ola.liljed...@linaro.org> wrote: > > > On 29 March 2017 at 13:25, Bill Fischofer <bill.fischo...@linaro.org> > wrote: > >> >> >> On Wed, Mar 29, 2017 at 5:47 AM, Ola Liljedahl <ola.liljed...@linaro

Re: [lng-odp] 32b support in ODP-Cloud

2017-03-29 Thread Bill Fischofer
; >>> When profiling some ODP examples, I can see hot spots in the functions >>> that convert "pointer"-handles into the actual object pointers >>> (virtual addresses). So we are paying a double price here, handles are >>> large (increases cache pre

Re: [lng-odp] 32b support in ODP-Cloud

2017-03-28 Thread Bill Fischofer
On Tue, Mar 28, 2017 at 10:47 PM Honnappa Nagarahalli < honnappa.nagaraha...@linaro.org> wrote: > On 28 March 2017 at 22:27, Bill Fischofer <bill.fischo...@linaro.org> > wrote: > > > > > > On Mon, Mar 27, 2017 at 10:11 PM, Honnappa Nagarahalli > &g

Re: [lng-odp] [API-NEXT 4/4] A scalable software scheduler

2017-03-28 Thread Bill Fischofer
m for your patches and then regenerated them for checkpatch testing via: git format-patch origin/api-next --subject-prefix="API-NEXT PATCH" > > Do we have to compile for 32b with gcc? > Yes, we require that ODP code compile and run in both 32-bit and 64-bit mode. > &g

Re: [lng-odp] 32b support in ODP-Cloud

2017-03-28 Thread Bill Fischofer
On Mon, Mar 27, 2017 at 10:11 PM, Honnappa Nagarahalli < honnappa.nagaraha...@linaro.org> wrote: > On 27 March 2017 at 08:36, Ola Liljedahl wrote: > > On 27 March 2017 at 07:58, Honnappa Nagarahalli > > wrote: > >> My answers inline. I

Re: [lng-odp] [PATCH 2/2] linux-gen: remove pktio ipc option from configure

2017-03-28 Thread Bill Fischofer
On Mon, Feb 27, 2017 at 9:21 AM, Maxim Uvarov <maxim.uva...@linaro.org> wrote: > Options becomes stable and not need any entry in main > configure for platform specific pktio. > > Signed-off-by: Maxim Uvarov <maxim.uva...@linaro.org> > Reviewed-by: Bill Fischofer

Re: [lng-odp] [PATCH] test: perf: fix bash syntax in odp_pktio_ordered_run.sh

2017-03-28 Thread Bill Fischofer
gt; Signed-off-by: Maxim Uvarov <maxim.uva...@linaro.org> > Reviewed-by: Bill Fischofer <bill.fischo...@linaro.org> > --- > .../performance/odp_pktio_ordered_run.sh | 22 > +++--- > 1 file changed, 15 insertions(+), 7 deletio

Re: [lng-odp] [PATCH] linux-gen: pktio: socket mmap: check unmap return code

2017-03-28 Thread Bill Fischofer
On Tue, Mar 21, 2017 at 12:08 PM, Maxim Uvarov <maxim.uva...@linaro.org> wrote: > Check unmap return code > https://bugs.linaro.org/show_bug.cgi?id=2831 > > Signed-off-by: Maxim Uvarov <maxim.uva...@linaro.org> > Reviewed-by: Bill Fischofer <bill.fischo...@linaro.

Re: [lng-odp] [API-NEXT 4/4] A scalable software scheduler

2017-03-28 Thread Bill Fischofer
First off, I'm not sure why you're seeing HTML since Gmail is set to plain text mode for me. On Tue, Mar 28, 2017 at 9:18 PM, Brian Brooks <brian.bro...@arm.com> wrote: > On 03/28 18:50:32, Bill Fischofer wrote: > > > > > > > > <!-- .EmailQuote { margin-le

Re: [lng-odp] [API-NEXT 3/4] api: queue: Add ring_size

2017-03-28 Thread Bill Fischofer
On Tue, Mar 28, 2017 at 2:23 PM, Brian Brooks wrote: > Signed-off-by: Brian Brooks > --- > include/odp/api/spec/queue.h | 5 + > 1 file changed, 5 insertions(+) > > diff --git a/include/odp/api/spec/queue.h b/include/odp/api/spec/queue.h > index

Re: [lng-odp] odp_queue_enq semantics

2017-03-28 Thread Bill Fischofer
On Tue, Mar 28, 2017 at 11:18 AM, Honnappa Nagarahalli <honnappa.nagaraha...@linaro.org> wrote: > On 28 March 2017 at 07:21, Bill Fischofer <bill.fischo...@linaro.org> wrote: >> On Tue, Mar 28, 2017 at 7:19 AM, Verma, Shally <shally.ve...@cavium.com> >> wrote:

Re: [lng-odp] [API-NEXT PATCH v3 1/4] api: ipsec: extend lookaside API

2017-03-28 Thread Bill Fischofer
e needed state information, which would be both error-prone and wasteful..That's why ODP handles things like SA expiration processing, and why, I argue, it should do the same for disablement status. > > On 28 March 2017 at 14:54, Bill Fischofer <bill.fischo...@linaro.org> wrote: >

Re: [lng-odp] odp_queue_enq semantics

2017-03-28 Thread Bill Fischofer
On Tue, Mar 28, 2017 at 7:19 AM, Verma, Shally <shally.ve...@cavium.com> wrote: > > > -Original Message- > From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of Bill > Fischofer > Sent: 28 March 2017 16:44 > To: Ola Liljedahl <ola.lil

Re: [lng-odp] [API-NEXT PATCH] api: packet: add per packet checksum control

2017-03-28 Thread Bill Fischofer
ould you trust it not to "cover its tracks" by recomputing checksums, or remember to call this API? End-to-end integrity is why protocols like IPsec are used. > > > >> -Original Message- >> From: Bill Fischofer [mailto:bill.fischo...@linaro.org] &g

Re: [lng-odp] [API-NEXT PATCH v3 1/4] api: ipsec: extend lookaside API

2017-03-28 Thread Bill Fischofer
On Tue, Mar 28, 2017 at 4:58 AM, Savolainen, Petri (Nokia - FI/Espoo) <petri.savolai...@nokia-bell-labs.com> wrote: > > >> -Original Message----- >> From: Bill Fischofer [mailto:bill.fischo...@linaro.org] >> Sent: Tuesday, March 28, 2017 4:32 AM >> To:

Re: [lng-odp] [API-NEXT PATCH] api: packet: add per packet checksum control

2017-03-28 Thread Bill Fischofer
These look good, but shouldn't these be documented as advisory? When dealing with well-formed packets, it should not matter if HW always recomputes checksums on transmit. The only time you'd need to suppress checksum generation would be in diagnostic packet generators that are intentionally

Re: [lng-odp] odp_queue_enq semantics

2017-03-28 Thread Bill Fischofer
On Tue, Mar 28, 2017 at 4:10 AM, Ola Liljedahl wrote: > On 28 March 2017 at 10:41, Joe Savage wrote: >> Hey, >> >> I just wanted to clarify something about the expected behaviour of >> odp_queue_enq. In the following code snippet, is it acceptable

Re: [lng-odp] [API-NEXT PATCH v3 1/4] api: ipsec: extend lookaside API

2017-03-27 Thread Bill Fischofer
On Mon, Mar 27, 2017 at 5:27 AM, Savolainen, Petri (Nokia - FI/Espoo) wrote: > >> > /** >> > + * Configuration options for IPSEC inbound processing >> > + */ >> > +typedef struct odp_ipsec_inbound_config_t { >> > + /** Default destination queue for

Re: [lng-odp] [API-NEXT PATCH v3 4/4] api: packet: add per packet checksum control

2017-03-27 Thread Bill Fischofer
On Mon, Mar 27, 2017 at 2:49 AM, Savolainen, Petri (Nokia - FI/Espoo) <petri.savolai...@nokia-bell-labs.com> wrote: > > >> -Original Message----- >> From: Bill Fischofer [mailto:bill.fischo...@linaro.org] >> Sent: Friday, March 24, 2017 5:39 PM >>

Re: [lng-odp] [API-NEXT PATCH v3 2/4] api: ipsec: add inline IPSEC support

2017-03-26 Thread Bill Fischofer
Hit return too soon. On Sun, Mar 26, 2017 at 10:01 AM, Bill Fischofer <bill.fischo...@linaro.org> wrote: > On Fri, Mar 24, 2017 at 10:04 AM, Petri Savolainen > <petri.savolai...@linaro.org> wrote: >> Added support for inline IPSEC processing on packet input and >

Re: [lng-odp] [API-NEXT PATCH v3 2/4] api: ipsec: add inline IPSEC support

2017-03-26 Thread Bill Fischofer
On Fri, Mar 24, 2017 at 10:04 AM, Petri Savolainen wrote: > Added support for inline IPSEC processing on packet input and > output. Inline mode IPSEC and traffic manager cannot be enabled > (currently) on the same pktio interface. > > Signed-off-by: Petri Savolainen

Re: [lng-odp] [API-NEXT PATCH v3 1/4] api: ipsec: extend lookaside API

2017-03-24 Thread Bill Fischofer
On Fri, Mar 24, 2017 at 10:04 AM, Petri Savolainen wrote: > Added configuration option for inbound SPI range (for > lookups). Removed unique SPI requirement and added config > option for overlap. Added default queue for lookup misses. > Added SA disable function and

Re: [lng-odp] [API-NEXT PATCH v3 4/4] api: packet: add per packet checksum control

2017-03-24 Thread Bill Fischofer
This patch is independent of the IPsec patch series and should be a separate patch. On Fri, Mar 24, 2017 at 10:04 AM, Petri Savolainen wrote: > Checksum insertion has pktio interface level configuration > options. Per packet override is needed for example when > L4

[lng-odp] [PATCHv3] validation: packet: do not require a max packet length

2017-03-23 Thread Bill Fischofer
-by: Bill Fischofer <bill.fischo...@linaro.org> --- test/common_plat/validation/api/crypto/crypto.c | 6 -- test/common_plat/validation/api/packet/packet.c | 13 +++-- test/common_plat/validation/api/pktio/pktio.c | 11 +++ 3 files changed, 22 insertions(+), 8 deletions(-)

Re: [lng-odp] [PATCH] Fix memory ordering in ring dequeue

2017-03-22 Thread Bill Fischofer
On Wed, Mar 22, 2017 at 10:37 AM, Maxim Uvarov wrote: > On 03/22/17 07:54, Brian Brooks wrote: >> Acquire ordering is needed to maintain proper release consistency with >> the ring enqueue operation. This issue presented itself as deadlock when >> running on an ARM-based

Re: [lng-odp] [API-NEXT PATCHv2 01/23] drv: adding compiler hints in the driver interface

2017-03-22 Thread Bill Fischofer
On Wed, Mar 22, 2017 at 9:48 AM, Christophe Milard wrote: > Largely inspired from its north api counterpart, the drv/spec/hint.h > file is added. Also includes the __constructor__ attributes that many > driver interface items will need. > > Signed-off-by: Christophe

Re: [lng-odp] [PATCH] Fix memory ordering in ring dequeue

2017-03-22 Thread Bill Fischofer
ned-off-by: Brian Brooks <brian.bro...@linaro.org> Reviewed-by: Bill Fischofer <bill.fischo...@linaro.org> > --- > platform/linux-generic/include/odp_ring_internal.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/platform/linux-generic/incl

Re: [lng-odp] [API-NEXT PATCH v2 2/3] api: ipsec: add inline IPSEC support

2017-03-21 Thread Bill Fischofer
On Tue, Mar 21, 2017 at 9:17 AM, Petri Savolainen < petri.savolai...@linaro.org> wrote: > Added support for inline IPSEC processing on packet input and > output. Inline mode IPSEC and traffic manager cannot be enabled > (currently) on the same pktio interface. > > Signed-off-by: Petri Savolainen

[lng-odp] Test msg, please ignore

2017-03-21 Thread Bill Fischofer
Bill

Re: [lng-odp] [PATCHv2] validation: packet: do not require a max packet length

2017-03-17 Thread Bill Fischofer
On Fri, Mar 17, 2017 at 9:45 AM, Maxim Uvarov <maxim.uva...@linaro.org> wrote: > On 03/14/17 16:55, Bill Fischofer wrote: > > Address bug https://bugs.linaro.org/show_bug.cgi?id=2908 by adding > > appropriate pool capability checks to the packet and crypto tests > >

Re: [lng-odp] Regarding Chained Buffers and Crypto

2017-03-16 Thread Bill Fischofer
Bug https://bugs.linaro.org/show_bug.cgi?id=2895 is already open regarding the current restriction on odp-linux not supporting segmented packets as input to crypto. Nikhil is working on this. On Thu, Mar 16, 2017 at 7:38 AM, Bala Manoharan wrote: > On 16 March 2017 at

Re: [lng-odp] ABI and deprecated API flag

2017-03-14 Thread Bill Fischofer
On Tue, Mar 14, 2017 at 4:02 PM, Honnappa Nagarahalli < honnappa.nagaraha...@linaro.org> wrote: > On 14 March 2017 at 14:41, Dmitry Eremin-Solenikov > wrote: > > Hi, > > > > On 14.03.2017 07:06, Honnappa Nagarahalli wrote: > >> 2) What is the purpose of the

[lng-odp] [PATCHv2] validation: packet: do not require a max packet length

2017-03-14 Thread Bill Fischofer
Address bug https://bugs.linaro.org/show_bug.cgi?id=2908 by adding appropriate pool capability checks to the packet and crypto tests to account for pkt.max_len, pkt.max_seg_len, or pkt.max_segs_per_pkt being zero, indicating these limits are bound only by available memory. Signed-off-by: Bill

Re: [lng-odp] [PATCH] test: bench_packet: add tests for reference functions

2017-03-14 Thread Bill Fischofer
On Tue, Mar 14, 2017 at 1:52 AM, Elo, Matias (Nokia - FI/Espoo) < matias@nokia-bell-labs.com> wrote: > > > On 13 Mar 2017, at 19:58, Bill Fischofer <bill.fischo...@linaro.org> > wrote: > > > > This is a good start and I have no problem merging this as-

Re: [lng-odp] [PATCH v2] test: bench_packet: add tests for reference functions

2017-03-14 Thread Bill Fischofer
On Tue, Mar 14, 2017 at 2:30 AM, Matias Elo <matias@nokia.com> wrote: > Add microbenchmarks for the new packet reference functions. > > Signed-off-by: Matias Elo <matias@nokia.com> > Reviewed-and-tested-by: Bill Fischofer <bill.fischo...@linaro.org>

Re: [lng-odp] [PATCH] linux-gen: packet: make inline table visible

2017-03-13 Thread Bill Fischofer
naro.org> > Reviewed-by: Bill Fischofer <bill.fischo...@linaro.org> > --- > platform/linux-generic/odp_packet.c | 4 > 1 file changed, 4 insertions(+) > > diff --git a/platform/linux-generic/odp_packet.c > b/platform/linux-generic/odp_packet.c > index

Re: [lng-odp] [PATCH] test: bench_packet: add tests for reference functions

2017-03-13 Thread Bill Fischofer
This is a good start and I have no problem merging this as-is if we want to do this in stages, but I think a bit more is needed. For one, this is using a fixed offset for all references. I'd like to see references created with a couple of different offsets (e.g., 0 and packet_len/2) to get a

[lng-odp] [PATCH] validation: packet: do not require a max packet length

2017-03-13 Thread Bill Fischofer
Address bug https://bugs.linaro.org/show_bug.cgi?id=2908 by checking the pool capability max packet length and modifying the test in test_extend_ref() to account for implementations that do not limit packet lengths. Signed-off-by: Bill Fischofer <bill.fischo...@linaro.org> --- test/commo

[lng-odp] [PATCHv2 11/11] linux-generic: packet: enable zero-copy reference creation

2017-03-12 Thread Bill Fischofer
Signed-off-by: Bill Fischofer <bill.fischo...@linaro.org> --- platform/linux-generic/odp_packet.c | 172 +--- 1 file changed, 103 insertions(+), 69 deletions(-) diff --git a/platform/linux-generic/odp_packet.c b/platform/linux-generic/odp_packet.c index 40

[lng-odp] [PATCHv2 10/11] linux-generic: packet: add reference support for head/tail manipulation

2017-03-12 Thread Bill Fischofer
Signed-off-by: Bill Fischofer <bill.fischo...@linaro.org> --- platform/linux-generic/odp_packet.c | 96 + 1 file changed, 77 insertions(+), 19 deletions(-) diff --git a/platform/linux-generic/odp_packet.c b/platform/linux-generic/odp_packet.c index 9d

[lng-odp] [PATCHv2 09/11] linux-generic: packet: restructure free routines for references

2017-03-12 Thread Bill Fischofer
Restructure the various packet/segment free routines to support references. Signed-off-by: Bill Fischofer <bill.fischo...@linaro.org> --- platform/linux-generic/odp_packet.c | 146 +++- 1 file changed, 111 insertions(+), 35 deletions(-) diff --git a/pl

[lng-odp] [PATCHv2 08/11] linux-generic: packet: segment manipulation with references

2017-03-12 Thread Bill Fischofer
Add support for segment operation with references Signed-off-by: Bill Fischofer <bill.fischo...@linaro.org> --- .../include/odp/api/plat/packet_inlines.h | 39 ++--- .../include/odp/api/plat/packet_inlines_api.h | 16 -- .../linux-generic/include/odp_packet_internal.h

[lng-odp] [PATCHv2 05/11] linux-generic: packet: add routines for manipulating reference counts

2017-03-12 Thread Bill Fischofer
Signed-off-by: Bill Fischofer <bill.fischo...@linaro.org> --- platform/linux-generic/include/odp_packet_internal.h | 19 +++ platform/linux-generic/odp_packet.c | 10 ++ 2 files changed, 29 insertions(+) diff --git a/platform/linux-generic/i

[lng-odp] [PATCHv2 07/11] linux-generic: packet: unshared_len maintenance

2017-03-12 Thread Bill Fischofer
Add code to initialize and maintain unshared_len packet metadata Signed-off-by: Bill Fischofer <bill.fischo...@linaro.org> --- .../linux-generic/include/odp_packet_internal.h| 4 ++ platform/linux-generic/odp_packet.c| 43 +- 2 files chang

[lng-odp] [PATCHv2 06/11] linux-generic: packet: add initializations for new hdr fields

2017-03-12 Thread Bill Fischofer
Add initializations for new packet hdr fields needed to support packet references. Signed-off-by: Bill Fischofer <bill.fischo...@linaro.org> --- platform/linux-generic/odp_packet.c | 9 + 1 file changed, 9 insertions(+) diff --git a/platform/linux-generic/odp_packet.c b/platform

[lng-odp] [PATCHv2 04/11] linux-generic: packet: add packet fields needed for references

2017-03-12 Thread Bill Fischofer
Add new fields to the odp_packet_hdr_t used for support of zero-copy references. Also added are the offsets needed to access them from inlined functions. Signed-off-by: Bill Fischofer <bill.fischo...@linaro.org> --- platform/linux-generic/include/odp/api/plat/packet_types

[lng-odp] [PATCHv2 03/11] linux-generic: packet: restructure inline routines to use macros

2017-03-12 Thread Bill Fischofer
Use an internal macro for accessing inline fields in preparation for introducing packet reference support. Signed-off-by: Bill Fischofer <bill.fischo...@linaro.org> --- .../include/odp/api/plat/packet_flag_inlines.h | 7 +++- .../include/odp/api/plat/packet_inlines.h

[lng-odp] [PATCHv2 02/11] linux-generic: packet: move pull_tail to packet mainline for consistency

2017-03-12 Thread Bill Fischofer
Move the pull_tail() internal routine to odp_packet.c for consistency with other internal head/tail manipulation routines. Signed-off-by: Bill Fischofer <bill.fischo...@linaro.org> --- platform/linux-generic/include/odp_packet_internal.h | 9 - platform/linux-generic/odp_pa

[lng-odp] [PATCHv2 00/11] Optimized Packet References

2017-03-12 Thread Bill Fischofer
reference support for the various head/tail extension and trunction routines. Finally, Part 11 enables the creation of zero-copy references that utilize the machinery found in the previous parts. Bill Fischofer (11): linux-generic: pool: restructure pool routines linux-generic: packet: move

[lng-odp] [PATCHv2 01/11] linux-generic: pool: restructure pool routines

2017-03-12 Thread Bill Fischofer
Restructure pool routines in preparation for introducing packet references. Signed-off-by: Bill Fischofer <bill.fischo...@linaro.org> --- platform/linux-generic/include/odp_pool_internal.h | 33 ++- platform/linux-generic/odp_pool.c | 47 +--

Re: [lng-odp] [PATCH v2] linux-generic: pool: don't allocate buffers from invalid pool

2017-03-10 Thread Bill Fischofer
nsoleni...@linaro.org> > Reviewed-by: Bill Fischofer <bill.fischo...@linaro.org> > --- > platform/linux-generic/odp_pool.c | 4 > 1 file changed, 4 insertions(+) > > diff --git a/platform/linux-generic/odp_pool.c > b/platform/linux-generic/odp_pool.c >

Re: [lng-odp] [API-NEXT 6/8] linux-generic: crypto: switch to EVP interface for cipher algorithms

2017-03-09 Thread Bill Fischofer
Checkpatch issue with this part: WARNING: Missing a blank line after declarations #163: FILE: platform/linux-generic/odp_crypto.c:312: + EVP_CIPHER_CTX *ctx = >cipher.ctx; + EVP_CIPHER_CTX_init(ctx); CHECK: Avoid CamelCase: #234: FILE: platform/linux-generic/odp_crypto.c:357: + rc =

Re: [lng-odp] [API-NEXT 5/8] linux-generic: crypto: unify auth code

2017-03-09 Thread Bill Fischofer
Checkpatch issue with this part: WARNING: Missing a blank line after declarations #38: FILE: platform/linux-generic/include/odp_crypto_internal.h:66: + uint32_t bytes; + const EVP_MD *evp_md; total: 0 errors, 1 warnings, 0 checks, 205 lines checked NOTE: Ignored message types: BIT_MACRO

Re: [lng-odp] [PATCH] linux-generic: pool: don't allocate buffers from invalid pool

2017-03-09 Thread Bill Fischofer
On Thu, Mar 9, 2017 at 1:21 PM Maxim Uvarov wrote: > On 03/09/2017 03:01 PM, Dmitry Eremin-Solenikov wrote: > > Check that passed pool is not ODP_POOL_INVALID before goint to try to > > allocate buffers from that pool. > > > > Signed-off-by: Dmitry Eremin-Solenikov < >

Re: [lng-odp] Linking problem with --disable-abi-compat

2017-03-09 Thread Bill Fischofer
This also points out a problem with our CI loops in that they don't do test builds from installed copies of the ODP shared library. On Thu, Mar 9, 2017 at 11:30 AM, Bill Fischofer <bill.fischo...@linaro.org> wrote: > Looks like you found a legit bug, however I'd fix this

Re: [lng-odp] Linking problem with --disable-abi-compat

2017-03-09 Thread Bill Fischofer
Looks like you found a legit bug, however I'd fix this by adding an ODP_VISIBLE macro and using that rather than directly using the __attribute__ on this struct. That keeps things consistent with other ODP indirect specification of attributes. On Wed, Mar 8, 2017 at 5:57 PM, Peltonen, Janne

Re: [lng-odp] [API-NEXT 0/8] crypto rework and support for SHA-1/-512

2017-03-09 Thread Bill Fischofer
Part 3/8 doesn't appear either on the mailing list or in patchworks. On Wed, Mar 8, 2017 at 10:45 AM, Dmitry Eremin-Solenikov < dmitry.ereminsoleni...@linaro.org> wrote: > This patchset concentrates on updating crypto framework in linux-generic: > > - merge auth code to use common code paths for

[lng-odp] [PATCH 11/11] linux-generic: packet: enable zero-copy reference creation

2017-03-05 Thread Bill Fischofer
Signed-off-by: Bill Fischofer <bill.fischo...@linaro.org> --- platform/linux-generic/odp_packet.c | 172 +--- 1 file changed, 103 insertions(+), 69 deletions(-) diff --git a/platform/linux-generic/odp_packet.c b/platform/linux-generic/odp_packet.c index 4

[lng-odp] [PATCH 10/11] linux-generic: packet: add reference support for head/tail manipulation

2017-03-05 Thread Bill Fischofer
Signed-off-by: Bill Fischofer <bill.fischo...@linaro.org> --- platform/linux-generic/odp_packet.c | 96 + 1 file changed, 77 insertions(+), 19 deletions(-) diff --git a/platform/linux-generic/odp_packet.c b/platform/linux-generic/odp_packet.c index 9

[lng-odp] [PATCH 09/11] linux-generic: packet: restructure free routines for references

2017-03-05 Thread Bill Fischofer
Restructure the various packet/segment free routines to support references. Signed-off-by: Bill Fischofer <bill.fischo...@linaro.org> --- platform/linux-generic/odp_packet.c | 146 +++- 1 file changed, 111 insertions(+), 35 deletions(-) diff --git a/pl

[lng-odp] [PATCH 08/11] linux-generic: packet: segment manipulation with references

2017-03-05 Thread Bill Fischofer
Add support for segment operation with references Signed-off-by: Bill Fischofer <bill.fischo...@linaro.org> --- .../include/odp/api/plat/packet_inlines.h | 39 ++--- .../include/odp/api/plat/packet_inlines_api.h | 16 -- .../linux-generic/include/odp_packet_internal.h

[lng-odp] [PATCH 07/11] linux-generic: packet: unshared_len maintenance

2017-03-05 Thread Bill Fischofer
Add code to initialize and maintain unshared_len packet metadata Signed-off-by: Bill Fischofer <bill.fischo...@linaro.org> --- .../linux-generic/include/odp_packet_internal.h| 4 ++ platform/linux-generic/odp_packet.c| 43 +- 2 files chang

[lng-odp] [PATCH 04/11] linux-generic: packet: add packet fields needed for references

2017-03-05 Thread Bill Fischofer
Add new fields to the odp_packet_hdr_t used for support of zero-copy references. Also added are the offsets needed to access them from inlined functions. Signed-off-by: Bill Fischofer <bill.fischo...@linaro.org> --- platform/linux-generic/include/odp/api/plat/packet_types

[lng-odp] [PATCH 06/11] linux-generic: packet: add initializations for new hdr fields

2017-03-05 Thread Bill Fischofer
Add initializations for new packet hdr fields needed to support packet references. Signed-off-by: Bill Fischofer <bill.fischo...@linaro.org> --- platform/linux-generic/odp_packet.c | 9 + 1 file changed, 9 insertions(+) diff --git a/platform/linux-generic/odp_packet.c b/platform

[lng-odp] [PATCH 05/11] linux-generic: packet: add routines for manipulating reference counts

2017-03-05 Thread Bill Fischofer
Signed-off-by: Bill Fischofer <bill.fischo...@linaro.org> --- platform/linux-generic/include/odp_packet_internal.h | 19 +++ platform/linux-generic/odp_packet.c | 10 ++ 2 files changed, 29 insertions(+) diff --git a/platform/linux-generic/i

[lng-odp] [PATCH 03/11] linux-generic: packet: restructure inline routines to use macros

2017-03-05 Thread Bill Fischofer
Use an internal macro for accessing inline fields in preparation for introducing packet reference support. Signed-off-by: Bill Fischofer <bill.fischo...@linaro.org> --- .../include/odp/api/plat/packet_flag_inlines.h | 7 +++- .../include/odp/api/plat/packet_inlines.h

[lng-odp] [PATCH 02/11] linux-generic: packet: move pull_tail to packet mainline for consistency

2017-03-05 Thread Bill Fischofer
Move the pull_tail() internal routine to odp_packet.c for consistency with other internal head/tail manipulation routines. Signed-off-by: Bill Fischofer <bill.fischo...@linaro.org> --- platform/linux-generic/include/odp_packet_internal.h | 9 - platform/linux-generic/odp_pa

[lng-odp] [PATCH 01/11] linux-generic: pool: restructure pool routines

2017-03-05 Thread Bill Fischofer
Restructure pool routines in preparation for introducing packet references. Signed-off-by: Bill Fischofer <bill.fischo...@linaro.org> --- platform/linux-generic/include/odp_pool_internal.h | 33 ++- platform/linux-generic/odp_pool.c | 47 +--

[lng-odp] [PATCH 00/11] Optimized Packet References

2017-03-05 Thread Bill Fischofer
that utilize the machinery found in the previous parts. Bill Fischofer (11): linux-generic: pool: restructure pool routines linux-generic: packet: move pull_tail to packet mainline for consistency linux-generic: packet: restructure inline routines to use macros linux-generic: packet: add

Re: [lng-odp] Maintaner change

2017-03-02 Thread Bill Fischofer
Thanks Nicolas, and best wishes. And welcome Jérôme. On Thu, Mar 2, 2017 at 6:48 AM, Nicolas Morey-Chaisemartin wrote: > Hi everyone, > > Just to let you know that this is my last week at Kalray. > Jérome Reybert (I think he's subscribing to this ML already) will be in >

Re: [lng-odp] [NEXT PATCH] update API version number from v1.13.0.0 to v1.14.0.0

2017-03-01 Thread Bill Fischofer
On Wed, Mar 1, 2017 at 8:37 AM, Maxim Uvarov <maxim.uva...@linaro.org> wrote: > Signed-off-by: Maxim Uvarov <maxim.uva...@linaro.org> > Reviewed-by: Bill Fischofer <bill.fischo...@linaro.org> > --- > abi change report is here: > > http://people.linaro.or

Re: [lng-odp] Generic handle in ODP

2017-03-01 Thread Bill Fischofer
ODP handles are by design abstract types that may have very different internal representations between different ODP implementations. When asking for a generic handle type the question is which types would you expect that to encompass? When we originally started defining the ODP type system we

Re: [lng-odp] [PATCH] As per mailing-list and meeting conversation: this patch addresses the build failure on operating systems where CPU_SETSIZE is bigger than 1024 entries.

2017-02-28 Thread Bill Fischofer
On Tue, Feb 28, 2017 at 11:55 AM, Marco Varlese <marco.varl...@suse.com> wrote: > Signed-off-by: Marco Varlese <marco.varl...@suse.com> > Reviewed-and-tested-by: Bill Fischofer <bill.fischo...@linaro.org> > --- > platform/linux-generic/include/odp/api/plat/cp

Re: [lng-odp] [PATCH] api: ipsec: make IPSEC protocol consistent with other types

2017-02-28 Thread Bill Fischofer
; > and then: > > typedef enum odp_ipsec_protocol_t > ODP_IPSEC_* > > looks like a minor inconsistency to me. I am not sure I will be able to > join the call since we have the OFP call about the same time... > > Regards, > Andriy > > > On 28.02.2017 13:43, Bill Fischo

Re: [lng-odp] [PATCH 1/2] linux-gen: ipc: use hdr to handle conversion function

2017-02-28 Thread Bill Fischofer
Your series also includes TM (good catch) so it seems this need extends beyond just IPC. On Tue, Feb 28, 2017 at 6:55 AM, Bill Fischofer <bill.fischo...@linaro.org> wrote: > > > On Tue, Feb 28, 2017 at 1:45 AM, Savolainen, Petri (Nokia - FI/Espoo) < > petri.savolai...@nokia

Re: [lng-odp] [PATCH 1/2] linux-gen: ipc: use hdr to handle conversion function

2017-02-28 Thread Bill Fischofer
Sent: Monday, February 27, 2017 6:10 PM > > To: lng-odp@lists.linaro.org > > Subject: Re: [lng-odp] [PATCH 1/2] linux-gen: ipc: use hdr to handle > > conversion function > > > > On 02/27/17 19:02, Bill Fischofer wrote: > > > On Mon, Feb 27, 2017 at 9:57 AM, Petri Savo

Re: [lng-odp] [PATCH] api: ipsec: make IPSEC protocol consistent with other types

2017-02-28 Thread Bill Fischofer
On Tue, Feb 28, 2017 at 2:22 AM, Savolainen, Petri (Nokia - FI/Espoo) < petri.savolai...@nokia-bell-labs.com> wrote: > > > > -Original Message- > > From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of > Bill > > Fischofer > >

Re: [lng-odp] Compilation error of ODP on Linux x86_64 platform

2017-02-28 Thread Bill Fischofer
I've added this topic to the agenda for today's ODP public call. Marco, if you're able to join us to provide your input to the discussion please do so. The call is at 15:00 UTC. To join just go to http://meetings.opendataplane.org. We use the BlueJeans conferencing system. Thanks. On Tue, Feb

[lng-odp] Canceled Event: OpenDataPlane (ODP) Public Call @ Tue Mar 7, 2017 9am - 10am (CST) (lng-odp@lists.linaro.org)

2017-02-27 Thread Bill Fischofer
Mar 7, 2017 9am – 10am Central Time Where: http://meetings.opendataplane.org Calendar: lng-odp@lists.linaro.org Who: * Bill Fischofer - creator * bogdan.pric...@linaro.org * Petri Savolainen * song@linaro.org * Maxim Uvarov * Yang Shi * Christian Ziethén

Re: [lng-odp] [PATCH 1/2] linux-gen: ipc: use hdr to handle conversion function

2017-02-27 Thread Bill Fischofer
On Mon, Feb 27, 2017 at 9:57 AM, Petri Savolainen < petri.savolai...@linaro.org> wrote: > Use conversion function instead of casting. > > Signed-off-by: Petri Savolainen > --- > platform/linux-generic/include/odp_packet_internal.h | 6 ++ >

Re: [lng-odp] [PATCH] api: ipsec: make IPSEC protocol consistent with other types

2017-02-27 Thread Bill Fischofer
T patch. Thanks. > > Andriy > > On 27.02.2017 13:55, Bill Fischofer wrote: > >> Thanks Andriy, >> >> Please note that all API changes should specify >> --subject-prefix="API-NEXT PATCH" as we use the api-next branch to >> accumulate all A

Re: [lng-odp] Compilation error of ODP on Linux x86_64 platform

2017-02-27 Thread Bill Fischofer
> OS: openSUSE Leap 42.2 > Compiler: gcc-6 > Kernel: 4.10.0-rc4-1.g4f824f1-default > > > Cheers, > Marco > > On Mon, 2017-02-27 at 08:44 -0600, Bill Fischofer wrote: > > What environment are you running in (OS, compiler, service levels, etc.)? > > On Mon, Feb 2

Re: [lng-odp] Compilation error of ODP on Linux x86_64 platform

2017-02-27 Thread Bill Fischofer
What environment are you running in (OS, compiler, service levels, etc.)? On Mon, Feb 27, 2017 at 8:35 AM, Marco Varlese wrote: > Hi, > > I've pulled latest code from the git repo and got into a compile-time > error. > > I followed the steps provided in the README file

Re: [lng-odp] [PATCH] api: ipsec: make IPSEC protocol consistent with other types

2017-02-27 Thread Bill Fischofer
Thanks Andriy, Please note that all API changes should specify --subject-prefix="API-NEXT PATCH" as we use the api-next branch to accumulate all API changes. On Mon, Feb 27, 2017 at 5:24 AM, Andriy Berestovskyy < andriy.berestovs...@cavium.com> wrote: > - rename odp_ipsec_protocol_t to

[lng-odp] [NEXT PATCHv2] changelog: summary of changes for ODP v1.14.0.0

2017-02-26 Thread Bill Fischofer
Signed-off-by: Bill Fischofer <bill.fischo...@linaro.org> --- CHANGELOG | 144 ++ 1 file changed, 144 insertions(+) diff --git a/CHANGELOG b/CHANGELOG index 72bf2253..a550a723 100644 --- a/CHANGELOG +++ b/CHANGELOG @@ -1,3

Re: [lng-odp] [PATCH v2 1/5] linux-gen: inline: rename _STATIC to _ODP_INLINE

2017-02-25 Thread Bill Fischofer
For this series: Reviewed-and-tested-by: Bill Fischofer <bill.fischo...@linaro.org> On Wed, Feb 8, 2017 at 6:17 AM, Petri Savolainen < petri.savolai...@linaro.org> wrote: > This define is visible to applications through API headers. Use _ODP prefix > to avoid name space colli

[lng-odp] [NEXT PATCH] changelog: summary of changes for odp v1.14.0.0

2017-02-24 Thread Bill Fischofer
Signed-off-by: Bill Fischofer <bill.fischo...@linaro.org> --- CHANGELOG | 129 ++ 1 file changed, 129 insertions(+) diff --git a/CHANGELOG b/CHANGELOG index 72bf2253..c8ed488c 100644 --- a/CHANGELOG +++ b/CHANGELOG @@ -1,3

Re: [lng-odp] [API-NEXT PATCH 00/21] driver items registration and probing

2017-02-24 Thread Bill Fischofer
st lost them. > > On Feb 24, 2017 3:31 AM, "Josep Puigdemont" <josep.puigdem...@linaro.org> > wrote: >> >> On Thu, Feb 23, 2017 at 10:51:27AM -0600, Bill Fischofer wrote: >> > I see all the patches in this series on the mailing list, but it appears &g

Re: [lng-odp] [API-NEXT PATCH 2/4] api: deprecated: add ODP_DEPRECATED configure option

2017-02-23 Thread Bill Fischofer
I have to agree with Brian here. Cluttering up the API spec files with #ifdefs seems ugly and unnecessary, and tying this into autotools at a spec level also seems awkward. The idea was to mark certain fields as deprecated in one release and then remove them in a follow-on release. We can make

Re: [lng-odp] [API-NEXT PATCH 02/21] linux-gen: drv: enumerator_class registration

2017-02-23 Thread Bill Fischofer
e actually statically bound or implicitly dynamically loaded (based on a static configuration) I leave to you. On Thu, Feb 23, 2017 at 4:13 AM, Yi He <yi...@linaro.org> wrote: > > On 23 February 2017 at 04:57, Bill Fischofer <bill.fischo...@linaro.org> > wrote: > >> >>

Re: [lng-odp] [API-NEXT PATCH 00/21] driver items registration and probing

2017-02-23 Thread Bill Fischofer
patchwork for this series I saw 14, 16, 21 are missing, do you see the > same problem? > > Best Regards, Yi > > On 23 February 2017 at 07:32, Bill Fischofer <bill.fischo...@linaro.org> > wrote: > >> This series compiles and runs/tests fine using gcc and clang on both 64 &g

Re: [lng-odp] [PATCH v3 1/3] linux-generic: crypto: add missing include

2017-02-23 Thread Bill Fischofer
For this series: Reviewed-and-tested-by: Bill Fischofer <bill.fischo...@linaro.org> On Thu, Feb 23, 2017 at 7:37 AM, Dmitry Eremin-Solenikov < dmitry.ereminsoleni...@linaro.org> wrote: > OpenSSL 1.1.0 headers do not include , so include it > manually to fix the following

Re: [lng-odp] [API-NEXT PATCH 1/2] api: pktio: add parser configuration

2017-02-23 Thread Bill Fischofer
For this series: Reviewed-and-tested-by: Bill Fischofer <bill.fischo...@linaro.org> On Fri, Feb 17, 2017 at 8:20 AM, Petri Savolainen < petri.savolai...@linaro.org> wrote: > Packet input parsing level configuration is added. An application > may express the maximum layer it i

Re: [lng-odp] odp_buffer_t usage

2017-02-23 Thread Bill Fischofer
On Thu, Feb 23, 2017 at 6:56 AM, Verma, Shally <shally.ve...@cavium.com> wrote: > > > > > *From:* Bill Fischofer [mailto:bill.fischo...@linaro.org] > *Sent:* 23 February 2017 18:17 > *To:* Verma, Shally <shally.ve...@cavium.com> > *Cc:* lng-odp@lists.

Re: [lng-odp] odp_buffer_t usage

2017-02-23 Thread Bill Fischofer
On Thu, Feb 23, 2017 at 6:28 AM, Verma, Shally <shally.ve...@cavium.com> wrote: > > > > > *From:* Bill Fischofer [mailto:bill.fischo...@linaro.org] > *Sent:* 23 February 2017 17:51 > *To:* Verma, Shally <shally.ve...@cavium.com> > *Cc:* lng-odp@lists.

Re: [lng-odp] odp_buffer_t usage

2017-02-23 Thread Bill Fischofer
ODP pools provide an abstraction for various types of managed storage. There are currently three types of pools supported: - ODP_POOL_BUFFER - ODP_POOL_PACKET - ODP_POOL_TIMEOUT A buffer pool is simply a collection of fixed-sized blocks represented by the odp_buffer_t abstraction. A packet pool

<    1   2   3   4   5   6   7   8   9   10   >