[lng-odp] [PATCHv3 4/4] doc: implementers guide update with the new structure

2016-07-13 Thread Christophe Milard
Signed-off-by: Christophe Milard --- doc/implementers-guide/implementers-guide.adoc | 137 +++-- 1 file changed, 81 insertions(+), 56 deletions(-) diff --git a/doc/implementers-guide/implementers-guide.adoc b/doc/implementers-guide/implementers-guide.adoc index 4f49e8f

[lng-odp] [PATCHv3 2/4] validation: moving api validation tests to prepare for new interfaces

2016-07-13 Thread Christophe Milard
api directory under "validation" simply enable adding other interfaces (such as future drv) as part of the validation tests Signed-off-by: Christophe Milard --- test/Makefile.am | 4 +- test/common_plat/Makefile.am

[lng-odp] [PATCHv3 3/4] test: restructuring platform-specific tests to allow other interface

2016-07-13 Thread Christophe Milard
ce "api" are created, hence allowing for other tests type to have platform specifics (for instance running perf test from platform side to set proper pktios), and allowing other interfaces to be tested under validation. Signed-off-by: Christophe Milard --- configure.ac

[lng-odp] [PATCHv3 1/4] validation: diverse cosmetic fixes for checkpatch

2016-07-13 Thread Christophe Milard
To reduce the number of issues picked up by check-odp when moving the files in next patch Signed-off-by: Christophe Milard --- test/performance/odp_crypto.c | 6 +- test/performance/odp_l2fwd.c | 1 - test/performance/odp_l2fwd_run.sh

[lng-odp] [PATCHv3 0/4] Restructuring tests for clarity and new interfaces.

2016-07-13 Thread Christophe Milard
+-- ring +-- validation //the platform specific side of the validation tests +-- api //platform specific things for the validation of the api +-- pktio +-- shmem +--drv //platform specific for validation of drv interface +-- pci

[lng-odp] [PATCHv2 3/4] test: restructuring platform-specific tests to allow other interface

2016-07-13 Thread Christophe Milard
ce "api" are created, hence allowing for other tests type to have platform specifics (for instance running perf test from platform side to set proper pktios), and allowing other interfaces to be tested under validation. Signed-off-by: Christophe Milard --- configure.ac

[lng-odp] [PATCHv2 2/4] validation: moving api validation tests to prepare for new interfaces

2016-07-13 Thread Christophe Milard
api directory under "validation" simply enable adding other interfaces (such as future drv) as part of the validation tests Signed-off-by: Christophe Milard --- test/Makefile.am | 4 +- test/common_plat/Makefile.am

[lng-odp] [PATCHv2 4/4] doc: implementers guide update with the new structure

2016-07-13 Thread Christophe Milard
Signed-off-by: Christophe Milard --- doc/implementers-guide/implementers-guide.adoc | 137 +++-- 1 file changed, 81 insertions(+), 56 deletions(-) diff --git a/doc/implementers-guide/implementers-guide.adoc b/doc/implementers-guide/implementers-guide.adoc index 4f49e8f

[lng-odp] [PATCHv2 1/4] validation: diverse cosmetic fixes for checkpatch

2016-07-13 Thread Christophe Milard
To reduce the number of issues picked up by check-odp when moving the files in next patch Signed-off-by: Christophe Milard --- test/performance/odp_crypto.c | 6 +- test/performance/odp_l2fwd.c | 1 - test/performance/odp_l2fwd_run.sh

[lng-odp] [PATCHv2 0/4] Restructuring tests for clarity and new interfaces.

2016-07-13 Thread Christophe Milard
cific side of the validation tests +-- api //platform specific things for the validation of the api +-- pktio +-- shmem +--drv //platform specific for validation of drv interface +-- pci +-- dma Christophe Milard (4): validation

Re: [lng-odp] [PATCH 2/4] validation: moving api validation tests to prepare for new interfaces

2016-07-12 Thread Christophe Milard
> > -PATH=$TEST_DIR:$TEST_DIR/../../example/generator:$PATH > +PATH=$TEST_DIR:$TEST_DIR/../../../example/generator:$PATH Thanks for catching that: Addressed in V2 > > and some comments below: > > On 11 July 2016 at 23:26, Christophe Milard > wrote: >> >> API te

Re: [lng-odp] [PATCH 4/4] doc: implementers guide update with the new structure

2016-07-12 Thread Christophe Milard
On 11 July 2016 at 20:19, Mike Holmes wrote: > > > On 11 July 2016 at 11:26, Christophe Milard > wrote: >> >> Signed-off-by: Christophe Milard >> --- >> doc/implementers-guide/implementers-guide.adoc | 141 >> +++-- >>

Re: [lng-odp] [PATCH 4/4] doc: implementers guide update with the new structure

2016-07-12 Thread Christophe Milard
On 11 July 2016 at 18:16, Bill Fischofer wrote: > > > On Mon, Jul 11, 2016 at 10:26 AM, Christophe Milard > wrote: >> >> Signed-off-by: Christophe Milard >> --- >> doc/implementers-guide/implementers-guide.adoc | 141 >> +++-

[lng-odp] [PATCH 3/4] test: restructuring platform-specific tests to allow other interface

2016-07-11 Thread Christophe Milard
ce "api" are created, hence allowing for other tests type to have platform specifics (for instance running perf test from platform side to set proper pktios), and allowing other interfaces to be tested under validation. Signed-off-by: Christophe Milard --- configure.ac

[lng-odp] [PATCH 4/4] doc: implementers guide update with the new structure

2016-07-11 Thread Christophe Milard
Signed-off-by: Christophe Milard --- doc/implementers-guide/implementers-guide.adoc | 141 +++-- 1 file changed, 83 insertions(+), 58 deletions(-) diff --git a/doc/implementers-guide/implementers-guide.adoc b/doc/implementers-guide/implementers-guide.adoc index 4f49e8f

[lng-odp] [PATCH 2/4] validation: moving api validation tests to prepare for new interfaces

2016-07-11 Thread Christophe Milard
. * creating the api directory under "validation" simply enable adding other interfaces (such as future drv) as part of the validation tests Signed-off-by: Christophe Milard --- test/Makefile.am | 4 +- test/all-platforms/Makefile.am

[lng-odp] [PATCH 1/4] validation: diverse cosmetic fixes for checkpatch

2016-07-11 Thread Christophe Milard
To reduce the number of issues picked up by check-odp when moving the files in next patch Signed-off-by: Christophe Milard --- .../classification/odp_classification_test_pmr.c | 1 - test/validation/crypto/odp_crypto_test_inp.c | 32 - test/validation/crypto/test_vectors.h

[lng-odp] [PATCH 0/4] Restructuring tests for clarity and new interfaces.

2016-07-11 Thread Christophe Milard
api //platform specific things for the validation of the api +-- pktio +-- shmem +--drv //platform specific for validation of drv interface +-- pci +-- dma Christophe Milard (4): validation: diverse cosmetic fixes for checkpatch validat

Re: [lng-odp] [PATCH] doc: driver-api-guide: initial revision

2016-07-08 Thread Christophe Milard
On 8 July 2016 at 21:05, Mike Holmes wrote: > > > On 7 July 2016 at 10:55, Christophe Milard > wrote: >> >> Yes! I DID send a mail!!! It is in my mail history! >> >> I re-include it here again: >> >> On 2016-07-05 08:47, Mike Holmes wrote: >&

Re: [lng-odp] [PATCH] doc: driver-api-guide: initial revision

2016-07-07 Thread Christophe Milard
Yes! I DID send a mail!!! It is in my mail history! I re-include it here again: On 2016-07-05 08:47, Mike Holmes wrote: > Add an initial driver API document structure for the existing driver > framework. > here again we have a vocabulary issue: the term "API" is used for "interface", but actually

[lng-odp] test directory structure

2016-07-07 Thread Christophe Milard
Hi, I need to move things around to include test for the driver interface in the test directory. This is what I can thing about. Mike, Does this match what you had in mind? test ├── platform//platform dependant stuff and launchers │   └── linux-generic │   ├── api │  

Re: [lng-odp] [PATCHv2] contributing: add user agreement and short log conventions

2016-06-28 Thread Christophe Milard
On 28 June 2016 at 00:40, Bill Fischofer wrote: > Signed-off-by: Bill Fischofer > --- > v2: Incorporate comments from Mike and Petri > > CONTRIBUTING | 141 > +-- > 1 file changed, 137 insertions(+), 4 deletions(-) > > diff --git a/CONTRIB

Re: [lng-odp] [PATCH 1/3] doc: implguide: reformat text to conform with current doc standards

2016-06-23 Thread Christophe Milard
On 2016-06-23 12:19, Bill Fischofer wrote: > Clean up whitespace and line length issues with current doc. > > Signed-off-by: Bill Fischofer > --- > doc/implementers-guide/implementers-guide.adoc | 253 > - > 1 file changed, 121 insertions(+), 132 deletions(-) > > diff -

Re: [lng-odp] [PATCHv5] linux-gen: move platform tests into test suite

2016-06-20 Thread Christophe Milard
On 21 June 2016 at 06:52, Yi He wrote: > Move platform tests from odp/platform/linux-generic/test > into test suite at odp/test/platform/linux-generic. > > Signed-off-by: Yi He Reviewed-by: Christophe Milard > --- > v5 only contains the platform tests move an

Re: [lng-odp] [PATCHv4] linux-gen: move platform tests into test suite

2016-06-17 Thread Christophe Milard
On 17 June 2016 at 08:10, Yi He wrote: > Move platform tests from odp/platform/linux-generic/test > into test suite at odp/test/platform/linux-generic. > > Signed-off-by: Yi He Reviewed-by: Christophe Milard > --- > v4 restore the invocation of general validation tests: >

Re: [lng-odp] [PATCHv4] linux-gen: move platform tests into test suite

2016-06-17 Thread Christophe Milard
On 2016-06-17 06:10, Yi He wrote: > Move platform tests from odp/platform/linux-generic/test > into test suite at odp/test/platform/linux-generic. > > Signed-off-by: Yi He > --- > v4 restore the invocation of general validation tests: > The Validation tests HAVE to be called from the platform sid

Re: [lng-odp] [PATCHv3] linux-gen: move platform tests into test suite

2016-06-16 Thread Christophe Milard
On 2016-06-16 07:56, Yi He wrote: > Move platform tests from odp/platform/linux-generic/test > into test suite at odp/test/platform/linux-generic. > > Signed-off-by: Yi He > --- > v3 fixed missing validation tests in target 'installcheck' by > lifting run-tests script to test/ top level to iterat

Re: [lng-odp] [PATCHv2] linux-gen: move platform tests into test suite

2016-06-16 Thread Christophe Milard
ot encounter and would you like > to send me a log in this case. > > thanks very much and best regards, Yi > > > > On 14 June 2016 at 21:38, Christophe Milard > wrote: >> >> Hi Yi, >> installcheck fails. >> I have not fully looked why, but if you run: >

Re: [lng-odp] [PATCHv2] linux-gen: move platform tests into test suite

2016-06-14 Thread Christophe Milard
Hi Yi, installcheck fails. I have not fully looked why, but if you run: ./bootstrap && ./configure --with-testdir=yes --enable-test-vald --prefix=/home/linaro/INSTALL && make -j 8 && make install && make installcheck Before and after you changes, you'll see that the tests are not run properly. I

Re: [lng-odp] [PATCH v3] doc: generate a pure api-guide with no platform data

2016-06-09 Thread Christophe Milard
The application guide is now ONLY the public specification. >> The new platform guide includes the additional definitions specific to >> odp-linux and it can contain platform specific notes and other >> documentation as needed >> >> Signed-off-by: Mike Holmes

Re: [lng-odp] thread/shmem discussion summary V4

2016-06-09 Thread Christophe Milard
a handle only approach would have too poor performance on some system, yes, but this another story. This is even maybe wrong. To start with I just want to understand how your proposal could be used by an programmer On 9 June 2016 at 16:30, Bill Fischofer wrote: > > > On Thu, Jun 9, 2016 a

Re: [lng-odp] thread/shmem discussion summary V4

2016-06-09 Thread Christophe Milard
On 9 June 2016 at 14:30, Bill Fischofer wrote: > > > On Thu, Jun 9, 2016 at 7:13 AM, Christophe Milard > wrote: >> >> Bill: >> S19: When you write:"These addresses are intended to be used within >> the scope of the calling thread and should not be assume

Re: [lng-odp] thread/shmem discussion summary V4

2016-06-09 Thread Christophe Milard
ndles in 2 different threads (for the same ODP object name), meaning that the scope of the handle is actually the ODP thread.? Thanks, Christophe. On 9 June 2016 at 14:54, Jerin Jacob wrote: > On Thu, Jun 09, 2016 at 02:13:49PM +0200, Christophe Milard wrote: >> Bill: >> S19: W

Re: [lng-odp] thread/shmem discussion summary V4

2016-06-09 Thread Christophe Milard
I. Pointers to BASED storage were stored as offsets and the > compiler automatically handled the relative addressing. They are very > convenient for this sort of purpose. > >> >> >> S23: agree with Bill's comments covered the cases. >> >> Thanks and best re

Re: [lng-odp] thread/shmem discussion summary V4

2016-06-08 Thread Christophe Milard
at 14:11, Jerin Jacob wrote: > On Fri, Jun 03, 2016 at 11:15:43AM +0200, Christophe Milard wrote: >> since V3: Update following Bill's comments >> since V2: Update following Barry and Bill's comments >> since V1: Update following arch call 31 may 2016 >>

Re: [lng-odp] thread/shmem discussion summary V4

2016-06-08 Thread Christophe Milard
; agree to the current S11, S12, S13, S14, S15, S16, S17 approach and we can > revisit if really realized upper layer programming practise/model affects > ODP's design in this aspect. > > Best Regards, Yi > > On 7 June 2016 at 16:47, Christophe Milard > wrote: >> >

Re: [lng-odp] [PATCH v3] example: introducing l3fwd

2016-06-07 Thread Christophe Milard
On 7 June 2016 at 11:04, Xuelin Shi wrote: > multi-thread, multi-queue and bi-directional forwarding. > > support (port, queue, core) arguments in cmdline. > it means core will handle rx queue at port. > forwarding logic will decide out port by this specification. > if no this argument in cmdline,

Re: [lng-odp] thread/shmem discussion summary V4

2016-06-07 Thread Christophe Milard
1,2,3 again.) There could be theoriticaly complex such dependency graphs where all cpus cannot be pinned from the beginning, and where your approach seem too restrictive. But I am glad to hear your voice on the arch call :-) Christophe. > > Best Regards, Yi > > > On 4 June 2016 at 05:5

Re: [lng-odp] Clarify the current situation: Break ODP cyclic dependence on ODP Helpers (ODP-430)

2016-06-06 Thread Christophe Milard
Hi Yi! Your first diagram shows at least one thing very clearly, apart the mess we have with dependencies: The location of the platform//test directory is confusing! This directory is *NOT* a part of the ODP implementation, despite its location: it is a part of the test structure: that part which

[lng-odp] thread/shmem discussion summary V4

2016-06-03 Thread Christophe Milard
since V3: Update following Bill's comments since V2: Update following Barry and Bill's comments since V1: Update following arch call 31 may 2016 This is a tentative to sum up the discussions around the thread/process that have been happening these last weeks. Sorry for the formalism of this mail,

[lng-odp] thread/shmem discussion summary V3

2016-06-02 Thread Christophe Milard
since V2: Update following Barry and Bill's comments since V1: Update following arch call 31 may 2016 This is a tentative to sum up the discussions around the thread/process that have been happening these last weeks. Sorry for the formalism of this mail, but it seems we need accuracy here... This

Re: [lng-odp] thread/shmem discussion summary V2

2016-06-01 Thread Christophe Milard
> > > > > > -Original Message- > From: Christophe Milard [mailto:christophe.mil...@linaro.org] > Sent: Tuesday, May 31, 2016 12:00 PM > To: Petri Savolainen; Barry Spinney; Krishna Garapati; Mike Holmes; Bill > Fischofer; LNG ODP Mailman List > Subject: thread/s

Re: [lng-odp] thread/shmem discussion summary V2

2016-06-01 Thread Christophe Milard
On 1 June 2016 at 02:08, Bill Fischofer wrote: > Thanks, Christophe, for this excellent summary. Comments inline. > > On Tue, May 31, 2016 at 11:00 AM, Christophe Milard > wrote: >> >> since V1: Update following arch call 31 may 2016 >> >> This is a tentat

[lng-odp] thread/shmem discussion summary V2

2016-05-31 Thread Christophe Milard
since V1: Update following arch call 31 may 2016 This is a tentative to sum up the discussions around the thread/process that have been happening these last weeks. Sorry for the formalism of this mail, but it seems we need accuracy here... This summary is organized as follows: It is a set of sta

Re: [lng-odp] [PATCHv3] linux-generic: sched: do not allocate sheduler info in shm area

2016-05-31 Thread Christophe Milard
Why does it have to be visible in the API, Maxim? (even introducing a specific prefix is really an API change, I think: Those app that happened to use the prefix before will not work as before). If IPC need its specific stuff, shouldn't it be using ODP internal functions, e.g. _odp_pool_create() wi

Re: [lng-odp] [PATCHv3] helper: cleaner interface to odph_odpthreads_create/join

2016-05-30 Thread Christophe Milard
On 30 May 2016 at 15:44, Savolainen, Petri (Nokia - FI/Espoo) < petri.savolai...@nokia.com> wrote: > > >> -Original Message- >> From: Christophe Milard [mailto:christophe.mil...@linaro.org] >> Sent: Monday, May 30, 2016 3:52 PM >> To: Savolainen,

Re: [lng-odp] [PATCHv3] helper: cleaner interface to odph_odpthreads_create/join

2016-05-30 Thread Christophe Milard
On 30 May 2016 at 14:12, Savolainen, Petri (Nokia - FI/Espoo) wrote: > > > > From: Christophe Milard [mailto:christophe.mil...@linaro.org] > Sent: Monday, May 30, 2016 1:34 PM > To: Savolainen, Petri (Nokia - FI/Espoo) > Cc: yi...@linaro.org; lng-odp@lists.linaro.org &g

Re: [lng-odp] [PATCHv3] helper: cleaner interface to odph_odpthreads_create/join

2016-05-30 Thread Christophe Milard
On 30 May 2016 at 11:23, Savolainen, Petri (Nokia - FI/Espoo) < petri.savolai...@nokia.com> wrote: > > > From: Christophe Milard [mailto:christophe.mil...@linaro.org] > Sent: Friday, May 27, 2016 4:08 PM > To: Savolainen, Petri (Nokia - FI/Espoo) > Cc: yi...@linaro.org;

Re: [lng-odp] 2fadf47 broke tm test

2016-05-29 Thread Christophe Milard
to:yi...@linaro.org>> >> Date: Thu May 26 07:10:19 2016 + >> >> helper: linux: odp thread cpu affinity APIs >> >> Provide helper APIs to set and get cpu affinity in ODP threads, >>

[lng-odp] Fwd: thread/shmem discussion summary

2016-05-29 Thread Christophe Milard
Forwarded again to the list as the address I wrote was obviously wrong (no change for those who already received a personnal copy) -- Forwarded message -- From: Christophe Milard Date: 26 May 2016 at 17:11 Subject: thread/shmem discussion summary To: christophe.mil...@linaro.org

Re: [lng-odp] [PATCHv3] helper: cleaner interface to odph_odpthreads_create/join

2016-05-27 Thread Christophe Milard
On 27 May 2016 at 09:56, Savolainen, Petri (Nokia - FI/Espoo) < petri.savolai...@nokia.com> wrote: > > > > -Original Message- > > From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of > > Christophe Milard > > Sent: Friday, May 27, 20

[lng-odp] [PATCHv3] helper: cleaner interface to odph_odpthreads_create/join

2016-05-26 Thread Christophe Milard
The odph_odpthread_t (non opaque array of odpthread) is now replaced by a single type odph_odpthread_tbl_t abstracted as a void*. The table describing the odpthreads being created is now malloc'd and freed by the helper function themselves. Signed-off-by: Christophe Milard --- sin

Re: [lng-odp] [PATCHv2] helper: cleaner interface to odph_odpthreads_create/join

2016-05-26 Thread Christophe Milard
to odph_odpthread_array_t? I feel > table and array are different thing, but it is up to you :) > > thanks and best regards, Yi > > On 27 May 2016 at 00:27, Christophe Milard > wrote: > >> The odph_odpthread_t (non opaque array of odpthread) is now replaced by a >> si

[lng-odp] [PATCHv2] helper: cleaner interface to odph_odpthreads_create/join

2016-05-26 Thread Christophe Milard
The odph_odpthread_t (non opaque array of odpthread) is now replaced by a single type odph_odpthread_tbl_t abstracted as a void*. The table describing the odpthreads being created is now malloc'd and freed by the helper function themselves. Signed-off-by: Christophe Milard --- sin

Re: [lng-odp] [PATCH] helper: cleaner interface to odph_odpthreads_create/join

2016-05-26 Thread Christophe Milard
On 26 May 2016 at 14:25, Yi He wrote: > > > On 26 May 2016 at 18:39, Christophe Milard > wrote: > >> >> >> On 26 May 2016 at 11:50, Yi He wrote: >> >>> >>> >>> On 25 May 2016 at 21:12, Christophe Milard >> > wrote: &g

Re: [lng-odp] [PATCH] helper: cleaner interface to odph_odpthreads_create/join

2016-05-26 Thread Christophe Milard
On 26 May 2016 at 11:50, Yi He wrote: > > > On 25 May 2016 at 21:12, Christophe Milard > wrote: > >> The odph_odpthread_t (non opaque array of odpthread) is now replaced by a >> single type odph_odpthread_tbl_t abstracted as a void*. >> The table describing th

Re: [lng-odp] [PATCHv4] helper: linux: odp thread cpu affinity APIs

2016-05-26 Thread Christophe Milard
On 26 May 2016 at 09:10, Yi He wrote: > Provide helper APIs to set and get cpu affinity in ODP threads, > and set cpu affinity to the 1st available control cpu for all odp > test/validation programs in odp_cunit_common library. > > Signed-off-by: Yi He > Reviewed-by:

Re: [lng-odp] [PATCH] linux-generic: test: ring: .gitignore ring_main

2016-05-25 Thread Christophe Milard
Maxim, maybe you can find a better title when merging :-) Christophe. On 26 May 2016 at 07:21, Yi He wrote: > Signed-off-by: Yi He > Reviewed-by: Christophe Milard --- > platform/linux-generic/test/ring/.gitignore | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >

Re: [lng-odp] [PATCHv3] helper: linux: odp thread cpu affinity APIs

2016-05-25 Thread Christophe Milard
On 26 May 2016 at 07:39, Yi He wrote: > Provide helper APIs to set and get cpu affinity in ODP threads, > and set cpu affinity to the 1st available control cpu for all odp > test/validation programs in odp_cunit_common library. > > Signed-off-by: Yi He > --- > helper/include/odp/helper/linux.h

Re: [lng-odp] [PATCH v2] helper: linux: odp thread cpu affinity APIs

2016-05-25 Thread Christophe Milard
On 25 May 2016 at 09:55, Yi He wrote: > Provide APIs to set and get cpu affinity in ODP threads, > and set affinity to the 1st available control cpu for all > odp test/validation programs in odp_cunit_common library. > > Signed-off-by: Yi He > --- > helper/include/odp/helper/linux.h |

[lng-odp] [PATCH] helper: cleaner interface to odph_odpthreads_create/join

2016-05-25 Thread Christophe Milard
The odph_odpthread_t (non opaque array of odpthread) is now replaced by a single type odph_odpthread_tbl_t abstracted as a void*. The table describing the odpthreads being created is now malloc'd and freed by the helper function themselves. Signed-off-by: Christophe Milard --- ex

Re: [lng-odp] thread model and memory/address sharing

2016-05-25 Thread Christophe Milard
On 25 May 2016 at 12:18, Ola Liljedahl wrote: > I have attempted to summarise and comment on the discussion. This is partly > intended for an external audience so sorry if I seem to repeat things > already "solved". Unfortunately I couldn't attend yesterdays public call > but I read the notes. >

Re: [lng-odp] [PATCH] helper: fixing doxygen comments for odpthread creation parameters

2016-05-23 Thread Christophe Milard
And on the top of this , I intend to write a patch to simplify this interface, so hopefully this will become obsolete soon :-) On 23 May 2016 at 18:31, Christophe Milard wrote: > OK. if everyone now agrees, maybe this can be marked as reviewed :-). 3 > extra comments should not generate a

Re: [lng-odp] [PATCH] helper: fixing doxygen comments for odpthread creation parameters

2016-05-23 Thread Christophe Milard
to > perpetuate this topic into its 5/6th week. I hoped to find a model. > > I agree, we dont want to work on helper support for anything new > unless it brought a robust proven model. > > On 23 May 2016 at 11:58, Christophe Milard > wrote: > > I don't think we shou

Re: [lng-odp] [PATCH] helper: fixing doxygen comments for odpthread creation parameters

2016-05-23 Thread Christophe Milard
pport , but might make an interesting project. > > > > https://software.intel.com/en-us/articles/choosing-the-right-threading-framework > > On 23 May 2016 at 11:34, Christophe Milard > wrote: > >> On 23 May 2016 at 17:31, Ola Liljedahl wrote: >> >> &

Re: [lng-odp] [PATCH] helper: fixing doxygen comments for odpthread creation parameters

2016-05-23 Thread Christophe Milard
On 23 May 2016 at 17:31, Ola Liljedahl wrote: > > > On 23 May 2016 at 17:28, Christophe Milard > wrote: > >> This is for linux helpers: in odp linux, just pthreads and processes are >> supported as odpthreads.(well actually processes are not supported yet, but >

Re: [lng-odp] [PATCH] helper: fixing doxygen comments for odpthread creation parameters

2016-05-23 Thread Christophe Milard
edahl wrote: > > > On 23 May 2016 at 17:04, Christophe Milard > wrote: > >> Signed-off-by: Christophe Milard >> --- >> helper/include/odp/helper/linux.h | 6 +++--- >> 1 file changed, 3 insertions(+), 3 deletions(-) >> >> diff --git a/helper/i

[lng-odp] [PATCH] helper: fixing doxygen comments for odpthread creation parameters

2016-05-23 Thread Christophe Milard
Signed-off-by: Christophe Milard --- helper/include/odp/helper/linux.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/helper/include/odp/helper/linux.h b/helper/include/odp/helper/linux.h index 01c348d..2e89833 100644 --- a/helper/include/odp/helper/linux.h +++ b

Re: [lng-odp] [PATCH] helper: linux: thread and process cpu affinity APIs

2016-05-23 Thread Christophe Milard
The behaviour of the differents ODP objects / pointers when accessed from different virtual address space (i.e. process) is not 100% clear to me. Christophe. > I'm not sure if this feeling is right :), we can talk in ARCH if got time. > > Best Regards, Yi > > On 23 May 2016 a

Re: [lng-odp] [PATCH] helper: linux: thread and process cpu affinity APIs

2016-05-23 Thread Christophe Milard
sched_setaffinity() or > pthread_setaffinity_np(). > > thanks and best regards, Yi > > > > On 23 May 2016 at 14:53, Yi He wrote: > >> Hi, Christophe >> >> Yes, I'll apply your series and send a new one later. >> >> Best Regards, Yi >>

Re: [lng-odp] [PATCH 2/2] doc: userguide: add notes on threads and addressing scope

2016-05-23 Thread Christophe Milard
Am I understanding correctly if I try to rephrase your suggestion, Petri, as follows: 1) " For simplicity all memory should be reserved from the system at global init time.": When calling init_global(), the application provides the total amount of memory it will ever need, including everything (Bu

Re: [lng-odp] [PATCH] helper: linux: thread and process cpu affinity APIs

2016-05-22 Thread Christophe Milard
On 20 May 2016 at 10:48, Yi He wrote: > Set affinity to 1st available control cpu for all odp > validation programs in odp_cunit_common library. > > Signed-off-by: Yi He > --- > helper/include/odp/helper/linux.h | 47 +++ > helper/linux.c| 32

Re: [lng-odp] [PATCHv9 00/35] running things in process mode

2016-05-20 Thread Christophe Milard
b) n > 379if (n > entries) { > (gdb) > 380if (behavior == _RING_QUEUE_FIXED) > (gdb) p n > $6 = 32 > (gdb) n > 381return -ENOENT; > (gdb) > > > That should not be related to current patch series, but we need to

[lng-odp] [PATCHv9 35/35] doc: implementers-guide: adding helper recommendations

2016-05-20 Thread Christophe Milard
The implementation guide is updated with recommendations regarding the usage of helpers and some of its functions. Signed-off-by: Christophe Milard --- doc/implementers-guide/implementers-guide.adoc | 32 ++ 1 file changed, 32 insertions(+) diff --git a/doc/implementers

[lng-odp] [PATCHv9 34/35] linux-generic: test: ringtest: adding helper cmd line parsing

2016-05-20 Thread Christophe Milard
ringtests.c now calls the helper command line parsing so that helper can collect its options. Hence enabling process mode run. Signed-off-by: Christophe Milard --- platform/linux-generic/test/ring/ringtest.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/platform/linux

[lng-odp] [PATCHv9 26/35] example: pktio: adding helper cmd line parsing

2016-05-20 Thread Christophe Milard
pktio now calls the helper command line parsing so that helper can collect its options. Hence enabling process mode run. Signed-off-by: Christophe Milard --- example/packet/odp_pktio.c | 13 + 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/example/packet/odp_pktio.c b

[lng-odp] [PATCHv9 33/35] linux-generic: test: ringtest: using agnostic function for ODP threads

2016-05-20 Thread Christophe Milard
ringtest.c is changed to use the implementation agnostic ODP thread create and join functions, from helpers. ringtest is hence no longer aware on how the odpthread is implemented. Signed-off-by: Christophe Milard --- platform/linux-generic/test/ring/ringtest.c | 19 +-- 1 file

[lng-odp] [PATCHv9 29/35] example: timer: using agnostic function for ODP threads

2016-05-20 Thread Christophe Milard
timer_test is changed to use the implementation agnostic ODP thread create and join functions, from helpers. timer_test is hence no longer aware on how the odpthread is implemented. Signed-off-by: Christophe Milard --- example/timer/odp_timer_test.c | 14 +++--- 1 file changed, 7

[lng-odp] [PATCHv9 32/35] example: switch: adding helper cmd line parsing

2016-05-20 Thread Christophe Milard
odp_switch now calls the helper command line parsing so that helper can collect its options. Hence enabling process mode run. Signed-off-by: Christophe Milard --- example/switch/odp_switch.c | 12 +--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/example/switch

[lng-odp] [PATCHv9 31/35] example: switch: using agnostic function for ODP threads

2016-05-20 Thread Christophe Milard
odp_switch is changed to use the implementation agnostic ODP thread create and join functions, from helpers. odp_switch is hence no longer aware on how the odpthread is implemented. Signed-off-by: Christophe Milard --- example/switch/odp_switch.c | 14 +++--- 1 file changed, 7

[lng-odp] [PATCHv9 30/35] example: timer: adding helper cmd line parsing

2016-05-20 Thread Christophe Milard
timer_test now calls the helper command line parsing so that helper can collect its options. Hence enabling process mode run. Signed-off-by: Christophe Milard --- example/timer/odp_timer_test.c | 12 +--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/example/timer

[lng-odp] [PATCHv9 27/35] example: time: using agnostic function for ODP threads

2016-05-20 Thread Christophe Milard
time is changed to use the implementation agnostic ODP thread create and join functions, from helpers. time is hence no longer aware on how the odpthread is implemented. Signed-off-by: Christophe Milard --- example/time/time_global_test.c | 12 ++-- 1 file changed, 6 insertions(+), 6

[lng-odp] [PATCHv9 28/35] example: time: adding helper cmd line parsing

2016-05-20 Thread Christophe Milard
time now calls the helper command line parsing so that helper can collect its options. Hence enabling process mode run. Signed-off-by: Christophe Milard --- example/time/time_global_test.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/example/time/time_global_test.c b

[lng-odp] [PATCHv9 25/35] example: pktio: using agnostic function for ODP threads

2016-05-20 Thread Christophe Milard
pktio is changed to use the implementation agnostic ODP thread create and join functions, from helpers. pktio is hence no longer aware on how the odpthread is implemented. Signed-off-by: Christophe Milard --- example/packet/odp_pktio.c | 32 1 file changed, 16

[lng-odp] [PATCHv9 24/35] example: l2fwd_simple: adding helper cmd line parsing

2016-05-20 Thread Christophe Milard
l2fwd_simple now calls the helper command line parsing so that helper can collect its options. Hence enabling process mode run. Signed-off-by: Christophe Milard --- example/l2fwd_simple/odp_l2fwd_simple.c | 32 +++- 1 file changed, 27 insertions(+), 5 deletions

[lng-odp] [PATCHv9 22/35] example: ipsec: adding helper cmd line parsing

2016-05-20 Thread Christophe Milard
odp_ipsec now calls the helper command line parsing so that helper can collect its options. Hence enabling process mode run. Signed-off-by: Christophe Milard --- example/ipsec/odp_ipsec.c | 12 +--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/example/ipsec/odp_ipsec.c

[lng-odp] [PATCHv9 23/35] example: l2fwd_simple: using agnostic function for ODP threads

2016-05-20 Thread Christophe Milard
l2fwd_simple is changed to use the implementation agnostic ODP thread create and join functions, from helpers. l2fwd_simple is hence no longer aware on how the odpthread is implemented. Signed-off-by: Christophe Milard --- example/l2fwd_simple/odp_l2fwd_simple.c | 15 --- 1 file

[lng-odp] [PATCHv9 20/35] example: generator: adding helper cmd line parsing

2016-05-20 Thread Christophe Milard
odp_generator now calls the helper command line parsing so that helper can collect its options. Hence enabling process mode run. Signed-off-by: Christophe Milard --- example/generator/odp_generator.c | 12 +--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/example

[lng-odp] [PATCHv9 21/35] example: ipsec: using agnostic function for ODP threads

2016-05-20 Thread Christophe Milard
odp_ipsec is changed to use the implementation agnostic ODP thread create and join functions, from helpers. odp_ipsec is hence no longer aware on how the odpthread is implemented. Signed-off-by: Christophe Milard --- example/ipsec/odp_ipsec.c | 15 +++ 1 file changed, 7 insertions

[lng-odp] [PATCHv9 19/35] example: generator: using agnostic function for ODP threads

2016-05-20 Thread Christophe Milard
odp_generator is changed to use the implementation agnostic ODP thread create and join functions, from helpers. odp_generator is hence no longer aware on how the odpthread is implemented. Signed-off-by: Christophe Milard --- example/generator/odp_generator.c | 33

[lng-odp] [PATCHv9 18/35] example: classifier: adding helper cmd line parsing

2016-05-20 Thread Christophe Milard
odp_classifier now calls the helper command line parsing so that helper can collect its options. Hence enabling process mode run. Signed-off-by: Christophe Milard --- example/classifier/odp_classifier.c | 12 +--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/example

[lng-odp] [PATCHv9 16/35] performance: crypto: adding helper cmd line parsing

2016-05-20 Thread Christophe Milard
odp_crypto now calls the helper command line parsing so that helper can collect its options. Hence enabling process mode run. Signed-off-by: Christophe Milard --- test/performance/odp_crypto.c | 12 +--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/test/performance

[lng-odp] [PATCHv9 17/35] example: classifier: using agnostic function for ODP threads

2016-05-20 Thread Christophe Milard
odp_classifier is changed to use the implementation agnostic ODP thread create and join functions, from helpers. odp_classifier is hence no longer aware on how the odpthread is implemented. Signed-off-by: Christophe Milard --- example/classifier/odp_classifier.c | 27

[lng-odp] [PATCHv9 14/35] performance: odp_l2fwd: adding helper cmd line parsing

2016-05-20 Thread Christophe Milard
odp_l2fwd now calls the helper command line parsing so that helper can collect its options. Hence enabling process mode run. Signed-off-by: Christophe Milard --- test/performance/odp_l2fwd.c | 12 +--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/test/performance

[lng-odp] [PATCHv9 15/35] performance: crypto: using agnostic function for ODP threads

2016-05-20 Thread Christophe Milard
odp_crypto is changed to use the implementation agnostic ODP thread create and join functions, from helpers. odp_crypto is hence no longer aware on how the odpthread is implemented. Signed-off-by: Christophe Milard --- test/performance/odp_crypto.c | 12 ++-- 1 file changed, 6

[lng-odp] [PATCHv9 13/35] performance: odp_l2fwd: using agnostic function for ODP threads

2016-05-20 Thread Christophe Milard
odp_l2fwd is changed to use the implementation agnostic ODP thread create and join functions, from helpers. odp_l2fwd is hence no longer aware on how the odpthread is implemented. Signed-off-by: Christophe Milard --- test/performance/odp_l2fwd.c | 25 + 1 file changed

[lng-odp] [PATCHv9 12/35] performance: odp_pktio_perf: adding helper cmd line parsing

2016-05-20 Thread Christophe Milard
odp_pktio_perf now calls the helper command line parsing so that helper can collect its options. Hence enabling process mode run. Signed-off-by: Christophe Milard --- test/performance/odp_pktio_perf.c | 11 +-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/test

[lng-odp] [PATCHv9 09/35] validation: pktio: adding command line argument parsing

2016-05-20 Thread Christophe Milard
As the test itself does not have specific args, it just calls the cunit_common parsing function to pick up cunit_common and helpers arguments. Signed-off-by: Christophe Milard --- platform/linux-generic/test/pktio/pktio_run.sh | 21 ++--- platform/linux-generic/test/pktio

[lng-odp] [PATCHv9 11/35] performance: odp_pktio_perf: using agnostic function for ODP threads

2016-05-20 Thread Christophe Milard
odp_pktio_perf is changed to use the implementation agnostic ODP thread create and join functions, from helpers. odp_pktio_perf is no longer aware on how the odpthread is implemented any longer. Signed-off-by: Christophe Milard --- test/performance/odp_pktio_perf.c | 23

[lng-odp] [PATCHv9 10/35] performance: odp_scheduling: proc mode done by helper

2016-05-20 Thread Christophe Milard
Remove the --proc option from odp_scheduling.c and use the helper functions (odph_odpthreads_create, odph_odpthreads_join) to handle odp threads. Let helper parse its command line args, hence recognising the --odph_proc option doing what --proc did. Signed-off-by: Christophe Milard --- test

<    3   4   5   6   7   8   9   10   11   12   >