Re: [lng-odp] [PATCH] linux-generic: make x86 cpuinfo parser more robust

2016-02-26 Thread Hongbo Zhang
nabled, cpus always run at max speed. If we still plan to keep cpu hz api, it deserves to do such a modification, but now I was using a ubuntu running in vm, don't have cpufreq sysfs to test with, and what's more, I won't have time to spend on this... On 25 February 2016 at 17:52,

[lng-odp] [PATCH] linux-generic: make x86 cpuinfo parser more robust

2016-02-25 Thread hongbo . zhang
From: Hongbo Zhang This is for https://bugs.linaro.org/show_bug.cgi?id=2033 If the model string doesn't include speed info, segfault should be avoided. Signed-off-by: Hongbo Zhang --- platform/linux-generic/arch/x86/odp_sysinfo_parse.c | 10 ++ 1 file changed, 6 insertions(

Re: [lng-odp] [PATCH v4 0/8] separate ODP_CACHE_LINE_SIZE to arch files and clean-up

2016-02-23 Thread Hongbo Zhang
There are checkpatch warnings, but they should be acceptable, because chechpatch rules don't apply some changes for example the edit in configure.ac. On 23 February 2016 at 16:12, wrote: > From: Hongbo Zhang > > v3-v4 changes: > - merge previous two patch sets into one: >

[lng-odp] [PATCH] linux-generic: fix usage of function strncpy

2016-02-23 Thread hongbo . zhang
From: Hongbo Zhang This is for https://bugs.linaro.org/show_bug.cgi?id=2030: "Memory - illegal accesses (BUFFER_SIZE_WARNING) Calling strncpy with a maximum size argument of 128 bytes on destination array "sysinfo->model_str[id]" of size 128 bytes might leave the destination s

[lng-odp] [PATCH v4 8/8] linux-generic: sysinfo clean up for ARM

2016-02-23 Thread hongbo . zhang
From: Hongbo Zhang The arch/arm/odp_sysinfo_parse.c is currently a symlink to arch/linux/odp_sysinfo_parse.c, but in fact there should be defferences between them. A separated real arch/arm/odp_sysinfo_parse.c is created for ARM, and the model_str is set to a general "ARM", which is m

[lng-odp] [PATCH v4 7/8] linux-generic: use one uniform call systemcpu()

2016-02-23 Thread hongbo . zhang
From: Hongbo Zhang Currently there are two systemcpu() functions, one is for some specific platforms and the other is for default dummy, but most of the contents are same except for sysinfo->cache_line_size: one is true data from calling systemcpu_cache_line_size() and another is dummy data.

[lng-odp] [PATCH v4 5/8] linux-generic: move CPU info dummy data to generic default file

2016-02-23 Thread hongbo . zhang
From: Hongbo Zhang The dummy data of cpu_hz_max and model_str are used when platform is unknown or data cannot be acquired, but these variables should be set in function odp_cpuinfo_parser() instead of the systemcpu() which should cover only the cpu_count, huge_page_size and cache_line_size

[lng-odp] [PATCH v4 6/8] linux-generic: systemcpu(): use input parameter instead of global data

2016-02-23 Thread hongbo . zhang
From: Hongbo Zhang In the systemcpu() function, odp_global_data.system_info.huge_page_size should be sysinfo->huge_page_size instead, because when systemcpu() is called, the &odp_global_data.system_info is passed as parameter, we should operate the parameter instead of the global data d

[lng-odp] [PATCH v4 4/8] linux-generic: create ARM files and move ARM ODP_CACHE_LINE_SIZE in it

2016-02-23 Thread hongbo . zhang
From: Hongbo Zhang Currently all ODP_CACHE_LINE_SIZE macros for different architectures are held in one header file, they should be moved to their own arch file. And in the legacy codes there was no ARM architecture directory, so this patch create it, the odp_cpu_arch.c and odp_sysinfo_parse.c

[lng-odp] [PATCH v4 2/8] linux-generic: separate MIPS ODP_CACHE_LINE_SIZE to its arch file

2016-02-23 Thread hongbo . zhang
From: Hongbo Zhang Currently all ODP_CACHE_LINE_SIZE macros for different architectures are held in one header file, they should be moved to their own arch file. This patch moves ODP_CACHE_LINE_SIZE for MIPS. Signed-off-by: Hongbo Zhang Reviewed-and-tested-by: Bill Fischofer --- platform

[lng-odp] [PATCH v4 3/8] linux-generic: separate PowerPC ODP_CACHE_LINE_SIZE to its arch file

2016-02-23 Thread hongbo . zhang
From: Hongbo Zhang Currently all ODP_CACHE_LINE_SIZE macros for different architectures are held in one header file, they should be moved to their own arch file. This patch moves ODP_CACHE_LINE_SIZE for PowerPC. The previous arch/powerpc/odp/cpu_arch.h was a symlink to the generic arch/linux/odp

[lng-odp] [PATCH v4 1/8] linux-generic: separate x86 ODP_CACHE_LINE_SIZE to its arch file

2016-02-23 Thread hongbo . zhang
From: Hongbo Zhang Currently all ODP_CACHE_LINE_SIZE macros for different architectures are held in one header file, they should be moved to their own arch file. This patch moves ODP_CACHE_LINE_SIZE for x86. Signed-off-by: Mike Holmes Signed-off-by: Hongbo Zhang Reviewed-and-tested-by: Bill

[lng-odp] [PATCH v4 0/8] separate ODP_CACHE_LINE_SIZE to arch files and clean-up

2016-02-23 Thread hongbo . zhang
From: Hongbo Zhang v3-v4 changes: - merge previous two patch sets into one: "[PATCH v3 API-NEXT 0/4] separate ODP_CACHE_LINE_SIZE to arch files" and "[PATCH API-NEXT 0/4] linux-generic sysinfo codes clean-ups" then this patch set contains 8 patches, this is for easier mergin

Re: [lng-odp] [PATCH v3 API-NEXT 1/4] linux-generic: separate x86 ODP_CACHE_LINE_SIZE to its arch file

2016-02-19 Thread Hongbo Zhang
On 5 February 2016 at 16:56, wrote: > From: Hongbo Zhang > > Currently all ODP_CACHE_LINE_SIZE macros for different architectures are > held in one header file, they should be moved to their own arch file. > This patch moves ODP_CACHE_LINE_SIZE for x86. > > Signed

Re: [lng-odp] [PATCH v3 API-NEXT 1/4] linux-generic: separate x86 ODP_CACHE_LINE_SIZE to its arch file

2016-02-18 Thread Hongbo Zhang
On 9 February 2016 at 18:41, Anders Roxell wrote: > On 2016-02-05 16:56, hongbo.zh...@linaro.org wrote: >> From: Hongbo Zhang >> >> Currently all ODP_CACHE_LINE_SIZE macros for different architectures are >> held in one header file, they should be moved to their o

Re: [lng-odp] [PATCH v3 API-NEXT 1/4] linux-generic: separate x86 ODP_CACHE_LINE_SIZE to its arch file

2016-02-17 Thread Hongbo Zhang
gt;>> Cc: lng-odp@lists.linaro.org >>> Subject: Re: [lng-odp] [PATCH v3 API-NEXT 1/4] linux-generic: separate >>> x86 >>> ODP_CACHE_LINE_SIZE to its arch file >>> >>> On 2016-02-05 16:56, hongbo.zh...@linaro.org wrote: >>>> >>>

Re: [lng-odp] [PATCH API-NEXT 0/4] linux-generic sysinfo codes clean-ups

2016-02-05 Thread Hongbo Zhang
prereq series this series looks OK, so for > it: > > Reviewed-and-tested-by: Bill Fischofer > > However, as I noted on it's thread, the odp_cache_line_size patch introduces > a doxygen error that should be corrected before that series can be applied. > > On Tue, Feb

[lng-odp] [PATCH v3 API-NEXT 4/4] linux-generic: create ARM files and move ARM ODP_CACHE_LINE_SIZE in it

2016-02-05 Thread hongbo . zhang
From: Hongbo Zhang Currently all ODP_CACHE_LINE_SIZE macros for different architectures are held in one header file, they should be moved to their own arch file. And in the legacy codes there was no ARM architecture directory, so this patch create it, the odp_cpu_arch.c and odp_sysinfo_parse.c

[lng-odp] [PATCH v3 API-NEXT 3/4] linux-generic: separate PowerPC ODP_CACHE_LINE_SIZE to its arch file

2016-02-05 Thread hongbo . zhang
From: Hongbo Zhang Currently all ODP_CACHE_LINE_SIZE macros for different architectures are held in one header file, they should be moved to their own arch file. This patch moves ODP_CACHE_LINE_SIZE for PowerPC. The previous arch/powerpc/odp/cpu_arch.h was a symlink to the generic arch/linux/odp

[lng-odp] [PATCH v3 API-NEXT 2/4] linux-generic: separate MIPS ODP_CACHE_LINE_SIZE to its arch file

2016-02-05 Thread hongbo . zhang
From: Hongbo Zhang Currently all ODP_CACHE_LINE_SIZE macros for different architectures are held in one header file, they should be moved to their own arch file. This patch moves ODP_CACHE_LINE_SIZE for MIPS. Signed-off-by: Hongbo Zhang --- platform/linux-generic/arch/mips64/odp/cpu_arch.h

[lng-odp] [PATCH v3 API-NEXT 1/4] linux-generic: separate x86 ODP_CACHE_LINE_SIZE to its arch file

2016-02-05 Thread hongbo . zhang
From: Hongbo Zhang Currently all ODP_CACHE_LINE_SIZE macros for different architectures are held in one header file, they should be moved to their own arch file. This patch moves ODP_CACHE_LINE_SIZE for x86. Signed-off-by: Hongbo Zhang --- doc/application-api-guide/doxygen.cfg | 1

[lng-odp] [PATCH v3 API-NEXT 0/4] separate ODP_CACHE_LINE_SIZE to arch files

2016-02-05 Thread hongbo . zhang
From: Hongbo Zhang v2-v3 change: Eliminate a doxygen-html compiling warning. v1-v2 change: Add macro __OCTEON for patch 2. v1 notes: This is for bug https://bugs.linaro.org/show_bug.cgi?id=1881 This is on top of latest api-next branch because the latest platform/linux-generic/arch

Re: [lng-odp] [PATCH] validation: system: fix return code for checks

2016-02-04 Thread Hongbo Zhang
Reviewed-by: Hongbo Zhang On 4 February 2016 at 15:49, Maxim Uvarov wrote: > From doc: "A return value of 0 meansinactive, > anything else is active.". > > Signed-off-by: Maxim Uvarov > --- > test/validation/system/system.c | 8 > 1 file change

Re: [lng-odp] [PATCH v2 API-NEXT 0/4] separate ODP_CACHE_LINE_SIZE to arch files

2016-02-03 Thread Hongbo Zhang
Hi all, Do we need this patch set? This is for bug https://bugs.linaro.org/show_bug.cgi?id=1881 On 29 January 2016 at 19:22, wrote: > From: Hongbo Zhang > > v1-v2 change: > > Add macro __OCTEON for patch 2. > > v1 notes: > > This is for bug https://bugs.lina

Re: [lng-odp] [API-NEXT PATCHv2] validation: system: make odp_cpu_hz optional in validation test

2016-02-03 Thread Hongbo Zhang
Please wait, As I replied in the v1 patch, system_test_odp_cpu_hz_id() should be done with the same solution. On 3 February 2016 at 22:22, Savolainen, Petri (Nokia - FI/Espoo) wrote: > Reviewed-by: Petri Savolainen > >> -Original Message- >> From: lng-odp [mailto:lng-odp-boun...@lists.l

Re: [lng-odp] [API-NEXT PATCH] validation: system: make odp_cpu_hz optional in validation test

2016-02-03 Thread Hongbo Zhang
Maxim, you only handled system_test_odp_cpu_hz(), you should do the same for system_test_odp_cpu_hz_id() On 3 February 2016 at 21:55, Savolainen, Petri (Nokia - FI/Espoo) wrote: > > >> -Original Message- >> From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of EXT >> Maxim

Re: [lng-odp] test/validation/system/system_main fails on arm64

2016-02-03 Thread Hongbo Zhang
and get v1.7 >> out). >> >> -Petri > > > +1 for that. > > Maxim. > >> >> >>> -Original Message- >>> From: EXT Maxim Uvarov [mailto:maxim.uva...@linaro.org] >>> Sent: Wednesday, February 03, 2016 1:15 PM >>> T

Re: [lng-odp] [PATCH API-NEXT] validation: system: disable validation of CPU current requency

2016-02-03 Thread Hongbo Zhang
I send this out today before going home, when at home I won't have a Linux PC to work. On 3 February 2016 at 18:48, wrote: > From: Hongbo Zhang > > This patch disable validation of CPU current frequency because it isn't > fully implemented on every platform, then u

[lng-odp] [PATCH API-NEXT] validation: system: disable validation of CPU current requency

2016-02-03 Thread hongbo . zhang
From: Hongbo Zhang This patch disable validation of CPU current frequency because it isn't fully implemented on every platform, then unnecesary failures are reported. This validation can be re-enable again in furture if every thing is ready. Signed-off-by: Hongbo Zhang --- test/valid

Re: [lng-odp] test/validation/system/system_main fails on arm64

2016-02-03 Thread Hongbo Zhang
I mean, use ODP_TEST_INFO_INACTIVE currently, and when everything becomes ready, we will come back to use ODP_TEST_INFO again. On 3 February 2016 at 17:56, Hongbo Zhang wrote: > I prefer ODP_TEST_INFO_INACTIVE at this stage, agree? > > And after 1.7, there still be something to be upd

Re: [lng-odp] test/validation/system/system_main fails on arm64

2016-02-03 Thread Hongbo Zhang
here we can get both max and current freq, if it ins't enabled, then let's go to each arch's parsing of /proc/cpuinfo. On 3 February 2016 at 17:51, Hongbo Zhang wrote: > On 3 February 2016 at 17:27, Savolainen, Petri (Nokia - FI/Espoo) > wrote: >> The test should look li

Re: [lng-odp] test/validation/system/system_main fails on arm64

2016-02-03 Thread Hongbo Zhang
ses. > /* Test value sanity: less than 10GHz */ > CU_ASSERT(hz < 10GHz); > > /* larger than 1kHz */ > CU_ASSERT(hz > 1kHz); > } > > > -Petri > > > From: EXT Maxim Uvarov [mailto:maxim.uva...@linaro.org] > Sent: Wednesday, February 03

Re: [lng-odp] test/validation/system/system_main fails on arm64

2016-02-03 Thread Hongbo Zhang
On 3 February 2016 at 17:13, Maxim Uvarov wrote: > > > On 3 February 2016 at 11:34, Hongbo Zhang wrote: >> >> On 3 February 2016 at 16:08, Savolainen, Petri (Nokia - FI/Espoo) >> wrote: >> > I think we updated the API to return 0, when a CPU frequency (max

Re: [lng-odp] test/validation/system/system_main fails on arm64

2016-02-03 Thread Hongbo Zhang
_cpu_hz(void) > { > uint64_t hz; > > hz = odp_cpu_hz(); > CU_ASSERT(0 < hz); > } > > it looks like simple change to 0 <= hz is right. You can add some comment. > > Maxim. > > On 3 February 2016 at 12:13, Maxim Uvarov wrote: >> >> &g

Re: [lng-odp] test/validation/system/system_main fails on arm64

2016-02-03 Thread Hongbo Zhang
nd even compile warning IIRC. > > -Petri > > > >> -Original Message- >> From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of EXT >> Hongbo Zhang >> Sent: Wednesday, February 03, 2016 5:46 AM >> To: Maxim Uvarov >> Cc: lng-odp-forw

Re: [lng-odp] test/validation/system/system_main fails on arm64

2016-02-03 Thread Hongbo Zhang
On 3 February 2016 at 15:29, Maxim Uvarov wrote: > On 02/03/2016 06:45, Hongbo Zhang wrote: >> >> No, not fixed. >> >> One reason is there isn't such info in /proc/cpuinfo for ARM, another >> reason is there isn't any user calling "current fre

Re: [lng-odp] [PATCH API-NEXT 0/4] linux-generic sysinfo codes clean-ups

2016-02-02 Thread Hongbo Zhang
it am --skip" instead. > To restore the original branch and stop patching, run "git am --abort". > > > On Tue, Feb 2, 2016 at 4:32 AM, Maxim Uvarov > wrote: >> >> Ping. >> >> This fixes have to be in 1.7. >> >> Trivial, but please one

Re: [lng-odp] test/validation/system/system_main fails on arm64

2016-02-02 Thread Hongbo Zhang
lete the "current freq" interfaces. On 2 February 2016 at 18:35, Maxim Uvarov wrote: > Hongbo, you fixed that in the latest patch set right? > > Maxim. > > > On 02/02/2016 11:28, Hongbo Zhang wrote: >> >> Sorry, please forget my previous reply

Re: [lng-odp] test/validation/system/system_main fails on arm64

2016-02-02 Thread Hongbo Zhang
power, the "current freq" isn't implemented, only the "max freq" is implemented now, so there are such failures. On x86, there is no "current freq" failures because it is implemented. On 2 February 2016 at 16:14, Hongbo Zhang wrote: > On 1

Re: [lng-odp] test/validation/system/system_main fails on arm64

2016-02-02 Thread Hongbo Zhang
On 1 February 2016 at 21:20, Mike Holmes wrote: > system_test_odp_cpu_hz_id > ./../../platform/linux-generic/odp_cpumask_task.c:44:odp_cpumask_default_worker(): > CPU0 will be used for both control and worker threads, > this will likely have a performance impact on the worker thread. > FAILED

[lng-odp] [PATCH API-NEXT 4/4] linux-generic: sysinfo clean up for ARM

2016-01-29 Thread hongbo . zhang
From: Hongbo Zhang The arch/arm/odp_sysinfo_parse.c is currently a symlink to arch/linux/odp_sysinfo_parse.c, but in fact there should be defferences between them. A separated real arch/arm/odp_sysinfo_parse.c is created for ARM, and the model_str is set to a general "ARM", which is m

[lng-odp] [PATCH API-NEXT 3/4] linux-generic: use one uniform call systemcpu()

2016-01-29 Thread hongbo . zhang
From: Hongbo Zhang Currently there are two systemcpu() functions, one is for some specific platforms and the other is for default dummy, but most of the contents are same except for sysinfo->cache_line_size: one is true data from calling systemcpu_cache_line_size() and another is dummy data.

[lng-odp] [PATCH API-NEXT 2/4] linux-generic: systemcpu(): use input parameter instead of global data

2016-01-29 Thread hongbo . zhang
From: Hongbo Zhang In the systemcpu() function, odp_global_data.system_info.huge_page_size should be sysinfo->huge_page_size instead, because when systemcpu() is called, the &odp_global_data.system_info is passed as parameter, we should operate the parameter instead of the global data d

[lng-odp] [PATCH API-NEXT 1/4] linux-generic: move CPU info dummy data to generic default file

2016-01-29 Thread hongbo . zhang
From: Hongbo Zhang The dummy data of cpu_hz_max and model_str are used when platform is unknown or data cannot be acquired, but these variables should be set in function odp_cpuinfo_parser() instead of the systemcpu() which should cover only the cpu_count, huge_page_size and cache_line_size

[lng-odp] [PATCH API-NEXT 0/4] linux-generic sysinfo codes clean-ups

2016-01-29 Thread hongbo . zhang
From: Hongbo Zhang This patch set does some architecture clean-ups for linux-generic sysinfo codes. This patch set is based on my previous patch set "separate ODP_CACHE_LINE_SIZE to arch files", so "API-NEXT" is uesed although no API is touched. Hongbo Zhang (4): linux-ge

[lng-odp] [PATCH v2 API-NEXT 4/4] linux-generic: create ARM files and move ARM ODP_CACHE_LINE_SIZE in it

2016-01-29 Thread hongbo . zhang
From: Hongbo Zhang Currently all ODP_CACHE_LINE_SIZE macros for different architectures are held in one header file, they should be moved to their own arch file. And in the legacy codes there was no ARM architecture directory, so this patch create it, the odp_cpu_arch.c and odp_sysinfo_parse.c

[lng-odp] [PATCH v2 API-NEXT 3/4] linux-generic: separate PowerPC ODP_CACHE_LINE_SIZE to its arch file

2016-01-29 Thread hongbo . zhang
From: Hongbo Zhang Currently all ODP_CACHE_LINE_SIZE macros for different architectures are held in one header file, they should be moved to their own arch file. This patch moves ODP_CACHE_LINE_SIZE for PowerPC. The previous arch/powerpc/odp/cpu_arch.h was a symlink to the generic arch/linux/odp

[lng-odp] [PATCH v2 API-NEXT 2/4] linux-generic: separate MIPS ODP_CACHE_LINE_SIZE to its arch file

2016-01-29 Thread hongbo . zhang
From: Hongbo Zhang Currently all ODP_CACHE_LINE_SIZE macros for different architectures are held in one header file, they should be moved to their own arch file. This patch moves ODP_CACHE_LINE_SIZE for MIPS. Signed-off-by: Hongbo Zhang --- platform/linux-generic/arch/mips64/odp/cpu_arch.h

[lng-odp] [PATCH v2 API-NEXT 1/4] linux-generic: separate x86 ODP_CACHE_LINE_SIZE to its arch file

2016-01-29 Thread hongbo . zhang
From: Hongbo Zhang Currently all ODP_CACHE_LINE_SIZE macros for different architectures are held in one header file, they should be moved to their own arch file. This patch moves ODP_CACHE_LINE_SIZE for x86. Signed-off-by: Hongbo Zhang --- platform/linux-generic/arch/x86/odp/cpu_arch.h

[lng-odp] [PATCH v2 API-NEXT 0/4] separate ODP_CACHE_LINE_SIZE to arch files

2016-01-29 Thread hongbo . zhang
From: Hongbo Zhang v1-v2 change: Add macro __OCTEON for patch 2. v1 notes: This is for bug https://bugs.linaro.org/show_bug.cgi?id=1881 This is on top of latest api-next branch because the latest platform/linux-generic/arch/ directory is needed, so I use "API-NEXT" tag There shou

Re: [lng-odp] [PATCH API-NEXT 2/4] linux-generic: separate MIPS ODP_CACHE_LINE_SIZE to its arch file

2016-01-29 Thread Hongbo Zhang
lng-odp@lists.linaro.org >> Subject: [lng-odp] [PATCH API-NEXT 2/4] linux-generic: separate MIPS >> ODP_CACHE_LINE_SIZE to its arch file >> >> From: Hongbo Zhang >> >> Currently all ODP_CACHE_LINE_SIZE macros for different architectures are >> held in one

[lng-odp] [PATCH API-NEXT 4/4] linux-generic: create ARM files and move ARM ODP_CACHE_LINE_SIZE in it

2016-01-29 Thread hongbo . zhang
From: Hongbo Zhang Currently all ODP_CACHE_LINE_SIZE macros for different architectures are held in one header file, they should be moved to their own arch file. And in the legacy codes there was no ARM architecture directory, so this patch create it, the odp_cpu_arch.c and odp_sysinfo_parse.c

[lng-odp] [PATCH API-NEXT 3/4] linux-generic: separate PowerPC ODP_CACHE_LINE_SIZE to its arch file

2016-01-29 Thread hongbo . zhang
From: Hongbo Zhang Currently all ODP_CACHE_LINE_SIZE macros for different architectures are held in one header file, they should be moved to their own arch file. This patch moves ODP_CACHE_LINE_SIZE for PowerPC. The previous arch/powerpc/odp/cpu_arch.h was a symlink to the generic arch/linux/odp

[lng-odp] [PATCH API-NEXT 2/4] linux-generic: separate MIPS ODP_CACHE_LINE_SIZE to its arch file

2016-01-29 Thread hongbo . zhang
From: Hongbo Zhang Currently all ODP_CACHE_LINE_SIZE macros for different architectures are held in one header file, they should be moved to their own arch file. This patch moves ODP_CACHE_LINE_SIZE for MIPS. Signed-off-by: Hongbo Zhang --- platform/linux-generic/arch/mips64/odp/cpu_arch.h

[lng-odp] [PATCH API-NEXT 1/4] linux-generic: separate x86 ODP_CACHE_LINE_SIZE to its arch file

2016-01-29 Thread hongbo . zhang
From: Hongbo Zhang Currently all ODP_CACHE_LINE_SIZE macros for different architectures are held in one header file, they should be moved to their own arch file. This patch moves ODP_CACHE_LINE_SIZE for x86. Signed-off-by: Hongbo Zhang --- platform/linux-generic/arch/x86/odp/cpu_arch.h

[lng-odp] [PATCH API-NEXT 0/4] separate ODP_CACHE_LINE_SIZE to arch files

2016-01-29 Thread hongbo . zhang
From: Hongbo Zhang This is for bug https://bugs.linaro.org/show_bug.cgi?id=1881 This is on top of latest api-next branch because the latest platform/linux-generic/arch/ directory is needed, so I use "API-NEXT" tag There should be some check patch warnings for patch 4, because when n

[lng-odp] [PATCH v8 API-NEXT 12/12] linux-generic: sysinfo: rename variable cpu_hz to cpu_hz_max

2016-01-27 Thread hongbo . zhang
From: Hongbo Zhang The legacy variable cpu_hz holds the max frequency for odp_cpu_hz_max(), so rename it to cpu_hz_max for better meaning. Signed-off-by: Hongbo Zhang --- platform/linux-generic/arch/mips64/odp_sysinfo_parse.c | 2 +- platform/linux-generic/arch/powerpc/odp_sysinfo_parse.c

[lng-odp] [PATCH v8 API-NEXT 09/12] linux-generic: sysinfo: set values for cpu_arch_str

2016-01-27 Thread hongbo . zhang
From: Hongbo Zhang The values of cpu_arch_str were deleted due to codes reorganization, this patch adds values to them again. Signed-off-by: Hongbo Zhang --- platform/linux-generic/arch/mips64/odp_sysinfo_parse.c | 1 + platform/linux-generic/arch/powerpc/odp_sysinfo_parse.c | 1 + platform

[lng-odp] [PATCH v8 API-NEXT 11/12] linux-generic: sysinfo: apply per-CPU implementation to PowerPC

2016-01-27 Thread hongbo . zhang
From: Hongbo Zhang When per-CPU framework was introduced, it was only implemented on x86, for other platforms, only the model_str[0] and cpu_hz[0] are set to pass compile, this patch set all values for model_str[] and cpu_hz[] on the PowerPC platform. Signed-off-by: Hongbo Zhang --- .../linux

[lng-odp] [PATCH v8 API-NEXT 07/12] linux-generic: sysinfo: move PowerPC system info codes to its plarform file

2016-01-27 Thread hongbo . zhang
From: Hongbo Zhang This patch moves the PowerPC system info codes into the newly added PowerPC specific platform file. This patch also creates syslink to arch/linux/odp_cpu_cycles.c for PowerPC. Signed-off-by: Hongbo Zhang --- configure.ac | 1

[lng-odp] [PATCH v8 API-NEXT 10/12] linux-generic: sysinfo: apply per-CPU implementation to MIPS

2016-01-27 Thread hongbo . zhang
From: Hongbo Zhang When per-CPU framework was introduced, it was only implemented on x86, for other platforms, only the model_str[0] and cpu_hz[0] are set to pass compile, this patch set all values for model_str[] and cpu_hz[] on the MIPS platform. Signed-off-by: Hongbo Zhang --- .../linux

[lng-odp] [PATCH v8 API-NEXT 08/12] api: cpu: make frequency API return 0 on failure

2016-01-27 Thread hongbo . zhang
From: Hongbo Zhang All the CPU frequency API return value type is uint64_t, this patch makes them return 0 on failure instead of -1. Signed-off-by: Hongbo Zhang --- include/odp/api/cpu.h | 4 platform/linux-generic/arch/linux/odp_sysinfo_parse.c | 2

[lng-odp] [PATCH v8 API-NEXT 05/12] linux-generic: sysinfo: move MIPS system info codes to its plarform file

2016-01-27 Thread hongbo . zhang
From: Hongbo Zhang This patch moves the MIPS system info codes into the newly added MIPS specific platform file. Signed-off-by: Hongbo Zhang --- platform/linux-generic/Makefile.am | 1 + .../linux-generic/arch/mips64/odp_sysinfo_parse.c | 53 ++ platform

[lng-odp] [PATCH v8 API-NEXT 06/12] linux-generic: sysinfo: move ARM system info codes to default arch file

2016-01-27 Thread hongbo . zhang
From: Hongbo Zhang This patch moves the ARM system info codes into the general arch file, ARM sysinfo isn't implemented now and there is no need to create specific arch file for it, but this can serve as the default implementaton instead. Signed-off-by: Hongbo Zhang --- platform/linux-ge

[lng-odp] [PATCH v8 API-NEXT 04/12] linux-generic: sysinfo: move x86 system info codes to its plarform file

2016-01-27 Thread hongbo . zhang
From: Hongbo Zhang This patch moves the x86 system info codes into the newly added x86 specific platform file. Signed-off-by: Hongbo Zhang --- platform/linux-generic/Makefile.am | 6 +- .../linux-generic/arch/x86/odp_sysinfo_parse.c | 72 ++ platform

[lng-odp] [PATCH v8 API-NEXT 03/12] linux-generic: sysinfo: rename odp_cpu_hz_current with odp_ prefix

2016-01-27 Thread hongbo . zhang
From: Hongbo Zhang This function will be moved to their own platform specific files too, it is better to be named with a odp_ prefix. Signed-off-by: Hongbo Zhang --- platform/linux-generic/odp_system_info.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a

[lng-odp] [PATCH v8 API-NEXT 02/12] linux-generic: sysinfo: use uniform call odp_sysinfo_parser

2016-01-27 Thread hongbo . zhang
From: Hongbo Zhang It is common way that the general top layer calls a uniform interface to initialize data structrure for different plarform, this patch introduces odp_sysinfo_parser() instead of using different interfaces for each platform, and also removes using structure odp_compiler_info_t

[lng-odp] [PATCH v8 API-NEXT 01/12] linux-generic: sysinfo: move cpu_arch_str to odp_system_info_t

2016-01-27 Thread hongbo . zhang
From: Hongbo Zhang This is a pre-step for separating platform specific codes into their own arch files. Value of cpu_arch_str will be set later in separate arch parser code. Signed-off-by: Hongbo Zhang --- platform/linux-generic/include/odp_internal.h | 1 + platform/linux-generic

[lng-odp] [PATCH v8 API-NEXT 00/12] Separate CPU info codes into their platform files

2016-01-27 Thread hongbo . zhang
From: Hongbo Zhang v7->v8 changes: - use file name odp_cpu_arch.c in this patch set instead of odp_cpu_cycles.c since the top api-next tree did this change v6->v7 changes: - update symlink in patch 7 v5->v6 changes: - eliminate checkpatch.pl warnings v4->v5 changes: - reba

Re: [lng-odp] [PATCH v7 API-NEXT 00/12] Separate CPU info codes into their platform files

2016-01-25 Thread Hongbo Zhang
h > > Thanks, > Maxim. > > > > On 01/20/2016 12:20, hongbo.zh...@linaro.org wrote: >> >> From: Hongbo Zhang >> >> v6->v7 changes: >> - update symlink in patch 7 >> >> v5->v6 changes: >> - eliminate checkpatch.pl warnings

Re: [lng-odp] [PATCH v7 API-NEXT 00/12] Separate CPU info codes into their platform files

2016-01-20 Thread Hongbo Zhang
thing to verify the code (only have to comment out some assembly code in odp_cpu_arch.c to pass compilation) by this way I tested my patches on my x86, it should work I think. On 20 January 2016 at 17:20, wrote: > From: Hongbo Zhang > > v6->v7 changes: > - update symlink in pat

Re: [lng-odp] [PATCH v7 API-NEXT 00/12] Separate CPU info codes into their platform files

2016-01-20 Thread Hongbo Zhang
And if we run validation, there should be no failure of system test on x86 and arm, but on mips and powerpc, there should be failures because current frequency on those platforms are not implemented (max freq is done), so failures can be expected. On 20 January 2016 at 22:35, Hongbo Zhang wrote

[lng-odp] [PATCH v7 API-NEXT 11/12] linux-generic: sysinfo: apply per-CPU implementation to PowerPC

2016-01-20 Thread hongbo . zhang
From: Hongbo Zhang When per-CPU framework was introduced, it was only implemented on x86, for other platforms, only the model_str[0] and cpu_hz[0] are set to pass compile, this patch set all values for model_str[] and cpu_hz[] on the PowerPC platform. Signed-off-by: Hongbo Zhang --- .../linux

[lng-odp] [PATCH v7 API-NEXT 12/12] linux-generic: sysinfo: rename variable cpu_hz to cpu_hz_max

2016-01-20 Thread hongbo . zhang
From: Hongbo Zhang The legacy variable cpu_hz holds the max frequency for odp_cpu_hz_max(), so rename it to cpu_hz_max for better meaning. Signed-off-by: Hongbo Zhang --- platform/linux-generic/arch/mips64/odp_sysinfo_parse.c | 2 +- platform/linux-generic/arch/powerpc/odp_sysinfo_parse.c

[lng-odp] [PATCH v7 API-NEXT 09/12] linux-generic: sysinfo: set values for cpu_arch_str

2016-01-20 Thread hongbo . zhang
From: Hongbo Zhang The values of cpu_arch_str were deleted due to codes reorganization, this patch adds values to them again. Signed-off-by: Hongbo Zhang --- platform/linux-generic/arch/mips64/odp_sysinfo_parse.c | 1 + platform/linux-generic/arch/powerpc/odp_sysinfo_parse.c | 1 + platform

[lng-odp] [PATCH v7 API-NEXT 07/12] linux-generic: sysinfo: move PowerPC system info codes to its plarform file

2016-01-20 Thread hongbo . zhang
From: Hongbo Zhang This patch moves the PowerPC system info codes into the newly added PowerPC specific platform file. This patch also creates syslink to arch/linux/odp_cpu_cycles.c for PowerPC. Signed-off-by: Hongbo Zhang --- configure.ac | 1

[lng-odp] [PATCH v7 API-NEXT 10/12] linux-generic: sysinfo: apply per-CPU implementation to MIPS

2016-01-20 Thread hongbo . zhang
From: Hongbo Zhang When per-CPU framework was introduced, it was only implemented on x86, for other platforms, only the model_str[0] and cpu_hz[0] are set to pass compile, this patch set all values for model_str[] and cpu_hz[] on the MIPS platform. Signed-off-by: Hongbo Zhang --- .../linux

[lng-odp] [PATCH v7 API-NEXT 08/12] api: cpu: make frequency API return 0 on failure

2016-01-20 Thread hongbo . zhang
From: Hongbo Zhang All the CPU frequency API return value type is uint64_t, this patch makes them return 0 on failure instead of -1. Signed-off-by: Hongbo Zhang --- include/odp/api/cpu.h | 4 platform/linux-generic/arch/linux/odp_sysinfo_parse.c | 2

[lng-odp] [PATCH v7 API-NEXT 06/12] linux-generic: sysinfo: move ARM system info codes to default arch file

2016-01-20 Thread hongbo . zhang
From: Hongbo Zhang This patch moves the ARM system info codes into the general arch file, ARM sysinfo isn't implemented now and there is no need to create specific arch file for it, but this can serve as the default implementaton instead. Signed-off-by: Hongbo Zhang --- platform/linux-ge

[lng-odp] [PATCH v7 API-NEXT 05/12] linux-generic: sysinfo: move MIPS system info codes to its plarform file

2016-01-20 Thread hongbo . zhang
From: Hongbo Zhang This patch moves the MIPS system info codes into the newly added MIPS specific platform file. Signed-off-by: Hongbo Zhang --- platform/linux-generic/Makefile.am | 1 + .../linux-generic/arch/mips64/odp_sysinfo_parse.c | 53 ++ platform

[lng-odp] [PATCH v7 API-NEXT 04/12] linux-generic: sysinfo: move x86 system info codes to its plarform file

2016-01-20 Thread hongbo . zhang
From: Hongbo Zhang This patch moves the x86 system info codes into the newly added x86 specific platform file. Signed-off-by: Hongbo Zhang --- platform/linux-generic/Makefile.am | 6 +- .../linux-generic/arch/x86/odp_sysinfo_parse.c | 72 ++ platform

[lng-odp] [PATCH v7 API-NEXT 02/12] linux-generic: sysinfo: use uniform call odp_sysinfo_parser

2016-01-20 Thread hongbo . zhang
From: Hongbo Zhang It is common way that the general top layer calls a uniform interface to initialize data structrure for different plarform, this patch introduces odp_sysinfo_parser() instead of using different interfaces for each platform, and also removes using structure odp_compiler_info_t

[lng-odp] [PATCH v7 API-NEXT 03/12] linux-generic: sysinfo: rename odp_cpu_hz_current with odp_ prefix

2016-01-20 Thread hongbo . zhang
From: Hongbo Zhang This function will be moved to their own platform specific files too, it is better to be named with a odp_ prefix. Signed-off-by: Hongbo Zhang --- platform/linux-generic/odp_system_info.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a

[lng-odp] [PATCH v7 API-NEXT 01/12] linux-generic: sysinfo: move cpu_arch_str to odp_system_info_t

2016-01-20 Thread hongbo . zhang
From: Hongbo Zhang This is a pre-step for separating platform specific codes into their own arch files. Value of cpu_arch_str will be set later in separate arch parser code. Signed-off-by: Hongbo Zhang --- platform/linux-generic/include/odp_internal.h | 1 + platform/linux-generic

[lng-odp] [PATCH v7 API-NEXT 00/12] Separate CPU info codes into their platform files

2016-01-20 Thread hongbo . zhang
From: Hongbo Zhang v6->v7 changes: - update symlink in patch 7 v5->v6 changes: - eliminate checkpatch.pl warnings v4->v5 changes: - rebase to latest api-next branch v3->v4 changes: - update patch 9 of platform naming - add new patch 12 to rename cpu_hz to cpu_hz_max v2->

Re: [lng-odp] [PATCH v6 API-NEXT 00/12] Separate CPU info codes into their platform files

2016-01-19 Thread Hongbo Zhang
ile it for powerpc? > > there is wrong symlink. > > And also checkpatch warns about empty line at the end of file. > > Maxim. > > > On 01/19/2016 13:22, Hongbo Zhang wrote: >> >> There are still some checkpatch warnings of patches 6 and 7, but they >> should

Re: [lng-odp] [PATCH v6 API-NEXT 00/12] Separate CPU info codes into their platform files

2016-01-19 Thread Hongbo Zhang
There are still some checkpatch warnings of patches 6 and 7, but they should be due some defect of checkpatch.pl script and can be ignored I think. On 19 January 2016 at 18:17, wrote: > From: Hongbo Zhang > > v5->v6 changes: > - eliminate checkpatch.pl warnings > > v4->

Re: [lng-odp] [PATCH v5 API-NEXT 00/12] Separate CPU info codes into their platform files

2016-01-19 Thread Hongbo Zhang
wrote: > please run ./scripts/checkpatch.pl > on patches, some of them have errors. > > Maxim. > > > On 01/18/2016 13:09, hongbo.zh...@linaro.org wrote: >> >> From: Hongbo Zhang >> >> v4->v5 changes: >> - rebase to latest api-next branch >

[lng-odp] [PATCH v6 API-NEXT 12/12] linux-generic: sysinfo: rename variable cpu_hz to cpu_hz_max

2016-01-19 Thread hongbo . zhang
From: Hongbo Zhang The legacy variable cpu_hz holds the max frequency for odp_cpu_hz_max(), so rename it to cpu_hz_max for better meaning. Signed-off-by: Hongbo Zhang --- platform/linux-generic/arch/mips64/odp_sysinfo_parse.c | 2 +- platform/linux-generic/arch/powerpc/odp_sysinfo_parse.c

[lng-odp] [PATCH v6 API-NEXT 11/12] linux-generic: sysinfo: apply per-CPU implementation to PowerPC

2016-01-19 Thread hongbo . zhang
From: Hongbo Zhang When per-CPU framework was introduced, it was only implemented on x86, for other platforms, only the model_str[0] and cpu_hz[0] are set to pass compile, this patch set all values for model_str[] and cpu_hz[] on the PowerPC platform. Signed-off-by: Hongbo Zhang --- .../linux

[lng-odp] [PATCH v6 API-NEXT 10/12] linux-generic: sysinfo: apply per-CPU implementation to MIPS

2016-01-19 Thread hongbo . zhang
From: Hongbo Zhang When per-CPU framework was introduced, it was only implemented on x86, for other platforms, only the model_str[0] and cpu_hz[0] are set to pass compile, this patch set all values for model_str[] and cpu_hz[] on the MIPS platform. Signed-off-by: Hongbo Zhang --- .../linux

[lng-odp] [PATCH v6 API-NEXT 08/12] api: cpu: make frequency API return 0 on failure

2016-01-19 Thread hongbo . zhang
From: Hongbo Zhang All the CPU frequency API return value type is uint64_t, this patch makes them return 0 on failure instead of -1. Signed-off-by: Hongbo Zhang --- include/odp/api/cpu.h | 4 platform/linux-generic/arch/linux/odp_sysinfo_parse.c | 2

[lng-odp] [PATCH v6 API-NEXT 09/12] linux-generic: sysinfo: set values for cpu_arch_str

2016-01-19 Thread hongbo . zhang
From: Hongbo Zhang The values of cpu_arch_str were deleted due to codes reorganization, this patch adds values to them again. Signed-off-by: Hongbo Zhang --- platform/linux-generic/arch/mips64/odp_sysinfo_parse.c | 1 + platform/linux-generic/arch/powerpc/odp_sysinfo_parse.c | 1 + platform

[lng-odp] [PATCH v6 API-NEXT 07/12] linux-generic: sysinfo: move PowerPC system info codes to its plarform file

2016-01-19 Thread hongbo . zhang
From: Hongbo Zhang This patch moves the PowerPC system info codes into the newly added PowerPC specific platform file. This patch also creates syslink to arch/linux/odp_cpu_cycles.c for PowerPC. Signed-off-by: Hongbo Zhang --- configure.ac | 1

[lng-odp] [PATCH v6 API-NEXT 06/12] linux-generic: sysinfo: move ARM system info codes to default arch file

2016-01-19 Thread hongbo . zhang
From: Hongbo Zhang This patch moves the ARM system info codes into the general arch file, ARM sysinfo isn't implemented now and there is no need to create specific arch file for it, but this can serve as the default implementaton instead. Signed-off-by: Hongbo Zhang --- platform/linux-ge

[lng-odp] [PATCH v6 API-NEXT 05/12] linux-generic: sysinfo: move MIPS system info codes to its plarform file

2016-01-19 Thread hongbo . zhang
From: Hongbo Zhang This patch moves the MIPS system info codes into the newly added MIPS specific platform file. Signed-off-by: Hongbo Zhang --- platform/linux-generic/Makefile.am | 1 + .../linux-generic/arch/mips64/odp_sysinfo_parse.c | 53 ++ platform

[lng-odp] [PATCH v6 API-NEXT 04/12] linux-generic: sysinfo: move x86 system info codes to its plarform file

2016-01-19 Thread hongbo . zhang
From: Hongbo Zhang This patch moves the x86 system info codes into the newly added x86 specific platform file. Signed-off-by: Hongbo Zhang --- platform/linux-generic/Makefile.am | 6 +- .../linux-generic/arch/x86/odp_sysinfo_parse.c | 72 ++ platform

[lng-odp] [PATCH v6 API-NEXT 03/12] linux-generic: sysinfo: rename odp_cpu_hz_current with odp_ prefix

2016-01-19 Thread hongbo . zhang
From: Hongbo Zhang This function will be moved to their own platform specific files too, it is better to be named with a odp_ prefix. Signed-off-by: Hongbo Zhang --- platform/linux-generic/odp_system_info.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a

[lng-odp] [PATCH v6 API-NEXT 00/12] Separate CPU info codes into their platform files

2016-01-19 Thread hongbo . zhang
From: Hongbo Zhang v5->v6 changes: - eliminate checkpatch.pl warnings v4->v5 changes: - rebase to latest api-next branch v3->v4 changes: - update patch 9 of platform naming - add new patch 12 to rename cpu_hz to cpu_hz_max v2->v3 changes: use "api: cpu:" tag in patch

[lng-odp] [PATCH v6 API-NEXT 02/12] linux-generic: sysinfo: use uniform call odp_sysinfo_parser

2016-01-19 Thread hongbo . zhang
From: Hongbo Zhang It is common way that the general top layer calls a uniform interface to initialize data structrure for different plarform, this patch introduces odp_sysinfo_parser() instead of using different interfaces for each platform, and also removes using structure odp_compiler_info_t

  1   2   3   >