eric/test/pktio_ipc:$PATH
+PATH=.:$PATH
+
+run()
+{
+local ret=0
+
+echo " run pktio_ipc1 then pktio_ipc2 "
+pktio_ipc1${EXEEXT} -t 30 &
+IPC_PID=$!
+
+pktio_ipc2${EXEEXT} -t 10
+ret=$?
+# pktio_ipc1 should do clean up an
ping
On 14.01.16 12:56, Ivan Khoronzhuk wrote:
In case of one loop pktio the MAC address is not set in the packets
but should be.
Signed-off-by: Ivan Khoronzhuk
---
test/validation/pktio/pktio.c | 18 ++
1 file changed, 14 insertions(+), 4 deletions(-)
diff --git a/test
ping
On 13.01.16 19:38, Ivan Khoronzhuk wrote:
The odp_pktio_stop() called is supposed to return error.
Signed-off-by: Ivan Khoronzhuk
---
test/validation/pktio/pktio.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/test/validation/pktio/pktio.c b/test/validation/pktio
ping
On 13.01.16 19:18, Ivan Khoronzhuk wrote:
Now odp_time_wait_ns() can be used.
Signed-off-by: Ivan Khoronzhuk
---
test/validation/pktio/pktio.c | 13 +
1 file changed, 1 insertion(+), 12 deletions(-)
diff --git a/test/validation/pktio/pktio.c b/test/validation/pktio
ping
On 15.01.16 17:55, Stuart Haslam wrote:
On Fri, Jan 15, 2016 at 05:53:20PM +0200, Ivan Khoronzhuk wrote:
On 15.01.16 17:51, Stuart Haslam wrote:
On Wed, Jan 13, 2016 at 06:46:57PM +0200, Ivan Khoronzhuk wrote:
If packet with size > MTU is sent the test can crash farther,
so better
L) < 0)
- CU_FAIL_FATAL("nanosleep failed");
+ _wait_for_timers_expiration();
+
while (nstale != 0) {
odp_event_t ev = odp_queue_deq(queue);
if (ev != ODP_EVENT_INVALID) {
--
Regards,
Ivan Khoronzhuk
___
lng-odp mailing list
lng-odp@lists.linaro.org
https://lists.linaro.org/mailman/listinfo/lng-odp
free(void);
void timer_test_odp_timer_cancel(void);
void timer_test_odp_timer_all(void);
+void timer_test_destroy_pool_with_scheduled_timers(void);
/* test arrays: */
extern odp_testinfo_t timer_suite[];
--
Regards,
Ivan Khoronzhuk
___
lng-odp mailing list
lng-odp@lists.linaro.org
https://lists.linaro.org/mailman/listinfo/lng-odp
On 19.01.16 11:59, Maxim Uvarov wrote:
On 01/19/2016 01:54, Ivan Khoronzhuk wrote:
Maxim,
in general, I had no look in this test, it was working for me and I was happy.
At fast glance I have some comments. Hope you will find time to correct it.
ok, some comments bellow.
On 15.01.16 11:14
On 19.01.16 13:27, Maxim Uvarov wrote:
On 01/19/2016 13:23, Ivan Khoronzhuk wrote:
On 19.01.16 11:59, Maxim Uvarov wrote:
On 01/19/2016 01:54, Ivan Khoronzhuk wrote:
Maxim,
in general, I had no look in this test, it was working for me and I was happy.
At fast glance I have some comments
ld be considered as fix of after-loop delay.
segfault. More detailed fix will be later.
Suggested-by: Ivan Khoronzhuk
Signed-off-by: Maxim Uvarov
---
test/validation/timer/timer.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/test/validation/timer/timer.c b/test/valid
On 19.01.16 15:11, Ivan Khoronzhuk wrote:
Maxim.
On 19.01.16 14:59, Maxim Uvarov wrote:
Increase after loop delay to:
10/10 - 7/10 = 3/10. 3/10 * 2000 + some 50ms = 650ms (instead of 1ms)
to make sure that timer hanles expired.
This patch can be considered as temporary fix for timer test to
On 19.01.16 16:16, Maxim Uvarov wrote:
On 01/19/2016 16:47, Ivan Khoronzhuk wrote:
On 19.01.16 15:11, Ivan Khoronzhuk wrote:
Maxim.
On 19.01.16 14:59, Maxim Uvarov wrote:
Increase after loop delay to:
10/10 - 7/10 = 3/10. 3/10 * 2000 + some 50ms = 650ms (instead of 1ms)
to make sure that
On 19.01.16 17:02, Ivan Khoronzhuk wrote:
On 19.01.16 16:16, Maxim Uvarov wrote:
On 01/19/2016 16:47, Ivan Khoronzhuk wrote:
On 19.01.16 15:11, Ivan Khoronzhuk wrote:
Maxim.
On 19.01.16 14:59, Maxim Uvarov wrote:
Increase after loop delay to:
10/10 - 7/10 = 3/10. 3/10 * 2000 + some
On 19.01.16 20:13, Maxim Uvarov wrote:
On 01/19/2016 19:56, Ivan Khoronzhuk wrote:
On 19.01.16 17:02, Ivan Khoronzhuk wrote:
On 19.01.16 16:16, Maxim Uvarov wrote:
On 01/19/2016 16:47, Ivan Khoronzhuk wrote:
On 19.01.16 15:11, Ivan Khoronzhuk wrote:
Maxim.
On 19.01.16 14:59, Maxim
ping
On 13.01.16 19:18, Ivan Khoronzhuk wrote:
Now odp_time_wait_ns() can be used.
Signed-off-by: Ivan Khoronzhuk
---
test/validation/pktio/pktio.c | 13 +
1 file changed, 1 insertion(+), 12 deletions(-)
diff --git a/test/validation/pktio/pktio.c b/test/validation/pktio
On 14.01.16 11:24, Petri Savolainen wrote:
Use only one definition for posix extension level. _GNU_SOURCE
defines _POSIX_C_SOURCE based on glibc version, and is
the only definition needed under Linux.
Signed-off-by: Petri Savolainen
Reviewed-by: Ivan Khoronzhuk
---
platform/linux
On 14.01.16 11:24, Petri Savolainen wrote:
Allways use _GNU_SOURCE instead of various _POSIX_C_SOURCE
defines.
Signed-off-by: Petri Savolainen
Reviewed-by: Ivan Khoronzhuk
---
example/generator/odp_generator.c | 4 +++-
example/ipsec/odp_ipsec.c | 6 --
example/ipsec
);
+void scheduler_test_ordered(void);
void scheduler_test_1q_1t_n(void);
void scheduler_test_1q_1t_a(void);
void scheduler_test_1q_1t_o(void);
--
2.5.0
___
lng-odp mailing list
lng-odp@lists.linaro.org
https://lists.linaro.o
ping
On 13.01.16 19:38, Ivan Khoronzhuk wrote:
The odp_pktio_stop() called is supposed to return error.
Signed-off-by: Ivan Khoronzhuk
---
test/validation/pktio/pktio.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/test/validation/pktio/pktio.c b/test/validation/pktio
On 20.01.16 21:43, Ivan Khoronzhuk wrote:
On 20.01.16 18:58, Bill Fischofer wrote:
ping.
On Wed, Dec 30, 2015 at 5:49 PM, Bill Fischofer mailto:bill.fischo...@linaro.org>> wrote:
Expand the existing scheduler chaos test to provide timing information for
mixed queues as w
Seems you've missed simplification.
On 20.01.16 23:31, Bill Fischofer wrote:
Ok, v2 submitted with requested changes. Thanks.
Bill
On Wed, Jan 20, 2016 at 2:24 PM, Ivan Khoronzhuk mailto:ivan.khoronz...@linaro.org>> wrote:
On 20.01.16 21:43, Ivan Khoronzhuk wrote:
On 21.01.16 00:02, Bill Fischofer wrote:
On Wed, Jan 20, 2016 at 3:36 PM, Ivan Khoronzhuk mailto:ivan.khoronz...@linaro.org>> wrote:
Seems you've missed simplification.
Can you be more specific? You requested that CHAOS_NUM_ROUNDS be reduced to
1000 and the test
-by: Bill Fischofer
Reviewed-by: Ivan Khoronzhuk
---
test/validation/scheduler/scheduler.c | 41 +++
test/validation/scheduler/scheduler.h | 3 +++
2 files changed, 40 insertions(+), 4 deletions(-)
diff --git a/test/validation/scheduler/scheduler.c
b/test
e for allocated bufs num, that is
prio_num * QUEUES_PER_PRIO * TEST_NUM_BUFS. It's h/w dependent, and should
be in normal frames. This patch tunes resource usage in order to allow
test passing for different h/w.
Signed-off-by: Ivan Khoronzhuk
---
test/validation/scheduler/scheduler.c | 8 +
Example should free resources in right order when terminates.
Also it should have correct error path.
Signed-off-by: Ivan Khoronzhuk
---
Since v2:
use less labels in one error path
Since v1:
Just rebase, no functional changes
example/timer/odp_timer_test.c | 57
sent v3.
On 17.12.15 19:07, Ivan Khoronzhuk wrote:
Example should free resources in right order when terminates.
Also it should have correct error path.
Signed-off-by: Ivan Khoronzhuk
---
Since v1:
Just rebase, no functional changes
example/timer/odp_timer_test.c | 46
https://bugs.linaro.org/show_bug.cgi?id=1992
Signed-off-by: Ivan Khoronzhuk
---
platform/linux-generic/odp_timer.c | 14 ++
1 file changed, 10 insertions(+), 4 deletions(-)
diff --git a/platform/linux-generic/odp_timer.c
b/platform/linux-generic/odp_timer.c
index 4bab481..01339ad
+ Stuart Haslam
On 22.01.16 17:07, Ivan Khoronzhuk wrote:
https://bugs.linaro.org/show_bug.cgi?id=1992
Signed-off-by: Ivan Khoronzhuk
---
platform/linux-generic/odp_timer.c | 14 ++
1 file changed, 10 insertions(+), 4 deletions(-)
diff --git a/platform/linux-generic
+ list
On 22.01.16 17:46, Ivan Khoronzhuk wrote:
It discussed several times when started to look at it and Bill proposed to add
some cls environment.
Finally, it's sent. After this change PMR is created while connection to CoSes,
and it's eliminates ability to connect the same PMR
e for allocated bufs num, that is
prio_num * QUEUES_PER_PRIO * TEST_NUM_BUFS. It's h/w dependent, and should
be in normal frames. This patch tunes resource usage in order to allow
test passing for different h/w.
Signed-off-by: Ivan Khoronzhuk
---
test/validation/scheduler/scheduler.c | 8 +
sent patch with corrected tag
On 22.01.16 12:24, Ivan Khoronzhuk wrote:
The scheduler test should test scheduler, not resource limits.
For instance, prio_num * QUEUES_PER_PRIO * 4. In case if prio_num = 16,
it's easily exits the queues maximum number allowed,
16 * 16 * 4 = 1024, plus q
It's not convenient to see reused a thread id for threads that are
finished to fast.
Signed-off-by: Ivan Khoronzhuk
---
test/validation/shmem/shmem.c | 4
1 file changed, 4 insertions(+)
diff --git a/test/validation/shmem/shmem.c b/test/validation/shmem/shmem.c
index 5524b5c..bb
It's not convenient to see reused a thread id for threads that are
finished to fast.
Signed-off-by: Ivan Khoronzhuk
---
test/validation/shmem/shmem.c | 4
1 file changed, 4 insertions(+)
diff --git a/test/validation/shmem/shmem.c b/test/validation/shmem/shmem.c
index 5524b5c..08
see v2
On 22.01.16 20:09, Ivan Khoronzhuk wrote:
It's not convenient to see reused a thread id for threads that are
finished to fast.
Signed-off-by: Ivan Khoronzhuk
---
test/validation/shmem/shmem.c | 4
1 file changed, 4 insertions(+)
diff --git a/test/validation/shmem/shme
still the same.
Signed-off-by: Ivan Khoronzhuk
---
platform/linux-generic/include/odp_internal.h | 3 +++
platform/linux-generic/odp_cpumask_task.c | 9 +++--
platform/linux-generic/odp_system_info.c | 22 ++
3 files changed, 20 insertions(+), 14 deletions(-)
This patch series is intended to run control thread on CPU0.
It's increases worker thread CPU independence and allow to use
local time API on main thread in correct way.
Ivan Khoronzhuk (2):
linux-generic: cpumask_task: use cpumask got at init
linux-generic: init: assign affinity for
e used, it
always runs on same CPU, allowing to use local time API,
which can be legal only on single CPU threads.
Signed-off-by: Ivan Khoronzhuk
---
platform/linux-generic/odp_init.c | 50 +--
1 file changed, 37 insertions(+), 13 deletions(-)
diff --git
cpuset);
- if (ret != 0)
- return 0;
+ odp_cpumask_t mask;
- return CPU_COUNT(&cpuset);
+ return odp_cpumask_all_available(&mask);
}
#if defined __x86_64__ || defined __i386__ || defined __OCTEON__ || \
--
Regards,
Ivan Khoronzhuk
___
lng-odp mailing list
lng-odp@lists.linaro.org
https://lists.linaro.org/mailman/listinfo/lng-odp
On 26.01.16 17:46, Maxim Uvarov wrote:
Signed-off-by: Maxim Uvarov
Reviewed-by: Ivan Khoronzhuk
---
test/validation/timer/timer.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/test/validation/timer/timer.c b/test/validation/timer/timer.c
index 5d89700
_
lng-odp mailing list
lng-odp@lists.linaro.org
https://lists.linaro.org/mailman/listinfo/lng-odp
--
Regards,
Ivan Khoronzhuk
___
lng-odp mailing list
lng-odp@lists.linaro.org
https://lists.linaro.org/mailman/listinfo/lng-odp
to
separate core to not disturb worker
cores.
Thank you,
Maxim.
___
lng-odp mailing list
lng-odp@lists.linaro.org
https://lists.linaro.org/mailman/listinfo/lng-odp
--
Regards,
Ivan Khoronzhuk
___
lng-odp mailing list
lng-odp@lists.linaro.org
https://lists.linaro.org/mailman/listinfo/lng-odp
ng-odp mailing list
lng-odp@lists.linaro.org <mailto:lng-odp@lists.linaro.org>
https://lists.linaro.org/mailman/listinfo/lng-odp
___
lng-odp mailing list
lng-odp@lists.linaro.org
https://lists.linaro.org/mailman/listinfo/lng-odp
--
Regards,
Ivan Khoronzhuk
___
lng-odp mailing list
lng-odp@lists.linaro.org
https://lists.linaro.org/mailman/listinfo/lng-odp
pause scheduling for main thread when
it doesn't participate in the multi-threaded test. Also move
pause/resume test closer to beginning, because it's used in tests
before.
Signed-off-by: Ivan Khoronzhuk
---
test/validation/scheduler/scheduler.c | 12 +++-
1 file changed, 11 i
, in order to be not so sensitive for some systems.
#define ODP_WAIT_TOLERANCE (40 * ODP_TIME_MSEC_IN_NS)
--
Regards,
Ivan Khoronzhuk
___
lng-odp mailing list
lng-odp@lists.linaro.org
https://lists.linaro.org/mailman/listinfo/lng-odp
Signed-off-by: Ivan Khoronzhuk
---
include/odp/api/time.h | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/include/odp/api/time.h b/include/odp/api/time.h
index efc5478..85692ec 100644
--- a/include/odp/api/time.h
+++ b/include/odp/api/time.h
@@ -119,7 +119,9 @@ odp_time_t
On 17.02.16 18:44, Mike Holmes wrote:
Does this tuning need to be documented in the implementer's guide ?
I thinks, no.
On 17 February 2016 at 10:51, Zoltan Kiss mailto:zoltan.k...@linaro.org>> wrote:
On 17/02/16 15:24, Ivan Khoronzhuk wrote:
Hi, Zoltan
ping
On 16.02.16 16:02, Ivan Khoronzhuk wrote:
When test for single thread is finished the following test for
many threads can be started, and for some implementations can
happen that future one event can arrive to main thread, as it was
requested in previous test. As result one event can be
Signed-off-by: Ivan Khoronzhuk
---
doc/users-guide/users-guide.adoc | 49
1 file changed, 44 insertions(+), 5 deletions(-)
diff --git a/doc/users-guide/users-guide.adoc b/doc/users-guide/users-guide.adoc
index ea5e6aa..108b1c8 100644
--- a/doc/users
For some systems sensitive to time deviation, would be better
to have some time backup while testing scheduler time, so increase
it to 3 jiffies.
https://bugs.linaro.org/show_bug.cgi?id=2076
Signed-off-by: Ivan Khoronzhuk
---
test/validation/scheduler/scheduler.c | 2 +-
1 file changed, 1
On 29.02.16 23:39, Bill Fischofer wrote:
On Mon, Feb 29, 2016 at 11:49 AM, Ivan Khoronzhuk mailto:ivan.khoronz...@linaro.org>> wrote:
For some systems sensitive to time deviation, would be better
to have some time backup while testing scheduler time, so increase
it to 3 j
lng-odp mailing list
lng-odp@lists.linaro.org
https://lists.linaro.org/mailman/listinfo/lng-odp
--
Regards,
Ivan Khoronzhuk
___
lng-odp mailing list
lng-odp@lists.linaro.org
https://lists.linaro.org/mailman/listinfo/lng-odp
Signed-off-by: Ivan Khoronzhuk
---
v2..v1:
- just rebased with several not important corrections
doc/users-guide/users-guide.adoc | 50
1 file changed, 45 insertions(+), 5 deletions(-)
diff --git a/doc/users-guide/users-guide.adoc b/doc/users-guide
ping
On 18.02.16 17:56, Ivan Khoronzhuk wrote:
ping
On 16.02.16 16:02, Ivan Khoronzhuk wrote:
When test for single thread is finished the following test for
many threads can be started, and for some implementations can
happen that future one event can arrive to main thread, as it was
bal_wait_until(void);
void time_test_wait_ns(void);
void time_test_local_to_u64(void);
void time_test_global_to_u64(void);
+void time_test_monotony(void);
/* test arrays: */
extern odp_testinfo_t time_suite_time[];
--
Regards,
Ivan Khoronzhuk
___
lng-odp mailing list
lng-odp@lists.linaro.org
https://lists.linaro.org/mailman/listinfo/lng-odp
to get correct CPU freq,
in another way it's possible to figure out needed number of loops in runtime...
-Original Message-
From: EXT Ivan Khoronzhuk [mailto:ivan.khoronz...@linaro.org]
Sent: Thursday, April 14, 2016 5:00 PM
To: Savolainen, Petri (Nokia - FI/Espoo) ;
lng-odp@lists
cle_diff = odp_cpu_cycles_diff(c2, c1);
loop_time += cycle_diff / odp_cpu_hz();
c1 = c2;
};
On 14.04.16 17:24, Ivan Khoronzhuk wrote:
On 14.04.16 17:15, Savolainen, Petri (Nokia - FI/Espoo) wrote:
Hi,
I said back then that we need one test case that runs longer th
n/listinfo/lng-odp
___
lng-odp mailing list
lng-odp@lists.linaro.org
https://lists.linaro.org/mailman/listinfo/lng-odp
--
Regards,
Ivan Khoronzhuk
___
lng-odp mailing list
lng-odp@lists.linaro.org
https://lists.linaro.org/ma
---
From: EXT Ivan Khoronzhuk [mailto:ivan.khoronz...@linaro.org]
Sent: Thursday, April 14, 2016 5:39 PM
To: Savolainen, Petri (Nokia - FI/Espoo) ;
lng-odp@lists.linaro.org
Subject: Re: [lng-odp] [PATCH] validation: time: shorten test duration
What about to do smth like below
(I didn't normal
Hi Bill,
What about to review this one?
On 16.02.16 16:02, Ivan Khoronzhuk wrote:
When test for single thread is finished the following test for
many threads can be started, and for some implementations can
happen that future one event can arrive to main thread, as it was
requested in previous
e_test_wait_ns(void);
void time_test_local_to_u64(void);
void time_test_global_to_u64(void);
+void time_test_monotony(void);
/* test arrays: */
extern odp_testinfo_t time_suite_time[];
--
Regards,
Ivan Khoronzhuk
___
lng-odp mailing list
lng-odp@lists.linaro.org
https://lists.linaro.org/mailman/listinfo/lng-odp
CPU. There should be enough
head room to keep loop duration over 4 seconds even with
higher CPU frequencies.
Signed-off-by: Petri Savolainen
Reviewed-by: Ivan Khoronzhuk
But, it needs to be revised when main thread will run only on single CPU
allowing odp_cpu_cycle APIs to work correctly
.
A user should pay attention on it while configuration.
Regards,usage
Zoltan
___
lng-odp mailing list
lng-odp@lists.linaro.org
https://lists.linaro.org/mailman/listinfo/lng-odp
--
Regards,
Ivan Khoronzhuk
_
Hi Ola,
Maybe I'm wrong, but let me try to explain change in question.
The main reason in this change is the lack of possibility to convert
buf_hdr to
buf_handle. The function odp_timeout_to_event requires this conversion.
By and
large it's not required the tmo_handle to be the tmo_header for
. It's not correct, the code shouldn't
have such kind dependency from macro definition, and it prevents to
re-use this code for another platforms with different
ODP_QUEUE_INVALID. So, fix it.
Signed-off-by: Ivan Khoronzhuk
---
platform/linux-generic/odp_timer.c | 1 +
1 file changed, 1
. It's not correct, the code shouldn't
have such kind dependency from macro definition, and it prevents to
re-use this code for another platforms with different
ODP_QUEUE_INVALID. So, fix it.
Signed-off-by: Ivan Khoronzhuk
---
platform/linux-generic/odp_timer.c | 1 +
1 file changed, 1
Guys, sorry I didn't ask the following questions during the ODP meeting.
I had an issue with my microphone and it seems the call was ended quickly.
But I need to ask. Maybe it's better, it requires some illustration.
For now, I need the answer on the following questions:
- Are we going to use th
generates error.
It's not correct, the code shouldn't have such kind dependency from
macro definition, and it prevents to re-use this code for another
platforms with different ODP_QUEUE_INVALID. So, fix it.
Reviewed-by: Ola Liljedahl
Signed-off-by: Ivan Khoronzhuk
---
platform/lin
On 24.06.15 19:57, Bala Manoharan wrote:
Hi Ivan,
Pls see my comments inline.
On 24 June 2015 at 09:13, Ivan Khoronzhuk mailto:ivan.khoronz...@linaro.org>> wrote:
Guys, sorry I didn't ask the following questions during the ODP meeting.
I had an issue with my microphone a
On 24.06.15 20:09, Bill Fischofer wrote:
Answers inline
On Wed, Jun 24, 2015 at 11:13 AM, Ivan Khoronzhuk
mailto:ivan.khoronz...@linaro.org>> wrote:
Guys, sorry I didn't ask the following questions during the ODP meeting.
I had an issue with my microphone and it seems t
Hi Bill,
On 25.06.15 16:52, Bill Fischofer wrote:
This RFC adds routines that permit classification rules to be manipulated
in a stateful manner. The odp_pktio_pmr_cos() routine is intended to be
deprecated and in its place the new odp_pktio_cls_context_swap() routine
is to be used instead.
Th
+ lng-odp. Unintentionally removed
On 25.06.15 20:06, Ivan Khoronzhuk wrote:
Hi Bill,
On 25.06.15 15:09, Bill Fischofer wrote:
Signed-off-by: Bill Fischofer
---
include/odp/api/pool.h | 9 +
1 file changed, 9 insertions(+)
diff --git a/include/odp/api/pool.h b/include/odp/api
POSIX model and provides for that implementation flexibility. In this
case for linux-generic it's implementated as a memset, but that detail
is now hidden from the user as other platforms are free to implement the
init functions in a manner that work best for them.
On Thu, Jun 25, 2015 at 12:06
It's more generic implementation simplify reusing timer API
for other platforms.
Signed-off-by: Ivan Khoronzhuk
---
I've checked this patch with Keystone implementation.
.../linux-generic/include/odp_timer_internal.h | 9 ---
platform/linux-generic/odp_timer.c
Hi, Bill
On 01.07.15 05:12, Bill Fischofer wrote:
Signed-off-by: Bill Fischofer
---
include/odp/api/classification.h | 106 +++
1 file changed, 106 insertions(+)
diff --git a/include/odp/api/classification.h b/include/odp/api/classification.h
index f597b2
Ola,
I need this change.
Could you please comment on this if you have some objections.
or maybe send your version.
On 30.06.15 13:16, Ivan Khoronzhuk wrote:
It's more generic implementation simplify reusing timer API
for other platforms.
Signed-off-by: Ivan Khoronzhuk
---
I've ch
leave the main loop only if the last tmo/timer is free.
Signed-off-by: Ivan Khoronzhuk
---
example/timer/odp_timer_test.c | 38 +-
1 file changed, 21 insertions(+), 17 deletions(-)
diff --git a/example/timer/odp_timer_test.c b/example/timer/odp_timer_test
On 03.07.15 12:56, Ivan Khoronzhuk wrote:
Current implementation has at least two races that lead to several issues:
- gbls->remain can overflow. One thread can decrement remain counter to 0.
While another can decrement it once again and it will be > 0 once again. After
what the threa
This series fixes some races in the timer test and adds some
new abilities. The races and drawbacks where found while testing
linux-generic timer API on keystone implementation, so it tested.
Ivan Khoronzhuk (2):
example: timer: delete races while termination
example: timer: use ability to
In case if for some reason one of the TMOs was lost, the test will
be polling forever in order to take it and delete. It can be used to
indicate that event was lost. Just abort the test if it cannot receive
one of the last TMOs for some period.
Signed-off-by: Ivan Khoronzhuk
---
example/timer
leave the main loop only if the last tmo/timer is free.
Signed-off-by: Ivan Khoronzhuk
---
example/timer/odp_timer_test.c | 38 +-
1 file changed, 21 insertions(+), 17 deletions(-)
diff --git a/example/timer/odp_timer_test.c b/example/timer/odp_timer_test.c
ind
Just decided to add the ability to indicate that some TMO was lost.
At least it already helped me to figure out the issue in odp_schedule of
keystone implementation.
So see this patch inside new series:
"[lng-odp] [Patch 0/2] example: timer: fix/improve test"
On 03.07.15 12:56, Ivan
This series fixes some races in the timer test termination path and
adds some new abilities. The races and drawbacks where found while
testing linux-generic timer API on Keystone implementation, so it's
tested.
Since v1:
- only comments were fixed
Ivan Khoronzhuk (2):
example:
an assign event for any of the threads, so one thread can
receive two last events for example.
According to above, added several improvements:
- don't send more timeouts that supposed to receive
- free timer and tmo for a last received tmos = num of threads.
- leave the main loop only if a last
In case if for some reason one of the TMOs was lost, the test will
be polling forever in order to take it and delete. It can be used to
indicate that event was lost. Just abort the test if it cannot receive
one of the "last" TMOs for some period.
Signed-off-by: Ivan Khoronzhuk
---
exa
Maxim,
mutex and spinlock is not the same ...
On 03.07.15 16:54, Maxim Uvarov wrote:
Petri, looks like you invented mutex (mtx_recursive) :
https://www-01.ibm.com/support/knowledgecenter/ssw_aix_71/com.ibm.aix.basetrf1/mtx_destroy.htm
Thanks,
Maxim.
On 07/03/15 16:25, Petri Savolainen wrot
For my opinion, using lock in lock its bad design. It shouldn't be
masked. So it can be useful only for legacy applications and should be
avoided in new apps or even disabled somehow.
On 03.07.15 17:00, Ivan Khoronzhuk wrote:
Maxim,
mutex and spinlock is not the same ...
On 03.07.15
07/03/15 17:00, Ivan Khoronzhuk wrote:
Maxim,
mutex and spinlock is not the same ...
yes, I know.
What is the use case of that locks? Defend some data between control
thread and worker thread? I.e. odp worker holds write lock and updates
something. While control thread needs do periodical re
Maxim,
On 03.07.15 18:13, Maxim Uvarov wrote:
On 3 July 2015 at 17:59, Ivan Khoronzhuk mailto:ivan.khoronz...@linaro.org>> wrote:
Maxim,
I've never used such kind of lock.
They are not used in LK for a lot of reasons.
It's not the same as rwlocks, it'
I suppose, the intention was to check only ODP_PMR_IPPROTO capability.
Signed-off-by: Ivan Khoronzhuk
---
test/validation/classification/odp_classification_tests.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/test/validation/classification/odp_classification_tests.c
b
used only one.
It's not formated patch and is only for demonstration.
Signed-off-by: Ivan Khoronzhuk
---
.../classification/odp_classification_tests.c | 42 ++
1 file changed, 42 insertions(+)
diff --git a/test/validation/classification/odp_classification_tests
Bala,
On 15.07.15 11:31, Bala Manoharan wrote:
Hi Ivan,
Comments Inline...
On 15 July 2015 at 02:48, Ivan Khoronzhuk mailto:ivan.khoronz...@linaro.org>> wrote:
It's simple improvement is intended to open eyes on possible
hidden issues when a packet can be lost (or sent
Bala,
.
On 15.07.15 12:25, Bala Manoharan wrote:
.
It's only a proposition to add.
You can add this as separate test. I just want to show that current test
is not enough to test this primitive.
The current validation suite is just used to test the acceptance of
differ
resources for that, and in case if it cannot implement l2-l2-l3 it
has to return error, but not 2.
On 15.07.15 17:35, Bala wrote:
On 15-Jul-2015, at 7:58 pm, Ivan Khoronzhuk wrote:
Bala,
.
On 15.07.15 12:25, Bala Manoharan wrote:
.
It's only a proposition to add.
Hi, Genis
On 15.07.15 18:47, Genis Riera wrote:
A new headroom parameter is added to odp_pool_param_t when the pool is
type of ODP_POOL_PACKET, so that headroom size could be configured at
pool initialization time (ODP application runtime).
Signed-off-by: Genis Riera Perez mailto:gri...@starflo
eer at StarFlow Networks
Edifici K2M, S103 c/ Jordi Girona 31
08034 Barcelona
E-mail: gri...@starflownetworks.com <mailto:gri...@starflownetworks.com>
On Wed, Jul 15, 2015 at 5:54 PM, Ivan Khoronzhuk
mailto:ivan.khoronz...@linaro.org>> wrote:
Hi, Genis
On 15.07.15 18:47, Ge
Genis,
On 15.07.15 19:11, Genis Riera wrote:
Ivan,
If you have this compilation issues I can send again the patch without
this check, assuming always positive values. Is it right for you?
Yes, but wait a while, maybe someone else have some propositions.
__
gri...@starflownetworks.com <mailto:gri...@starflownetworks.com>
On Wed, Jul 15, 2015 at 6:04 PM, Ivan Khoronzhuk
mailto:ivan.khoronz...@linaro.org>> wrote:
Genis
On 15.07.15 19:00, Genis Riera wrote:
Hi, Ivan,
Not, but I adde
Hi, Nicolas
Maybe I'm wrong, but it's supposed that headroom is used to extend the
packet data, when it's required. And if you need some meta-data you
probably should add it in packet header or else, but under headroom.
On 15.07.15 19:28, Nicolas Morey-Chaisemartin wrote:
As this is a change of
On 15.07.15 19:43, Ivan Khoronzhuk wrote:
Hi, Nicolas
Maybe I'm wrong, but it's supposed that headroom is used to extend the
packet data, when it's required. And if you need some meta-data you
probably should add it in packet header or else, but under headroom.
I meant your
ss through the list server.
It's good when the letter is seen by everyone with the same subject.
Envoyé depuis un mobile Samsung.
Message d'origine
De : Ivan Khoronzhuk
Date :15/07/2015 18:34 (GMT+01:00)
À : Bill Fischofer , Genis Riera
Cc : ODP mailing list
Objet :
501 - 600 of 676 matches
Mail list logo
