[lng-odp] [API-NEXT/PATCHv1 4/4] validation: classificaiton: remove redundant sequence number check

2015-10-20 Thread Balasubramanian Manoharan
check for invalid sequence number is performed during packet create and it is not required during packet receive Signed-off-by: Balasubramanian Manoharan --- test/validation/classification/odp_classification_test_pmr.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/test/validation/classifi

Re: [lng-odp] [API-NEXT/PATCHv1 4/4] validation: classificaiton: remove redundant sequence number check

2015-10-21 Thread Ivan Khoronzhuk
Seems in last patch the following was added to test_pktio_error_cos(): + seqno = cls_pkt_get_seq(pkt); + CU_ASSERT(seqno != TEST_SEQ_INVALID); ... + CU_ASSERT(seqno == cls_pkt_get_seq(pkt)); Why did you skip it here? I expected patch with name "Align..." including this change.

Re: [lng-odp] [API-NEXT/PATCHv1 4/4] validation: classificaiton: remove redundant sequence number check

2015-10-21 Thread Bala Manoharan
I skipped this coz this as I just realised that since this was an error packet and it might not be required for platforms to parse an error packet and hence I removed the sequence number check for this packet and just checked whether this packet was received on error CoS queue. Regards, Bala On 2

Re: [lng-odp] [API-NEXT/PATCHv1 4/4] validation: classificaiton: remove redundant sequence number check

2015-10-21 Thread Ivan Khoronzhuk
On 21.10.15 15:14, Bala Manoharan wrote: I skipped this coz this as I just realised that since this was an error packet and it might not be required for platforms to parse an error packet and hence I removed the sequence number check for this packet and just checked whether this packet was recei

Re: [lng-odp] [API-NEXT/PATCHv1 4/4] validation: classificaiton: remove redundant sequence number check

2015-10-21 Thread Bala Manoharan
Whenever a packet contains an error in L3 layer the HW will not parse the L4 layer and since we are reading the sequence number in the L4 data checking the sequence number in this case of error packet is invalid. Regards, Bala On 21 October 2015 at 18:15, Ivan Khoronzhuk wrote: > > On 21.10.15 1

Re: [lng-odp] [API-NEXT/PATCHv1 4/4] validation: classificaiton: remove redundant sequence number check

2015-10-21 Thread Ivan Khoronzhuk
On 21.10.15 16:54, Bala Manoharan wrote: Whenever a packet contains an error in L3 layer the HW will not parse the L4 layer and since we are reading the sequence number in the L4 data checking the sequence number in this case of error packet is invalid. Regards, Bala Yep. It should be checke