Re: [lng-odp] [PATCH 1/6] linux-gen: queue: reuse enq_ and deq_multi

2016-09-22 Thread Bill Fischofer
I posted patch http://patches.opendataplane.org/patch/6991/ to address the doxygen issues with this patch. On Thu, Sep 22, 2016 at 12:00 PM, Maxim Uvarov wrote: > that was merged but doxygen needs refining: > > /opt/Linaro/odp3.git/platform/linux-generic/include/odp/api/plat/ticketlock_inlines.h

Re: [lng-odp] [PATCH 1/6] linux-gen: queue: reuse enq_ and deq_multi

2016-09-22 Thread Maxim Uvarov
that was merged but doxygen needs refining: /opt/Linaro/odp3.git/platform/linux-generic/include/odp/api/plat/ticketlock_inlines.h:21: warning: Member _odp_ticketlock_lock(odp_ticketlock_t *ticketlock) (function) of file ticketlock_inlines.h is not documented. /opt/Linaro/odp3.git/platform/linux

Re: [lng-odp] [PATCH 1/6] linux-gen: queue: reuse enq_ and deq_multi

2016-09-22 Thread Maxim Uvarov
Merged, Maxim. On 09/22/16 10:28, Savolainen, Petri (Nokia - FI/Espoo) wrote: Which config ? $ ./configure --with-platform=linux-generic --prefix=/opt/Linaro/check-odp-v3.git/new-build --enable-test-perf --enable-test-perf-proc --enable-test-helper --enable-test-example --enable-test-vald -

Re: [lng-odp] [PATCH 1/6] linux-gen: queue: reuse enq_ and deq_multi

2016-09-22 Thread Savolainen, Petri (Nokia - FI/Espoo)
> > Which config ? > >$ ./configure --with-platform=linux-generic > --prefix=/opt/Linaro/check-odp-v3.git/new-build --enable-test-perf > --enable-test-perf-proc --enable-test-helper --enable-test-example > --enable-test-vald --with-testdir=yes > > > Which pktio ? > > socket mmap > > pktio:

Re: [lng-odp] [PATCH 1/6] linux-gen: queue: reuse enq_ and deq_multi

2016-09-21 Thread Maxim Uvarov
On 09/21/16 15:06, Savolainen, Petri (Nokia - FI/Espoo) wrote: -Original Message- From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of Maxim Uvarov Sent: Wednesday, September 21, 2016 2:35 PM To: lng-odp@lists.linaro.org Subject: Re: [lng-odp] [PATCH 1/6] linux-gen: queue

Re: [lng-odp] [PATCH 1/6] linux-gen: queue: reuse enq_ and deq_multi

2016-09-21 Thread Savolainen, Petri (Nokia - FI/Espoo)
> -Original Message- > From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of Maxim > Uvarov > Sent: Wednesday, September 21, 2016 2:35 PM > To: lng-odp@lists.linaro.org > Subject: Re: [lng-odp] [PATCH 1/6] linux-gen: queue: reuse enq_ and > deq_multi >

Re: [lng-odp] [PATCH 1/6] linux-gen: queue: reuse enq_ and deq_multi

2016-09-21 Thread Maxim Uvarov
odp check fails for this patch: [01] num pktios 1, PKTIN_DIRECT, PKTOUT_DIRECT ../../helper/linux.c:273:odpthread_run_start_routine():helper: ODP worker thread started as linux pthread. (pid=10762) [02] num pktios 1, PKTIN_DIRECT, PKTOUT_DIRECT 17 pps, 17 max pps, 0 rx drops, 0 tx drops 9 pps,

Re: [lng-odp] [PATCH 1/6] linux-gen: queue: reuse enq_ and deq_multi

2016-09-19 Thread Bill Fischofer
For this series: Reviewed-and-tested-by: Bill Fischofer On Thu, Sep 15, 2016 at 8:39 AM, Petri Savolainen < petri.savolai...@nokia.com> wrote: > Reuse multi enqueue and dequeue implementations for single > enq/deq operations. This enables implementation to > concentrate on optimizing the multi

[lng-odp] [PATCH 1/6] linux-gen: queue: reuse enq_ and deq_multi

2016-09-15 Thread Petri Savolainen
Reuse multi enqueue and dequeue implementations for single enq/deq operations. This enables implementation to concentrate on optimizing the multi operations. Single operations do not suffer a major performance decrease since compiler likely optimizes the inlined code for single operations (num is f