Re: [lng-odp] [RFC 00/15] Add and use a generic pktio interface for all implementation

2015-07-07 Thread Maxim Uvarov
On 07/07/15 09:35, Nicolas Morey-Chaisemartin wrote: On 07/03/2015 12:22 PM, Maxim Uvarov wrote: On 07/03/15 10:05, Nicolas Morey-Chaisemartin wrote: I really like that changes. They should simplify porting to new platform and adding new pktio. Also we can think about moving all pktio files

Re: [lng-odp] [RFC 00/15] Add and use a generic pktio interface for all implementation

2015-07-07 Thread Nicolas Morey-Chaisemartin
I have a patch ready to add an global init function to the pktio_if_ops but as it is not needed by any of the current pktio type, I wasn't sure if I needed to publish it. But we can add it later on if needed. On 07/07/2015 10:06 AM, Maxim Uvarov wrote: On 07/07/15 09:35, Nicolas

Re: [lng-odp] [RFC 00/15] Add and use a generic pktio interface for all implementation

2015-07-07 Thread Nicolas Morey-Chaisemartin
On 07/03/2015 12:22 PM, Maxim Uvarov wrote: On 07/03/15 10:05, Nicolas Morey-Chaisemartin wrote: I really like that changes. They should simplify porting to new platform and adding new pktio. Also we can think about moving all pktio files to platform/linux-generic/pktio/ or directory,

Re: [lng-odp] [RFC 00/15] Add and use a generic pktio interface for all implementation

2015-07-06 Thread Maxim Uvarov
On 6 July 2015 at 12:26, Nicolas Morey-Chaisemartin nmo...@kalray.eu wrote: On 07/06/2015 12:10 AM, Mike Holmes wrote: Agree, 15 patches is right on the need to do a pull request from your repo to keep it manageable. It starts with a bit of cleanup and reorganizing functions in

Re: [lng-odp] [RFC 00/15] Add and use a generic pktio interface for all implementation

2015-07-06 Thread Nicolas Morey-Chaisemartin
On 07/06/2015 12:10 AM, Mike Holmes wrote: Agree, 15 patches is right on the need to do a pull request from your repo to keep it manageable. It starts with a bit of cleanup and reorganizing functions in different files, What is the right way to make a pull request for ODP? Should I just

Re: [lng-odp] [RFC 00/15] Add and use a generic pktio interface for all implementation

2015-07-05 Thread Bill Fischofer
Let's plan on discussing this during Tuesday's ODP call. On Fri, Jul 3, 2015 at 6:40 AM, Maxim Uvarov maxim.uva...@linaro.org wrote: On 07/03/15 13:43, Nicolas Morey-Chaisemartin wrote: On 07/03/2015 12:22 PM, Maxim Uvarov wrote: On 07/03/15 10:05, Nicolas Morey-Chaisemartin wrote: The

Re: [lng-odp] [RFC 00/15] Add and use a generic pktio interface for all implementation

2015-07-05 Thread Mike Holmes
On Jul 3, 2015 3:05 AM, Nicolas Morey-Chaisemartin nmo...@kalray.eu wrote: The goal of this patch series is to remove all the switch/case from all the odp_packet_io.c functions and go through a generic interface (function pointers) that each pktio implementation should implement. This means

Re: [lng-odp] [RFC 00/15] Add and use a generic pktio interface for all implementation

2015-07-05 Thread Mike Holmes
On Jul 5, 2015 4:05 PM, Bill Fischofer bill.fischo...@linaro.org wrote: Let's plan on discussing this during Tuesday's ODP call This dove tails with the proposals to pursue the odp-netmap repo as a more performance oriented implementation that still attempts to avoid specific SDKs. Adding a

[lng-odp] [RFC 00/15] Add and use a generic pktio interface for all implementation

2015-07-03 Thread Nicolas Morey-Chaisemartin
The goal of this patch series is to remove all the switch/case from all the odp_packet_io.c functions and go through a generic interface (function pointers) that each pktio implementation should implement. This means that adding a new pktio type now only requires a few single steps and no

Re: [lng-odp] [RFC 00/15] Add and use a generic pktio interface for all implementation

2015-07-03 Thread Maxim Uvarov
On 07/03/15 10:05, Nicolas Morey-Chaisemartin wrote: The goal of this patch series is to remove all the switch/case from all the odp_packet_io.c functions and go through a generic interface (function pointers) that each pktio implementation should implement. This means that adding a new pktio

Re: [lng-odp] [RFC 00/15] Add and use a generic pktio interface for all implementation

2015-07-03 Thread Nicolas Morey-Chaisemartin
On 07/03/2015 12:22 PM, Maxim Uvarov wrote: On 07/03/15 10:05, Nicolas Morey-Chaisemartin wrote: The goal of this patch series is to remove all the switch/case from all the odp_packet_io.c functions and go through a generic interface (function pointers) that each pktio implementation

Re: [lng-odp] [RFC 00/15] Add and use a generic pktio interface for all implementation

2015-07-03 Thread Maxim Uvarov
On 07/03/15 13:43, Nicolas Morey-Chaisemartin wrote: On 07/03/2015 12:22 PM, Maxim Uvarov wrote: On 07/03/15 10:05, Nicolas Morey-Chaisemartin wrote: The goal of this patch series is to remove all the switch/case from all the odp_packet_io.c functions and go through a generic interface