Re: [lng-odp] validation: pktio: fix start_stop and send_failure tests

2015-12-08 Thread Ilya Maximets
Matias, please check out my patch ( https://lists.linaro.org/pipermail/lng-odp/2015-December/018057.html ) from my 'TAP pktio' patch set. Best regards, Ilya Maximets. On 08.12.2015 13:36, Elo, Matias (Nokia - FI/Espoo) wrote: > In both tests set MAC addresses to test packets to enable > testing

Re: [lng-odp] validation: pktio: fix start_stop and send_failure tests

2015-12-08 Thread Elo, Matias (Nokia - FI/Espoo)
Hi Ilya, I had completely missed your previous patch. You could also remove the two errno value checks in pktio_test_send_failure(). They are not defined in the API, so they should not be tested. -Matias > -Original Message- > From: EXT Ilya Maximets [mailto:i.maxim...@samsung.com] > S

Re: [lng-odp] validation: pktio: fix start_stop and send_failure tests

2015-12-08 Thread Ilya Maximets
Matias, I think, better to make separate patch for that. It will not intersect with mine in case of only 2 deletions. Would you prepare it? Best regards, Ilya Maximets. On 08.12.2015 15:21, Elo, Matias (Nokia - FI/Espoo) wrote: > Hi Ilya, > > I had completely missed your previous patch. You cou

Re: [lng-odp] validation: pktio: fix start_stop and send_failure tests

2015-12-08 Thread Stuart Haslam
On Tue, Dec 08, 2015 at 12:21:06PM +, Elo, Matias (Nokia - FI/Espoo) wrote: > Hi Ilya, > > I had completely missed your previous patch. You could also remove the two > errno value checks in pktio_test_send_failure(). They are not defined in the > API, so they should not be tested. > > -Mati

Re: [lng-odp] validation: pktio: fix start_stop and send_failure tests

2015-12-08 Thread Ilya Maximets
On 08.12.2015 17:38, Stuart Haslam wrote: > On Tue, Dec 08, 2015 at 12:21:06PM +, Elo, Matias (Nokia - FI/Espoo) > wrote: >> Hi Ilya, >> >> I had completely missed your previous patch. You could also remove the two >> errno value checks in pktio_test_send_failure(). They are not defined in

Re: [lng-odp] validation: pktio: fix start_stop and send_failure tests

2015-12-08 Thread Savolainen, Petri (Nokia - FI/Espoo)
> -Original Message- > From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of EXT > Ilya Maximets > Sent: Tuesday, December 08, 2015 4:48 PM > To: Stuart Haslam; Elo, Matias (Nokia - FI/Espoo) > Cc: lng-odp@lists.linaro.org > Subject: Re: [lng-odp] v

Re: [lng-odp] validation: pktio: fix start_stop and send_failure tests

2015-12-08 Thread Mike Holmes
mber 08, 2015 4:48 PM > > To: Stuart Haslam; Elo, Matias (Nokia - FI/Espoo) > > Cc: lng-odp@lists.linaro.org > > Subject: Re: [lng-odp] validation: pktio: fix start_stop and send_failure > > tests > > > > > > > > On 08.12.2015 17:38, Stuart Haslam wr

Re: [lng-odp] validation: pktio: fix start_stop and send_failure tests

2015-12-08 Thread Stuart Haslam
> To: Stuart Haslam; Elo, Matias (Nokia - FI/Espoo) > > Cc: lng-odp@lists.linaro.org > > Subject: Re: [lng-odp] validation: pktio: fix start_stop and send_failure > > tests > > > > > > > > On 08.12.2015 17:38, Stuart Haslam wrote: > >