Re: [lng-odp] [API-NEXT PATCH v2 15/16] Add llqueue, an unbounded concurrent queue

On 04.04.2017 22:25, Maxim Uvarov wrote: > it's better to have 2 separate files for that. One for ODP_CONFIG_LLDSCD > defined and one for not. Seconding that. At least LLDSCD and non-LLDSCD code should not be interleaved. -- With best wishes Dmitry

Re: [lng-odp] [API-NEXT PATCH v2 01/16] Fix native Clang build on ARMv8

On 04.04.2017 23:26, Brian Brooks wrote: > On 04/04 23:04:10, Dmitry Eremin-Solenikov wrote: >> On 04.04.2017 21:47, Brian Brooks wrote: >>> Signed-off-by: Brian Brooks >> >> Brian, >> >> how does this fail with clang on ARMv8? Could you please incl

Re: [lng-odp] [API-NEXT PATCH v2 01/16] Fix native Clang build on ARMv8

On 05.04.2017 00:31, Brian Brooks wrote: > On 04/04 14:53:23, Bill Fischofer wrote: >> On Tue, Apr 4, 2017 at 2:45 PM, Brian Brooks wrote: >>> On 04/04 21:55:06, Maxim Uvarov wrote: this patch should be not part of this serries and can go to master as standalone patch. >>> >>> Can you he

Re: [lng-odp] [API-NEXT PATCH v2 01/16] Fix native Clang build on ARMv8

On 04.04.2017 23:34, Brian Brooks wrote: > On 04/04 23:27:51, Dmitry Eremin-Solenikov wrote: >> On 04.04.2017 23:26, Brian Brooks wrote: >>> On 04/04 23:04:10, Dmitry Eremin-Solenikov wrote: >>>> On 04.04.2017 21:47, Brian Brooks wrote: >>>>>

Re: [lng-odp] [API-NEXT PATCH v2 15/16] Add llqueue, an unbounded concurrent queue

On 05.04.2017 00:25, Brian Brooks wrote: > On 04/04 23:23:33, Dmitry Eremin-Solenikov wrote: >> On 04.04.2017 22:25, Maxim Uvarov wrote: >>> it's better to have 2 separate files for that. One for ODP_CONFIG_LLDSCD >>> defined and one for not. >> >> Se

Re: [lng-odp] [API-NEXT PATCH v2 13/16] Add a bitset

On 04.04.2017 23:52, Ola Liljedahl wrote: > Sending from my ARM email account, I hope Outlook does not mess up the > format. > > > > On 04/04/2017, 22:21, "Dmitry Eremin-Solenikov" > wrote: > >> On 04.04.2017 21:48, Brian Brooks wrote: >>> Sig

Re: [lng-odp] [API-NEXT PATCH v2 12/16] Add LL/SC and signaling primitives

On 05.04.2017 00:00, Ola Liljedahl wrote: > I think I missed one comment. > > > On 04/04/2017, 22:14, "Dmitry Eremin-Solenikov" > wrote: > >> On 04.04.2017 21:48, Brian Brooks wrote: >>> Signed-off-by: Ola Liljedahl >>> Reviewed-by:

Re: [lng-odp] [API-NEXT PATCH v2 12/16] Add LL/SC and signaling primitives

On 05.04.2017 01:00, Brian Brooks wrote: > On Tue, Apr 4, 2017 at 3:38 PM, Ola Liljedahl wrote: >> On 04/04/2017, 22:14, "Dmitry Eremin-Solenikov" >> wrote: >>> On 04.04.2017 21:48, Brian Brooks wrote: >>>> +#endif >>>> + >>>

Re: [lng-odp] [API-NEXT PATCH v2 12/16] Add LL/SC and signaling primitives

On 05.04.2017 02:34, Ola Liljedahl wrote: > > > > > On 05/04/2017, 01:29, "Dmitry Eremin-Solenikov" > wrote: > >> On 05.04.2017 01:00, Brian Brooks wrote: >>> On Tue, Apr 4, 2017 at 3:38 PM, Ola Liljedahl >>> wrote: >>>> On

Re: [lng-odp] [API-NEXT PATCH v2 13/16] Add a bitset

On 05.04.2017 02:31, Ola Liljedahl wrote: > On 05/04/2017, 01:25, "Dmitry Eremin-Solenikov" > wrote: >> On 04.04.2017 23:52, Ola Liljedahl wrote: >>> Sending from my ARM email account, I hope Outlook does not mess up the >>> format. >>> >>&

Re: [lng-odp] [API-NEXT PATCH v2 13/16] Add a bitset

On 05.04.2017 15:16, Ola Liljedahl wrote: > On 05/04/2017, 12:36, "Dmitry Eremin-Solenikov" > wrote: > >> On 05.04.2017 02:31, Ola Liljedahl wrote: >>> On 05/04/2017, 01:25, "Dmitry Eremin-Solenikov" >>> wrote: >>>> On 04.04

Re: [lng-odp] [API-NEXT PATCH v2 13/16] Add a bitset

On 05.04.2017 16:33, Ola Liljedahl wrote: > > > > > On 05/04/2017, 15:22, "Dmitry Eremin-Solenikov" > wrote: > >> On 05.04.2017 15:16, Ola Liljedahl wrote: >>> On 05/04/2017, 12:36, "Dmitry Eremin-Solenikov" >>> wrote: >&

Re: [lng-odp] [API-NEXT PATCH v2 15/16] Add llqueue, an unbounded concurrent queue

On 05.04.2017 17:40, Ola Liljedahl wrote: > On 5 April 2017 at 14:20, Maxim Uvarov wrote: >> On 04/05/17 01:46, Ola Liljedahl wrote: >>> On 4 April 2017 at 21:25, Maxim Uvarov wrote: it's better to have 2 separate files for that. One for ODP_CONFIG_LLDSCD >>> "better"? In what way? > Please

Re: [lng-odp] [RFC][PATCH] added asymmetric crypto algorithm support.

On 05.04.2017 13:02, Umesh Kartha wrote: > Asymmetric crypto algorithms are essential in protocols such as SSL/TLS. > As the current ODP crypto library lacks support for asymmetric crypto > algorithms, this RFC is an attempt to address it and add support for the > same. If you target TLS, you shou

Re: [lng-odp] [API-NEXT PATCH v2 15/16] Add llqueue, an unbounded concurrent queue

On 05.04.2017 21:36, Ola Liljedahl wrote: > On 5 April 2017 at 17:33, Dmitry Eremin-Solenikov > wrote: >> On 05.04.2017 17:40, Ola Liljedahl wrote: >>> On 5 April 2017 at 14:20, Maxim Uvarov wrote: >>>> On 04/05/17 01:46, Ola Liljedahl wrote: >>>>&g

Re: [lng-odp] [PATCH v2] fix native Clang build on ARMv8

On 06.04.2017 20:25, Brian Brooks wrote: > See [1] for details. > > [1] https://lists.linaro.org/pipermail/lng-odp/2017-April/029684.html Brian, not that this is a good long description of the commit. I'd still suggest to just change the line setting CFLAGS from just -mcx16 to -mcx16 -Werror. An

Re: [lng-odp] [API-NEXT] API: IPSEC: Updating ipsec APIs to support sNIC implementation.

On 07.04.2017 13:00, Nikhil Agarwal wrote: > +typedef union odp_ipsec_protocols_t { > + /** Cipher algorithms */ > + struct { > + /** ODP_IPSEC_ESP */ > + uint32_t esp: 1; > + > + /** ODP_IPSEC_AH */ > + uint32_t ah : 1; Smal

[lng-odp] [PATCH 3/3] api: ipsec: add default queue for outbound events

If SA lookup fails for outbound IPsec packet in async mode, there is no way to report it back to application except using default queue (which does not exist at this moment). Signed-off-by: Dmitry Eremin-Solenikov --- include/odp/api/spec/ipsec.h | 7 +++ 1 file changed, 7 insertions

[lng-odp] [PATCH 2/3] api: ipsec: mark odp_ipsec_sa_create argument as constant

odp_ipsec_sa_create() should not change its argument. Thus mark it as a constant. Signed-off-by: Dmitry Eremin-Solenikov --- include/odp/api/spec/ipsec.h | 2 +- platform/linux-generic/odp_ipsec.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/include/odp/api/spec

[lng-odp] [PATCH 1/3] api: ipsec: make num_pkt/out/sa/opt unsigned

It does not make sense to specify negative amount inside num_*. Make respective fields unsigned instead. Signed-off-by: Dmitry Eremin-Solenikov --- include/odp/api/spec/ipsec.h | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/include/odp/api/spec/ipsec.h b/include

Re: [lng-odp] [PATCH 1/3] api: ipsec: make num_pkt/out/sa/opt unsigned

On 10.04.2017 16:30, Maxim Uvarov wrote: > On 10 April 2017 at 16:14, Savolainen, Petri (Nokia - FI/Espoo) < > petri.savolai...@nokia-bell-labs.com> wrote: > >> Is there a way to get Github to send individual patches to the list ? ... >> Instead of this all-patches-in-one-mail format, with a misl

Re: [lng-odp] [PATCH 1/3] api: ipsec: make num_pkt/out/sa/opt unsigned

ge- >> From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of Maxim >> Uvarov >> Sent: Monday, April 10, 2017 3:43 PM >> To: lng-odp@lists.linaro.org >> Subject: [lng-odp] [PATCH 1/3] api: ipsec: make num_pkt/out/sa/opt >> unsigned >> >>

[lng-odp] [PATCH] api: ipsec: change semantics of odp_ipsec_result function

one to copy packets from the event in small batches and process them accordingly. Signed-off-by: Dmitry Eremin-Solenikov --- include/odp/api/spec/ipsec.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/include/odp/api/spec/ipsec.h b/include/odp/api/spec/ipsec.h index

[lng-odp] [API-NEXT][RFC] linux-gen: ipsec: draft IPsec implementation

For now it's only a preview with the following limitation: - No inline processing support - No SA lookups - Only IPv4 support - No tunnel support - No header modification according to RFCs Signed-off-by: Dmitry Eremin-Solenikov --- platform/linux-generic/include/odp_internal.h |

[lng-odp] [API-NEXT][RFC][rebased] linux-gen: ipsec: draft IPsec implementation

For now it's only a preview with the following limitation: - No inline processing support - No SA lookups - Only IPv4 support - No tunnel support - No header modification according to RFCs Signed-off-by: Dmitry Eremin-Solenikov --- platform/linux-generic/include/odp_internal.h |

Re: [lng-odp] [PATCH] api: ipsec: change semantics of odp_ipsec_result function

On 12.04.2017 12:44, Savolainen, Petri (Nokia - FI/Espoo) wrote: > > >> -Original Message- >> From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of >> Dmitry Eremin-Solenikov >> Sent: Tuesday, April 11, 2017 2:02 AM >> To: lng-odp@l

Re: [lng-odp] [API-NEXT PATCH v2 0/4] Deprecated macros

On 30.03.2017 16:58, Petri Savolainen wrote: > Replaced ODP_DEPRECATED macro (which was based on GCC __attribute__) with > compiler independent mechanism to control if deprecated API definitions are > visible to the application. ODP_DEPRECATED_API can be used both in > application > and impleme

Re: [lng-odp] [API-NEXT PATCH v2 0/4] Deprecated macros

On 12.04.2017 14:50, Savolainen, Petri (Nokia - FI/Espoo) wrote: > > >> -Original Message----- >> From: Dmitry Eremin-Solenikov [mailto:dmitry.ereminsoleni...@linaro.org] >> Sent: Wednesday, April 12, 2017 2:32 PM >> To: Petri Savolainen ; lng- >> o...@l

Re: [lng-odp] [PATCH v3] example: add IPv4 fragmentation/reassembly example

On 12.04.2017 14:05, Joe Savage wrote: > On 12/04/17 11:32, Maxim Uvarov wrote: >> On 12.04.2017 13:15, Joe Savage wrote: >> The problem is that when we discussed this patch on ODP call people very >> worry about having 128bit instructions in ODP examples. At least Petri >> and Barry as

Re: [lng-odp] [PATCH v3] example: add IPv4 fragmentation/reassembly example

On 12.04.2017 14:05, Joe Savage wrote: > On 12/04/17 11:32, Maxim Uvarov wrote: >> On 12.04.2017 13:15, Joe Savage wrote: >> The problem is that when we discussed this patch on ODP call people very >> worry about having 128bit instructions in ODP examples. At least Petri >> and Barry as

Re: [lng-odp] [PATCH v3] example: add IPv4 fragmentation/reassembly example

On 10.02.2017 19:06, Joe Savage wrote: > Add an example application implementing lock-free IPv4 fragmentation > and reassembly functionality using ODP's packet "concat" and "split". > > Signed-off-by: Joe Savage > Reviewed-and-tested-by: Bill Fischofer > --- > (This code contribution is provided

Re: [lng-odp] [API-NEXT PATCH v2 0/4] Deprecated macros

On 12.04.2017 15:21, Bill Fischofer wrote: > On Wed, Apr 12, 2017 at 7:11 AM, Dmitry Eremin-Solenikov > wrote: >> On 12.04.2017 14:50, Savolainen, Petri (Nokia - FI/Espoo) wrote: >>> >>> >>>> -----Original Message- >>>> From: Dmitry Erem

Re: [lng-odp] [PATCH v3] example: add IPv4 fragmentation/reassembly example

On 12.04.2017 16:01, Joe Savage wrote: > On 12/04/17 13:22, Dmitry Eremin-Solenikov wrote: >> On 12.04.2017 14:05, Joe Savage wrote: >>> On 12/04/17 11:32, Maxim Uvarov wrote: >>>> On 12.04.2017 13:15, Joe Savage wrote: >>>>>>>> The problem i

Re: [lng-odp] [PATCH v3] example: add IPv4 fragmentation/reassembly example

On 12.04.2017 16:37, Joe Savage wrote: > On 12/04/17 14:24, Dmitry Eremin-Solenikov wrote: >> On 12.04.2017 16:01, Joe Savage wrote: >>> I'm not sure I quite follow your comments regarding $(ARCH_DIR) though. Are >>> there some ODP-defined macros that I can

Re: [lng-odp] [API-NEXT PATCH v2 0/4] Deprecated macros

On 12.04.2017 17:24, Bill Fischofer wrote: > On Wed, Apr 12, 2017 at 8:22 AM, Dmitry Eremin-Solenikov > wrote: >> On 12.04.2017 15:21, Bill Fischofer wrote: >>> On Wed, Apr 12, 2017 at 7:11 AM, Dmitry Eremin-Solenikov >>> wrote: >>>> On 12.04.2017

Re: [lng-odp] [PATCH v3] example: add IPv4 fragmentation/reassembly example

On 12.04.2017 17:24, Brian Brooks wrote: > On Wed, Apr 12, 2017 at 8:24 AM, Dmitry Eremin-Solenikov > wrote: >> On 12.04.2017 16:01, Joe Savage wrote: >>> On 12/04/17 13:22, Dmitry Eremin-Solenikov wrote: >>>> On 12.04.2017 14:05, Joe Savage wrote: >>&g

Re: [lng-odp] [PATCH v2] build: fix native Clang build on ARMv8

le changed, 16 insertions(+), 14 deletions(-) Reviewed-by: Dmitry Eremin-Solenikov > > diff --git a/configure.ac b/configure.ac > index 9320f360..d364b8dd 100644 > --- a/configure.ac > +++ b/configure.ac > @@ -303,20 +303,22 @@ ODP_CFLAGS="$ODP_CFLAGS -std=c99" >

Re: [lng-odp] [API-NEXT PATCH v2 0/4] Deprecated macros

On 13.04.2017 10:33, Savolainen, Petri (Nokia - FI/Espoo) wrote: > > >> -Original Message----- >> From: Dmitry Eremin-Solenikov [mailto:dmitry.ereminsoleni...@linaro.org] >> Sent: Wednesday, April 12, 2017 3:11 PM >> To: Savolainen, Petri (Nokia -

Re: [lng-odp] [API-NEXT PATCH v2 0/4] Deprecated macros

On 13.04.2017 15:26, Bill Fischofer wrote: > On Thu, Apr 13, 2017 at 6:46 AM, Maxim Uvarov wrote: >> I vote for default build will not build with deprecating support. Yes all >> general propose distributives will need to enable --enable-deprecated-api >> to support some old software. But develope

[lng-odp] [API-NEXT] api: ipsec: factor out definitions for feature support levels

Instead of having magic 0-1-2 numbers, let's have the special enum for feature support levels (unsupported/supported/preferred). Signed-off-by: Dmitry Eremin-Solenikov --- include/odp/api/spec/ipsec.h | 56 +++- 1 file changed, 29 insertions(+

Re: [lng-odp] [API-NEXT][RFC][rebased] linux-gen: ipsec: draft IPsec implementation

Eremin-Solenikov > wrote: >> For now it's only a preview with the following limitation: >> - No inline processing support >> - No SA lookups >> - Only IPv4 support >> - No tunnel support >> - No header modification according to RFCs >> >> Sig

Re: [lng-odp] [API-NEXT] api: ipsec: factor out definitions for feature support levels

On 14.04.2017 16:25, Bill Fischofer wrote: > On Fri, Apr 14, 2017 at 6:53 AM, Bala Manoharan > wrote: >> Regards, >> Bala >> >> >> On 14 April 2017 at 16:52, Bill Fischofer wrote: >>> On Fri, Apr 14, 2017 at 5:58 AM, Dmitry Eremin-Solenikov >>&

Re: [lng-odp] [API-NEXT] api: ipsec: factor out definitions for feature support levels

the header file, where to place this definition. > > On Fri, Apr 14, 2017 at 8:49 AM, Dmitry Eremin-Solenikov > wrote: >> On 14.04.2017 16:25, Bill Fischofer wrote: >>> On Fri, Apr 14, 2017 at 6:53 AM, Bala Manoharan >>> wrote: >>>> Regards, >>

[lng-odp] [API-NEXT] api: ipsec: factor out definitions for feature support levels

Instead of having magic 0-1-2 numbers, let's have the special enum for feature support levels (unsupported/supported/preferred). Signed-off-by: Dmitry Eremin-Solenikov --- include/odp/api/spec/ipsec.h | 56 +++- 1 file changed, 29 insertions(+

[lng-odp] [API-NEXT v2] api: feature: factor out definitions for feature support levels

Instead of having magic 0-1-2 numbers, let's have the special enum for feature support levels (unsupported/supported/preferred). Signed-off-by: Dmitry Eremin-Solenikov --- include/odp/api/spec/feature.h | 54 include/odp/api/spec/ip

[lng-odp] [API-NEXT v3] api: ipsec: factor out definitions for feature support levels

Instead of having magic 0-1-2 numbers, let's have the special enum for feature support levels (unsupported/supported/preferred). Signed-off-by: Dmitry Eremin-Solenikov --- include/odp/api/spec/feature.h | 53 include/odp/api/spec/ip

Re: [lng-odp] [API-NEXT v3] api: ipsec: factor out definitions for feature support levels

On 17.04.2017 18:13, Maxim Uvarov wrote: > make distcheck fails: > > > In file included from > ../../../platform/linux-generic/include/protocols/ip.h:20:0, > > from > ../../../platform/linux-generic/include/odp_classification_datamodel.h:28, > > from > ../../..

[lng-odp] [API-NEXT v4] api: ipsec: factor out definitions for feature support levels

Instead of having magic 0-1-2 numbers, let's have the special enum for feature support levels (unsupported/supported/preferred). Signed-off-by: Dmitry Eremin-Solenikov --- include/odp/api/spec/feature.h | 53 include/odp/api/spec/ip

Re: [lng-odp] [API-NEXT][RFC][rebased] linux-gen: ipsec: draft IPsec implementation

;>> crypto_param.iv.length = odp_random_data(crypto_param.iv.data, >>> ipsec_sa->esp_iv_len, ODP_RANDOM_CRYPTO); > > Note that for AES-GCM one cannot use random IV since IV values must > never be reused in GCM. With AES-GCM a counter or alike would work. AES-GC

Re: [lng-odp] [RFC, API-NEXT v2 1/1] comp:compression interface

On 19.04.2017 13:00, Shally Verma wrote: > An API set to add compression/decompression support in ODP > interface. > > Signed-off-by: Shally Verma > Signed-off-by: Mahipal Challa > --- > include/odp/api/spec/comp.h | 748 > > 1 file changed, 748 ins

[lng-odp] [API-NEXT v5] api: ipsec: factor out definitions for feature support levels

Instead of having magic 0-1-2 numbers, let's have the special enum for feature support levels (unsupported/supported/preferred). Signed-off-by: Dmitry Eremin-Solenikov --- include/odp/api/spec/ipsec.h | 39 +--- include/odp/api/spec/supp

Re: [lng-odp] [RFC, API-NEXT v2 1/1] comp:compression interface

On 19.04.2017 17:02, Verma, Shally wrote: > > > -Original Message- > From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of Verma, > Shally > Sent: 19 April 2017 19:30 > To: Dmitry Eremin-Solenikov ; Shally Verma > ; lng-odp@lists.linaro.org > C

[lng-odp] [API-NEXT PATCH v2] api: ipsec: change semantics of odp_ipsec_result function

one to copy packets from the event in small batches and process them accordingly. - Freeing the event in odp_ipsec_result() leaves space for optimized implementations, where an event is actually a packet with additional metadata. Signed-off-by: Dmitry Eremin-Solenikov --- include/odp/api

Re: [lng-odp] [API-NEXT PATCHv2 2/6] api: ipsec: add additional doxygen documentation

On 20 April 2017 at 01:34, Bill Fischofer wrote: > Resolve Bug https://bugs.linaro.org/show_bug.cgi?id=2952 by adding > additional field documentation to avoid problems with doxygen 1.8.13 > and higher. > > Signed-off-by: Bill Fischofer Reviewed-by: Dmitry Eremin-Solenikov

Re: [lng-odp] [PATCH v2] linux-generic: crypto: properly handle errors in packet copy

On 20.04.2017 23:25, Maxim Uvarov wrote: > On 04/20/17 19:12, Bill Fischofer wrote: >> On Mon, Mar 13, 2017 at 6:44 AM, Dmitry Eremin-Solenikov < >> dmitry.ereminsoleni...@linaro.org> wrote: >> >>> Add proper handling for errors returned by odp_packet_copy_from_

[lng-odp] [PATCH v3] linux-generic: crypto: properly handle errors in packet copy

Add proper handling for errors returned by odp_packet_copy_from_pkt(). Signed-off-by: Dmitry Eremin-Solenikov --- platform/linux-generic/odp_crypto.c | 22 +++--- 1 file changed, 19 insertions(+), 3 deletions(-) diff --git a/platform/linux-generic/odp_crypto.c b/platform/linux

[lng-odp] [PATCH v4] linux-generic: crypto: properly handle errors in packet copy

Add proper handling for errors returned by odp_packet_copy_from_pkt(). Signed-off-by: Dmitry Eremin-Solenikov --- platform/linux-generic/odp_crypto.c | 24 1 file changed, 20 insertions(+), 4 deletions(-) diff --git a/platform/linux-generic/odp_crypto.c b/platform

[lng-odp] [PATCH 0/4] crypto: rework implementation of encryption and auth code

and auth code. Dmitry Eremin-Solenikov (4): validation: crypto: add tests for checking message digests validation: crypto: correct comment for HMAC-SHA-256 tests linux-generic: crypto: unify auth code linux-generic: crypto: switch to EVP interface for cipher algorithms .../linux-generic

[lng-odp] [PATCH 1/4] validation: crypto: add tests for checking message digests

Currently ODP testsuite only verifies generation of digests. Let's also verify that checking the digest actually works. Test that check function will accept valid digest and that it will reject wrong digests. Signed-off-by: Dmitry Eremin-Solenikov --- test/common_plat/validation/api/c

[lng-odp] [PATCH 2/4] validation: crypto: correct comment for HMAC-SHA-256 tests

Comment for HMAC-SHA-256 tests talks about HMAC-MD5 and respective lengths. Correct it to mention SHA-256 and proper digest lengths. Signed-off-by: Dmitry Eremin-Solenikov --- test/common_plat/validation/api/crypto/odp_crypto_test_inp.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions

[lng-odp] [PATCH 3/4] linux-generic: crypto: unify auth code

Authentication code contains similar functions. Instead of replicating them further (e.g. for SHA-1 or SHA-3) factor out common code blocks, moving all difference to session data. Signed-off-by: Dmitry Eremin-Solenikov --- .../linux-generic/include/odp_crypto_internal.h| 14 +-- platform

[lng-odp] [PATCH 4/4] linux-generic: crypto: switch to EVP interface for cipher algorithms

there will be more AEAD ciphers. Signed-off-by: Dmitry Eremin-Solenikov --- .../linux-generic/include/odp_crypto_internal.h| 16 +- platform/linux-generic/odp_crypto.c| 232 + 2 files changed, 52 insertions(+), 196 deletions(-) diff --git a/platform/linux

[lng-odp] [API-NEXT PATCH] api: packet: introduce odp_packet_data_range_t

Rename odp_crypto_data_range_t to odp_packet_data_range_t, as it is relevant not only to the crypto interface. Signed-off-by: Dmitry Eremin-Solenikov --- include/odp/api/spec/crypto.h | 17 +++-- include/odp/api/spec/packet.h | 12

Re: [lng-odp] [Linaro/odp] Zeroing packet data (#18)

Maxim, On 26.04.2017 17:02, muvarov wrote: > From: Github ODP bot > From: Dmitry Eremin-Solenikov > > Check that odp_packet_zero_data() works with single-segment packets and > with segmented packets. > > Signed-off-by: Dmitry Eremin-Solenikov Can we somehow preve

Re: [lng-odp] [Linaro/odp] Zeroing packet data (#18)

On 26.04.2017 17:06, Codecov wrote: > Impacted Files > Coverage Δ > test/common_plat/validation/api/packet/packet.c >

Re: [lng-odp] [PATCH] linux-generic: rwlock: fix odp_rwlock_read_trylock()

On 26.04.2017 20:54, Peltonen, Janne (Nokia - FI/Espoo) wrote: > > That does not work. Since the value of cnt is not checked, the code > would happily take the lock even when a writer already has it. Nice catch. Updated to check for writers. -- With best wishes Dmitry

Re: [lng-odp] [PATCH 4/4] linux-generic: crypto: switch to EVP interface for cipher algorithms

On 25.04.2017 04:41, Dmitry Eremin-Solenikov wrote: > Switch AES-CBC and 3DES-CBC to use generic (EVP) interface instad of low > level interface (as recommended by OpenSSL documentation). This allows > to use the same code path for all non-AEAD ciphers. The only AEAD cipher > (AES-

Re: [lng-odp] [API-NEXT PATCH v2 4/4] api: crypto: enforce deprecated API status

this later if we see point in it (or maybe a suggestion from distro guys). I'd propose to merge this series as is. So, for the whole patchset: Reviewed-by: Dmitry Eremin-Solenikov -- With best wishes Dmitry

[lng-odp] [[RFCv2] 1/4] api: ipsec: mark odp_ipsec_sa_create argument as constant

odp_ipsec_sa_create() should not change its argument. Thus mark it as a constant. Signed-off-by: Dmitry Eremin-Solenikov --- include/odp/api/spec/ipsec.h | 2 +- platform/linux-generic/odp_ipsec.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/include/odp/api/spec

[lng-odp] [[RFCv2] 3/4] api: ipsec: change semantics of odp_ipsec_result function

one to copy packets from the event in small batches and process them accordingly. - Freeing the event in odp_ipsec_result() leaves space for optimized implementations, where an event is actually a packet with additional metadata. Signed-off-by: Dmitry Eremin-Solenikov --- include/odp/api

[lng-odp] [[RFCv2] 2/4] api: ipsec: add default queue for outbound events

If an application has passed invalid SA in async mode, there is no way to report it back to application except using default queue (which does not exist at this moment). Signed-off-by: Dmitry Eremin-Solenikov --- include/odp/api/spec/ipsec.h | 7 +++ 1 file changed, 7 insertions(+) diff

[lng-odp] [[RFCv2] 4/4] linux-gen: ipsec: draft IPsec implementation

For now it's only a preview with the following limitation: - No inline processing support - No SA lookups - Only IPv4 support - No zeroing of mutable IPv4 options for AH ICV calculation - No replay protection - No ESN support Signed-off-by: Dmitry Eremin-Solenikov --- .../include/od

Re: [lng-odp] [[RFCv2] 3/4] api: ipsec: change semantics of odp_ipsec_result function

On 28.04.2017 01:46, Bill Fischofer wrote: > > > On Thu, Apr 27, 2017 at 6:51 AM, Dmitry Eremin-Solenikov > <mailto:dmitry.ereminsoleni...@linaro.org>> wrote: > > - Move packets from the event instead of copying them. This simplifies >event handlin

Re: [lng-odp] [[RFCv2] 2/4] api: ipsec: add default queue for outbound events

On 28.04.2017 01:23, Bill Fischofer wrote: > > > On Thu, Apr 27, 2017 at 6:51 AM, Dmitry Eremin-Solenikov > <mailto:dmitry.ereminsoleni...@linaro.org>> wrote: > > If an application has passed invalid SA in async mode, there is no way > to report it ba

Re: [lng-odp] [[RFCv2] 4/4] linux-gen: ipsec: draft IPsec implementation

lso complains about a number of lines being > 80 chars. Yes, sure. I just hate that requirement, so I usually fix long lines during the last stages before actually submitting the patch. So that if I change smth in the 'split' line, I don't have to resplit/realign it. > > O

Re: [lng-odp] [[RFCv2] 2/4] api: ipsec: add default queue for outbound events

On 28.04.2017 03:33, Bill Fischofer wrote: > > > On Thu, Apr 27, 2017 at 6:19 PM, Dmitry Eremin-Solenikov > <mailto:dmitry.ereminsoleni...@linaro.org>> wrote: > > On 28.04.2017 01:23, Bill Fischofer wrote: > > > > > > On Thu, Apr

Re: [lng-odp] [[RFCv2] 3/4] api: ipsec: change semantics of odp_ipsec_result function

On 28.04.2017 03:45, Bill Fischofer wrote: > > > On Thu, Apr 27, 2017 at 5:49 PM, Dmitry Eremin-Solenikov > <mailto:dmitry.ereminsoleni...@linaro.org>> wrote: > > On 28.04.2017 01:46, Bill Fischofer wrote: > > > > > > On Thu, Apr

[lng-odp] IPsec SA disabling

Hello, While responding to Janne's email, I've come to an issue which warrants a separate discussion IMO. Consider the following scenario. Application with two thread. - First thread: gets outbound packet, finds SA through SPD, configures IPsec request, submits it. - Second thread: wants to dis

Re: [lng-odp] IPsec SA disabling

On 28.04.2017 12:27, Peltonen, Janne (Nokia - FI/Espoo) wrote: > Hi, > >> -Original Message- >> From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of Dmitry >> Eremin- >> Solenikov >> Sent: Friday, April 28, 2017 11:59 AM >> To: ln

Re: [lng-odp] [[RFCv2] 2/4] api: ipsec: add default queue for outbound events

On 28.04.2017 11:29, Peltonen, Janne (Nokia - FI/Espoo) wrote: > > >> -Original Message- >> From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of Dmitry >> Eremin- >> Solenikov >> Sent: Friday, April 28, 2017 3:44 AM >>

Re: [lng-odp] [[RFCv2] 3/4] api: ipsec: change semantics of odp_ipsec_result function

On 28.04.2017 12:03, Peltonen, Janne (Nokia - FI/Espoo) wrote: > >> -Original Message- >> From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of Bill >> Fischofer >> Sent: Friday, April 28, 2017 4:06 AM >> To: Dmitry Eremin-Solenikov >&

Re: [lng-odp] [[RFCv2] 3/4] api: ipsec: change semantics of odp_ipsec_result function

On 28.04.2017 12:03, Peltonen, Janne (Nokia - FI/Espoo) wrote: > >> -Original Message- >> From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of Bill >> Fischofer >> Sent: Friday, April 28, 2017 4:06 AM >> To: Dmitry Eremin-Solenikov >&

Re: [lng-odp] IPsec SA disabling

On 28.04.2017 15:32, Bala Manoharan wrote: > On 28 April 2017 at 15:41, Dmitry Eremin-Solenikov > wrote: >> On 28.04.2017 12:27, Peltonen, Janne (Nokia - FI/Espoo) wrote: >>> Hi, >>> >>>> -Original Message- >>>> From: lng-odp

Re: [lng-odp] IPsec SA disabling

Hi, On 28.04.2017 16:57, Peltonen, Janne (Nokia - FI/Espoo) wrote: > Hi, > > I believe the current API is complete in the sense that all necessary > things can be done safely. Maybe ODP could provide an easier-to-use > API but if the application and the API give fewer guarantees to the > ODP impl

Re: [lng-odp] github web hook updated

On 02.05.2017 11:27, Maxim Uvarov wrote: > Updated github web hook: > > Changes: > > Now on merge request topic (title) of merge request automatic changed to: > [PATCH vX] title > or > [PATCH API-NEXT vX] title PR https://github.com/Linaro/odp/pull/10 was correctly renamed by your hook, but when

Re: [lng-odp] [API-NEXT PATCH v2 0/4] Deprecated macros

On 03.05.2017 07:43, Honnappa Nagarahalli wrote: > Let us say: > > API spec v1.20 could define: > > typedef struct odp_foo_bar_t { > /** This is foo*/ > uint8_t foo; > } odp_foo_bar_t; > > > API spec v1.30 could define: > > typedef struct odp_foo_bar_t { > /** @deprecat

Re: [lng-odp] [PATCH] api: ipsec: factor out IP protocol version parameter

On 03.05.2017 17:00, Github ODP bot wrote: > From: Dmitry Eremin-Solenikov > > Both tunnel and lookup parameters refer IP protocol version. Factor that > out as an IPsec enum used in both places. > > Signed-off-by: Dmitry Eremin-Solenikov > --- > /** Email crea

Re: [lng-odp] [PATCH 3/4] linux-generic: crypto: add SHA-1 authentication support

On 03.05.2017 17:17, Peltonen, Janne (Nokia - FI/Espoo) wrote: > Hi, > > I think there is a problem or ambiguity in the ODP API spec regarding > the truncation of the HMAC output. > > According to RFC 2104 the terminology goes so that HMAC-{hash-func} (e.g. > HMAC-SHA-512) means the HMAC with the

[lng-odp] IPsec PIPELINE_CLS support

Hello, I have been looking through the missing pieces in my linux-generic implementation. One of the remaining pieces that I don't quite understand is the pipeline_cls capability. How should I behave wrt to it? Should I just send the event via odp_cos_queue(param->cos)? Or should I submit the pack

Re: [lng-odp] [PATCH] api: ipsec: factor out IP protocol version parameter

On 03.05.2017 19:00, Github ODP bot wrote: > From: Dmitry Eremin-Solenikov > > Both tunnel and lookup parameters refer IP protocol version. Factor that > out as an IPsec enum used in both places. Subject prefixes are still not correct. -- With best wishes Dmitry

[lng-odp] [PATCH API-NEXT v2] api: packet: introduce odp_packet_data_range_t

Rename odp_crypto_data_range_t to odp_packet_data_range_t, as it is relevant not only to the crypto interface. Signed-off-by: Dmitry Eremin-Solenikov --- include/odp/api/spec/crypto.h | 17 +++-- include/odp/api/spec/packet.h | 12

Re: [lng-odp] [PATCH 3/4] linux-generic: crypto: add SHA-1 authentication support

On 04.05.2017 09:34, Peltonen, Janne (Nokia - FI/Espoo) wrote: > > Dmitry Eremin-Solenikov [mailto:dmitry.ereminsoleni...@linaro.org] wrote: >> >> On 03.05.2017 17:17, Peltonen, Janne (Nokia - FI/Espoo) wrote: >>> Hi, >>> >>> I think there is a probl

Re: [lng-odp] [API-NEXT PATCH 1/2] api: crypto: add digest length session parameter

On 04.05.2017 15:55, Petri Savolainen wrote: > Authentication capabilities list supported digest lengths > per algorithm, but application did not have means to select which > length is used. > > Signed-off-by: Petri Savolainen Both patches: Reviewed-by: Dmitry E

[lng-odp] IPsec limits support

Hello, I have been working on limits support in IPsec. Now I have several questions: - Is hard limit crossing fatal? IOW, should I start returning unprocessed packets after crossing it? - Does 'bytes' limit count packet bytes before or IPsec operation? Does it count 'usefull' payload or the wh

Re: [lng-odp] IPsec limits support

On 04.05.2017 19:35, Bill Fischofer wrote: > > > On Thu, May 4, 2017 at 11:25 AM, Dmitry Eremin-Solenikov > <mailto:dmitry.ereminsoleni...@linaro.org>> wrote: > > Hello, > > I have been working on limits support in IPsec. Now I have several >

Re: [lng-odp] [API-NEXT PATCH 2/3] api: ipsec: add capability for max packets per result event

On 05.05.2017 15:34, Petri Savolainen wrote: > Added maximum number of packets per result event to make it easy > for application to prepare enough storage for packets. I'm still not sure that this is a good idea. Patches 1 and 3 are: Reviewed-by: Dmitry Eremin-Solenikov > &

Re: [lng-odp] [PATCH] api: ipsec: factor out IP protocol version parameter

rg >> Subject: [lng-odp] [PATCH] api: ipsec: factor out IP protocol version >> parameter >> >> From: Dmitry Eremin-Solenikov >> >> Both tunnel and lookup parameters refer IP protocol version. Factor that >> out as an IPsec enum used in both places. >&

Re: [lng-odp] [PATCH API-NEXT v1 2/2] api: ipsec: move soft limits expiration to flags, rather than errors

org >> Subject: [lng-odp] [PATCH API-NEXT v1 2/2] api: ipsec: move soft limits >> expiration to flags, rather than errors >> >> From: Dmitry Eremin-Solenikov >> >> Soft limit expiration isn't an error per se. It does not mean, that we >> received invalid

Re: [lng-odp] [PATCH API-NEXT v1 1/2] api: ipsec: add soft limit expiration event

org >> Subject: [lng-odp] [PATCH API-NEXT v1 1/2] api: ipsec: add soft limit >> expiration event >> >> From: Dmitry Eremin-Solenikov >> >> If outbound packet was processed in inline mode, soft limit expiration >> event is not reported, as packet goes t

Re: [lng-odp] [PATCH API-NEXT v1 2/2] api: ipsec: move soft limits expiration to flags, rather than errors

On 06.05.2017 00:29, Bill Fischofer wrote: > On Fri, May 5, 2017 at 4:24 PM, Dmitry Eremin-Solenikov > wrote: >> On 05.05.2017 11:17, Savolainen, Petri (Nokia - FI/Espoo) wrote: >>> >>> >>>> -Original Message- >>>> From: lng-odp

<    1   2   3   4   5   >