svn commit: r1567531 - /incubator/log4cxx/trunk/src/test/cpp/helpers/cacheddateformattestcase.cpp

2014-02-11 Thread rhys
Author: rhys Date: Wed Feb 12 05:51:52 2014 New Revision: 1567531 URL: http://svn.apache.org/r1567531 Log: Uncomment out tests. Accidentally nuked these in the prior commit. Sorry. Modified: incubator/log4cxx/trunk/src/test/cpp/helpers/cacheddateformattestcase.cpp Modified: incubator/log4

Re: Seeing cacheddateformattestcase regression from r1559522.

2014-02-11 Thread Rhys Ulerich
FYI, r1567530 tweaks the unit test harness to get e.what() when e inherits from std::exception. $ ./src/test/cpp/testsuite -v cacheddateformattestcase ... Line -1: Unexpected std::exception: basic_string::compare Line -1: Unexpected std::exception: basic_string::compare Line -1: Unexpected std::ex

svn commit: r1567530 - in /incubator/log4cxx/trunk/src/test/cpp: helpers/cacheddateformattestcase.cpp logunit.h

2014-02-11 Thread rhys
Author: rhys Date: Wed Feb 12 05:48:26 2014 New Revision: 1567530 URL: http://svn.apache.org/r1567530 Log: Get e.what() on unexpected std::exception Done towards chasing down cacheddateformattestcase problems. Modified: incubator/log4cxx/trunk/src/test/cpp/helpers/cacheddateformattestcase.cp

Re: Seeing cacheddateformattestcase regression from r1559522.

2014-02-11 Thread Rhys Ulerich
> I'm guessing the problem is in the test cases themselves-- I'll try to > hook up a debugger to verify soon. Finally got that debugger attached. The unexpected exceptions are std::out_of_range, I think, from bad invocations of std::string::compare. The backtraces all resemble __cxa_throw () fr

svn commit: r1567526 - in /incubator/log4cxx/trunk/src: ant/ examples/cpp/ main/cpp/ main/include/log4cxx/ main/include/log4cxx/db/ main/include/log4cxx/helpers/ main/include/log4cxx/net/ main/include

2014-02-11 Thread rhys
Author: rhys Date: Wed Feb 12 05:15:58 2014 New Revision: 1567526 URL: http://svn.apache.org/r1567526 Log: Remove +x on .{cpp,h,xml,properties} and witnesses Modified: incubator/log4cxx/trunk/src/ant/apr-build.xml (props changed) incubator/log4cxx/trunk/src/ant/apr-util-build.xml (pro

[jira] [Commented] (LOGCXX-319) Please make sure that the LOG4CXX_* macro's can be used as ordinary statements.

2014-02-11 Thread Rhys Ulerich (JIRA)
[ https://issues.apache.org/jira/browse/LOGCXX-319?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13898802#comment-13898802 ] Rhys Ulerich commented on LOGCXX-319: - r1567525 updates the examples and tests to matc

svn commit: r1567525 - in /incubator/log4cxx/trunk/src: examples/cpp/ test/cpp/ test/cpp/customlogger/ test/cpp/defaultinit/ test/cpp/net/ test/cpp/rolling/ test/cpp/xml/

2014-02-11 Thread rhys
Author: rhys Date: Wed Feb 12 04:54:05 2014 New Revision: 1567525 URL: http://svn.apache.org/r1567525 Log: LOG4CXX-319: Sprinkle semis in examples, tests r1566619 updated logger.h to make LOG4CXX_INFO and friends proper statements using the common do { stuff } while (0) idiom. There were many pla

[jira] [Reopened] (LOGCXX-337) Suggested fix for socketappender not reconnecting multiple times

2014-02-11 Thread Rhys Ulerich (JIRA)
[ https://issues.apache.org/jira/browse/LOGCXX-337?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rhys Ulerich reopened LOGCXX-337: - The application of the patch broke compilation. I've tried repairing things in r1567521, but someon

svn commit: r1567521 - /incubator/log4cxx/trunk/src/main/cpp/threadcxx.cpp

2014-02-11 Thread rhys
Author: rhys Date: Wed Feb 12 04:34:39 2014 New Revision: 1567521 URL: http://svn.apache.org/r1567521 Log: LOG4CXX-337 Attempt to get threadcxx.cpp compiling r1566630 broke this compilation unit with mismatched preprocessor directives and making Thread::join() disappear. I suspect the problem wa

Please don't apply/commit patches unless you can confirm they compile

2014-02-11 Thread Rhys Ulerich
Hi all, Please, please don't apply and commit patches from issues unless you can confirm build correctly afterwards. The fixes for 320 and 305 have been invoked APR methods without the correct arguments and have dropped down mismatched processor directives. - Rhys

svn commit: r1567513 - /incubator/log4cxx/trunk/src/main/include/log4cxx/helpers/aprinitializer.h

2014-02-11 Thread rhys
Author: rhys Date: Wed Feb 12 03:39:05 2014 New Revision: 1567513 URL: http://svn.apache.org/r1567513 Log: LOG4CXX-305: undo initialize return change Patch C applied as part of this issue changed the declared return type of the static initialize method without changing it in the implementation.

[jira] [Resolved] (LOGCXX-320) TLS memory of APR is not freed in destructor of APRInitializer

2014-02-11 Thread Rhys Ulerich (JIRA)
[ https://issues.apache.org/jira/browse/LOGCXX-320?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rhys Ulerich resolved LOGCXX-320. - Resolution: Fixed r1567511 fixes that compilation issue, though several others remain atop that

svn commit: r1567511 - /incubator/log4cxx/trunk/src/main/cpp/aprinitializer.cpp

2014-02-11 Thread rhys
Author: rhys Date: Wed Feb 12 03:30:33 2014 New Revision: 1567511 URL: http://svn.apache.org/r1567511 Log: LOG4CXX-320: Correct apr_threadkey_private_delete Change in r154 missed an argument to the method. Modified: incubator/log4cxx/trunk/src/main/cpp/aprinitializer.cpp Modified: incub

[jira] [Reopened] (LOGCXX-320) TLS memory of APR is not freed in destructor of APRInitializer

2014-02-11 Thread Rhys Ulerich (JIRA)
[ https://issues.apache.org/jira/browse/LOGCXX-320?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rhys Ulerich reopened LOGCXX-320: - Assignee: Rhys Ulerich (was: Curt Arnold) The patch applied in r154 included a bad call to

Re: Freezing trunk?

2014-02-11 Thread Thorsten Schöning
Guten Tag Florian Seydoux, am Dienstag, 11. Februar 2014 um 20:21 schrieben Sie: > (not always aligned with the coding style of > the rest of the lib). I simply ignored that for now because I have the feeling the current codebase isn't very consistent anyways and felt that getting outstanding pat

Re: Freezing trunk?

2014-02-11 Thread Florian Seydoux
On 10.02.2014 18:00, Thorsten Schöning wrote: > [...] > So, how about freezing the trunk now Good idea (and really good initiative). I'm anyway a bit like Joseph - except that I'll need more time (~a week) to close something. To be honest, I've looked at some ticket with patch, but I wasn't reall