Re: checkstyle in log4j-sandbox

2003-03-19 Thread Ceki Gülcü
At 11:23 PM 3/19/2003 -0800, you wrote: I moved over the checkstyle 3.0 build changes into log4j-sandbox. The only difference is that I turned on javadoc checking. We should turn this on in the log4j cvs as well. I know it seems like busy work to fix all the complaints, but it will be better in

checkstyle in log4j-sandbox

2003-03-19 Thread mwomack
I moved over the checkstyle 3.0 build changes into log4j-sandbox. The only difference is that I turned on javadoc checking. We should turn this on in the log4j cvs as well. I know it seems like busy work to fix all the complaints, but it will be better in the long run. -Mark -

cvs commit: jakarta-log4j-sandbox/src/java/org/apache/log4j/servlet InitServlet.java InitContextListener.java ConfigurationServlet.java

2003-03-19 Thread mwomack
mwomack 2003/03/19 23:19:24 Modified:src/java/org/apache/log4j/servlet InitServlet.java InitContextListener.java ConfigurationServlet.java Log: Jalopy-ized & checkstyled versions. Revision ChangesPath 1.6 +2 -0 jakarta-log4j-sandbox/src

cvs commit: jakarta-log4j-sandbox/src/java/org/apache/log4j/filter LoggerNameMatchFilter.java SetLocationInfoFilter.java NDCMatchFilter.java MessageMatchFilter.java MDCMatchFilter.java MatchFilterBase.java LevelRangeMatchFilter.java LevelMatchFilter.java

2003-03-19 Thread mwomack
mwomack 2003/03/19 23:18:32 Modified:src/java/org/apache/log4j/filter SetLocationInfoFilter.java NDCMatchFilter.java MessageMatchFilter.java MDCMatchFilter.java MatchFilterBase.java LevelRangeMatchFilter.java LevelMa

cvs commit: jakarta-log4j-sandbox/src sun_checks.xml

2003-03-19 Thread mwomack
mwomack 2003/03/19 23:17:42 Added: src sun_checks.xml Log: Changes to use checkstyle 3.0. Revision ChangesPath 1.1 jakarta-log4j-sandbox/src/sun_checks.xml Index: sun_checks.xml ===

cvs commit: jakarta-log4j-sandbox build.xml

2003-03-19 Thread mwomack
mwomack 2003/03/19 23:17:34 Modified:.build.xml Log: Changes to use checkstyle 3.0. Revision ChangesPath 1.6 +13 -3 jakarta-log4j-sandbox/build.xml Index: build.xml === RCS file: /h

RE: LoggingEvent and XML transport protocol

2003-03-19 Thread mwomack
Hi all, I am replying to this email to the dev email list because I think it is of general interest. I spent some time recently evangelizing Scott to convert his Chainsaw specific receiver code into the new general Receiver model, saying that he could take the xml his UDPAppender was generating an

RE: Chainsaw Preview?

2003-03-19 Thread mwomack
Richard, we haven't gotten Scott's cool stuff integrated yet, and we have been changing things sufficiently to make it a challenge for Scott to integrate. But hope is there. Have you had a chance to look at the recent changes we have made to Chainsaw? Not that the gui looks any different, but we

cvs commit: jakarta-log4j/src/java/org/apache/log4j/chainsaw XMLFileHandler.java MyTableModel.java EventDetails.java DetailPanel.java ControlPanel.java

2003-03-19 Thread mwomack
mwomack 2003/03/19 21:42:46 Modified:src/java/org/apache/log4j/chainsaw XMLFileHandler.java MyTableModel.java EventDetails.java DetailPanel.java ControlPanel.java Log: Changes to support display and filtering of property values. Re

cvs commit: jakarta-log4j/src/java/org/apache/log4j/spi LoggingEvent.java

2003-03-19 Thread mwomack
mwomack 2003/03/19 21:37:52 Modified:src/java/org/apache/log4j/spi LoggingEvent.java Log: Added getPropertyKeySet() method to return an unmodifiable set of the keys in the event properties. If the properties is null, then an empty set is returned. Revision ChangesPath 1

RE: Adding more MDC support to several classes

2003-03-19 Thread Paul Smith
> Oooh. Test cases. Primo! We aim to please! :) > Sounds like you have a good handle on it to me. I usually create the > witness file by generating it using the test case. Mmm, that would be easier, but I never trust myself that way. I'll copy a shell from another witness, and modify it to

RE: Adding more MDC support to several classes

2003-03-19 Thread mwomack
Paul, > I've just started preparing for the change, and started off by thinking > about the Test cases first. > > Am I correct in thinking that the following is the process to add a test > case for log4j & MDC?: > > * modify XMLLayoutTestCase, add another test method for MDC. > * create an xmlLayo

cvs commit: jakarta-log4j/contribs/JayFunnell NetSendAppender.java

2003-03-19 Thread mwomack
mwomack 2003/03/19 20:37:07 Modified:contribs/JayFunnell NetSendAppender.java Log: Submitting new version of NetSendAppender, per Jay Funnell. "The corrections were provided by Volker Mentzner to handle the case where the native DLL is missing." Revision ChangesPath 1.2

RE: Custom Log Level Example(s)

2003-03-19 Thread Jim Moore
You need to let your Logger (why are you using the deprecated Category class?) that it needs to use at least TRACE level. I've updated the Wiki page. -Original Message- From: David Siegel [mailto:[EMAIL PROTECTED] Sent: Wednesday, March 19, 2003 3:57 PM To: Log4J Developers List Subject

RE: Adding more MDC support to several classes

2003-03-19 Thread Paul Smith
Ok, thanks to all the +1's. I've just started preparing for the change, and started off by thinking about the Test cases first. Am I correct in thinking that the following is the process to add a test case for log4j & MDC?: * modify XMLLayoutTestCase, add another test method for MDC. * create a

RE: Adding more MDC support to several classes

2003-03-19 Thread Nicko Cadell
+1 > -Original Message- > From: Paul Smith [mailto:[EMAIL PROTECTED] > Sent: 19 March 2003 21:32 > To: 'Log4J Developers List' > Subject: RE: Adding more MDC support to several classes > > > Ok, thanks everyone for their input. I'm learning things > about XML on the way, so thanks. >

RE: Adding more MDC support to several classes

2003-03-19 Thread Mark Womack
> After reading the thread over a couple of times, could I summarise the > feeling of the group, that the format: > > > > > ... > > > would be acceptable to the group? (along with valid > Transform.escapeTag > stuff) > > The element cou

RE: Adding more MDC support to several classes

2003-03-19 Thread Ceki Gülcü
+1 At 08:31 AM 3/20/2003 +1100, you wrote: Ok, thanks everyone for their input. I'm learning things about XML on the way, so thanks. After reading the thread over a couple of times, could I summarise the feeling of the group, that the format: ...

RE: Adding more MDC support to several classes

2003-03-19 Thread Paul Smith
Ok, thanks everyone for their input. I'm learning things about XML on the way, so thanks. After reading the thread over a couple of times, could I summarise the feeling of the group, that the format: ... would be acceptable to the group?

DO NOT REPLY [Bug 18163] New: - bug in the flushBuffer method of JDBCAppender

2003-03-19 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bu

RE: Custom Log Level Example(s)

2003-03-19 Thread David Siegel
Thanks Jim, I created a class using this example, but cannot get the output to show. I get all levels but the TRACE level. Can anyone point out what I am doing wrong please? Thanks The test class: import org.apache.log4j.*; public class TestLogging { // Initialize a logging category. H

cvs commit: jakarta-log4j/src/java/org/apache/log4j/rolling RollingFileAppender.java

2003-03-19 Thread ceki
ceki2003/03/19 11:54:46 Added: src/java/org/apache/log4j/rolling RollingFileAppender.java Log: Starting point for improved RollingFileAppender.java Revision ChangesPath 1.1 jakarta-log4j/src/java/org/apache/log4j/rolling/RollingFileAppender.java

RE: Adding more MDC support to several classes

2003-03-19 Thread Nicko Cadell
> > > >You don't need to use a CDATA section for the message, you could use > >Transform.escapeTags for the message itself. In fact the best idea > >would be to use a version of Transform.escapeTags that tried > to escape > >tags, but if there were too many escapes (i.e. more than 4 > escapes

RE: Custom Log Level Example(s)

2003-03-19 Thread Jim Moore
http://nagoya.apache.org/wiki/apachewiki.cgi?Log4JProjectPages/TraceLevel -Original Message- From: David Siegel [mailto:[EMAIL PROTECTED] Sent: Wednesday, March 19, 2003 12:39 PM To: [EMAIL PROTECTED] Subject: Custom Log Level Example(s) Hi I've been scanning numerous sites looking

RE: Adding more MDC support to several classes

2003-03-19 Thread Ceki Gülcü
At 09:55 AM 3/19/2003 -0800, you wrote: > >> timestamp="213341234" level="INFO" thread="main"> > > > > > > > > > > > > > > > > > > ... > > > > > > I don't see why the > > and > > Need to be different. > > E

RE: Adding more MDC support to several classes

2003-03-19 Thread Ceki Gülcü
At 04:54 PM 3/19/2003 +, you wrote: > At 03:21 PM 3/19/2003 +, you wrote: > >Couple of questions. > > > >How will the logging event properties be represented in the > event XML? > > Good question. How about the following, > >timestamp="213341234" level="INFO" thread="main"> >

RE: Adding more MDC support to several classes

2003-03-19 Thread Mark Womack
> >> timestamp="213341234" level="INFO" thread="main"> > > > > > > > > > > > > > > > > > > ... > > > > > > I don't see why the > > and > > Need to be different. > > Essentially you just have a 'generic'

Custom Log Level Example(s)

2003-03-19 Thread David Siegel
Hi I've been scanning numerous sites looking for a step by step guide to generating and using your own custom levels in log4j. I found such an example very fast for the Java logging API but I've only uncovered example pieces for log4j that I am sure will eventually get me there. It seems as th

DO NOT REPLY [Bug 18134] - Logging stops if context is reloaded in Tomcat 4.0

2003-03-19 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bu

RE: Adding more MDC support to several classes

2003-03-19 Thread Nicko Cadell
> At 03:21 PM 3/19/2003 +, you wrote: > >Couple of questions. > > > >How will the logging event properties be represented in the > event XML? > > Good question. How about the following, > >timestamp="213341234" level="INFO" thread="main"> > > > > >

RE: Adding more MDC support to several classes

2003-03-19 Thread Ceki Gülcü
For example, ... At 03:21 PM 3/19/2003 +, you wrote: Couple of questions. How will the logging event properties be represented in the event XML? Good question. How about the following,

RE: Adding more MDC support to several classes

2003-03-19 Thread Nicko Cadell
Couple of questions. How will the logging event properties be represented in the event XML? Why is the value a text node and the mdc key value an attribute node? Both are strings. Both could potentially contain characters that are invalid (or at least need escaping). If they are stored in differ

Re: Adding more MDC support to several classes

2003-03-19 Thread Ceki Gülcü
Paul, I suggest the following format: ... Note that the MDC is optional. So the DTD should allow for the possibility of no MDC. At 10:14 PM 3/19/2003 +1100, you wrote: Just following up on something Mark has mentioned offline re: adding some more support for MDC thr

RE: Adding more MDC support to several classes

2003-03-19 Thread Nicko Cadell
As the LoggingEvent properties and the MDC properties are just a mapped set of properties attached to a different context, how about representing them using the same consistent form in XML. How about throwing in some other thread specific properties? What about something like: [item value

Adding more MDC support to several classes

2003-03-19 Thread Paul Smith
Just following up on something Mark has mentioned offline re: adding some more support for MDC through XMLLayout, and Chainsaw. I wanted to run some things by the group. Sorry if this is a bit long. The first thing that needs to happen is to modify the log4j.dtd file to incorporate the MDC struct

DO NOT REPLY [Bug 18134] - Logging stops if context is reloaded in Tomcat 4.0

2003-03-19 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bu

DO NOT REPLY [Bug 18134] New: - Logging stop if context is reloaded in Tomcat 4.0

2003-03-19 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bu