RE: Adding more MDC support to several classes

2003-03-19 Thread Paul Smith
> Oooh. Test cases. Primo! We aim to please! :) > Sounds like you have a good handle on it to me. I usually create the > witness file by generating it using the test case. Mmm, that would be easier, but I never trust myself that way. I'll copy a shell from another witness, and modify it to

RE: Adding more MDC support to several classes

2003-03-19 Thread mwomack
Paul, > I've just started preparing for the change, and started off by thinking > about the Test cases first. > > Am I correct in thinking that the following is the process to add a test > case for log4j & MDC?: > > * modify XMLLayoutTestCase, add another test method for MDC. > * create an xmlLayo

RE: Adding more MDC support to several classes

2003-03-19 Thread Paul Smith
Ok, thanks to all the +1's. I've just started preparing for the change, and started off by thinking about the Test cases first. Am I correct in thinking that the following is the process to add a test case for log4j & MDC?: * modify XMLLayoutTestCase, add another test method for MDC. * create a

RE: Adding more MDC support to several classes

2003-03-19 Thread Nicko Cadell
+1 > -Original Message- > From: Paul Smith [mailto:[EMAIL PROTECTED] > Sent: 19 March 2003 21:32 > To: 'Log4J Developers List' > Subject: RE: Adding more MDC support to several classes > > > Ok, thanks everyone for their input. I'm learning th

RE: Adding more MDC support to several classes

2003-03-19 Thread Mark Womack
> After reading the thread over a couple of times, could I summarise the > feeling of the group, that the format: > > > > > ... > > > would be acceptable to the group? (along with valid > Transform.escapeTag > stuff) > > The element cou

RE: Adding more MDC support to several classes

2003-03-19 Thread Ceki Gülcü
+1 At 08:31 AM 3/20/2003 +1100, you wrote: Ok, thanks everyone for their input. I'm learning things about XML on the way, so thanks. After reading the thread over a couple of times, could I summarise the feeling of the group, that the format: ...

RE: Adding more MDC support to several classes

2003-03-19 Thread Paul Smith
Ok, thanks everyone for their input. I'm learning things about XML on the way, so thanks. After reading the thread over a couple of times, could I summarise the feeling of the group, that the format: ... would be acceptable to the group?

RE: Adding more MDC support to several classes

2003-03-19 Thread Nicko Cadell
> > > >You don't need to use a CDATA section for the message, you could use > >Transform.escapeTags for the message itself. In fact the best idea > >would be to use a version of Transform.escapeTags that tried > to escape > >tags, but if there were too many escapes (i.e. more than 4 > escapes

RE: Adding more MDC support to several classes

2003-03-19 Thread Ceki Gülcü
At 09:55 AM 3/19/2003 -0800, you wrote: > >> timestamp="213341234" level="INFO" thread="main"> > > > > > > > > > > > > > > > > > > ... > > > > > > I don't see why the > > and > > Need to be different. > > E

RE: Adding more MDC support to several classes

2003-03-19 Thread Ceki Gülcü
At 04:54 PM 3/19/2003 +, you wrote: > At 03:21 PM 3/19/2003 +, you wrote: > >Couple of questions. > > > >How will the logging event properties be represented in the > event XML? > > Good question. How about the following, > >timestamp="213341234" level="INFO" thread="main"> >

RE: Adding more MDC support to several classes

2003-03-19 Thread Mark Womack
> >> timestamp="213341234" level="INFO" thread="main"> > > > > > > > > > > > > > > > > > > ... > > > > > > I don't see why the > > and > > Need to be different. > > Essentially you just have a 'generic'

RE: Adding more MDC support to several classes

2003-03-19 Thread Nicko Cadell
lob. The NDC is a stack of data, the stack information is lost in the xml version. This could better be encoded as: [item value] [item value] [item value] Or: [item value] [item value] [item value] Or: Just more thoughts... Thanks for listening Nicko > > >

RE: Adding more MDC support to several classes

2003-03-19 Thread Ceki Gülcü
- > From: Ceki Gülcü [mailto:[EMAIL PROTECTED] > Sent: 19 March 2003 14:45 > To: Log4J Developers List > Subject: Re: Adding more MDC support to several classes > > > > Paul, > > I suggest the following format: > > timestamp="213341234" level="I

RE: Adding more MDC support to several classes

2003-03-19 Thread Nicko Cadell
003 14:45 > To: Log4J Developers List > Subject: Re: Adding more MDC support to several classes > > > > Paul, > > I suggest the following format: > > timestamp="213341234" level="INFO" > thread="main"> > > >

Re: Adding more MDC support to several classes

2003-03-19 Thread Ceki Gülcü
Paul, I suggest the following format: ... Note that the MDC is optional. So the DTD should allow for the possibility of no MDC. At 10:14 PM 3/19/2003 +1100, you wrote: Just following up on something Mark has mentioned offline re: adding some more support for MDC thr

RE: Adding more MDC support to several classes

2003-03-19 Thread Nicko Cadell
arch 2003 11:14 > To: '[EMAIL PROTECTED] ' > Subject: Adding more MDC support to several classes > > > Just following up on something Mark has mentioned offline re: > adding some more support for MDC through XMLLayout, and > Chainsaw. I wanted to run some things

Adding more MDC support to several classes

2003-03-19 Thread Paul Smith
Just following up on something Mark has mentioned offline re: adding some more support for MDC through XMLLayout, and Chainsaw. I wanted to run some things by the group. Sorry if this is a bit long. The first thing that needs to happen is to modify the log4j.dtd file to incorporate the MDC struct