Re: Log4j2 setup in Eclipse

2013-08-15 Thread Ralph Goers
As I think I've said before, I use IntelliJ so this may or may not help you, but I always debug using -Dmaven.surefire.debug set for remote debugging and then attach to it from IntelliJ. I don't know why but I do this for everything, including debugging stuff in JBoss or Tomcat or unit tests.

Re: Usage of generics in Appender

2013-08-15 Thread Ralph Goers
No, I have not started working on LOG4J2-338. Go ahead and I will find a way to work around the problems that will occur with that patch. Ralhp On Aug 14, 2013, at 7:41 PM, Remko Popma wrote: I have attached an update to Henning's patch to LOG4J2-343. The update was necessary to resolve the

[jira] [Resolved] (LOG4J2-343) Remove the Generics from Appender

2013-08-15 Thread Remko Popma (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-343?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Remko Popma resolved LOG4J2-343. Resolution: Fixed Fix Version/s: 2.0-beta9 Committed in revision 1514231. Please verify and

Re: Usage of generics in Appender

2013-08-15 Thread Remko Popma
I committed Henning's patch for LOG4J2-343. Thanks Henning for doing the work! Ralph, I looked at the patch for LOG4J2-338 and I believe the only impact will be on the TLSSyslogAppender class. On Thu, Aug 15, 2013 at 4:08 PM, Ralph Goers ralph.go...@dslextreme.comwrote: No, I have not started

Re: Log4j2 setup in Eclipse

2013-08-15 Thread Gary Gregory
Fwiw, debugging from within eclipse works except for some cases which I've written about here before but can't quite recall ATM. Gary On Aug 15, 2013, at 3:05, Ralph Goers ralph.go...@dslextreme.com wrote: As I think I've said before, I use IntelliJ so this may or may not help you, but I

[jira] [Commented] (LOG4J2-168) Include arbitrary message fields in RFC-5424 structured data

2013-08-15 Thread Tibor Benke (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-168?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13740953#comment-13740953 ] Tibor Benke commented on LOG4J2-168: Does the log4j2 support multiple SD-ELEMENTs in

[jira] [Commented] (LOG4J2-168) Include arbitrary message fields in RFC-5424 structured data

2013-08-15 Thread Scott Severtson (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-168?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13740957#comment-13740957 ] Scott Severtson commented on LOG4J2-168: It currently does not support multiple

org.apache.logging.log4j.flume.appender.FlumePersistentManager.send(Event)

2013-08-15 Thread Gary Gregory
Shouldn't org.apache.logging.log4j.flume.appender.FlumePersistentManager.send(Event) be synchronized? Gary -- E-Mail: garydgreg...@gmail.com | ggreg...@apache.org Java Persistence with Hibernate, Second Editionhttp://www.manning.com/bauer3/ JUnit in Action, Second Edition

org.slf4j.helpers.MarkerWrapper.add(Marker)

2013-08-15 Thread Gary Gregory
Should org.slf4j.helpers.MarkerWrapper.add(Marker) be synchronized? The super impl is. Gary -- E-Mail: garydgreg...@gmail.com | ggreg...@apache.org Java Persistence with Hibernate, Second Editionhttp://www.manning.com/bauer3/ JUnit in Action, Second Edition http://www.manning.com/tahchiev/

Re: org.apache.logging.log4j.flume.appender.FlumePersistentManager.send(Event)

2013-08-15 Thread Ralph Goers
No. What in that method do you think needs synchronization? Ralph On Aug 15, 2013, at 6:33 AM, Gary Gregory wrote: Shouldn't org.apache.logging.log4j.flume.appender.FlumePersistentManager.send(Event) be synchronized? Gary -- E-Mail: garydgreg...@gmail.com | ggreg...@apache.org

Re: org.slf4j.helpers.MarkerWrapper.add(Marker)

2013-08-15 Thread Ralph Goers
What is synchronizing this method going to achieve? Ralph On Aug 15, 2013, at 6:39 AM, Gary Gregory wrote: Should org.slf4j.helpers.MarkerWrapper.add(Marker) be synchronized? The super impl is. Gary -- E-Mail: garydgreg...@gmail.com | ggreg...@apache.org Java Persistence with

[jira] [Commented] (LOG4J2-168) Include arbitrary message fields in RFC-5424 structured data

2013-08-15 Thread Tibor Benke (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-168?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13740983#comment-13740983 ] Tibor Benke commented on LOG4J2-168: I think we should only modify the LoggerFields,

Re: org.apache.logging.log4j.flume.appender.FlumePersistentManager.send(Event)

2013-08-15 Thread Gary Gregory
The super implementation it overrides is synchronized, so it would be good at least document why one is synchronized and the other one not. Gary On Thu, Aug 15, 2013 at 9:51 AM, Ralph Goers ralph.go...@dslextreme.comwrote: No. What in that method do you think needs synchronization? Ralph

Re: Usage of generics in Appender

2013-08-15 Thread Nick Williams
Oh. I thought we were going to wait for me to review the patch this weekend and weigh in. Oh, well. N On Aug 15, 2013, at 6:09 AM, Remko Popma wrote: I committed Henning's patch for LOG4J2-343. Thanks Henning for doing the work! Ralph, I looked at the patch for LOG4J2-338 and I believe

Re: org.slf4j.helpers.MarkerWrapper.add(Marker)

2013-08-15 Thread Gary Gregory
The impl is: @Override public void add(final org.slf4j.Marker reference) { super.add(reference); ((MarkerWrapper) reference).setParent(this); } and the super.add impl IS synchronized so either this is a subtle bug or it should be documented, even if it is just an

[jira] [Commented] (LOG4J2-168) Include arbitrary message fields in RFC-5424 structured data

2013-08-15 Thread Gary Gregory (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-168?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13741024#comment-13741024 ] Gary Gregory commented on LOG4J2-168: - {quote} Can we use arrays with @PluginElement?

Re: Usage of generics in Appender

2013-08-15 Thread Gary Gregory
On Thu, Aug 15, 2013 at 10:47 AM, Nick Williams nicho...@nicholaswilliams.net wrote: Oh. I thought we were going to wait for me to review the patch this weekend and weigh in. Oh, well. N That's the way I read the thread as well... G On Aug 15, 2013, at 6:09 AM, Remko Popma wrote: I

org.apache.logging.log4j.core.appender.CompressionType

2013-08-15 Thread Gary Gregory
Does anyone use org.apache.logging.log4j.core.appender.CompressionType? Is it a placeholder for future use? Gary -- E-Mail: garydgreg...@gmail.com | ggreg...@apache.org Java Persistence with Hibernate, Second Editionhttp://www.manning.com/bauer3/ JUnit in Action, Second Edition

[jira] [Commented] (LOG4J2-159) log4j.xml loading from classpath not working correct in osgi environment

2013-08-15 Thread Roland Weiglhofer (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-159?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13741088#comment-13741088 ] Roland Weiglhofer commented on LOG4J2-159: -- I have the same problem with beta9,

Re: org.apache.logging.log4j.core.appender.CompressionType

2013-08-15 Thread Ralph Goers
I'm thinking I created it when I wrote the RollingFileAppender but then didn't end up using it. Ralph On Aug 15, 2013, at 8:34 AM, Gary Gregory wrote: Does anyone use org.apache.logging.log4j.core.appender.CompressionType? Is it a placeholder for future use? Gary -- E-Mail:

Re: Usage of generics in Appender

2013-08-15 Thread Remko Popma
Apologies. I did mention that I wanted to commit sooner (see my email 22 hours ago that starts with I have attached an update... and ends with Does that make sense?. I assumed everyone had seen that message. Again sorry. On Thu, Aug 15, 2013 at 11:55 PM, Gary Gregory

Re: svn commit: r1514264 - /logging/log4j/log4j2/trunk/flume-ng/src/main/java/org/apache/logging/log4j/flume/appender/FlumeConfigurationBuilder.java

2013-08-15 Thread Remko Popma
Gary, just FYI, that looks like tab characters instead of spaces for the indents. On Thu, Aug 15, 2013 at 10:32 PM, ggreg...@apache.org wrote: Author: ggregory Date: Thu Aug 15 13:32:38 2013 New Revision: 1514264 URL: http://svn.apache.org/r1514264 Log: Statement unnecessarily nested

[jira] [Assigned] (LOG4J2-315) Multiple threads logging to same AsyncAppender- Data Loss

2013-08-15 Thread Remko Popma (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-315?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Remko Popma reassigned LOG4J2-315: -- Assignee: Remko Popma Multiple threads logging to same AsyncAppender- Data Loss

[jira] [Created] (LOG4J2-354) log4j2 + FastFileAppender + Tomcat logrotate problem

2013-08-15 Thread Remko Popma (JIRA)
Remko Popma created LOG4J2-354: -- Summary: log4j2 + FastFileAppender + Tomcat logrotate problem Key: LOG4J2-354 URL: https://issues.apache.org/jira/browse/LOG4J2-354 Project: Log4j 2 Issue Type:

Re: svn commit: r1514264 - /logging/log4j/log4j2/trunk/flume-ng/src/main/java/org/apache/logging/log4j/flume/appender/FlumeConfigurationBuilder.java

2013-08-15 Thread Gary Gregory
Arg! I'll fix tomorrow unless you get to it. Gary On Aug 15, 2013, at 21:38, Remko Popma remko.po...@gmail.com wrote: Gary, just FYI, that looks like tab characters instead of spaces for the indents. On Thu, Aug 15, 2013 at 10:32 PM, ggreg...@apache.org wrote: Author: ggregory Date: Thu

[jira] [Commented] (LOG4J2-354) log4j2 + FastFileAppender + Tomcat logrotate problem

2013-08-15 Thread Remko Popma (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13741924#comment-13741924 ] Remko Popma commented on LOG4J2-354: (quick heads-up: FastFileAppender will be renamed

[jira] [Comment Edited] (LOG4J2-354) log4j2 + FastFileAppender + Tomcat logrotate problem

2013-08-15 Thread Remko Popma (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13741924#comment-13741924 ] Remko Popma edited comment on LOG4J2-354 at 8/16/13 5:15 AM: -

[jira] [Assigned] (LOG4J2-321) Provide configuration alternative to system properties

2013-08-15 Thread Remko Popma (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-321?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Remko Popma reassigned LOG4J2-321: -- Assignee: Remko Popma Provide configuration alternative to system properties

[jira] [Commented] (LOG4J2-344) Log4j2 doesnt work with Weblogic 12c

2013-08-15 Thread Remko Popma (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13741934#comment-13741934 ] Remko Popma commented on LOG4J2-344: Keir, do you have any additional information?