Re: Proposal to move some interfaces in log4j-core.

2014-04-30 Thread Ralph Goers
1) I need to find some time to look at the JMX stuff. The last time I looked at it I noticed that some of it was implemented incorrectly - but i don’t recall exactly what. I like this being in a separate jar as including it would automatically mean the user wants JMX support. I like that. So I

[jira] [Resolved] (LOG4J2-439) Create a LogEventPatternConverter to escape newlines and HTML special characters

2014-04-30 Thread Ralph Goers (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-439?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ralph Goers resolved LOG4J2-439. Resolution: Fixed Documentation patch applied in revision 1591549. Please verify and close. > Crea

[jira] [Commented] (LOG4J2-609) StatusConfiguration doesn't close files

2014-04-30 Thread Ralph Goers (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13986376#comment-13986376 ] Ralph Goers commented on LOG4J2-609: why did you remove configureExistingStatusConsole

[jira] [Assigned] (LOG4J2-609) StatusConfiguration doesn't close files

2014-04-30 Thread Ralph Goers (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-609?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ralph Goers reassigned LOG4J2-609: -- Assignee: Ralph Goers > StatusConfiguration doesn't close files > -

[jira] [Resolved] (LOG4J2-542) LogEvents with exceptions fail to deserialize

2014-04-30 Thread Ralph Goers (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-542?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ralph Goers resolved LOG4J2-542. Resolution: Fixed Fix Version/s: 2.0-rc2 Throwable was made transient in revision 1591544.

[jira] [Updated] (LOG4J2-609) StatusConfiguration doesn't close files

2014-04-30 Thread Bruce Brouwer (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-609?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruce Brouwer updated LOG4J2-609: - Attachment: log4j2-609.patch With log4j2-609.patch, now all tests pass with a clean install on Wi

Re: New log4j-streams Module

2014-04-30 Thread Ralph Goers
That makes a lot of sense to me Sent from my iPhone > On Apr 30, 2014, at 6:05 PM, Bruce Brouwer wrote: > > Can we agree to pull out jpa and jms? > > As for web, I know there was some discussion on how we could not register a > shutdown hook. If we broke out log4j-web, maybe we could make it

Re: New log4j-streams Module

2014-04-30 Thread Bruce Brouwer
Can we agree to pull out jpa and jms? As for web, I know there was some discussion on how we could not register a shutdown hook. If we broke out log4j-web, maybe we could make it as simple as registering a shutdown hook if log4j-web is not included, but if log4j-web was included, the shutdown hook

[jira] [Commented] (LOG4J2-626) ThreadContext for Asynchronous logger in multithreaded environmant is overwriting the values.

2014-04-30 Thread Remko Popma (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13986258#comment-13986258 ] Remko Popma commented on LOG4J2-626: It should not matter whether you use asynchronous

[jira] [Commented] (LOG4J2-628) Cannot set log4j.Clock with Async appender

2014-04-30 Thread Remko Popma (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13986246#comment-13986246 ] Remko Popma commented on LOG4J2-628: This is expected behaviour as of RC-1. The use

[jira] [Created] (LOG4J2-628) Cannot set log4j.Clock with Async appender

2014-04-30 Thread Bryan Hsueh (JIRA)
Bryan Hsueh created LOG4J2-628: -- Summary: Cannot set log4j.Clock with Async appender Key: LOG4J2-628 URL: https://issues.apache.org/jira/browse/LOG4J2-628 Project: Log4j 2 Issue Type: Question

Re: Log4j Project Guidelines

2014-04-30 Thread Matt Sicker
There are legitimate reasons to do that as long as you maintain thread-safety such as the case Ralph mentioned. Though that would probably require full control of the API from top to bottom-ish. On 30 April 2014 10:22, Ralph Goers wrote: > Actually, I believe there was a case where I did that b

[jira] [Commented] (LOG4J2-623) Better structure of Thread Context Map in JSONLayout

2014-04-30 Thread JIRA
[ https://issues.apache.org/jira/browse/LOG4J2-623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13985672#comment-13985672 ] Mikael Ståldal commented on LOG4J2-623: --- Ah, yes then I agree. > Better structure o

[jira] [Commented] (LOG4J2-623) Better structure of Thread Context Map in JSONLayout

2014-04-30 Thread Ralph Goers (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13985656#comment-13985656 ] Ralph Goers commented on LOG4J2-623: I didn't mean in terms of structure. I mean the n

[jira] [Commented] (LOG4J2-623) Better structure of Thread Context Map in JSONLayout

2014-04-30 Thread JIRA
[ https://issues.apache.org/jira/browse/LOG4J2-623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13985647#comment-13985647 ] Mikael Ståldal commented on LOG4J2-623: --- Currently, it does mimic the XMLLayout. Thi

Re: Log4j Project Guidelines

2014-04-30 Thread Ralph Goers
Actually, I believe there was a case where I did that because the method in the subclass used java.util.concurrent instead of requiring method synchronization. Ralph On Apr 30, 2014, at 7:19 AM, Remko Popma wrote: > Yes, overriding a synchronized method with an unsynchronized method sounds >

synchronized vs. Lock (was: Log4j Project Guidelines)

2014-04-30 Thread Jörn Huxhorn
Did you try https://gist.github.com/huxi/81c152a672d1b39aed64 with different delays? (If you find anything wrong with that code, please let me know.) The output on my system with 0ms, 1ms and 10ms delays looks like this:  http://pastebin.com/za07QmUU Unfairness increases with the amount of time

Re: Log4j Project Guidelines

2014-04-30 Thread Remko Popma
Yes, overriding a synchronized method with an unsynchronized method sounds dangerous... Warnings would probably be helpful. On Wed, Apr 30, 2014 at 11:13 PM, Gary Gregory wrote: > I'm pretty sure Eclipse does that. > > Gary > > > On Wed, Apr 30, 2014 at 9:50 AM, Matt Sicker wrote: > >> So it's

Re: Log4j Project Guidelines

2014-04-30 Thread Gary Gregory
I'm pretty sure Eclipse does that. Gary On Wed, Apr 30, 2014 at 9:50 AM, Matt Sicker wrote: > So it's a good idea to set up your IDE to warn if you override a > synchronized method with an unsynchronized method? I remember seeing that > one somewhere. > > > On 30 April 2014 00:35, Remko Popma

Re: Log4j Project Guidelines

2014-04-30 Thread Matt Sicker
So it's a good idea to set up your IDE to warn if you override a synchronized method with an unsynchronized method? I remember seeing that one somewhere. On 30 April 2014 00:35, Remko Popma wrote: > Agreed that unless the synchronization is part of the public API it is > better to lock on an in

[jira] [Updated] (LOG4J2-626) ThreadContext for Asynchronous logger in multithreaded environmant is overwriting the values.

2014-04-30 Thread sivan (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-626?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] sivan updated LOG4J2-626: - Description: ThreadContext for Asynchronous loggers in multithreaded environmant is overwriting the values. Is t

[jira] [Commented] (LOG4J2-626) ThreadContext for Asynchronous logger in multithreaded environmant is overwriting the values.

2014-04-30 Thread sivan (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13985491#comment-13985491 ] sivan commented on LOG4J2-626: -- Log4j2 will not modify this. that is OK. But when many users

[jira] [Comment Edited] (LOG4J2-626) ThreadContext for Asynchronous logger in multithreaded environmant is overwriting the values.

2014-04-30 Thread Remko Popma (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13985328#comment-13985328 ] Remko Popma edited comment on LOG4J2-626 at 4/30/14 12:36 PM: --

[jira] [Updated] (LOG4J2-626) ThreadContext for Asynchronous logger in multithreaded environmant is overwriting the values.

2014-04-30 Thread sivan (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-626?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] sivan updated LOG4J2-626: - Description: ThreadContext for Asynchronous loggers in multithreaded environmant is overwriting the values. Is t

[jira] [Commented] (LOG4J2-626) ThreadContext for Asynchronous logger in multithreaded environmant is overwriting the values.

2014-04-30 Thread Remko Popma (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13985328#comment-13985328 ] Remko Popma commented on LOG4J2-626: Sorry but this is not enough information to even

[jira] [Created] (LOG4J2-627) Better structure of Thread Context Stack in XMLLayout

2014-04-30 Thread JIRA
Mikael Ståldal created LOG4J2-627: - Summary: Better structure of Thread Context Stack in XMLLayout Key: LOG4J2-627 URL: https://issues.apache.org/jira/browse/LOG4J2-627 Project: Log4j 2 Issue

[jira] [Updated] (LOG4J2-624) Better structure of Thread Context Stack in JSONLayout

2014-04-30 Thread JIRA
[ https://issues.apache.org/jira/browse/LOG4J2-624?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mikael Ståldal updated LOG4J2-624: -- Description: The Thread Context Stack is currently represented like this in JSONLayout: {code:

[jira] [Created] (LOG4J2-626) ThreadContext for Asynchronous logger in multithreaded environmant is overwriting the values.

2014-04-30 Thread sivan (JIRA)
sivan created LOG4J2-626: Summary: ThreadContext for Asynchronous logger in multithreaded environmant is overwriting the values. Key: LOG4J2-626 URL: https://issues.apache.org/jira/browse/LOG4J2-626 Project: