FOSDEM 2016 - take action by 4th of December 2015

As most of you probably know FOSDEM 2016 (the biggest, 100% free open source developer conference) is right around the corner: https://fosdem.org/2016/ We hope to have an ASF booth and we would love to see as many ASF projects as possible present at various tracks (AKA Developer rooms): htt

[jira] [Commented] (LOG4J2-435) Feature request: auto-delete older log files

[ https://issues.apache.org/jira/browse/LOG4J2-435?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15033046#comment-15033046 ] Remko Popma commented on LOG4J2-435: Good catch again. The OR is not supported. All AN

Re: Builder class naming consistency

Oh, right. I forgot the setter was on the builder, not the actual object. Forget I said anything. Ralph > On Nov 30, 2015, at 3:11 PM, Matt Sicker wrote: > > Builders are for creating immutable objects. > > On 30 November 2015 at 15:30, Ralph Goers > wrote:

Re: Builder class naming consistency

Builders are for creating immutable objects. On 30 November 2015 at 15:30, Ralph Goers wrote: > Generally I prefer factories over builders because the objects created are > immutable. OTOH, the new Builder for the Configuration creates an > intermediate object. The actual objects use the “normal

Re: Builder class naming consistency

Generally I prefer factories over builders because the objects created are immutable. OTOH, the new Builder for the Configuration creates an intermediate object. The actual objects use the “normal” plugin builders/factories so they can still be immutable. Ralph > On Nov 30, 2015, at 12:49 PM,

Re: Builder class naming consistency

Right, to me using "with" implies getting a *new* object/copy. Gary On Mon, Nov 30, 2015 at 12:17 PM, Paul Benedict wrote: > Gary, I also prefer "set" but I didn't want to pollute my objectivity in > explaining the options. My cards are now laid down. :-) BTW, "with" has > been used in JSR-310

Re: Builder class naming consistency

Gary, I also prefer "set" but I didn't want to pollute my objectivity in explaining the options. My cards are now laid down. :-) BTW, "with" has been used in JSR-310 (Java 8 Date/Time) for immutable objects "mutability"; that prefix means you get back a new object when "changing" the property (thin

Re: Builder class naming consistency

I find using foo() instead of setFoo() somewhat confusing. It forces you to think that you are using a builder and you cannot just do set/auto-complete. In addition, when foo is a verb, it's misleading, since the call does not perform anything but merely sets a value. Gary On Mon, Nov 30, 2015 at

Re: Builder class naming consistency

I actually had an interesting discussion lately with builders; so this topic interests me. Since builders are inherently mutable (and they should be right? it's a process of constructing an object), it's okay to use "set" methods. For example, see Spring's BeanDefinitionBuilder [1]. But you don't h

[jira] [Commented] (LOG4J2-1169) PatternLayout: Possible variable substitution in equals substitution parameter

[ https://issues.apache.org/jira/browse/LOG4J2-1169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15032322#comment-15032322 ] Matt Sicker commented on LOG4J2-1169: - I applied the given patch in a new branch call

Re: Builder class naming consistency

I like "set" better, but that's just because I like to type "set" and use auto-complete. I'd rather not have to decide if I have to type "set" or "with" and then auto-complete. Gary On Mon, Nov 30, 2015 at 11:36 AM, Matt Sicker wrote: > Sorry, but I introduced this problem a while ago by using

Builder class naming consistency

Sorry, but I introduced this problem a while ago by using withFoo() in some builder classes, but setFoo() in other builder classes. Both are equally valid naming schemes for builder classes. It would be great to be consistent, though. Which one would be preferable? -- Matt Sicker

[jira] [Resolved] (LOG4J2-802) Marker.isInstanceOf may not terminate if parent Markers form a cycle

[ https://issues.apache.org/jira/browse/LOG4J2-802?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matt Sicker resolved LOG4J2-802. Resolution: Not A Problem > Marker.isInstanceOf may not terminate if parent Markers form a cycle > -

[jira] [Commented] (LOG4J2-802) Marker.isInstanceOf may not terminate if parent Markers form a cycle

[ https://issues.apache.org/jira/browse/LOG4J2-802?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15032165#comment-15032165 ] Matt Sicker commented on LOG4J2-802: I don't think there's anything we can do to preve

[jira] [Resolved] (LOG4J2-604) Audit use of ClassLoader, Class.forName, etc.

[ https://issues.apache.org/jira/browse/LOG4J2-604?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matt Sicker resolved LOG4J2-604. Resolution: Fixed This has been addressed as well as possible. Anything else can be addressed in ne

[jira] [Commented] (LOG4J2-606) Consider moving log4j-core SPI-like classes to its own package.

[ https://issues.apache.org/jira/browse/LOG4J2-606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15032156#comment-15032156 ] Matt Sicker commented on LOG4J2-606: I think it's too late to do this for BC reasons.

Re: Remko's schedule

I hope that isn’t the case. Your contributions here are invaluable. Ralph > On Nov 30, 2015, at 12:56 AM, Remko Popma wrote: > > Hi all, > > I'll be starting a new job from December (in the same industry and same > location). > > Just letting you know because I may not be able to spend much

Re: Remko's schedule

Congratulations! Gary On Nov 30, 2015 2:56 AM, "Remko Popma" wrote: > Hi all, > > I'll be starting a new job from December (in the same industry and same > location). > > Just letting you know because I may not be able to spend much time on > log4j in the near future. > > Remko > > -

[jira] [Commented] (LOG4J2-508) Add new Levels: NOTICE, DIAG, VERBOSE.

[ https://issues.apache.org/jira/browse/LOG4J2-508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15031765#comment-15031765 ] Gary Gregory commented on LOG4J2-508: - This discussion comes up every once in a while,

[jira] [Commented] (LOG4J2-606) Consider moving log4j-core SPI-like classes to its own package.

[ https://issues.apache.org/jira/browse/LOG4J2-606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15031760#comment-15031760 ] Gary Gregory commented on LOG4J2-606: - Seems like subtle nitpicking to me Matt, sorry.

[jira] [Commented] (LOG4J2-435) Feature request: auto-delete older log files

[ https://issues.apache.org/jira/browse/LOG4J2-435?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15031726#comment-15031726 ] Robert Schaft commented on LOG4J2-435: -- I really appreciate that you took the burden

[jira] [Comment Edited] (LOG4J2-435) Feature request: auto-delete older log files

[ https://issues.apache.org/jira/browse/LOG4J2-435?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15031697#comment-15031697 ] Remko Popma edited comment on LOG4J2-435 at 11/30/15 12:17 PM: -

[jira] [Commented] (LOG4J2-435) Feature request: auto-delete older log files

[ https://issues.apache.org/jira/browse/LOG4J2-435?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15031697#comment-15031697 ] Remko Popma commented on LOG4J2-435: Ordering is supported. Please take a look at the

[jira] [Commented] (LOG4J2-1195) KafkaAppender doesn't work with SerializedLayout

[ https://issues.apache.org/jira/browse/LOG4J2-1195?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15031539#comment-15031539 ] Mikael Ståldal commented on LOG4J2-1195: This is fixed, please verify and close.

[jira] [Commented] (LOG4J2-508) Add new Levels: NOTICE, DIAG, VERBOSE.

[ https://issues.apache.org/jira/browse/LOG4J2-508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15031527#comment-15031527 ] Mikael Ståldal commented on LOG4J2-508: --- I think we should be careful about adding n

[jira] [Commented] (LOG4J2-435) Feature request: auto-delete older log files

[ https://issues.apache.org/jira/browse/LOG4J2-435?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15031521#comment-15031521 ] Robert Schaft commented on LOG4J2-435: -- Remko, I was not aware that the mentioned app

[jira] [Commented] (LOG4J2-606) Consider moving log4j-core SPI-like classes to its own package.

[ https://issues.apache.org/jira/browse/LOG4J2-606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15031513#comment-15031513 ] Mikael Ståldal commented on LOG4J2-606: --- Sounds like a good idea to me. But it will

[jira] [Closed] (LOG4J2-1208) Startup time log4j2

[ https://issues.apache.org/jira/browse/LOG4J2-1208?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pedro Morales closed LOG4J2-1208. - Resolution: Not A Problem Fix Version/s: 2.4.1 Surprisingly after reboot my machine, it lo