Re: Config element name confusion

2014-07-08 Thread Gary Gregory
On Tue, Jul 8, 2014 at 11:18 AM, Ralph Goers wrote: > > On Jul 8, 2014, at 7:49 AM, Gary Gregory wrote: > > On Tue, Jul 8, 2014 at 10:47 AM, Ralph Goers > wrote: > >> >> On Jul 8, 2014, at 7:32 AM, Gary Gregory wrote: >> >> On Mon, Jul 7, 2014 at 1:44 PM, Ralph Goers >> wrote: >> >>> Well, If

Re: Config element name confusion

2014-07-08 Thread Ralph Goers
On Jul 8, 2014, at 7:49 AM, Gary Gregory wrote: > On Tue, Jul 8, 2014 at 10:47 AM, Ralph Goers > wrote: > > On Jul 8, 2014, at 7:32 AM, Gary Gregory wrote: > >> On Mon, Jul 7, 2014 at 1:44 PM, Ralph Goers >> wrote: >> Well, If there is only one Filter then it would just be declared. If th

Re: Config element name confusion

2014-07-08 Thread Gary Gregory
On Tue, Jul 8, 2014 at 10:47 AM, Ralph Goers wrote: > > On Jul 8, 2014, at 7:32 AM, Gary Gregory wrote: > > On Mon, Jul 7, 2014 at 1:44 PM, Ralph Goers > wrote: > >> Well, If there is only one Filter then it would just be declared. If >> there is more than one then it should be: >> >> >> … >

Re: Config element name confusion

2014-07-08 Thread Ralph Goers
On Jul 8, 2014, at 7:32 AM, Gary Gregory wrote: > On Mon, Jul 7, 2014 at 1:44 PM, Ralph Goers > wrote: > Well, If there is only one Filter then it would just be declared. If there is > more than one then it should be: > > > … > … > > > Even in this case since there is only the Composi

Re: Config element name confusion

2014-07-08 Thread Gary Gregory
On Mon, Jul 7, 2014 at 1:44 PM, Ralph Goers wrote: > Well, If there is only one Filter then it would just be declared. If there > is more than one then it should be: > > > … > … > > > Even in this case since there is only the CompositeFilter (which contains > the other Filters) there should

Re: Config element name confusion

2014-07-07 Thread Ralph Goers
Well, If there is only one Filter then it would just be declared. If there is more than one then it should be: … … Even in this case since there is only the CompositeFilter (which contains the other Filters) there should only be one Filter and it should be declared as PluginElement(“Filt

Re: Config element name confusion

2014-07-07 Thread Gary Gregory
This one would not need to be fixed: org.apache.logging.log4j.core.appender.RollingFileAppender.createAppender: @PluginFactory public static RollingFileAppender createAppender( ... @PluginElement("Filter") final Filter filter, ... So we do have some inconsistencies. Gary O

Config element name confusion

2014-07-07 Thread Gary Gregory
I see: org.apache.logging.log4j.core.filter.CompositeFilter.createFilters(Filter[]): @PluginFactory public static CompositeFilter createFilters(@PluginElement("Filters") final Filter[] filters) { Which is clear, but then I see: public static FileAppender createAppender(