Re: Use of java.util.ServiceLoader

2014-10-07 Thread Remko Popma
:-) Sent from my iPhone > On 2014/10/08, at 13:00, Matt Sicker wrote: > > Of course I'm getting side tracked, it's what I do! > >> On 7 October 2014 22:47, Remko Popma wrote: >> +1 I would also like to release what we have now. >> >> Sent from my iPhone >> >>> On 2014/10/08, at 11:43, Gary

Re: Use of java.util.ServiceLoader

2014-10-07 Thread Matt Sicker
Of course I'm getting side tracked, it's what I do! On 7 October 2014 22:47, Remko Popma wrote: > +1 I would also like to release what we have now. > > Sent from my iPhone > > On 2014/10/08, at 11:43, Gary Gregory wrote: > > Are we getting side tracked here? Is this all required for 2.1. We got

Re: Use of java.util.ServiceLoader

2014-10-07 Thread Remko Popma
+1 I would also like to release what we have now. Sent from my iPhone > On 2014/10/08, at 11:43, Gary Gregory wrote: > > Are we getting side tracked here? Is this all required for 2.1. We got up to > RC3 this weekend. It seems we should go to RC4 and then continue on 2.2-SNAP. > > Gary > >>

Re: Use of java.util.ServiceLoader

2014-10-07 Thread Gary Gregory
Are we getting side tracked here? Is this all required for 2.1. We got up to RC3 this weekend. It seems we should go to RC4 and then continue on 2.2-SNAP. Gary On Tue, Oct 7, 2014 at 10:32 PM, Matt Sicker wrote: > So far I've figured out that you can specify multiple classes in a > ServiceLoade

Re: Use of java.util.ServiceLoader

2014-10-07 Thread Matt Sicker
So far I've figured out that you can specify multiple classes in a ServiceLoader file. Each line can have a class. And the order things are parsed are determined by ClassLoader.getResources() (which I'd assume is classpath order). This could really use a sort of extension that allowed prioritizing

Re: Use of java.util.ServiceLoader

2014-10-07 Thread Matt Sicker
It's actually a bit more complicated than I thought. Sometimes, the properties are there for overriding the default (usually with another log4j-provided class instead of a custom one). I'll have to delve into this a bit more. On 7 October 2014 21:18, Matt Sicker wrote: > Let me compile a list of

Re: Use of java.util.ServiceLoader

2014-10-07 Thread Matt Sicker
Let me compile a list of example service classes that could benefit from using ServiceLoader. I'll be back soon. On 7 October 2014 21:11, Ralph Goers wrote: > Yes, I looked at it and purposely decided not to use it for the > LoggerContextFactory. I wanted to do API version checking to make sure

Re: Use of java.util.ServiceLoader

2014-10-07 Thread Ralph Goers
Yes, I looked at it and purposely decided not to use it for the LoggerContextFactory. I wanted to do API version checking to make sure what we were binding with is compatible. As for using it for other stuff, I am not really sure how or why ServiceLoader was bypassed. Ralph On Oct 7, 2014,

Use of java.util.ServiceLoader

2014-10-07 Thread Matt Sicker
This was added back in 1.6, and I still don't see it used very often. It seems like a more effective method of making customizable service classes than all system properties all the time (even though you can technically just make a log4j2.component.properties file to set them). I think we could use