Re: Use of {@example}'s line number to tolerate ASF source license header (was Re: [VOTE] Create release based on Log4PHP-2.0.0 RC1)

2009-11-22 Thread Christian Grobmeier
> Time for RC2? Yeah, will start on it tomorrow :) Thanks ! > > bye, > > -christian- > > Am Thu, 19 Nov 2009 21:38:41 -0600 > schrieb Curt Arnold : > >> The {...@example} directive can optionally take an starting line number >> (http://manual.phpdoc.org/HTMLSmartyConverter/HandS/phpDocumentor/t

Re: Use of {@example}'s line number to tolerate ASF source license header (was Re: [VOTE] Create release based on Log4PHP-2.0.0 RC1)

2009-11-22 Thread Christian Hammers
Hello That was a good hint. I did as you suggested and now RAT is happy. The MDC and NDC phpdoc looks proper again, too. Time for RC2? bye, -christian- Am Thu, 19 Nov 2009 21:38:41 -0600 schrieb Curt Arnold : > The {...@example} directive can optionally take an starting line number > (http://

Use of {@example}'s line number to tolerate ASF source license header (was Re: [VOTE] Create release based on Log4PHP-2.0.0 RC1)

2009-11-19 Thread Curt Arnold
The {...@example} directive can optionally take an starting line number (http://manual.phpdoc.org/HTMLSmartyConverter/HandS/phpDocumentor/tutorial_tags.inlineexample.pkg.html). I've played with it with LoggerMDC.php and it would seem to allow us to add the ASF source license header to the examp

Re: [Vote] Create release based on Log4PHP-2.0.0 RC1

2009-11-19 Thread Christian Hammers
Hello I commented to the example snippet issue in another mail. On Wed, 18 Nov 2009 19:20:02 -0600 Curt Arnold wrote: ... > > Else, if you have the time for it, that would indeed be great. If > > not I > > would risk bringing this issue up on the IPMC and if it gets rejected > > just cut & pa

Re: [Vote] Create release based on Log4PHP-2.0.0 RC1

2009-11-19 Thread Christian Hammers
On Thu, 19 Nov 2009 06:48:34 +0100 Christian Grobmeier wrote: > >> I mean, thinking about it, we should "claim rights" on a php script that > >> does not do more than logging "hello world". > > > > Maybe some of the 1-3 lines of code snippets could be argued to have no > > degree of creativity, b

Re: [Vote] Create release based on Log4PHP-2.0.0 RC1

2009-11-18 Thread Christian Grobmeier
>> I mean, thinking about it, we should "claim rights" on a php script that >> does not do more than logging "hello world". > > Maybe some of the 1-3 lines of code snippets could be argued to have no > degree of creativity, but src/examples/simplesocketserver.php is 55 lines of > non-trivial code.

Re: [Vote] Create release based on Log4PHP-2.0.0 RC1

2009-11-18 Thread Curt Arnold
On Nov 18, 2009, at 4:44 PM, Christian Hammers wrote: Hello Curt Am Tue, 17 Nov 2009 22:42:45 -0600 schrieb Curt Arnold : Running "mvn rat:check" generates a RAT (release audit tool) report in target/rat.txt. The check fails since all the .php files in src/ examples/php and src/examples/re

Re: [Vote] Create release based on Log4PHP-2.0.0 RC1

2009-11-18 Thread Christian Hammers
Hello Curt Am Tue, 17 Nov 2009 22:42:45 -0600 schrieb Curt Arnold : > Running "mvn rat:check" generates a RAT (release audit tool) report > in target/rat.txt. The check fails since all the .php files in src/ > examples/php and src/examples/resources do not have ASF Source > Header. src/examp

Re: [Vote] Create release based on Log4PHP-2.0.0 RC1

2009-11-17 Thread Christian Grobmeier
Thanks to both of you for your feedback! I will create new packages iwth the correct path in it - my fault. I also will do the svn mv because of the license header issue. >The examples are used with the @example phpdoc directive, so any ASF header in >the example body would be incorporated >itera

Re: [Vote] Create release based on Log4PHP-2.0.0 RC1

2009-11-17 Thread Curt Arnold
Running "mvn rat:check" generates a RAT (release audit tool) report in target/rat.txt. The check fails since all the .php files in src/ examples/php and src/examples/resources do not have ASF Source Header. src/examples/README.LICENSE explains a rationale, however unless there has already

Re: [Vote] Create release based on Log4PHP-2.0.0 RC1

2009-11-17 Thread Curt Arnold
On Nov 16, 2009, at 1:28 AM, Christian Grobmeier wrote: Dear all, its my pleasure to let you know about the first release candidate of Log4PHP. According to the process, please vote with: [ ] +1 Yes go ahead an release based on RC1 [ ] -1 No, because... It can't be "based on RC1", fo

Re: [Vote] Create release based on Log4PHP-2.0.0 RC1

2009-11-17 Thread Christian Hammers
Hello Seeing an RC just one day after my birthday was a nice present *g* But I don't think they let us pass with having the wrong directory names and PEAR package versions inside: $ tar tzf apache-log4php-2.0.0-incubating-src.tar.gz | head apache-log4php-2.0.1-incubating-SNAPSHOT/

[Vote] Create release based on Log4PHP-2.0.0 RC1

2009-11-15 Thread Christian Grobmeier
Dear all, its my pleasure to let you know about the first release candidate of Log4PHP. According to the process, please vote with: [ ] +1 Yes go ahead an release based on RC1 [ ] -1 No, because... Log4PHP 2.0.0 is available for review here: * http://people.apache.org/builds/logging/log4php/