On Fri, May 30, 2003 at 01:26:14PM +0100, John Levon wrote:
> Never mind, it seemed OK anyway. Though I agree with Lars we should
> lockdown for a bit and concentrate on undo and the broken inset
> iterators
Hm. All crashes I currently get are asserts in boost::optional.
They go magically away if
On Fri, May 30, 2003 at 01:27:30PM +0100, John Levon wrote:
> On Tue, May 27, 2003 at 04:45:56PM +0200, Andre Poenitz wrote:
>
> > Can people please make the mind up how the first phase (the metrics
> > computation) in a two-phase drawing should be named?
> >
> > If no consensus appears I'd stick
John Levon <[EMAIL PROTECTED]> writes:
| On Fri, May 30, 2003 at 08:39:19AM +0200, Lars Gullik Bj?nnes wrote:
|
| > So, "Inter-word Space" is my suggestion.
|
| That sounds good ... or "Hard Space" ?
No... hard space would imo be more like protected space or visible
space.
--
Lgb
On Tue, May 27, 2003 at 04:45:56PM +0200, Andre Poenitz wrote:
> Can people please make the mind up how the first phase (the metrics
> computation) in a two-phase drawing should be named?
>
> If no consensus appears I'd stick to 'metrics' as it is used in more
> cases than 'dimension'.
I'd much
On Fri, May 30, 2003 at 08:54:20AM +0200, Andre Poenitz wrote:
> I really checked all mail before I commited, you just missed it by a few
> seconds.
Never mind, it seemed OK anyway. Though I agree with Lars we should
lockdown for a bit and concentrate on undo and the broken inset
iterators
regar
On Fri, May 30, 2003 at 08:39:19AM +0200, Lars Gullik Bj?nnes wrote:
> So, "Inter-word Space" is my suggestion.
That sounds good ... or "Hard Space" ?
john
Jean-Marc, this is a backport of the patch already in 1.4.x. Ago to apply?
Angus
Index: config/ChangeLog
===
RCS file: /usr/local/lyx/cvsroot/lyx-devel/config/ChangeLog,v
retrieving revision 1.86.2.14
diff -u -p -r1.86.2.14 ChangeLog
-
On Fri, May 30, 2003 at 11:07:31AM +0200, Andre' Poenitz wrote:
> To really benefit from the two-stage drawing,
"... on top of cleaner code ..."
This removes some _really_ ugly glue between
mathed and the outside work (most notably
the different metrics() hacks and the cached
font_ member)
> t
With this, we have IU for drawing related stuff
(i.e. both phases)
To really benefit from the two-stage drawing,
the row painter would need some work.
[After that I'd guess we could even have a shot
at removal of all 'update' stuff (at least
to get a feeling on what would break and
what that upd
On Thursday 29 May 2003 21:18, [EMAIL PROTECTED] wrote:
> As you probably noticed, the lists are up again. Thx for your patience.
You are the one who deserves thanks. :-)
> The Summer should be uneventful...
Sorry but here I can not resist: "Famous last words". ;-)
> Mate
--
José Abílio
On Fri, May 30, 2003 at 08:47:26AM +0200, Lars Gullik Bjønnes wrote:
> Andre Poenitz <[EMAIL PROTECTED]> writes:
>
> | This is "InsetUnificiation" for draw()
>
> I'd like this patch to go in, _BUT_ I'd like more to stabilize and
> remove the breakage we have a bit first.
Sorry, too late.
I re
Andre Poenitz <[EMAIL PROTECTED]> writes:
| This is "InsetUnificiation" for draw()
I'd like this patch to go in, _BUT_ I'd like more to stabilize and
remove the breakage we have a bit first.
John has been helping me with this, so the greatest help I (we) can
get now is to test and help finaliz
Andre Poenitz <[EMAIL PROTECTED]> writes:
| Anybody out there?
We are alll here...
--
Lgb
On Fri, May 30, 2003 at 02:31:57AM +0100, John Levon wrote:
>
> Lars, this one is tricky for cross-buffer copy.
>
> You need to add some code to iterate across all inset includes
> in the buffer and replace masterFilename I think. Does this sound
> sensible ?
>
> Should InsetInclude store a Buff
On Fri, May 30, 2003 at 01:51:02AM +0100, John Levon wrote:
> Please review. This is a necessary starting point to the optional<>
> brekage
Looks good.
I'd move the clone() 'out-of-line', though and I don't really see a reason
to start removing the empty /// comments. Better to fill in a few word
"Garst R. Reese" <[EMAIL PROTECTED]> writes:
| Why not just "Normal Space" ?
| The word "Force" is redundant. You could even leave out "Normal".
But it is not a normal space... as in pressing SPACE. It is an
excplicit inter-word space.
So, "Inter-word Space" is my suggestion.
--
Lgb
On Wed, May 28, 2003 at 12:53:39AM +0200, Lars Gullik Bjønnes wrote:
> This patch introduces ParagraphList::const_iterator, and adjust stuff
> to fit. All problems larger than --><-- has been solved by a
> const_cast.
@@ -243,12 +243,12 @@ int getEndLabel(ParagraphList::iterator
{
Parag
On Wed, May 28, 2003 at 04:24:44AM +0100, John Levon wrote:
>
> This helps a little bit in that minipage gets the right height now ...
> sometimes...
>
> Andre, please look.
>
> There is still total horkage for minipages alas. It thinks it has a
> width of 0. Andre, I don't see any handling of
Can people please make the mind up how the first phase (the metrics
computation) in a two-phase drawing should be named?
Currently we have two precursors of such a first phase: 'metrics()'
in mathed/* and 'dimension' in inset/*.
I'd prefer a reasonably short name, so 'computeMetricsOrDimensions'
On Tue, May 27, 2003 at 11:27:55PM +0200, Lars Gullik Bjønnes wrote:
+bool operator==(Paragraph const & lhs, Paragraph const & rhs)
+{
+#warning FIXME this implementatoin must be completely wrong...
+ return &lhs == &rhs;
+}
As the warning says.
Wouldn't it be more prudent to use a special-
On Wed, May 28, 2003 at 05:05:23AM +0100, John Levon wrote:
> Andre, I think Dimension::height() is strictly useless. From what I can
> tell inset metrics look like :
>
>
>| Minipage || |
> |-
On Wed, May 28, 2003 at 05:25:49AM +0100, John Levon wrote:
> Seems relatively straight forward. Comments ?
Good!
Andre'
--
Those who desire to give up Freedom in order to gain Security, will not have,
nor do they deserve, either one. (T. Jefferson or B. Franklin or both...)
On Wed, May 28, 2003 at 08:35:01AM +0200, Lars Gullik Bjønnes wrote:
> Andre Poenitz <[EMAIL PROTECTED]> writes:
>
> | > to fit. All problems larger than --><-- has been solved by a
> | > const_cast.
>
> This ^^
>
> | Wouldn't it be better in such cases to change the functions' signature t
On Wed, May 28, 2003 at 09:05:23AM +0200, Lars Gullik Bjønnes wrote:
> | I think std::list<>::const_iterator has a corresponding constructor.
>
> Show me.
I don't find it in the Standard right now.
But:
template
struct _List_iterator : public _List_iterator_base
{
typedef _List
On Wed, May 28, 2003 at 09:44:29AM +0200, Lars Gullik Bjønnes wrote:
> | It certainly is undefined behaviour. But every std::list<>::iterator I know
> | of is binary compatible with its corresponding std::list<>::const_iterator
> | (in contrast to your string/int example) even if that's not require
On Wed, May 28, 2003 at 09:58:46AM +0200, Lars Gullik Bjønnes wrote:
> but it is not iterator -> const_iterator that is cumbersom (as you
> have shown), but const_iterator -> iterator.
Ah ok. Well for this the reinterpret_cast would work too, but we shouldn't
use it as this would not be eliminated
On Wed, May 28, 2003 at 11:19:55AM +0200, Charpentier Philippe wrote:
> I did that for lyx-1.2.3 and lyx-1.3.2. Precisely I wrote
>
> \format "pdf4" "pdf" "PDF (vlatex)" "" (in the FORMATS SECTION)
>
> and
>
> \converter "latex" "pdf4" "/usr/local/vtex/bin/vlatex $$i" "latex" (in the
> CONVERTE
On Wed, May 28, 2003 at 01:11:40PM +0100, John Levon wrote:
> *shrug*. Too much has changed for me to play the "why" game.
So just commit that if it works...
Andre'
--
Those who desire to give up Freedom in order to gain Security, will not have,
nor do they deserve, either one. (T. Jefferso
This is "InsetUnificiation" for draw()
[And incidentally the second phase of the two-phase drawing,
and 80 lines of removed code]
There should be no user visible change, but I am not 100% sure because
of the 'float x' -> 'int x' change.
Known drawback: For Insets that do not properly impl
Anybody out there?
Andre'
On Thu, May 29, 2003 at 11:46:51PM +0100, John Levon wrote:
> On Fri, May 30, 2003 at 12:32:44AM +0200, Lars Gullik Bj?nnes wrote:
>
> > I wonder what made this come up now...
> > Can it be some iterator search that searches from the beginning of the
> > document all the time?
>
> getParFromID vi
Juergen Spitzmueller wrote:
>
> John Levon wrote:
> > I'm not too happy with "Force Normal Space".
>
> Me neither.
>
> > What is '\ ' used for ? A
> > better name anybody ?
>
> It forces normal, breakable space, especially after punctuation when latex
> guesses end of sentence (e.\,g.\ here). B
John Levon wrote:
> I'm not too happy with "Force Normal Space".
Me neither.
> What is '\ ' used for ? A
> better name anybody ?
It forces normal, breakable space, especially after punctuation when latex
guesses end of sentence (e.\,g.\ here). Basically it is the correct solution
for most of
On Thu, May 29, 2003 at 09:32:25PM -0400, John Weiss wrote:
> Do it.
It's already done (though I noticed a capitalisation error so it
wasn't pointless ;)
I'm not too happy with "Force Normal Space". What is '\ ' used for ? A
better name anybody ?
regards
john
OK Lars this is as minimal as it gets. See the #warnings, I would
like you to fill those bits in.
I believe this works out OK because we do LyXTabular(bp) which does
indeed call InsetText(bp), *but* we then overwrite that with operator=.
I think we're OK, maybe ...
But we still have to reset In
On Tue, May 20, 2003 at 08:37:35PM +0100, John Levon wrote:
>
> I think it would be clearer if these menu items just said "Protected
> Space" etc. instead. Comments ?
Do it.
In fact, I question why it was ever changed to "Protected Blank" in
the first space. It's a protected space, or a "non-b
On Fri, May 30, 2003 at 02:24:22AM +0100, John Levon wrote:
> > I believe we should *always* store an absolute path at
> > runtime. At save time, we can convert it to a relative path.
Fixed patch. It seems to work for me. It fixes the Save As bug.
Please please test.
john
p.s. sorry, no, I'm n
Lars, this one is tricky for cross-buffer copy.
You need to add some code to iterate across all inset includes
in the buffer and replace masterFilename I think. Does this sound
sensible ?
Should InsetInclude store a Buffer * ?
Is Inset::clone() used anywhere else than undo and copy/paste ?
re
On Fri, May 30, 2003 at 01:49:28AM +0100, John Levon wrote:
> I believe we should *always* store an absolute path at
> runtime. At save time, we can convert it to a relative path.
Here's an attempt at a patch. Not tested
john
Index: insetgraphics.C
=
Please review. This is a necessary starting point to the optional<>
brekage
john
Index: insetcommand.C
===
RCS file: /usr/local/lyx/cvsroot/lyx-devel/src/insets/insetcommand.C,v
retrieving revision 1.75
diff -u -p -r1.75 insetcomma
Is there anyone who knows this code ? Angus ?
We seem to be storing relative paths in the InsetGraphics
cache (see cache_->update()). This is broken across e.g. file->save as.
It also causes significant problems in trying to fix the current
massive horkage in the tree.
I believe we should *alway
On Fri, May 30, 2003 at 12:32:44AM +0200, Lars Gullik Bj?nnes wrote:
> I wonder what made this come up now...
> Can it be some iterator search that searches from the beginning of the
> document all the time?
getParFromID via undo ?
john
John Levon <[EMAIL PROTECTED]> writes:
| On Thu, May 29, 2003 at 02:32:00AM +0100, John Levon wrote:
|
| > Load extended.lyx and find the first Itemize list, then increase the
| > depth of one of the items. Dead slow. Has to be fixed I think
|
| Lars, looks like you're right about find_if :
|
|
On Thu, May 29, 2003 at 02:32:00AM +0100, John Levon wrote:
> Load extended.lyx and find the first Itemize list, then increase the
> depth of one of the items. Dead slow. Has to be fixed I think
Lars, looks like you're right about find_if :
CPU: PIII, speed 863.195 MHz (estimated)
Counted CPU_CL
On Tue, May 27, 2003 at 11:11:37AM +0200, Andre Poenitz wrote:
> If there is really an UI issue, this can be brushed over later
> (like 'jump ahead two positions on Cursor-Right when the next inset is
> "invisible")
strictly shutting up on UI issues as told, this makes for ugly core
code. Little
This helps a little bit in that minipage gets the right height now ...
sometimes...
Andre, please look.
There is still total horkage for minipages alas. It thinks it has a
width of 0. Andre, I don't see any handling of -1 widths. Where does the
correction from -1 -> max text width happen ?
reg
On Wed, May 28, 2003 at 08:37:00AM +0200, Andre Poenitz wrote:
> The notion 'ascent above baseline' (positive upwards) and 'descent below
> baseline' (positive downwards) is not mathed's invention (certainly not
> mine).
Didn't say it was.
> > + dim.asc = d.ascent() + d.descent
On Wed, May 28, 2003 at 09:08:35AM +0200, Juergen Spitzmueller wrote:
> > Just that the user does not expect that the clipboard is modified.
> > There should not be any clipboard modification without an explicit
> > cut/copy.
>
> Well then how about this? (As I said, the current implementation is
On Thu, May 29, 2003 at 06:27:47PM +0200, Lars Gullik Bj?nnes wrote:
> This patch does it, the brute force way, and as a result you get a lot
> of nice crashes. Please have a look if you want to exercise your
> problem solving abilities.
Don't we have enough problems to solve already in terms of
On Wed, May 28, 2003 at 04:24:44AM +0100, John Levon wrote:
> This helps a little bit in that minipage gets the right height now ...
> sometimes...
Even better, I can't reproduce any problems at all with the below.
Please review and test.
Andre, I think Dimension::height() is strictly useless. F
As you probably noticed, the lists are up again. Thx for your patience.
The Summer should be uneventful...
Mate
John Levon <[EMAIL PROTECTED]> writes:
| On Tue, May 27, 2003 at 01:49:23PM +0200, Jean-Marc Lasgouttes wrote:
|
| > The solution would be to modify CutAndPaste to allow an alternative
| > temporary clipboard, but this is probably a lot of work.
|
| It's probably not that much work once lars is
The bibtex inset now constructs itself using InsetCommandParams
in factory.C with a name of "bibtex". This breaks when you read it in,
since we are expecting "BibTeX" as the command name.
Possible fixes :
o make createInset() set the command name to BibTeX (I assume this
won't break the dial
On Tue, May 27, 2003 at 01:49:23PM +0200, Jean-Marc Lasgouttes wrote:
> The solution would be to modify CutAndPaste to allow an alternative
> temporary clipboard, but this is probably a lot of work.
It's probably not that much work once lars is finished actually.
I'm OK with Juergen's patch as i
On Tue, May 27, 2003 at 10:00:26AM +0200, Andre Poenitz wrote:
> But its a worthy goal...
It is. In 1.7 ... (Lars' new nickname for "not gonna happen" :)
john
On Wed, May 28, 2003 at 02:28:13PM +0200, Juergen Spitzmueller wrote:
> OK. Then I'm out (no more ideas). But I vote for removing the current
> conversion. If we don't do it right, we should not do it at all.
We wouldn't end up doing anything, we do barely anything fully
correctly.
Why can't we
Load extended.lyx and find the first Itemize list, then increase the
depth of one of the items. Dead slow. Has to be fixed I think
Profiles later
john
Seems relatively straight forward. Comments ?
regards
john
Index: insets/insetcite.C
===
RCS file: /usr/local/lyx/cvsroot/lyx-devel/src/insets/insetcite.C,v
retrieving revision 1.53
diff -u -p -r1.53 insetcite.C
--- insets/insetcit
On Tue, 27 May 2003, Andre Poenitz wrote:
> But we would need to be careful nevertheless as in some cases we would
> still have to invalidate iterators (i.e. when the underlying paragraph is
> removed).
>
> So in e.g. undo we'd better not remove the changed par from the list and
> re-insert a copy
We really need to make Inset::clone take no arguments, this cleans up
stuff and makes other things easier to understand... unfortunately it
is not so easy...
This patch does it, the brute force way, and as a result you get a lot
of nice crashes. Please have a look if you want to exercise your
pro
> Just to mention another option:
>
> I've used 'InnoSetup' at the time I had to create a Windows version of my
> programms. That creates nice installers which can create icons on the
> desktop etc and had the benefit that InnoSetup itself as well as the
> created installers ran fine under Wine.
>
John Levon wrote:
> We wouldn't end up doing anything, we do barely anything fully
> correctly.
>
> Why can't we just use your patch, and file a bug on the broken clipboard
> behaviour ? It's a reasonable tradeoff of bugs IMHO.
Note that even if this might sound so, I am not frustrated at all. It'
On Mon, May 26, 2003 at 11:15:04AM -0400, Zvezdan Petkovic wrote:
> On Thu, May 22, 2003 at 10:47:29AM +0200, Helge Hafting wrote:
> > Truetype fonts in pdf seems to work only with pdflatex, not
> > dvi->ps->pdf. And the pdflatex way is noticeable faster too.
>
> People obviously do not bother to
John Levon wrote:
> Rejected. We don't fix our bugs by trying to fix our users. Or rather,
> we shouldn't.
OK. Then I'm out (no more ideas). But I vote for removing the current
conversion. If we don't do it right, we should not do it at all.
Jürgen.
I just realized that there is no such thing as "find" in std::list.
So this patch removes that and replaces it with std::find.
? src/frontends/xforms/lyx_forms.h
? src/frontends/xforms/lyx_xpm.h
Index: src/ParagraphList.C
===
RCS fi
This patch introduces ParagraphList::const_iterator, and adjust stuff
to fit. All problems larger than --><-- has been solved by a
const_cast.
Have a look if you want to.
? src/frontends/xforms/lyx_forms.h
? src/frontends/xforms/lyx_xpm.h
Index: src/ParagraphList.C
=
Mostly just a simple switch-over, but some small other things as well.
Have a look.
? src/less
? src/frontends/xforms/lyx_forms.h
? src/frontends/xforms/lyx_xpm.h
Index: src/CutAndPaste.h
===
RCS file: /usr/local/lyx/cvsroot/lyx-dev
Andre Poenitz <[EMAIL PROTECTED]> writes:
| > Perhaps. But I am not willing to open that issue now... It is some
| > easy to come in the situation that you need to convert
| > ParagraphList::iterator to ParagraphList::const_iterator and that is
| > reall cumbersome.
|
| I think std::list<>::const
Andre Poenitz <[EMAIL PROTECTED]> writes:
| On Tue, May 27, 2003 at 11:27:55PM +0200, Lars Gullik Bjønnes wrote:
| +bool operator==(Paragraph const & lhs, Paragraph const & rhs)
| +{
| +#warning FIXME this implementatoin must be completely wrong...
| + return &lhs == &rhs;
| +}
|
| As the w
Andre Poenitz <[EMAIL PROTECTED]> writes:
| > to fit. All problems larger than --><-- has been solved by a
| > const_cast.
This ^^
| Wouldn't it be better in such cases to change the functions' signature to
|
| int getEndLabel(ParagraphList::const_iterator...
Perhaps. But I am not wil
John Levon <[EMAIL PROTECTED]> writes:
| o make readInset() handle only "bibtex", and do s/BibTeX/bibtex/ in
|lyx2lyx
This one I think, but I have no strong feeling about this.
--
Lgb
Andre Poenitz <[EMAIL PROTECTED]> writes:
| On Wed, May 28, 2003 at 09:44:29AM +0200, Lars Gullik Bjønnes wrote:
| > | It certainly is undefined behaviour. But every std::list<>::iterator I know
| > | of is binary compatible with its corresponding std::list<>::const_iterator
| > | (in contrast to
Andre Poenitz <[EMAIL PROTECTED]> writes:
| On Wed, May 28, 2003 at 09:05:23AM +0200, Lars Gullik Bjønnes wrote:
| > | I think std::list<>::const_iterator has a corresponding constructor.
| >
| > Show me.
|
| I don't find it in the Standard right now.
Right... :-)
| But:
|
| template
|
Jean-Marc Lasgouttes wrote:
> Just that the user does not expect that the clipboard is modified.
> There should not be any clipboard modification without an explicit
> cut/copy.
Well then how about this? (As I said, the current implementation is more
confusing than helpful).
> The solution would
On Tue, 27 May 2003 11:46:20 +0200
Andre Poenitz <[EMAIL PROTECTED]> wrote:
> On Tue, May 27, 2003 at 11:43:22AM +0200, Charpentier Philippe wrote:
> > sometimes I find usefull to use vlatex instead of pdflatex to
> > produce a PDF file. Is it possible (in any version of LyX and
> > for the user i
75 matches
Mail list logo
