Re: Anybody want a fun project ?

2003-08-27 Thread John Levon
On Thu, Aug 28, 2003 at 12:34:53AM +0200, Christian Ridderstr?m wrote: > mnemonic? > Or keyboard shortcut for the menu? This. (Shortcut is normally what's used for .e.g control-c meaning copy) > Insert->File->_S_ource Listing > into the menus of lyx 1.4. Super regards john -- Khendon's

Re: Anybody want a fun project ?

2003-08-27 Thread Christian Ridderström
On Wed, 27 Aug 2003, Andre Poenitz wrote: > > Who should I contact about the CVS account? > > Lars. > Ok, will do. > > Stick to the indentation/spacing already used. > Ok, I think I've fixed that now. /Christian -- Christian Ridderström http://www.md.kth.se/~chr

Re: Anybody want a fun project ?

2003-08-27 Thread Christian Ridderström
On Wed, 27 Aug 2003, John Levon wrote: > On Wed, Aug 27, 2003 at 10:56:18AM +0200, Christian Ridderstr?m wrote: > > > + Item "Program Listing" "listing-insert" > > I'd prefer "Source Listing". Do we have a mnemonic avaliable ? mnemonic? do you mean the name of the lfun (currently LFUN_INSERT_

Re: Anybody want a fun project ?

2003-08-27 Thread Christian Ridderström
On Wed, 27 Aug 2003, John Levon wrote: > > +2003-08-26 Christian Ridderström <[EMAIL PROTECTED]> > > Two spaces after your real name (you'll break my syntax highlighting !!) Funny... looks fine in my Emacs. I put some (over-enthusiastic) notes on it here http://wiki.lyx.org/pmwiki.ph

Re: Bugzilla

2003-08-27 Thread John Levon
On Wed, Aug 27, 2003 at 10:56:06PM +0200, Michael Schmitt wrote: > As mentioned in bug #1328, I think we should add a new severity level I don't think it's a good idea, because it engenders lots of discussion and bugzilla isn't a good way of doing that. regards john -- Khendon's Law: If the

Bugzilla

2003-08-27 Thread Michael Schmitt
Hi John, thanks for checking my bug reports. I intended to do some more testing today but even elementary features were broken so that all efforts would have been in vain. As mentioned in bug #1328, I think we should add a new severity level "design". This allows us to describe design problems

lyxerr paintrows:: rit::

2003-08-27 Thread Garst R. Reese
Is the serving any purpose? Garst

[patch] outerPar

2003-08-27 Thread Alfredo Braunstein
Saves a few cycles (and lines), and is enough. Ok? Alfredo Index: paragraph_funcs.C === RCS file: /usr/local/lyx/cvsroot/lyx-devel/src/paragraph_funcs.C,v retrieving revision 1.64 diff -u -p -u -r1.64 paragraph_funcs.C --- paragraph_

Bugs etc.

2003-08-27 Thread John Levon
I've been through a number of unco and 1.4 bugs now, currently we have 61 1.4 targetted bugs, most of them are regressions and cover multiple sins. My lyx folder is empty now too, so if somebody's still expecting a reply to something, please tell me :) regards john -- Khendon's Law: If the sam

Re: 1.1.6fix4 to 1.3.2: problems with figure floats

2003-08-27 Thread John Levon
On Fri, Jul 25, 2003 at 05:03:51PM +0100, Oliver wrote: > in the dvi/ps output. After some experiments I identified the change from > \centering ... \par > to > \begin{center} ... \end{center} > as the problem. This bug is known and listed on bugzilla > The default behaviour of the latex geom

Re: suggestions to improve change tracking

2003-08-27 Thread Nirmal Govind
> It would be relatively easy to work well for 80% of cases. File it as an > enhancement. Great!! I've filed the enhancement request.. > Context menu stuff has been wanted for a long time. It requires some > very careful design, and I'm not looking at doing anything in the > current tree right

Re: Bug: crash on clicking button of pasted collapsable inset

2003-08-27 Thread John Levon
On Wed, Aug 27, 2003 at 10:16:04PM +0300, Martin Vermeer wrote: > 1) copy a collapsable inset to the clipboard > 2) paste it elsewhere > 3) if the C&P'ed inset was closed, click button to open it > 4) (DO NOT CLICK in the text inside the inset) > 5) click the button Hmm, I thought we'd resolved t

Re: LyX archeology (status)

2003-08-27 Thread Jose' Matos
On Wednesday 27 August 2003 08:13, Asger Kunuk Alstrup wrote: > On Tue, 26 Aug 2003, Jose' Matos wrote: > > For those who like here follows the family album: > > http://www.lyx.org/~jamatos/archeology/ > > That's great ;-) At least someone who understand me. ;-) > Could you put the 1.0 and 1.2

Bug: crash on clicking button of pasted collapsable inset

2003-08-27 Thread Martin Vermeer
Recipe: 1) copy a collapsable inset to the clipboard 2) paste it elsewhere 3) if the C&P'ed inset was closed, click button to open it 4) (DO NOT CLICK in the text inside the inset) 5) click the button ...boom. Point 4) is funny. It seems there has to be a visible paragraph inside the pasted inse

Re: Anybody want a fun project ?

2003-08-27 Thread John Levon
On Wed, Aug 27, 2003 at 10:56:18AM +0200, Christian Ridderstr?m wrote: > + Item "Program Listing" "listing-insert" I'd prefer "Source Listing". Do we have a mnemonic avaliable ? > +2003-08-26 Christian Ridderström <[EMAIL PROTECTED]> Two spaces after your real name (you'll break my syntax

Re: suggestions to improve change tracking

2003-08-27 Thread John Levon
On Wed, Aug 27, 2003 at 01:51:43PM -0400, Nirmal Govind wrote: > 1. In the Merge Changes box, would it be possible to show the changed stuff > (either the crossed out text or the new additions) so that it would be > possible to accept/reject w/o looking at the lyx document again? Basically It wou

suggestions to improve change tracking

2003-08-27 Thread Nirmal Govind
Hi.. I've just started using the change tracking feature (thanks to Johnathan Burchill's adaptation of John's patch for 1.3.2).. it's a great feature.. thanks John.. Two suggestions that would improve the useability: 1. In the Merge Changes box, would it be possible to show the changed stuff (eith

[patch] buffer ref take 3

2003-08-27 Thread Lars Gullik Bjønnes
Unless I get objections I will apply this later this evening. bufferref-3.diff.gz Description: GNU Zip compressed data -- Lgb

Re: inset traversal problem

2003-08-27 Thread Andre Poenitz
On Wed, Aug 27, 2003 at 06:03:06PM +0200, Alfredo Braunstein wrote: > Andre Poenitz wrote: > > > Ok.. so we have two layers for a Table. > > > > Now, what about a 'collapsable inset'. > > > > Should this be able to contain a simple MathFracInset or should this be > > wrapped in some kind of cont

Re: inset traversal problem

2003-08-27 Thread John Levon
On Wed, Aug 27, 2003 at 06:03:06PM +0200, Alfredo Braunstein wrote: > I wonder if the whole discussion is not about Quite possibly. > > Should this be able to contain a simple MathFracInset or should this be > > wrapped in some kind of container. Like a InsetText^H^H^H Cell? It would have exact

Re: inset traversal problem

2003-08-27 Thread Alfredo Braunstein
Andre Poenitz wrote: > Ok.. so we have two layers for a Table. > > Now, what about a 'collapsable inset'. > > Should this be able to contain a simple MathFracInset or should this be > wrapped in some kind of container. Like a InsetText^H^H^H Cell? I wonder if the whole discussion is not about

Re: inset traversal problem

2003-08-27 Thread Andre Poenitz
On Wed, Aug 27, 2003 at 04:32:42PM +0100, John Levon wrote: > On Wed, Aug 27, 2003 at 04:57:03PM +0200, Andre Poenitz wrote: > > > > Put it this way: if we have a containing something called X, I don't see > > > a reason for anything else. Xes can be contained by, and contain Xes. > > > > A table

Re: inset traversal problem

2003-08-27 Thread John Levon
On Wed, Aug 27, 2003 at 04:57:03PM +0200, Andre Poenitz wrote: > > Put it this way: if we have a containing something called X, I don't see > > a reason for anything else. Xes can be contained by, and contain Xes. > > A table only contains 'CellInsets'. No 'MathAlphaInset', no > 'InsetBibtex'. C

Re: [patch] getParentLanguage

2003-08-27 Thread Lars Gullik Bjønnes
Andre Poenitz <[EMAIL PROTECTED]> writes: | Language const * BufferView::getParentLanguage(InsetOld * inset) const | { | - LyXText * text = getParentText(inset); | - return text->cursor.par()->getFontSettings(buffer()->params, | -text->curs

Edit->Find crash in latest CVS

2003-08-27 Thread Kayvan A. Sylvan
Edit->Find crashes like this for the latest CVS. If you need more info, just ask. This happens on Solaris, Linux, Cygwin. (gdb) where #0 0xfee9c71c in _libc_kill () from /usr/lib/libc.so.1 #1 0xfee35a44 in abort () from /usr/lib/libc.so.1 #2 0x00528210 in lyx::support::abort() () at ../../.

[patch] getParentLanguage

2003-08-27 Thread Andre Poenitz
This implements 'getParentLanguage' on top of 'ownerPar()' instead of anw Inset::onwer() cascade. Moreover, the new code is no more depentend so some spurious cursor... Ok? Andre' -- Those who desire to give up Freedom in order to gain Security, will not have, nor do they deserve, either one.

Re: Inset::display() ?

2003-08-27 Thread Lars Gullik Bjønnes
John Levon <[EMAIL PROTECTED]> writes: | On Wed, Aug 27, 2003 at 03:45:58PM +0100, John Levon wrote: > >> Unfortunately not. cmd.x,y are never set in many LFUN_INSET_EDIT >> invocations. Oh well > | It even leaves .x and .y uninitialised !! > | Objections to below ? not from me -- Lgb

Re: Inset::display() ?

2003-08-27 Thread Andre Poenitz
On Wed, Aug 27, 2003 at 03:50:49PM +0100, John Levon wrote: > On Wed, Aug 27, 2003 at 03:45:58PM +0100, John Levon wrote: > > > Unfortunately not. cmd.x,y are never set in many LFUN_INSET_EDIT > > invocations. Oh well > > It even leaves .x and .y uninitialised !! > > Objections to below ? No.

Re: [patch] top_y

2003-08-27 Thread Alfredo Braunstein
John Levon wrote: > On Wed, Aug 27, 2003 at 04:38:27PM +0200, Alfredo Braunstein wrote: > >> Can I? > > I don't see why not. Applied. Alfredo

Re: inset traversal problem

2003-08-27 Thread Andre Poenitz
On Wed, Aug 27, 2003 at 03:38:48PM +0100, John Levon wrote: > > Would it make you happy if I used the term 'CellInset' instead of 'Cell'? > > Reading the rest of the thread it looks like mostly terminology > problems... I don't think so. Implementation-wise it might be such, but the conceptual st

Re: inset traversal problem

2003-08-27 Thread Lars Gullik Bjønnes
Asger Kunuk Alstrup <[EMAIL PROTECTED]> writes: | On Wed, 27 Aug 2003, Andre Poenitz wrote: > >> What would be your basic chunk of data? >> >> "List of Insets"? >> >> What's wrong with giving this concept a name ("Cell")? > | I'm not sure if it helps, but a long time ago, we discussed how to do |

Re: Inset::display() ?

2003-08-27 Thread John Levon
On Wed, Aug 27, 2003 at 03:45:58PM +0100, John Levon wrote: > Unfortunately not. cmd.x,y are never set in many LFUN_INSET_EDIT > invocations. Oh well It even leaves .x and .y uninitialised !! Objections to below ? john Index: funcrequest.C =

Re: Inset::display() ?

2003-08-27 Thread John Levon
On Wed, Aug 27, 2003 at 04:41:16PM +0200, Andre Poenitz wrote: > That would be a solution, too. Unfortunately not. cmd.x,y are never set in many LFUN_INSET_EDIT invocations. Oh well john -- Khendon's Law: If the same point is made twice by the same person, the thread is over.

Re: [patch] top_y

2003-08-27 Thread Andre Poenitz
On Wed, Aug 27, 2003 at 04:38:27PM +0200, Alfredo Braunstein wrote: > This is only the top_y part of yesterday patch. > It moves top_y from LyXText to BufferView. Rationale: insets don't scroll, > so don't need it nor use it. If inset scrolling is to be implemented > sometime, it doesn't have to be

Re: [patch] top_y

2003-08-27 Thread John Levon
On Wed, Aug 27, 2003 at 04:38:27PM +0200, Alfredo Braunstein wrote: > Can I? I don't see why not. john

Re: getParentLanguage

2003-08-27 Thread John Levon
On Wed, Aug 27, 2003 at 04:32:40PM +0200, Andre Poenitz wrote: > Ever done that? I'm mono-lingual. > If you say that this is important to keep I will build something aroung I suspect it's important. But really we'd need to ask somebody who regularly works in several languages if they'd mind hav

Re: Inset::display() ?

2003-08-27 Thread Andre Poenitz
On Wed, Aug 27, 2003 at 03:32:17PM +0100, John Levon wrote: > On Wed, Aug 27, 2003 at 04:15:10PM +0200, Andre Poenitz wrote: > > > Ok. I think this is easily fixed by introducing the notion of a > > 'sensitive part' of an inset. I.e. 'insetHit' would only check for the > > 'real' size > > I w

Re: inset traversal problem

2003-08-27 Thread John Levon
On Wed, Aug 27, 2003 at 04:29:17PM +0200, Andre Poenitz wrote: > Would it make you happy if I used the term 'CellInset' instead of 'Cell'? Reading the rest of the thread it looks like mostly terminology problems... Put it this way: if we have a containing something called X, I don't see a reason

[patch] top_y

2003-08-27 Thread Alfredo Braunstein
This is only the top_y part of yesterday patch. It moves top_y from LyXText to BufferView. Rationale: insets don't scroll, so don't need it nor use it. If inset scrolling is to be implemented sometime, it doesn't have to be restricted to LyXText/InsetText. Removes also the unneeded LyXText argumen

Re: Inset::display() ?

2003-08-27 Thread John Levon
On Wed, Aug 27, 2003 at 04:15:10PM +0200, Andre Poenitz wrote: > Ok. I think this is easily fixed by introducing the notion of a > 'sensitive part' of an inset. I.e. 'insetHit' would only check for the > 'real' size I was considering that. But wouldn't it be nicer to simply check the real wid

Re: getParentLanguage

2003-08-27 Thread Andre Poenitz
On Wed, Aug 27, 2003 at 03:23:22PM +0100, John Levon wrote: > On Wed, Aug 27, 2003 at 04:03:19PM +0200, Andre Poenitz wrote: > > > How useful is this feature in InsetText? > > Without it seems that inserting an insettext inside a german paragraph > in an english document defaults to english. *sh

Re: inset traversal problem

2003-08-27 Thread Andre Poenitz
On Wed, Aug 27, 2003 at 03:14:35PM +0100, John Levon wrote: > On Wed, Aug 27, 2003 at 02:11:16PM +0200, Andre Poenitz wrote: > > > > Why insets cannot own insets? > > > > There is no need to. > > There is every need to. It is the only sane way to do things like > removing all the manual/auto lab

Re: getParentLanguage

2003-08-27 Thread John Levon
On Wed, Aug 27, 2003 at 04:03:19PM +0200, Andre Poenitz wrote: > How useful is this feature in InsetText? Without it seems that inserting an insettext inside a german paragraph in an english document defaults to english. Doesn't sound too good for removal to me ... But can't we do this on insert

Re: inset traversal problem

2003-08-27 Thread John Levon
On Wed, Aug 27, 2003 at 02:45:11PM +0200, Andre Poenitz wrote: > What is your basic chunk of data that's used for cut&paste etc? > A single Inset? Only copying whole paragraphs? Of course not. Start and end position are marked by Inset+Data iterators. To actually perform a cut, a Text Iterato

Re: inset traversal problem

2003-08-27 Thread John Levon
On Wed, Aug 27, 2003 at 02:11:16PM +0200, Andre Poenitz wrote: > > Why insets cannot own insets? > > There is no need to. There is every need to. It is the only sane way to do things like removing all the manual/auto label stuff. > [And I'd even argue that math tables are much easier to handle

Re: Inset::display() ?

2003-08-27 Thread Andre Poenitz
On Wed, Aug 27, 2003 at 03:08:19PM +0100, John Levon wrote: > On Wed, Aug 27, 2003 at 11:53:26AM +0300, Martin Vermeer wrote: > > > I see none of these problems. Even math display works fine. Yes, > > clicking besides an inset (same row) activates it > > Are you someone who, on banging on a wall,

Re: Inset::display() ?

2003-08-27 Thread John Levon
On Wed, Aug 27, 2003 at 11:53:26AM +0300, Martin Vermeer wrote: > I see none of these problems. Even math display works fine. Yes, > clicking besides an inset (same row) activates it Are you someone who, on banging on a wall, expects a window to open ? If the whole row will open a dialog, then t

Re: Inset::display() ?

2003-08-27 Thread John Levon
On Wed, Aug 27, 2003 at 09:03:32AM +0200, Andre Poenitz wrote: > > 61 center_indent_ = (mi.base.textwidth - dim.wid) / 2; > > 62 dim.wid = mi.base.textwidth; > > 63 dim_ = dim; > > > > Can I say "ouch" ? hitInset() isn't going to like the inset claiming it >

getParentLanguage

2003-08-27 Thread Andre Poenitz
How useful is this feature in InsetText? // If the inset is empty set the language of the current font to the // language to the surronding text (if different). if (paragraphs.begin()->empty() && paragraphs.size() == 1 &&

Re: Inset::display() ?

2003-08-27 Thread Alfredo Braunstein
Andre Poenitz wrote: > Ok. > > Andre' Now it seems to work ok, so I've commited. Regards, Alfredo

Re: inset traversal problem

2003-08-27 Thread Andre Poenitz
On Wed, Aug 27, 2003 at 03:01:08PM +0200, Asger Kunuk Alstrup wrote: > On Wed, 27 Aug 2003, Andre Poenitz wrote: > > > What would be your basic chunk of data? > > > > "List of Insets"? > > > > What's wrong with giving this concept a name ("Cell")? > > I'm not sure if it helps, but a long time ago

Re: inset traversal problem

2003-08-27 Thread Alfredo Braunstein
On Wednesday 27 August 2003 14:45, you wrote: > *shrug* > > What would be your basic chunk of data? > > "List of Insets"? > > What's wrong with giving this concept a name ("Cell")? > > > >> Why insets cannot own insets? > > > > > > There is no need to. > > > > > >> Think about tables for instances.

Re: inset traversal problem

2003-08-27 Thread Asger Kunuk Alstrup
On Wed, 27 Aug 2003, Andre Poenitz wrote: > What would be your basic chunk of data? > > "List of Insets"? > > What's wrong with giving this concept a name ("Cell")? I'm not sure if it helps, but a long time ago, we discussed how to do this. At that point in time, we agreed that the following stru

Re: inset traversal problem

2003-08-27 Thread Andre Poenitz
On Wed, Aug 27, 2003 at 02:26:45PM +0200, Alfredo Braunstein wrote: > Andre Poenitz wrote: > > > On Wed, Aug 27, 2003 at 01:54:55PM +0200, Alfredo Braunstein wrote: > >> Andre Poenitz wrote: > >> > >> > Hm, I think ParIterator + InsetList::iterator should suffice. > >> > > >> > The problem with

Re: inset traversal problem

2003-08-27 Thread Alfredo Braunstein
Andre Poenitz wrote: > On Wed, Aug 27, 2003 at 01:54:55PM +0200, Alfredo Braunstein wrote: >> Andre Poenitz wrote: >> >> > Hm, I think ParIterator + InsetList::iterator should suffice. >> > >> > The problem with the InsetText hidden in InsetCollapsable is that this >> > is not an inset, but some

Re: inset traversal problem

2003-08-27 Thread Andre Poenitz
On Wed, Aug 27, 2003 at 02:11:16PM +0200, Andre' Poenitz wrote: > The mathed model is > > Inset has cells.("MathArray") > A cell has insets. > > Nothing else. To expand that to the outside world this would be: > > Inset has cells.(ParagraphList) > A cell has d

Re: inset traversal problem

2003-08-27 Thread Andre Poenitz
On Wed, Aug 27, 2003 at 01:54:55PM +0200, Alfredo Braunstein wrote: > Andre Poenitz wrote: > > > Hm, I think ParIterator + InsetList::iterator should suffice. > > > > The problem with the InsetText hidden in InsetCollapsable is that this > > is not an inset, but some implementation detail which s

Re: inset traversal problem

2003-08-27 Thread Jose' Matos
On Wednesday 27 August 2003 12:54, Alfredo Braunstein wrote: > > IMO we should standarise the access of insets owned by insets, that's all. IMHO the paragraph should be insets, and then have a unified scheme to transverse the document. The restrictions for insets to be first order citizens are

Re: inset traversal problem

2003-08-27 Thread Alfredo Braunstein
Andre Poenitz wrote: > Hm, I think ParIterator + InsetList::iterator should suffice. > > The problem with the InsetText hidden in InsetCollapsable is that this > is not an inset, but some implementation detail which should be > completely invisible. I do not agree. What is it that forces con

Re: profiling

2003-08-27 Thread Lars Gullik Bjønnes
Andre Poenitz <[EMAIL PROTECTED]> writes: | On Wed, Aug 27, 2003 at 12:24:45PM +0200, Lars Gullik Bjønnes wrote: >> Andre Poenitz <[EMAIL PROTECTED]> writes: >> >> | On Wed, Aug 27, 2003 at 11:53:22AM +0200, Lars Gullik Bjønnes wrote: >> >> If you really want to profile stuff, compile with --disa

Re: inset traversal problem

2003-08-27 Thread Andre Poenitz
On Wed, Aug 27, 2003 at 01:32:11PM +0200, Andre' Poenitz wrote: > On Wed, Aug 27, 2003 at 01:16:53PM +0200, Alfredo Braunstein wrote: > > I repose the problem for clarification. > > > > paragraph_funcs::outerPar is buggy, because it cannot traverse all insets in > > the document. The problem is th

Re: inset traversal problem

2003-08-27 Thread Andre Poenitz
On Wed, Aug 27, 2003 at 01:16:53PM +0200, Alfredo Braunstein wrote: > I repose the problem for clarification. > > paragraph_funcs::outerPar is buggy, because it cannot traverse all insets in > the document. The problem is that some insets (like collapsables) are > direct members of other insets, a

Re: profiling

2003-08-27 Thread Andre Poenitz
On Wed, Aug 27, 2003 at 12:24:45PM +0200, Lars Gullik Bjønnes wrote: > Andre Poenitz <[EMAIL PROTECTED]> writes: > > | On Wed, Aug 27, 2003 at 11:53:22AM +0200, Lars Gullik Bjønnes wrote: > >> If you really want to profile stuff, compile with --disable-assertions > >> --enable-optimizaton="-O2" >

Re: [patch] Updated buffer refs patch

2003-08-27 Thread Angus Leeming
Lars Gullik Bjønnes wrote: > > | You have not changed the signature in the frontend controllers > | back to a Buffer *. I've exlained why the use of a Buffer & is > | unsafe here. > > When is it unsafe? Can you show any "unsafe" behaviour? > When playing with menus/preferences and stuff, I am un

inset traversal problem

2003-08-27 Thread Alfredo Braunstein
I repose the problem for clarification. paragraph_funcs::outerPar is buggy, because it cannot traverse all insets in the document. The problem is that some insets (like collapsables) are direct members of other insets, and not inside some paragraph InsetList. So for instance (random example), how

Re: [patch] Updated buffer refs patch

2003-08-27 Thread Lars Gullik Bjønnes
Angus Leeming <[EMAIL PROTECTED]> writes: | Lars Gullik Bjønnes wrote: > >> I'll go through it later and fix some stuff. > | Fixing stuff: | showMessage::operator()(string) should take a 'const &' arg. Yes, I | know it's conceptually separate to your change. However, neither are | your changes t

Re: [patch] Updated buffer refs patch

2003-08-27 Thread Lars Gullik Bjønnes
[EMAIL PROTECTED] (Lars Gullik Bjønnes) writes: | I'll go through it later and fix some stuff. Actually I cannot get this to crash... so what should I fix? Are there any obvious problems that I have not found? If not, I'll just apply this... -- Lgb

Re: Inset::display() ?

2003-08-27 Thread Lars Gullik Bjønnes
Alfredo Braunstein <[EMAIL PROTECTED]> writes: | Alfredo Braunstein wrote: > >> Yes, I'd prefer to understand what's happening. > | Found it. The problem is big and unrelated. > | CollapsableInsets contain an InsetText *as a member* so this insettext is | not in any paragraph InsetList. > | This i

Re: Inset::display() ?

2003-08-27 Thread Alfredo Braunstein
Alfredo Braunstein wrote: > This is also a general problem with ParIterator: the pars inside the > insettext are not visited. Of course I confused things, the problem is adressed in ParIterator (with InsetOld::getParagraphs). But it remains in outerPar. Regards, Alfredo

Re: [patch] Updated buffer refs patch

2003-08-27 Thread Angus Leeming
Lars Gullik Bjønnes wrote: > I'll go through it later and fix some stuff. Fixing stuff: showMessage::operator()(string) should take a 'const &' arg. Yes, I know it's conceptually separate to your change. However, neither are your changes to src/frontends/screen.C. Moreover, I've taken the time

Re: Inset::display() ?

2003-08-27 Thread Alfredo Braunstein
Alfredo Braunstein wrote: > Yes, I'd prefer to understand what's happening. Found it. The problem is big and unrelated. CollapsableInsets contain an InsetText *as a member* so this insettext is not in any paragraph InsetList. This is also a general problem with ParIterator: the pars inside the

[patch] Updated buffer refs patch

2003-08-27 Thread Lars Gullik Bjønnes
I'll go through it later and fix some stuff. bufferref-2.diff.gz Description: GNU Zip compressed data -- Lgb

Re: Inset::display() ?

2003-08-27 Thread Angus Leeming
Alfredo Braunstein wrote: >> Looks to me like updateInset expects the inset arg to always point >> to a valid InsetOld. Why not pass 'InsetOld const &' then? Therea >> are two many pointers that should be references already... > > But I don't agree in this case, as we are not interested in the >

Re: profiling

2003-08-27 Thread Alfredo Braunstein
Andre Poenitz wrote: > > From scroilling through the Userguide: > > Each sample counts as 0.01 seconds. > % cumulative self self total > time seconds secondscalls s/call s/call name > 13.90 0.31 0.31 2303 0.00 0.00 This can improve gre

Re: profiling

2003-08-27 Thread Lars Gullik Bjønnes
Andre Poenitz <[EMAIL PROTECTED]> writes: | On Wed, Aug 27, 2003 at 11:53:22AM +0200, Lars Gullik Bjønnes wrote: >> If you really want to profile stuff, compile with --disable-assertions >> --enable-optimizaton="-O2" > | Is that like the distributed binaries are built? For the rpms that is actual

Re: profiling

2003-08-27 Thread Lars Gullik Bjønnes
Andre Poenitz <[EMAIL PROTECTED]> writes: | On Wed, Aug 27, 2003 at 11:53:22AM +0200, Lars Gullik Bjønnes wrote: >> If you really want to profile stuff, compile with --disable-assertions >> --enable-optimizaton="-O2" > | Is that like the distributed binaries are built? yes, should be. (and if no

Bug in LyX 1.3.2 on Macintosh hardware

2003-08-27 Thread Martin Kuball
I compiled LyX 1.3.2 with gcc 2.95.4 and qt 3.1.1 on an apple iBook. Right after starting LyX I get a SIGSEV error and the following stacktrace (from the core): 0 0x0f4f318c in kill () from /lib/libc.so.6 (gdb) bt #0 0x0f4f318c in kill () from /lib/libc.so.6 #1 0x0f4f3008 in raise () from /li

Re: Inset::display() ?

2003-08-27 Thread Alfredo Braunstein
Andre Poenitz wrote: > Strange. Really strnge indeed. > Maybe there's only a copy of the inset in the text, not the 'calling' > inset itself? It doesn't seem. > Well, we could drop the Assert and return > > return const_cast(buf).paragraphs.begin(); // shut up compiler > > as a workaround.

Re: profiling

2003-08-27 Thread Andre Poenitz
On Wed, Aug 27, 2003 at 11:53:22AM +0200, Lars Gullik Bjønnes wrote: > If you really want to profile stuff, compile with --disable-assertions > --enable-optimizaton="-O2" Is that like the distributed binaries are built? Andre'

Re: problems with figures and previewed math

2003-08-27 Thread Andre Poenitz
On Wed, Aug 27, 2003 at 11:55:05AM +0200, Lars Gullik Bjønnes wrote: > Andre Poenitz <[EMAIL PROTECTED]> writes: > > | On Wed, Aug 27, 2003 at 11:18:34AM +0200, Lars Gullik Bjønnes wrote: > >> Andre Poenitz <[EMAIL PROTECTED]> writes: > >> > >> | On Tue, Aug 26, 2003 at 05:27:29PM +0200, Alfredo

Re: Inset::display() ?

2003-08-27 Thread Andre Poenitz
On Wed, Aug 27, 2003 at 11:42:43AM +0200, Alfredo Braunstein wrote: > Alfredo Braunstein wrote: > > > Andre Poenitz wrote: > > > >> If it works... > > > > Seems to work as expected. Ok to apply? > > Too eager: I get this while clicking inside an open footnote > > (gdb) up > #1 0x42028a73 in a

Re: Inset::display() ?

2003-08-27 Thread Alfredo Braunstein
Angus Leeming wrote: > Looks to me like updateInset expects the inset arg to always point to > a valid InsetOld. Why not pass 'InsetOld const &' then? Therea are > two many pointers that should be references already... But I don't agree in this case, as we are not interested in the inset per se,

Re: Inset::display() ?

2003-08-27 Thread Andre Poenitz
On Wed, Aug 27, 2003 at 11:39:23AM +0200, Alfredo Braunstein wrote: > Andre Poenitz wrote: > > > If it works... > > Seems to work as expected. Ok to apply? Ok. Andre' -- Those who desire to give up Freedom in order to gain Security, will not have, nor do they deserve, either one. (T. Jeff

Re: problems with figures and previewed math

2003-08-27 Thread Lars Gullik Bjønnes
Andre Poenitz <[EMAIL PROTECTED]> writes: | On Wed, Aug 27, 2003 at 11:18:34AM +0200, Lars Gullik Bjønnes wrote: >> Andre Poenitz <[EMAIL PROTECTED]> writes: >> >> | On Tue, Aug 26, 2003 at 05:27:29PM +0200, Alfredo Braunstein wrote: >> >> Andre Poenitz wrote: >> >> >> >> > I'd guess it->outerP

Re: profiling

2003-08-27 Thread Lars Gullik Bjønnes
Andre Poenitz <[EMAIL PROTECTED]> writes: >>From scroilling through the Userguide: > | Each sample counts as 0.01 seconds. | % cumulative self self total | time seconds secondscalls s/call s/call name | 13.90 0.31 0.31 2303 0.00

Re: Inset::display() ?

2003-08-27 Thread Angus Leeming
Alfredo Braunstein wrote: > Andre Poenitz wrote: > >> If it works... > > Seems to work as expected. Ok to apply? Looks to me like updateInset expects the inset arg to always point to a valid InsetOld. Why not pass 'InsetOld const &' then? Therea are two many pointers that should be references

Re: Inset::display() ?

2003-08-27 Thread Alfredo Braunstein
Alfredo Braunstein wrote: > Andre Poenitz wrote: > >> If it works... > > Seems to work as expected. Ok to apply? Too eager: I get this while clicking inside an open footnote (gdb) up #1 0x42028a73 in abort () from /lib/tls/libc.so.6 (gdb) up #2 0x082c7567 in lyx::support::abort() () (gdb) up

Re: Inset::display() ?

2003-08-27 Thread Alfredo Braunstein
Andre Poenitz wrote: > If it works... Seems to work as expected. Ok to apply? Regards, Alfredo Index: BufferView.C === RCS file: /usr/local/lyx/cvsroot/lyx-devel/src/BufferView.C,v retrieving revision 1.180 diff -u -p -u -r1.180 Bu

profiling

2003-08-27 Thread Andre Poenitz
>From scroilling through the Userguide: Each sample counts as 0.01 seconds. % cumulative self self total time seconds secondscalls s/call s/call name 13.90 0.31 0.31 2303 0.00 0.00 LyXText::updateRowPositions() 6.28

Re: Inset::display() ?

2003-08-27 Thread Alfredo Braunstein
Alfredo Braunstein wrote: > Why do I get this, if InsetText is derived from UpdatableInset which is > derived from InsetOld? What am I missing? Never mind... it was forward declared (missing include). Alfredo

Re: problems with figures and previewed math

2003-08-27 Thread Andre Poenitz
On Wed, Aug 27, 2003 at 11:18:34AM +0200, Lars Gullik Bjønnes wrote: > Andre Poenitz <[EMAIL PROTECTED]> writes: > > | On Tue, Aug 26, 2003 at 05:27:29PM +0200, Alfredo Braunstein wrote: > >> Andre Poenitz wrote: > >> > >> > I'd guess it->outerPar() would be simpler to use (this function > >> >

Re: Inset::display() ?

2003-08-27 Thread Alfredo Braunstein
Why do I get this, if InsetText is derived from UpdatableInset which is derived from InsetOld? What am I missing? g++ -DHAVE_CONFIG_H -I. -I../../src -I. -I../../boost -I/usr/X11R6/include -O -fno-exceptions -W -Wall -c -o bufferview_funcs.o `test -f '../../src/bufferview_funcs.C' || echo '../.

Re: tex2lyx bug and ERT discussion.

2003-08-27 Thread Michael Schmitt
Dear Joao, could you please add these two bugs to bugzilla.lyx.org such that they do not get lost? Please select "tex2lyx" as component. Choosing a component makes it easy to search for groups of similar bugs (and to identify identical bug reports). Thanks, Michael

Re: problems with figures and previewed math

2003-08-27 Thread Lars Gullik Bjønnes
Andre Poenitz <[EMAIL PROTECTED]> writes: | On Tue, Aug 26, 2003 at 05:27:29PM +0200, Alfredo Braunstein wrote: >> Andre Poenitz wrote: >> >> > I'd guess it->outerPar() would be simpler to use (this function >> > exists...) >> >> ...and is O(1) (I don't know why I though that it had to be somet

Re: Anybody want a fun project ?

2003-08-27 Thread Andre Poenitz
On Wed, Aug 27, 2003 at 10:56:18AM +0200, Christian Ridderström wrote: > On Wed, 27 Aug 2003, John Levon wrote: > > > John, how do I create a patch? > > > > We should give you a CVS account so you can do a proper patch by "cvs > > add"ing the new files. Then from the top lyx directory, you do >

Re: Inset::display() ?

2003-08-27 Thread Andre Poenitz
On Wed, Aug 27, 2003 at 10:54:02AM +0200, Alfredo Braunstein wrote: > Andre Poenitz wrote: > > >> I will introduce an Inset * argument to updateInset instead, cleaner and > >> not all insets know about their bv so the other way won't work. > > > > How do they call BufferView::updateInset if they

Re: Anybody want a fun project ?

2003-08-27 Thread Christian Ridderström
On Wed, 27 Aug 2003, John Levon wrote: > > John, how do I create a patch? > > We should give you a CVS account so you can do a proper patch by "cvs > add"ing the new files. Then from the top lyx directory, you do > > cvs diff -Nup >mypatch.diff Who should I contact about the CVS account? In c

Re: Inset::display() ?

2003-08-27 Thread Alfredo Braunstein
Andre Poenitz wrote: >> I will introduce an Inset * argument to updateInset instead, cleaner and >> not all insets know about their bv so the other way won't work. > > How do they call BufferView::updateInset if they don't know their bv? Good point ;). Sorry, I meant the base InsetOld doesn't kn

Re: Inset::display() ?

2003-08-27 Thread Andre Poenitz
On Wed, Aug 27, 2003 at 10:43:39AM +0200, Alfredo Braunstein wrote: > Andre Poenitz wrote: > > > Yes, please. > > I will introduce an Inset * argument to updateInset instead, cleaner and not > all insets know about their bv so the other way won't work. How do they call BufferView::updateInset if

Re: Inset::display() ?

2003-08-27 Thread Alfredo Braunstein
Andre Poenitz wrote: > Yes, please. I will introduce an Inset * argument to updateInset instead, cleaner and not all insets know about their bv so the other way won't work. Regards, Alfredo

  1   2   >