Re: [Patch] fix bug 1765: fixed width cell's width not displayed on screen

2005-05-07 Thread Asger Ottar Alstrup
Andre Poenitz wrote: On Fri, May 06, 2005 at 11:57:47AM +0300, Martin Vermeer wrote: I expect this would work fine if we could, in coordcache, turn bool updating into int updating, counting the number of screen redraws we have pending. Best thing I can think of right now is some 'dispatch queue'

Re: cvs messages

2005-05-07 Thread Andre Poenitz
On Fri, May 06, 2005 at 09:58:34PM +0200, Michael Schmitt wrote: Well, the files are in the way... :-) Either you have removed the CVS subdirectory or you work on a Windows machine and you have changed the file names from lower to upper case or vice versa... No Windows, and I haven't

Re: [Patch] Table crash blues

2005-05-07 Thread Andre Poenitz
On Fri, May 06, 2005 at 10:43:45PM +0300, Martin Vermeer wrote: On Fri, May 06, 2005 at 08:28:47PM +0200, Andre Poenitz wrote: On Fri, May 06, 2005 at 03:59:47PM +0300, Martin Vermeer wrote: But there is no graphics or the like within a mile. It is _typing characters_ that does this. Does

Re: [Patch] Table crash blues

2005-05-07 Thread Andre Poenitz
On Fri, May 06, 2005 at 10:43:45PM +0300, Martin Vermeer wrote: On Fri, May 06, 2005 at 08:28:47PM +0200, Andre Poenitz wrote: On Fri, May 06, 2005 at 03:59:47PM +0300, Martin Vermeer wrote: But there is no graphics or the like within a mile. It is _typing characters_ that does this. Does

Re: [Patch] Table crash blues

2005-05-07 Thread Andre Poenitz
And the patch... Index: BufferView_pimpl.C === RCS file: /usr/local/lyx/cvsroot/lyx-devel/src/BufferView_pimpl.C,v retrieving revision 1.581 diff -u -p -r1.581 BufferView_pimpl.C --- BufferView_pimpl.C 20 Apr 2005 17:35:46 -

Re: Fix invalid access in insetcommandparams.C

2005-05-07 Thread Alfredo Braunstein
Andre Poenitz wrote: On Thu, May 05, 2005 at 05:23:56PM +0100, Angus Leeming wrote: Urs. Doesn't cmd[-1] mean cmd[cmd.length()-2]. Some nasty c-ism? Only for cmd.lenght() == -1. I think you should redo your math ;-P Alfredo

Re: [Patch] Table crash blues

2005-05-07 Thread Alfredo Braunstein
Andre Poenitz wrote: PS: If Alfredo doesn't shout within a few hours that he'll give it a try I'd try to convince the family that this is important... Haha Good luck with that ;-) Alfredo

[PATCH 1.3] Fix menu entry

2005-05-07 Thread Michael Schmitt
Hello the menu entry NavigateRefs in LyX 1.3 is misleading, because the user expects to navigate to the next reference in the document. Instead, Refs lets the user jump from a reference to its corresponding label. (Actually, I thought the function is broken until I found out its real purpose)

Re: [Patch] Table crash blues

2005-05-07 Thread Andre Poenitz
On Fri, May 06, 2005 at 10:43:45PM +0300, Martin Vermeer wrote: On Fri, May 06, 2005 at 08:28:47PM +0200, Andre Poenitz wrote: On Fri, May 06, 2005 at 03:59:47PM +0300, Martin Vermeer wrote: But there is no graphics or the like within a mile. It is _typing characters_ that does this. Does

Re: Windows file copy in fs_extras.c

2005-05-07 Thread Angus Leeming
Rob Bearman wrote: In other words, noclobber is the same as bFailIfExists. When noclobber==FALSE, you want the copy to overwrite. Instead, the current code fails the copy. Good spot! I take it LyX chewed up something it shouldn't have done? -- Angus

Re: Windows file copy in fs_extras.c

2005-05-07 Thread Rob Bearman
Rob Bearman wrote: In other words, noclobber is the same as bFailIfExists. When noclobber==FALSE, you want the copy to overwrite. Instead, the current code fails the copy. Good spot! I take it LyX chewed up something it shouldn't have done? I found it while playing with Save As The

Re: [Patch] Table crash blues

2005-05-07 Thread Helge Hafting
On Fri, May 06, 2005 at 08:19:06PM +0200, Andre Poenitz wrote: On Fri, May 06, 2005 at 04:01:26PM +0100, Angus Leeming wrote: As soon as you have acknowledged the recursive nature of the current update(), then something like this was bound to be needed. Well done for getting to grips with

Re: [PATCH 1.3] Fix menu entry

2005-05-07 Thread John Levon
On Sat, May 07, 2005 at 12:40:08PM +0200, Michael Schmitt wrote: the menu entry NavigateRefs in LyX 1.3 is misleading, because the user expects to navigate to the next reference in the document. Instead, Refs lets the user jump from a reference to its corresponding label. (Actually, I

Re: [PATCH 1.3] Fix menu entry

2005-05-07 Thread Michael Schmitt
John Levon wrote: This is called 'Goto Reference'[1] in 1.4, we need to harmonise any changes. Don't worry. I will send a corresponding LyX 1.4 patch in a few seconds. I've no idea why we have this but not the inverse operation in the menu. If we have one, we should have the other. We have the

Re: [PATCH 1.3] Fix menu entry

2005-05-07 Thread John Levon
On Sat, May 07, 2005 at 05:58:52PM +0200, Michael Schmitt wrote: This is called 'Goto Reference'[1] in 1.4, we need to harmonise any changes. Don't worry. I will send a corresponding LyX 1.4 patch in a few seconds. We still want the 'Goto'. I've no idea why we have this but not the

[PATCH] Some more text changes

2005-05-07 Thread Michael Schmitt
Hello, here are a few more text changes for LyX 1.4 (partly ported from the 1.3 branch). Once again, the objective is GUI consistency. Due to the fact that Goto Reference is called Goto Label now (see previous emails), I also changed the name of the corresponding LFUN. I hope this is OK.

Re: [PATCH] Some more text changes

2005-05-07 Thread John Levon
On Sat, May 07, 2005 at 06:08:11PM +0200, Michael Schmitt wrote: here are a few more text changes for LyX 1.4 (partly ported from the 1.3 branch). Once again, the objective is GUI consistency. Looks fine john

Re: Fix invalid access in insetcommandparams.C

2005-05-07 Thread Andre Poenitz
On Sat, May 07, 2005 at 12:39:19PM +0200, Alfredo Braunstein wrote: Andre Poenitz wrote: On Thu, May 05, 2005 at 05:23:56PM +0100, Angus Leeming wrote: Urs. Doesn't cmd[-1] mean cmd[cmd.length()-2]. Some nasty c-ism? Only for cmd.lenght() == -1. I think you should redo your math

Re: [Patch] Table crash blues

2005-05-07 Thread Andre Poenitz
On Sat, May 07, 2005 at 04:49:53PM +0200, Helge Hafting wrote: On Fri, May 06, 2005 at 08:19:06PM +0200, Andre Poenitz wrote: On Fri, May 06, 2005 at 04:01:26PM +0100, Angus Leeming wrote: As soon as you have acknowledged the recursive nature of the current update(), then something like

unneeded update() calls

2005-05-07 Thread Andre Poenitz
Could anybody please make sure that 'his' code does not contain unnecessary update() calls? As a first approximation I'd classify any update() with exception of the one in lyxfunc.C as 'unnecessary'. Most notably the LFUN_INSET_MODIFY handling seems to have sneaked something in... Andre'

Re: [Patch] Table crash blues

2005-05-07 Thread Angus Leeming
Andre Poenitz wrote: [Actually, there seems to be some bad Qt GUI interaction involved as the problem shows only up when having certain dialogs open. Otherwise, plain full redraw seems to be fast enough...] You reckon it's fast enough? 14x is *much* slower than 13x when using over an ADSL

Re: [Patch] Table crash blues

2005-05-07 Thread Helge Hafting
On Sat, May 07, 2005 at 08:42:39PM +0200, Andre Poenitz wrote: On Sat, May 07, 2005 at 04:49:53PM +0200, Helge Hafting wrote: On Fri, May 06, 2005 at 08:19:06PM +0200, Andre Poenitz wrote: I understand (now) that update() might be called recursively (again). However, this does not serve

Re: [Patch] fix bug 1765: fixed width cell's width not displayed on screen

2005-05-07 Thread Asger Ottar Alstrup
Andre Poenitz wrote: On Fri, May 06, 2005 at 11:57:47AM +0300, Martin Vermeer wrote: I expect this would work fine if we could, in coordcache, turn bool updating into int updating, counting the number of screen redraws we have pending. Best thing I can think of right now is some 'dispatch queue'

Re: cvs messages

2005-05-07 Thread Andre Poenitz
On Fri, May 06, 2005 at 09:58:34PM +0200, Michael Schmitt wrote: > Well, the files are in the way... :-) > > Either you have removed the CVS subdirectory or you work on a Windows > machine and you have changed the file names from lower to upper case or > vice versa... No Windows, and I haven't

Re: [Patch] Table crash blues

2005-05-07 Thread Andre Poenitz
On Fri, May 06, 2005 at 10:43:45PM +0300, Martin Vermeer wrote: > On Fri, May 06, 2005 at 08:28:47PM +0200, Andre Poenitz wrote: > > On Fri, May 06, 2005 at 03:59:47PM +0300, Martin Vermeer wrote: > > > But there is no graphics or the like within a mile. > > > It is _typing characters_ that does

Re: [Patch] Table crash blues

2005-05-07 Thread Andre Poenitz
On Fri, May 06, 2005 at 10:43:45PM +0300, Martin Vermeer wrote: > On Fri, May 06, 2005 at 08:28:47PM +0200, Andre Poenitz wrote: > > On Fri, May 06, 2005 at 03:59:47PM +0300, Martin Vermeer wrote: > > > But there is no graphics or the like within a mile. > > > It is _typing characters_ that does

Re: [Patch] Table crash blues

2005-05-07 Thread Andre Poenitz
And the patch... Index: BufferView_pimpl.C === RCS file: /usr/local/lyx/cvsroot/lyx-devel/src/BufferView_pimpl.C,v retrieving revision 1.581 diff -u -p -r1.581 BufferView_pimpl.C --- BufferView_pimpl.C 20 Apr 2005 17:35:46 -

Re: Fix invalid access in insetcommandparams.C

2005-05-07 Thread Alfredo Braunstein
Andre Poenitz wrote: > On Thu, May 05, 2005 at 05:23:56PM +0100, Angus Leeming wrote: >> Urs. Doesn't cmd[-1] mean cmd[cmd.length()-2]. Some nasty c-ism? > > Only for cmd.lenght() == -1. I think you should redo your math ;-P Alfredo

Re: [Patch] Table crash blues

2005-05-07 Thread Alfredo Braunstein
Andre Poenitz wrote: > PS: If Alfredo doesn't shout within a few hours that he'll give it a try > I'd try to convince the family that this is important... Haha Good luck with that ;-) Alfredo

[PATCH 1.3] Fix menu entry

2005-05-07 Thread Michael Schmitt
Hello the menu entry "Navigate>Refs" in LyX 1.3 is misleading, because the user expects to navigate to the next reference in the document. Instead, "Refs" lets the user jump from a reference to its corresponding label. (Actually, I thought the function is broken until I found out its real

Re: [Patch] Table crash blues

2005-05-07 Thread Andre Poenitz
On Fri, May 06, 2005 at 10:43:45PM +0300, Martin Vermeer wrote: > On Fri, May 06, 2005 at 08:28:47PM +0200, Andre Poenitz wrote: > > On Fri, May 06, 2005 at 03:59:47PM +0300, Martin Vermeer wrote: > > > But there is no graphics or the like within a mile. > > > It is _typing characters_ that does

Re: Windows file copy in fs_extras.c

2005-05-07 Thread Angus Leeming
Rob Bearman wrote: > In other words, "noclobber" is the same as "bFailIfExists." When > noclobber==FALSE, you want the copy to overwrite. Instead, the current > code fails the copy. Good spot! I take it LyX chewed up something it shouldn't have done? -- Angus

Re: Windows file copy in fs_extras.c

2005-05-07 Thread Rob Bearman
> Rob Bearman wrote: > >> In other words, "noclobber" is the same as "bFailIfExists." When >> noclobber==FALSE, you want the copy to overwrite. Instead, the current >> code fails the copy. > > Good spot! I take it LyX chewed up something it shouldn't have done? I found it while playing with

Re: [Patch] Table crash blues

2005-05-07 Thread Helge Hafting
On Fri, May 06, 2005 at 08:19:06PM +0200, Andre Poenitz wrote: > On Fri, May 06, 2005 at 04:01:26PM +0100, Angus Leeming wrote: > > As soon as you have acknowledged the recursive nature of the current > > update(), then something like this was bound to be needed. Well done for > > getting to

Re: [PATCH 1.3] Fix menu entry

2005-05-07 Thread John Levon
On Sat, May 07, 2005 at 12:40:08PM +0200, Michael Schmitt wrote: > the menu entry "Navigate>Refs" in LyX 1.3 is misleading, because the > user expects to navigate to the next reference in the document. Instead, > "Refs" lets the user jump from a reference to its corresponding label. >

Re: [PATCH 1.3] Fix menu entry

2005-05-07 Thread Michael Schmitt
John Levon wrote: This is called 'Goto Reference'[1] in 1.4, we need to harmonise any changes. Don't worry. I will send a corresponding LyX 1.4 patch in a few seconds. I've no idea why we have this but not the inverse operation in the menu. If we have one, we should have the other. We have the

Re: [PATCH 1.3] Fix menu entry

2005-05-07 Thread John Levon
On Sat, May 07, 2005 at 05:58:52PM +0200, Michael Schmitt wrote: > >This is called 'Goto Reference'[1] in 1.4, we need to harmonise any > >changes. > > > Don't worry. I will send a corresponding LyX 1.4 patch in a few seconds. We still want the 'Goto'. > >I've no idea why we have this but not

[PATCH] Some more text changes

2005-05-07 Thread Michael Schmitt
Hello, here are a few more text changes for LyX 1.4 (partly ported from the 1.3 branch). Once again, the objective is GUI consistency. Due to the fact that "Goto Reference" is called "Goto Label" now (see previous emails), I also changed the name of the corresponding LFUN. I hope this is OK.

Re: [PATCH] Some more text changes

2005-05-07 Thread John Levon
On Sat, May 07, 2005 at 06:08:11PM +0200, Michael Schmitt wrote: > here are a few more text changes for LyX 1.4 (partly ported from the 1.3 > branch). Once again, the objective is GUI consistency. Looks fine john

Re: Fix invalid access in insetcommandparams.C

2005-05-07 Thread Andre Poenitz
On Sat, May 07, 2005 at 12:39:19PM +0200, Alfredo Braunstein wrote: > Andre Poenitz wrote: > > > On Thu, May 05, 2005 at 05:23:56PM +0100, Angus Leeming wrote: > >> Urs. Doesn't cmd[-1] mean cmd[cmd.length()-2]. Some nasty c-ism? > > > > Only for cmd.lenght() == -1. > > I think you should

Re: [Patch] Table crash blues

2005-05-07 Thread Andre Poenitz
On Sat, May 07, 2005 at 04:49:53PM +0200, Helge Hafting wrote: > On Fri, May 06, 2005 at 08:19:06PM +0200, Andre Poenitz wrote: > > On Fri, May 06, 2005 at 04:01:26PM +0100, Angus Leeming wrote: > > > As soon as you have acknowledged the recursive nature of the current > > > update(), then

unneeded update() calls

2005-05-07 Thread Andre Poenitz
Could anybody please make sure that 'his' code does not contain unnecessary update() calls? As a first approximation I'd classify any update() with exception of the one in lyxfunc.C as 'unnecessary'. Most notably the LFUN_INSET_MODIFY handling seems to have sneaked something in... Andre'

Re: [Patch] Table crash blues

2005-05-07 Thread Angus Leeming
Andre Poenitz wrote: > [Actually, there seems to be some bad Qt GUI interaction involved as the > problem shows only up when having certain dialogs open. Otherwise, plain > full redraw seems to be fast enough...] You reckon it's fast enough? 14x is *much* slower than 13x when using over an ADSL

Re: [Patch] Table crash blues

2005-05-07 Thread Helge Hafting
On Sat, May 07, 2005 at 08:42:39PM +0200, Andre Poenitz wrote: > On Sat, May 07, 2005 at 04:49:53PM +0200, Helge Hafting wrote: > > On Fri, May 06, 2005 at 08:19:06PM +0200, Andre Poenitz wrote: > > > I understand (now) that update() might be called recursively (again). > > > However, this does