Re: Why lyx can not paste its own selection.

2006-07-10 Thread Bo Peng
In text3.C case LFUN_MOUSE_PRESS: { // Middle button press pastes if we have a selection // We do this here as if the selection was inside an inset // it could get cleared on the unlocking of the inset so // we have to check

Why lyx can not paste its own selection.

2006-07-10 Thread Bo Peng
Hi, It is strange to me that lyx can not paste (middle-button) its own selection, since it can paste selection from other application, and other application can paste lyx' selection. I traced a little bit in text3.C, and find that the selection will become empty if a single click is executed. Tha

Re: [patch] split external clipboard and selection

2006-07-10 Thread Lars Gullik Bjønnes
Charles de Miramon <[EMAIL PROTECTED]> writes: | In a usability point of view, I think the selection clipboard should not be | accessible from the menu. It is more something for power users. I am not so sure... it is very convenient to work with, and it takes minimal time to learn... | I'm als

Re: [PATCH] remove redrawGUI

2006-07-10 Thread Lars Gullik Bjønnes
Angus Leeming <[EMAIL PROTECTED]> writes: | Michael Gerz <[EMAIL PROTECTED]> writes: | > Abdel, Lars, | > could you please have a look at the attached patch? | | I don't think that you'll get a definitive answer from them. This signal | precedes Abdel and Lars has only just found the frontend cod

Re: [patch] split external clipboard and selection

2006-07-10 Thread Charles de Miramon
Georg Baum wrote: > I think we should modify 2: > 2. paste -> paste from external clipboard. If the external clipboard > contains plain text this would be equivalent to the current "Clipboard as > Lines". Only in that case we would also have "Clipboard as Paragraphs" as > an extra menu option (th

Re: [patch] split external clipboard and selection

2006-07-10 Thread Bo Peng
I do not object to an edit->paste special -> as line/paragraph/whatever. Other applications also have such things. I just want edit->paste to paste external clipboard in a reasonable default format. That is to say, if I copy formula (or graphics) from one lyx instance, I should be able to paste it

Re: [PATCH] remove redrawGUI

2006-07-10 Thread Angus Leeming
Michael Gerz <[EMAIL PROTECTED]> writes: > Abdel, Lars, > could you please have a look at the attached patch? I don't think that you'll get a definitive answer from them. This signal precedes Abdel and Lars has only just found the frontend code ;-) > Is redrawGUI a remainder of the xforms or is i

Re: [PATCH] Yet another xforms relict

2006-07-10 Thread Angus Leeming
Michael Gerz writes: > I think this code can be removed. Any comments? I think you're right. A.

[PATCH] remove redrawGUI

2006-07-10 Thread Michael Gerz
Abdel, Lars, could you please have a look at the attached patch? Is redrawGUI a remainder of the xforms or is it still needed? Michael Index: Dialogs.h === --- Dialogs.h (Revision 14416) +++ Dialogs.h (Arbeitskopie) @@ -34,14 +34,

[PATCH] Yet another xforms relict

2006-07-10 Thread Michael Gerz
Hi, I think this code can be removed. Any comments? Michael Index: src/frontends/controllers/ControlPrefs.C === --- src/frontends/controllers/ControlPrefs.C (Revision 14401) +++ src/frontends/controllers/ControlPrefs.C (Arbeitskopie

[PATCH] more xforms cleanup

2006-07-10 Thread Michael Gerz
Subject says it all. Michael Index: SConstruct === --- SConstruct (Revision 14416) +++ SConstruct (Arbeitskopie) @@ -122,7 +122,7 @@ opts.AddOptions( # frontend EnumOption('frontend', 'Main GUI', default_frontend, -

[PATCH] More qt => qt3

2006-07-10 Thread Michael Gerz
Hi, I also missed these places. Michael Index: src/Makefile.am === --- src/Makefile.am (Revision 14401) +++ src/Makefile.am (Arbeitskopie) @@ -31,11 +31,11 @@ bin_PROGRAMS = lyx noinst_PROGRAMS = $(FRONTENDS_PROGS) -EXTRA_

Re: [patch] split external clipboard and selection

2006-07-10 Thread Bo Peng
> Selection (middle button): > 1. can paste external selection. (right) > 2. do not paste internal selection (need improvement) What is "internal selection"? I think we have none, I meant selection followed by middle button in the same lyx window. lyx does not paste selection in this case. (Thi

Wiki idea

2006-07-10 Thread Ekkehart Schlicht
Hi, Here some links which I could use, once the Wiki page is established: http://www.personeel.unimaas.nl/l.koczy/downloads.htm#edu http://kent.kellogg.northwestern.edu/bibtex/index.html#styles http://www.stat.ufl.edu/~presnell/Downloads/TeX/StatBib/ http://jo.irisson.free.fr/bstdatabase/ Ma

Re: [patch] split external clipboard and selection

2006-07-10 Thread Georg Baum
Bo Peng wrote: > As far as I can see, lyx behave like this: > > Selection (middle button): > 1. can paste external selection. (right) > 2. do not paste internal selection (need improvement) What is "internal selection"? I think we have none, and we should not have one. Selection is always global

Re: [PATCH] Preamble dialog, again

2006-07-10 Thread Michael Gerz
Michael Gerz wrote: Hi, my final contribution for today (soccer final starts in a few seconds!!!). Does this patch make sense? Hmmm. Nobody seems to object. Very well... committed! Michael

[PATCH] wheel jump

2006-07-10 Thread Michael Gerz
Hi, I missed two places. Now wheel jump has gone completely. Michael Index: src/lyxrc.h === --- src/lyxrc.h (Revision 14412) +++ src/lyxrc.h (Arbeitskopie) @@ -139,7 +139,6 @@ RC_USE_SPELL_LIB, RC_VIEWDVI_PAPEROPTION, RC_VI

Re: [patch] split external clipboard and selection

2006-07-10 Thread Bo Peng
If you want to develop a patch to integrate the internal clipboard with the external clipboard: Great, but I think we should first discuss how it should work. As far as I can see, lyx behave like this: Selection (middle button): 1. can paste external selection. (right) 2. do not paste internal

Re: [Patch] delete some Qt "signals" macro reference.

2006-07-10 Thread Abdelrazak Younes
Lars Gullik Bjønnes wrote: Abdelrazak Younes <[EMAIL PROTECTED]> writes: | Committed to trunk. This is Qt4 only right? (Hard to tell from the paths.) Yes, sorry, I generated the patch from the qt4 subdir. Abdel.

Re: [Patch] delete some Qt "signals" macro reference.

2006-07-10 Thread Lars Gullik Bjønnes
Abdelrazak Younes <[EMAIL PROTECTED]> writes: | Abdelrazak Younes wrote: | > Committed to trunk. | | By the way, the headers can now be re-ordered logically in qt4 thanks | to Lars signals/slots change. I mention this in case someone has some | time to clean this up. I have it on my list, but I

Re: [Patch] delete some Qt "signals" macro reference.

2006-07-10 Thread Abdelrazak Younes
Abdelrazak Younes wrote: Committed to trunk. By the way, the headers can now be re-ordered logically in qt4 thanks to Lars signals/slots change. I mention this in case someone has some time to clean this up. Abdel.

Re: [Patch] delete some Qt "signals" macro reference.

2006-07-10 Thread Lars Gullik Bjønnes
Abdelrazak Younes <[EMAIL PROTECTED]> writes: | Committed to trunk. This is Qt4 only right? (Hard to tell from the paths.) -- Lgb

[Patch] delete some Qt "signals" macro reference.

2006-07-10 Thread Abdelrazak Younes
Committed to trunk. Abdel. Index: Dialogs.C === --- Dialogs.C (revision 14408) +++ Dialogs.C (working copy) @@ -58,10 +58,6 @@ #include "QERT.h" #include "QExternal.h" #include "QFloat.h" -// Here would be an appropriate point

Re: make Private private

2006-07-10 Thread Michael Gerz
Angus Leeming wrote: I believe that this was needed by DEC's cxx. Maybe Jean-Marc still has access to this compiler to test? According to the comment, this was an xforms issue. Anyway, we can make it public again if someone complains. Michael

Re: [patch] split external clipboard and selection

2006-07-10 Thread Georg Baum
Bo Peng wrote: > I think the reason is that recent applications like Kate conform to > the standard better than emacs etc I should have tried Kate. I tested it with some kde programs when developing the patch, and that works. > Anyway, if you open two lyx sessions, selection, copy, you can n

Re: [Path] BufferView::Pimpl::updateMetrics() simple optimization

2006-07-10 Thread Abdelrazak Younes
Abdelrazak Younes wrote: Jean-Marc Lasgouttes wrote: +CoordCache::InnerParPosCache const & const parPos = theCoords.parPos()[text]; But parPos is modified in the loop so cannot be const. -Paragraph & par = text->getPar(pit); +Paragraph const & const par = text->getPar(pit); S

Re: [Path] BufferView::Pimpl::updateMetrics() simple optimization

2006-07-10 Thread Jean-Marc Lasgouttes
> "Abdelrazak" == Abdelrazak Younes <[EMAIL PROTECTED]> writes: Abdelrazak> But parPos is modified in the loop so cannot be const. Indeed. >> - Paragraph & par = text->getPar(pit); + Paragraph const & const >> par = text->getPar(pit); Abdelrazak> Same here. I think should be right: - Par

Re: [Path] BufferView::Pimpl::updateMetrics() simple optimization

2006-07-10 Thread Abdelrazak Younes
Lars Gullik Bjønnes wrote: Jean-Marc Lasgouttes <[EMAIL PROTECTED]> writes: | - Paragraph & par = text->getPar(pit); | + Paragraph const & const par = text->getPar(pit); | | (OK, I may have added too many consts, but they do help the compiler | to generate better code, and it makes the

Re: [Path] BufferView::Pimpl::updateMetrics() simple optimization

2006-07-10 Thread Jean-Marc Lasgouttes
> "Lars" == Lars Gullik Bjønnes <[EMAIL PROTECTED]> writes: Lars> What is the difference between Lars> "Foo const & const" Lars> and Lars> "Foo const &" ?? Indeed, it seems that Foo const & is enough. I got carried away :) JMarc

Re: [Path] BufferView::Pimpl::updateMetrics() simple optimization

2006-07-10 Thread Lars Gullik Bjønnes
Jean-Marc Lasgouttes <[EMAIL PROTECTED]> writes: | - Paragraph & par = text->getPar(pit); | + Paragraph const & const par = text->getPar(pit); | | (OK, I may have added too many consts, but they do help the compiler | to generate better code, and it makes the intent of the code clearer)

Re: [Path] BufferView::Pimpl::updateMetrics() simple optimization

2006-07-10 Thread Abdelrazak Younes
Jean-Marc Lasgouttes wrote: "Abdelrazak" == Abdelrazak Younes <[EMAIL PROTECTED]> writes: Abdelrazak> Hello, This simple optimization bring (subjectively) 1 Abdelrazak> second in the scroll test. I think it is a safe and non Abdelrazak> controversial improvement so I will commit now. It looks

Re: [Path] BufferView::Pimpl::updateMetrics() simple optimization

2006-07-10 Thread Jean-Marc Lasgouttes
> "Abdelrazak" == Abdelrazak Younes <[EMAIL PROTECTED]> writes: Abdelrazak> Hello, This simple optimization bring (subjectively) 1 Abdelrazak> second in the scroll test. I think it is a safe and non Abdelrazak> controversial improvement so I will commit now. It looks safe indeed. You should a

Re: [patch] split external clipboard and selection

2006-07-10 Thread Bo Peng
Strange. Here, I can copy some text in Oowriter with ctrl-C and paste it with ctrl-v in Kate, the other clipboard pasted with the middle button is independent from the first one. Maybe, you have a broken Windows Manager. I think the reason is that recent applications like Kate conform to the st

[Path] BufferView::Pimpl::updateMetrics() simple optimization

2006-07-10 Thread Abdelrazak Younes
Hello, This simple optimization bring (subjectively) 1 second in the scroll test. I think it is a safe and non controversial improvement so I will commit now. Abdel. Index: BufferView_pimpl.C === --- BufferView_pimpl.C (revision

Re: [patch] split external clipboard and selection

2006-07-10 Thread Charles de Miramon
Bo Peng wrote: >> Copy/paste via clipboard or selection should be functionally > BTW, I just played a bit under linux, using ooffice, firefox, emacs. I > notice that the primary inter-application cut/paste has to be done > with SELECTION, not CLIPBOARD. It looks like that the menu item > copy/cut

Re: XPM dependency

2006-07-10 Thread Jean-Marc Lasgouttes
> "Michael" == Michael Gerz <[EMAIL PROTECTED]> writes: Michael> Hello, I noticed that xforms needed the XPM library. Do we Michael> still rely on the XPM library now that xforms has gone? I do not think do. JMarc

Re: make Private private

2006-07-10 Thread Jean-Marc Lasgouttes
> "Angus" == Angus Leeming <[EMAIL PROTECTED]> writes: Angus> Michael Gerz <[EMAIL PROTECTED]> writes: >> qt3 does not complain about making private_ private. I will commit >> the patch. Angus> I believe that this was needed by DEC's cxx. Maybe Jean-Marc Angus> still has access to this compil

Re: XPM dependency

2006-07-10 Thread Georg Baum
Michael Gerz wrote: > Hello, > > I noticed that xforms needed the XPM library. Do we still rely on the > XPM library now that xforms has gone? No. Georg

XPM dependency

2006-07-10 Thread Michael Gerz
Hello, I noticed that xforms needed the XPM library. Do we still rely on the XPM library now that xforms has gone? Michael

[PATCH] Preamble dialog, again

2006-07-10 Thread Michael Gerz
Hi, my final contribution for today (soccer final starts in a few seconds!!!). Does this patch make sense? Michael Index: src/frontends/gtk/lyx_gui.C === --- src/frontends/gtk/lyx_gui.C (Revision 14401) +++ src/frontends/gtk/lyx_

Re: LyX for Windows Packaging

2006-07-10 Thread Joost Verburg
Jean-Marc Lasgouttes wrote: Branches for the installer is not a bad solution. Then I'll just upload the installer to the current location and we'll have a different branch for 1.4 and 1.5. I want to finish this now. Joost

Re: LyxWinInstaller status

2006-07-10 Thread Joost Verburg
Jean-Marc Lasgouttes wrote: It is on ftp.lyx.org that I planned to put them. The problem with this server is that it is not ours, so I am not sure lars is going to give access to everybody... I think we should move it back to or own servers, where things will be much easier. I'll prepare a sing

Re: [patch] split external clipboard and selection

2006-07-10 Thread Bo Peng
Copy/paste via clipboard or selection should be functionally equivalent. What I am trying to convey is a *standard*, *system* (no internal/external differences) copy/paste mechanism that allows lyx to communicate with other applications efficiently. And then, under some platforms, allow the conven

[Patch] delete Painter::fillPolygon()

2006-07-10 Thread Abdelrazak Younes
I promised this patch a long time ago. It's safe and non controversial so will commit now. Abdel. Index: frontends/gtk/GPainter.C === --- frontends/gtk/GPainter.C(revision 14408) +++ frontends/gtk/GPainter.C(working copy) @

Re: [patch] disable concept checks

2006-07-10 Thread Angus Leeming
Georg Baum wrote: > Abdelrazak Younes wrote: >> AFAIS all files in gtk but one or two have this concept check disabled. >> Why not just erase all those #ifdef and #undef and just disable libsigc >> concept check in the config.h? > How would that work? We want the concept checks for as many files a

Re: [patch] disable concept checks

2006-07-10 Thread Abdelrazak Younes
Georg Baum wrote: Abdelrazak Younes wrote: AFAIS all files in gtk but one or two have this concept check disabled. Why not just erase all those #ifdef and #undef and just disable libsigc concept check in the config.h? How would that work? We want the concept checks for as many files as possib

Re: [patch] split external clipboard and selection

2006-07-10 Thread Bo Peng
And does selection catters for copy-pasting complex lyx objects, or only ascii text? As a linux user, the latter would really annoy me. Doing copy/paste with mouse only is great. Copy/paste via clipboard or selection should be functionally equivalent. What I am trying to convey is a *standard*,

Re: [patch] disable concept checks

2006-07-10 Thread Georg Baum
Abdelrazak Younes wrote: > AFAIS all files in gtk but one or two have this concept check disabled. > Why not just erase all those #ifdef and #undef and just disable libsigc > concept check in the config.h? How would that work? We want the concept checks for as many files as possible. Somebody sho

Re: [patch] disable concept checks

2006-07-10 Thread Abdelrazak Younes
Georg Baum wrote: this file does not compile with concept checks enabled because of libsigc. Committing now. AFAIS all files in gtk but one or two have this concept check disabled. Why not just erase all those #ifdef and #undef and just disable libsigc concept check in the config.h? Abdel.

Re: make Private private

2006-07-10 Thread Angus Leeming
Michael Gerz <[EMAIL PROTECTED]> writes: > qt3 does not complain about making private_ private. I will commit the > patch. I believe that this was needed by DEC's cxx. Maybe Jean-Marc still has access to this compiler to test? Angus

[patch] disable concept checks

2006-07-10 Thread Georg Baum
this file does not compile with concept checks enabled because of libsigc. Committing now. GeorgIndex: src/frontends/gtk/GuiImplementation.C === --- src/frontends/gtk/GuiImplementation.C (Revision 14406) +++ src/frontends/gtk/GuiImpl

Re: Subscript deletion in mathed

2006-07-10 Thread Georg Baum
Jean-Pierre Chretien wrote: > Hello, > > I don't know if this is related to bug #2582, but here it is. > Given the math construct A_iB_j, if I set the cursor between i and B > and type backspace, the j subscript disappears. > > This true only if I come back in the expression to edit it: if I do

Re: [Patch] Re: qt4: lyx hangs

2006-07-10 Thread Abdelrazak Younes
Lars Gullik Bjønnes wrote: Abdelrazak Younes <[EMAIL PROTECTED]> writes: | Lars Gullik Bjønnes wrote: | > Georg Baum <[EMAIL PROTECTED]> writes: | > What about this: | | > + updateMetrics(flags & Update::SinglePar); | > if ((flags & (Update::FitCursor | | > Update

Subscript deletion in mathed

2006-07-10 Thread Jean-Pierre Chretien
Hello, I don't know if this is related to bug #2582, but here it is. Given the math construct A_iB_j, if I set the cursor between i and B and type backspace, the j subscript disappears. This true only if I come back in the expression to edit it: if I do the same operation when I create the equati

Re: [Patch] Fix crash in rowpainter.C: paint

2006-07-10 Thread Abdelrazak Younes
Andre Poenitz wrote: On Sun, Jul 09, 2006 at 01:47:07AM +0200, Lars Gullik Bjønnes wrote: | | I cannot at the same time do | | very small patches so that everyone can understand and wait tomorrow | | for committing to trunk and then merging trunk with my branch. | | Sure you can. And to expan