[patch 1.4] fix update of natbib labels cache

2007-01-08 Thread Jürgen Spitzmüller
Jean-Marc, this patch is what I committed to trunk yesterday. I'd like to have it in 1.4 as well. O.K.? Jürgen Index: status.14x === --- status.14x (Revision 16624) +++ status.14x (Arbeitskopie) @@ -171,6 +171,9 @@ - On Mac OS X,

AW: Re: [Cvslog] r16590 - /lyx-devel/trunk/lib/ui/stdmenus.inc

2007-01-08 Thread michael . gerz
>> - Copy some text in the editor of your choice. >> - If you paste "Plain text as Lines", each line in the clipboard >> becomes a separate paragraph in LyX >> - If you paste "Plain text as Paragraphs", all lines in the clipboard >> are put in the _same_ paragraph in LyX. >> >> => This doesn'

Re: [Cvslog] r16515 - /lyx-devel/trunk/Status.15x

2007-01-08 Thread Peter Kümmel
Peter Kümmel wrote: > Jürgen Spitzmüller wrote: >> José Matos wrote: How would you call the thing between the browser window and the buttons? >>> Horizontal slider. ;-) >>> >>> In my defense I was thinking about the vertical slider, that has the >>> scroll bar. :-) >> I'm talking Qt, you k

Re: [Cvslog] r16515 - /lyx-devel/trunk/Status.15x

2007-01-08 Thread Jürgen Spitzmüller
Peter Kümmel wrote: > Is this the last remaining TOC-dialog-bug on your stdlib-debug system? Yes. Jürgen

Re: [Cvslog] r16515 - /lyx-devel/trunk/Status.15x

2007-01-08 Thread Peter Kümmel
Jürgen Spitzmüller wrote: > José Matos wrote: >>> How would you call the thing between the browser window and the buttons? >> Horizontal slider. ;-) >> >> In my defense I was thinking about the vertical slider, that has the >> scroll bar. :-) > > I'm talking Qt, you know? Slider (as in QSlider

Re: [Cvslog] r16515 - /lyx-devel/trunk/Status.15x

2007-01-08 Thread Jürgen Spitzmüller
José Matos wrote: > > How would you call the thing between the browser window and the buttons? > >   Horizontal slider. ;-) > >   In my defense I was thinking about the vertical slider, that has the > scroll bar. :-) I'm talking Qt, you know? Slider (as in QSlider), not scrollbar (as in QScrollba

Re: [patch] fix bug 2629

2007-01-08 Thread Jürgen Spitzmüller
Uwe Stöhr wrote: > This is my first patch to the source code so don't beat me when I did it > wrong, just tell me how it's done correctly and I'll learn my lesson. Welcome, finally :-) > Add fancyplain to Page Style list: > http://bugzilla.lyx.org/show_bug.cgi?id=2629 > > Opinions? This is a fil

Re: SVN changeset 16589: remove shortcuts to bookmark-save 2/3/4/5

2007-01-08 Thread Jean-Marc Lasgouttes
> "Bo" == Bo Peng <[EMAIL PROTECTED]> writes: >> I understand this now, but this is then a regression to LyX 1.4: >> When I'm working at a large document I have often 3-5 bookmarks >> saved for one document and can then jump to the 3-5 different >> positions. This is now not possible in LyX 1.

Re: SVN changeset 16589: remove shortcuts to bookmark-save 2/3/4/5

2007-01-08 Thread Bo Peng
> 2. can save up to 20 bookmarks (compared to 5 in 1.4.x) > 3. can go to a bookmark without active buffer How? You can save up to 20 bookmarks, close all windows, close lyx, restart lyx and you will see the old bookmarks. You can use the bookmarks to open the files at the saved positions. > 5

Re: How to debug LyX on Windows?

2007-01-08 Thread Uwe Stöhr
Bo Peng schrieb: Bo could you then please report it to the Scons people? In contary to me you'll be able to melt the problematic down to a small scons trest script for the bug report. Please CC me the report. I can not do that without access to a 64 bit windows machine. The windows XP license

Re: SVN changeset 16589: remove shortcuts to bookmark-save 2/3/4/5

2007-01-08 Thread Uwe Stöhr
Bo Peng schrieb: Shortcuts for 'bookmark-goto 1/2/3/4/5' still exists. Just remember that the bookmarks are in a stack so the most recent one is always 1. Compared to 1.4.x, the current bookmark system 1. save/restore bookmarks in session. there's a bug, see http://bugzilla.lyx.org/show_bug.c

Re: How to debug LyX on Windows?

2007-01-08 Thread Bo Peng
Bo could you then please report it to the Scons people? In contary to me you'll be able to melt the problematic down to a small scons trest script for the bug report. Please CC me the report. I can not do that without access to a 64 bit windows machine. The windows XP license is simply too expe

Re: SVN changeset 16589: remove shortcuts to bookmark-save 2/3/4/5

2007-01-08 Thread Bo Peng
I understand this now, but this is then a regression to LyX 1.4: When I'm working at a large document I have often 3-5 bookmarks saved for one document and can then jump to the 3-5 different positions. This is now not possible in LyX 1.5svn or what need I do to get this? Shortcuts for 'bookmark

Re: How to debug LyX on Windows?

2007-01-08 Thread Uwe Stöhr
> I guess so. This looks like a scons windows 64 bug but I have no > access to such a machine. Bo could you then please report it to the Scons people? In contary to me you'll be able to melt the problematic down to a small scons trest script for the bug report. Please CC me the report. Thanks

Re: SVN changeset 16589: remove shortcuts to bookmark-save 2/3/4/5

2007-01-08 Thread Uwe Stöhr
Bo Peng schrieb: Uwe> Bo, please revert the shortcut remove for bookmarks. I really Uwe> need them! Why did you cange it? Because there is no such thing as 'bookmark save 2/3/4/5' now. Bookmarks are stored in a stack so you only have 'bookmark-save'. The most frequently used operations should

[patch] fix bug 2721

2007-01-08 Thread Uwe Stöhr
LyX creates dvi documents without proper dimension information http://bugzilla.lyx.org/show_bug.cgi?id=2721 Simply add the [dvips] option to the geometry package when landscape is used. Opinions? regards Uwe

[patch] fix bug 2629

2007-01-08 Thread Uwe Stöhr
This is my first patch to the source code so don't beat me when I did it wrong, just tell me how it's done correctly and I'll learn my lesson. Add fancyplain to Page Style list: http://bugzilla.lyx.org/show_bug.cgi?id=2629 Opinions? regards Uwe Index: src/bufferparams.C

Re: Policy of adding new commands to syntax.default

2007-01-08 Thread José Matos
On Monday 08 January 2007 11:59 pm, Gregor Gorjanc wrote: > Pretty please with a sugar on a top ;) IMHO the only reason for not having an answer at this time is that Jean-Marc and Georg, the developers who know best the code are busy with other issues (including the real life ;-). So please

Re: [Cvslog] r16590 - /lyx-devel/trunk/lib/ui/stdmenus.inc

2007-01-08 Thread Bo Peng
Well, I actually removed "Paste" because it doesn't "feel right" to have it here but not there. Fine with me. - Copy some text in the editor of your choice. - If you paste "Plain text as Lines", each line in the clipboard becomes a separate paragraph in LyX - If you paste "Plain text as

Re: Policy of adding new commands to syntax.default

2007-01-08 Thread Gregor Gorjanc
Gregor Gorjanc <[EMAIL PROTECTED]> writes: > Jean-Marc Lasgouttes ...> writes: > > Gregor> Any chance to port this also to 1_4_X branch? > > > > I just did it.to say > > I have another set of Sweave specific commands. I believe this is the last > one. > Here is the patch. Trunk and 1_4_X branch

Re: [Cvslog] r16590 - /lyx-devel/trunk/lib/ui/stdmenus.inc

2007-01-08 Thread José Matos
On Monday 08 January 2007 11:24 pm, Michael Gerz wrote: > One things that confuses me: > >   - Copy some text in the editor of your choice. >   - If you paste "Plain text as Lines", each line in the clipboard > becomes a separate paragraph in LyX >   - If you paste "Plain text as Paragraphs", all l

Re: [Cvslog] r16590 - /lyx-devel/trunk/lib/ui/stdmenus.inc

2007-01-08 Thread Michael Gerz
Bo Peng schrieb: why do you use the term "Paste" for the last two entries but not for the first two entries. This looks inconsistent. After replacing clipboard with plain text, I somehow feel 'paste selection' emphasizes what these menu items do because there is no contrast between clipboard an

Re: Hebrew encoding (cp1255)

2007-01-08 Thread Dov Feldstern
Georg Baum wrote: Am Montag, 8. Januar 2007 00:09 schrieb Dov Feldstern: I was just testing this and ran into problems with the attached file. The problem occurs when there is encoded text in a \section. I don't know what's causing it, though. But I know. I forgot to handle the case where t

Re: slow opening of docs

2007-01-08 Thread Abdelrazak Younes
Edwin Leuven wrote: Abdelrazak Younes wrote: Could you profile this instead: lyx -e text UserGuide.lyx then you get this: Each sample counts as 0.01 seconds. % cumulative self self total time seconds secondscalls ms/call ms/call name 100.00 0.01 0.0

Re: slow opening of docs

2007-01-08 Thread Edwin Leuven
Abdelrazak Younes wrote: Could you profile this instead: lyx -e text UserGuide.lyx then you get this: Each sample counts as 0.01 seconds. % cumulative self self total time seconds secondscalls ms/call ms/call name 100.00 0.01 0.01110.00

Re: LyX's main window frozen when exporting/viewing documents

2007-01-08 Thread Bennett Helm
On Jan 8, 2007, at 4:01 PM, Peter Kümmel wrote: Abdelrazak Younes wrote: Jean-Marc Lasgouttes wrote: "Peter" == Peter Kümmel <[EMAIL PROTECTED]> writes: There's a bug report about this where it is additionally requested to be able to continue the work in LyX while the export is running:

Re: [Cvslog] r16515 - /lyx-devel/trunk/Status.15x

2007-01-08 Thread Peter Kümmel
Jürgen Spitzmüller wrote: > José Matos wrote: >> Just to make this clear. If the TOC is empty I do not see the slider. > > How would you call the thing between the browser window and the buttons? I think Jose is talking about the vertical slider on the right. > > Jürgen > -- Peter Kümmel

Re: [Cvslog] r16515 - /lyx-devel/trunk/Status.15x

2007-01-08 Thread José Matos
On Monday 08 January 2007 8:53 pm, Jürgen Spitzmüller wrote: > José Matos wrote: > > Just to make this clear. If the TOC is empty I do not see the slider. > > How would you call the thing between the browser window and the buttons? Horizontal slider. ;-) In my defense I was thinking about th

Re: LyX's main window frozen when exporting/viewing documents

2007-01-08 Thread Peter Kümmel
Abdelrazak Younes wrote: > Jean-Marc Lasgouttes wrote: >>> "Peter" == Peter Kümmel <[EMAIL PROTECTED]> writes: >> There's a bug report about this where it is additionally requested to be able to continue the work in LyX while the export is running: http://bugzilla.lyx.org/show_bu

Re: LyX's main window frozen when exporting/viewing documents

2007-01-08 Thread Peter Kümmel
Jean-Marc Lasgouttes wrote: >> "Peter" == Peter Kümmel <[EMAIL PROTECTED]> writes: > >>> There's a bug report about this where it is additionally requested >>> to be able to continue the work in LyX while the export is running: >>> http://bugzilla.lyx.org/show_bug.cgi?id=412 > > Peter> Maybe

Re: [Cvslog] r16515 - /lyx-devel/trunk/Status.15x

2007-01-08 Thread Jürgen Spitzmüller
José Matos wrote: > Just to make this clear. If the TOC is empty I do not see the slider. How would you call the thing between the browser window and the buttons? Jürgen

Re: [PATCH] delay bibfileCache first update

2007-01-08 Thread Jürgen Spitzmüller
Abdelrazak Younes wrote: > Could you test the attached patch nevertheless? Or Georg maybe? It fails whenever different documents use different bib files of the same name (without absolute path). Consider the following case: - I have a file one.lyx in directory /myfiles/one/ that includes a bibf

Re: [PATCH] delay bibfileCache first update

2007-01-08 Thread Georg Baum
Am Montag, 8. Januar 2007 19:29 schrieb Abdelrazak Younes: > Could you test the attached patch nevertheless? Or Georg maybe? I don't have a large natbib test doc, sorry. Georg

Re: [PATCH] delay bibfileCache first update

2007-01-08 Thread Georg Baum
Am Montag, 8. Januar 2007 18:58 schrieb Abdelrazak Younes: > The scanning of the bibtex files should be independent of the loaded > Buffer. Imagine you have two Buffers using the same bibtex file, the > same scanning will need to be done twice for no reason. Or maybe I am > missing something? I

Re: Hebrew encoding (cp1255)

2007-01-08 Thread Georg Baum
Am Montag, 8. Januar 2007 00:09 schrieb Dov Feldstern: > I was just testing this and ran into problems with the attached file. > The problem occurs when there is encoded text in a \section. I don't > know what's causing it, though. But I know. I forgot to handle the case where the paragraph is o

Re: [Cvslog] r16516 - /lyx-devel/trunk/lib/ui/stdmenus.ui

2007-01-08 Thread Bo Peng
They also work for the internal selection, but do not make much sense because you can't paste them somewhere else than the current cursor location as you found out. After you finish your selection cleanup/fixes, I will try to implement 'persistent selection' (show me how, please :-). Then, sudde

Re: [Cvslog] r16515 - /lyx-devel/trunk/Status.15x

2007-01-08 Thread José Matos
On Monday 08 January 2007 9:07 am, Jürgen Spitzmüller wrote: > José Matos wrote: > > Here, using FC6 with gcc-4.1.1-47.fc6 and qt4-4.2.2-1.fc6 I don't see the > > slider and so no crash... Just to make this clear. If the TOC is empty I do not see the slider. > This sound highly obscure. Could y

Re: [Cvslog] r16516 - /lyx-devel/trunk/lib/ui/stdmenus.ui

2007-01-08 Thread Georg Baum
Am Montag, 8. Januar 2007 17:15 schrieb Bo Peng: > > Thanks for the explanation. As I see it, 1 could go, but 2 and 3 are useful. > > There is where current svn at. > > > If they don't make sense on windows, hide the entries there. > > Since they only work for external selection (am I right her

Re: [Cvslog] r16592 - /lyx-devel/trunk/src/graphics/GraphicsConverter.C

2007-01-08 Thread Enrico Forestieri
On Mon, Jan 08, 2007 at 07:25:12PM +0100, Georg Baum wrote: > Am Montag, 8. Januar 2007 04:03 schrieb [EMAIL PROTECTED]: > > Author: forenr > > Date: Mon Jan 8 04:03:12 2007 > > New Revision: 16592 > > > > URL: http://www.lyx.org/trac/changeset/16592 > > Log: > > Fix problem with filename encodi

Re: [Cvslog] r16516 - /lyx-devel/trunk/lib/ui/stdmenus.ui

2007-01-08 Thread Georg Baum
Am Montag, 8. Januar 2007 16:34 schrieb Bo Peng: > 1 is middle-button paste, 2 and 3 are special paste modes. Let us look closely: > > For selection from within lyx, > 1. paste with format, but meaningless > 2. invalid > 3. invalid Not invalid, that was a bug in my getStatus implementation. What

Re: Remaining selection/clipboard problems: How to proceed

2007-01-08 Thread Georg Baum
Am Montag, 8. Januar 2007 10:03 schrieb Jean-Marc Lasgouttes: > I am OK with the fact that the list only contains (contained?) stuff > copied from within LyX, since this is coherent. That is still the case. > Concerning tables and maths, I would prefer them to be added, of > course. I did that.

Re: [Cvslog] r16516 - /lyx-devel/trunk/lib/ui/stdmenus.ui

2007-01-08 Thread Bo Peng
> 2. paste selection as lines is not usable for selection within lyx. You mean because it was always disabled? I fixed that now. So, the only within-lyx usage is to select a piece of text and paste as a paragraph? This is when 'persistent selection' is useful. You can click on another place an

Re: [Cvslog] r16559 - in /lyx-devel/trunk/src/mathed: InsetMathRoot.C ...

2007-01-08 Thread Enrico Forestieri
On Mon, Jan 08, 2007 at 10:12:33AM +0100, Jean-Marc Lasgouttes wrote: > > "Enrico" == Enrico Forestieri <[EMAIL PROTECTED]> writes: > > Enrico> Jean-Marc, may I apply this patch to 1.4.x, too? > > Yes please. Done. -- Enrico

Re: [PATCH] delay bibfileCache first update

2007-01-08 Thread Abdelrazak Younes
Angus Leeming wrote: Abdelrazak Younes <[EMAIL PROTECTED]> writes: Jürgen Spitzmüller wrote: Abdelrazak Younes wrote: The scanning of the bibtex files should be independent of the loaded Buffer. Imagine you have two Buffers using the same bibtex file, the same scanning will need to be done twi

Re: [PATCH] delay bibfileCache first update

2007-01-08 Thread Angus Leeming
Abdelrazak Younes <[EMAIL PROTECTED]> writes: > Jürgen Spitzmüller wrote: > > Abdelrazak Younes wrote: > >> The scanning of the bibtex files should be independent of the loaded > >> Buffer. Imagine you have two Buffers using the same bibtex file, the > >> same scanning will need to be done twice fo

Re: [PATCH] delay bibfileCache first update

2007-01-08 Thread Abdelrazak Younes
Jürgen Spitzmüller wrote: Abdelrazak Younes wrote: Georg said that in his case it could be as long as 20 seconds because of this scanning. That's why I talked about that since the beginning. It don't think it'll take that long (for one scan). I used to have a full TeXLive installation and sev

Re: [PATCH] delay bibfileCache first update

2007-01-08 Thread Jürgen Spitzmüller
Abdelrazak Younes wrote: > Georg said that in his case it could be as long as 20 seconds because of > this scanning. That's why I talked about that since the beginning. It don't think it'll take that long (for one scan). I used to have a full TeXLive installation and several hundreds of bibfiles,

Re: [Cvslog] r16516 - /lyx-devel/trunk/lib/ui/stdmenus.ui

2007-01-08 Thread Georg Baum
Am Sonntag, 7. Januar 2007 21:45 schrieb Bo Peng: > Georg, do you notice that > > 1. for selection from external application, paste selection as lines = > middle-button paste Wrong, it is the other way round: Paste selection as paragraph = middle-button paste. I wrote that in one of my earlier m

Re: slow opening of docs

2007-01-08 Thread Michael Gerz
Edwin, is there any need to further optimize things? I still see some change tracking-related stuff on top of the reports but I wonder whether it really matters... Michael

Re: [PATCH] delay bibfileCache first update

2007-01-08 Thread Abdelrazak Younes
Jürgen Spitzmüller wrote: Abdelrazak Younes wrote: The scanning of the bibtex files should be independent of the loaded Buffer. Imagine you have two Buffers using the same bibtex file, the same scanning will need to be done twice for no reason. Or maybe I am missing something? You're right, th

Re: [Cvslog] r16597 - /lyx-devel/trunk/src/dociterator.h

2007-01-08 Thread Jürgen Spitzmüller
Jean-Marc Lasgouttes wrote: > Abdelrazak> Please try to link in order to make sure. > > It does link, but I do not like the warnings. It does not here: BufferView.o: In function `lyx::BufferView::getStatus(lyx::FuncRequest const&)': /home/juergen/lyx/lyx-qt/src/BufferView.C:611: undefined refere

Re: slow opening of docs

2007-01-08 Thread Angus Leeming
Abdelrazak Younes <[EMAIL PROTECTED]> writes: > > Each sample counts as 0.01 seconds. > > % cumulative self self total > > time seconds secondscalls ms/call ms/call name > > 7.41 0.02 0.02 268500 0.00 0.00 > > lyx::InsetBase::inMathed() const

Re: [Cvslog] r16592 - /lyx-devel/trunk/src/graphics/GraphicsConverter.C

2007-01-08 Thread Georg Baum
Am Montag, 8. Januar 2007 04:03 schrieb [EMAIL PROTECTED]: > Author: forenr > Date: Mon Jan 8 04:03:12 2007 > New Revision: 16592 > > URL: http://www.lyx.org/trac/changeset/16592 > Log: > Fix problem with filename encoding in python script for graphics conversion > > * src/graphics/Graphi

Re: [PATCH] delay bibfileCache first update

2007-01-08 Thread Jürgen Spitzmüller
Abdelrazak Younes wrote: > The scanning of the bibtex files should be independent of the loaded > Buffer. Imagine you have two Buffers using the same bibtex file, the > same scanning will need to be done twice for no reason. Or maybe I am > missing something? You're right, that could be optimized.

Re: slow opening of docs

2007-01-08 Thread Abdelrazak Younes
Edwin Leuven wrote: copy/paste (using the clipboard) from konsole ;-) Thanks Edwin but I suspect that those number are not very meaningful because of the Gui loading etc. Could you profile this instead: lyx -e text UserGuide.lyx or Any other big file that you have. Abdel.

Re: [Cvslog] r16590 - /lyx-devel/trunk/lib/ui/stdmenus.inc

2007-01-08 Thread Bo Peng
why do you use the term "Paste" for the last two entries but not for the first two entries. This looks inconsistent. After replacing clipboard with plain text, I somehow feel 'paste selection' emphasizes what these menu items do because there is no contrast between clipboard and selection as we

Re: [PATCH] delay bibfileCache first update

2007-01-08 Thread Abdelrazak Younes
Jürgen Spitzmüller wrote: Abdelrazak Younes wrote: I think that if you close and reopen the file, the kpsewhich calls will be called several times again. Yes. And everytime you modify (one of) the bibtex inset(s). AFAIU this has to be done, since we need to call kpsewhich for each bibtex fil

Re: [Cvslog] r16590 - /lyx-devel/trunk/lib/ui/stdmenus.inc

2007-01-08 Thread Michael Gerz
[EMAIL PROTECTED] schrieb: Author: bpeng Date: Sun Jan 7 23:52:04 2007 New Revision: 16590 URL: http://www.lyx.org/trac/changeset/16590 Log: lib/ui/stdmenus.inc: change 'Clipboard as xxx' to 'Plain Text as xxx'. I still think we should remove 'Selection as xxx'. Modified: lyx-devel/trunk/

Re: [PATCH] delay bibfileCache first update

2007-01-08 Thread Abdelrazak Younes
Georg Baum wrote: Abdelrazak Younes wrote: Jürgen Spitzmüller wrote: Abdelrazak Younes wrote: I see. There's something wrong with nsetBibtex::getFiles(Buffer const & buffer), buffer is not used at all. Sure it is: Path p(buffer.filePath()); p is not used. It is, by simply instantiating th

Re: [PATCH] delay bibfileCache first update

2007-01-08 Thread Jürgen Spitzmüller
Abdelrazak Younes wrote: > This update showed in Edwin's recent profile results. I reckon that one > does not need to have immediate use of the cache; especially if he/she > just want to visualize the document. > > Juergen, I know you are a heavy bibtex user, is this acceptable to you? The bibfile

Re: [PATCH] delay bibfileCache first update

2007-01-08 Thread Jürgen Spitzmüller
Abdelrazak Younes wrote: > >> The local "vector vec" in > >> this method is the one that needs to be cached. > > > > I don't think so. It is returned in the function. > > I know, but look more closely to the code. My point is that this code is > independent from the given Buffer. AFAIU, BibTex dat

Re: slow opening of docs

2007-01-08 Thread Edwin Leuven
copy/paste (using the clipboard) from konsole ;-) file open: Each sample counts as 0.01 seconds. % cumulative self self total time seconds secondscalls ms/call ms/call name 9.09 0.02 0.02 184108 0.00 0.00 lyx::Paragraph::setFont(int, lyx::

Re: Bugzilla reports

2007-01-08 Thread christian . ridderstrom
On Mon, 8 Jan 2007, José Matos wrote: On Sunday 07 January 2007 9:32 pm, [EMAIL PROTECTED] wrote: Question to people on this list: Do you log in with a password, or do you use a public/private key pair? If it's the key pair, that might explain why Uwe can't commit. I use th

Re: [PATCH] delay bibfileCache first update

2007-01-08 Thread Georg Baum
Abdelrazak Younes wrote: > Jürgen Spitzmüller wrote: >> Abdelrazak Younes wrote: >>> I see. There's something wrong with nsetBibtex::getFiles(Buffer const & >>> buffer), buffer is not used at all. >> >> Sure it is: >> Path p(buffer.filePath()); > > p is not used. It is, by simply instantiating

Re: [PATCH] delay bibfileCache first update

2007-01-08 Thread Abdelrazak Younes
Jürgen Spitzmüller wrote: Abdelrazak Younes wrote: I see. There's something wrong with nsetBibtex::getFiles(Buffer const & buffer), buffer is not used at all. Sure it is: Path p(buffer.filePath()); p is not used. The local "vector vec" in this method is the one that needs to be cached.

Re: [PATCH] delay bibfileCache first update

2007-01-08 Thread Jürgen Spitzmüller
Abdelrazak Younes wrote: > I see. There's something wrong with nsetBibtex::getFiles(Buffer const & > buffer), buffer is not used at all. Sure it is: Path p(buffer.filePath()); > The local "vector vec" in > this method is the one that needs to be cached. I don't think so. It is returned in the

Re: [PATCH] delay bibfileCache first update

2007-01-08 Thread Abdelrazak Younes
Jürgen Spitzmüller wrote: Abdelrazak Younes wrote: yes, I think so. The problem was that we checked if the cache was empty, not if the cache did not contain data for the current buffer. The attached patch fixes this. I'd propose to shove this in despite what we are doing later. I'd also like t

Re: [PATCH] delay bibfileCache first update

2007-01-08 Thread Abdelrazak Younes
Georg Baum wrote: Abdelrazak Younes wrote: Georg Baum wrote: Not all static variables are evil, sometimes they are exactly the right tool for the right job. Sure, when you know what you are doing... Exactly. In this case, at a first glance, I think your suggestion to transfer it to the buff

Re: [PATCH] delay bibfileCache first update

2007-01-08 Thread Jürgen Spitzmüller
Abdelrazak Younes wrote: > So this has nothing to do with those two static variables inside > insetcite.C right? Well, indirectly. The timestamps are stored there. > If I am right, then you just need to transfer the cached_keys variable > to Buffer. > And if I am still right then the problem with

Re: [PATCH] delay bibfileCache first update

2007-01-08 Thread Abdelrazak Younes
Jürgen Spitzmüller wrote: Abdelrazak Younes wrote: I don't see this kpsewhich being called anywhere here. Could you please enlighten us? it gets called via findtexfiles, which is called in insetbibtex, which is queried by the bibfilescache. So this has nothing to do with those two static va

Re: [PATCH] delay bibfileCache first update

2007-01-08 Thread Georg Baum
Abdelrazak Younes wrote: > Georg Baum wrote: >> Not all static variables are evil, >> sometimes they are exactly the right tool for the right job. > > Sure, when you know what you are doing... Exactly. In this case, at a first glance, I think your suggestion to transfer it to the buffer would al

Re: [PATCH] delay bibfileCache first update

2007-01-08 Thread Jürgen Spitzmüller
Abdelrazak Younes wrote: > I don't see this kpsewhich being called anywhere here. Could you please > enlighten us? it gets called via findtexfiles, which is called in insetbibtex, which is queried by the bibfilescache. Jürgen

Re: [PATCH] delay bibfileCache first update

2007-01-08 Thread Jürgen Spitzmüller
Abdelrazak Younes wrote: > But this is still working right? Yes. I'll investigate if I can fix the glitch (which has been there from the beginning I think). Jürgen

Re: [PATCH] delay bibfileCache first update

2007-01-08 Thread Abdelrazak Younes
Jürgen Spitzmüller wrote: Abdelrazak Younes wrote: Did this ever work? It works pretty well (except for the minor glitch I just mentioned). That was my question. And it was a massive speedup improvement. But this is still working right? Abdel.

Re: [PATCH] delay bibfileCache first update

2007-01-08 Thread Abdelrazak Younes
Georg Baum wrote: Abdelrazak Younes wrote: Abdelrazak Younes wrote: Jürgen Spitzmüller wrote: The only case where it doesn't work is if you close and reopen a file without closing LyX, but this is unrelated to your patch (maybe you have an idea nevertheless?) Does natbib support code uses so

Re: [PATCH] delay bibfileCache first update

2007-01-08 Thread Jürgen Spitzmüller
Abdelrazak Younes wrote: > Did this ever work? It works pretty well (except for the minor glitch I just mentioned). And it was a massive speedup improvement. Jürgen

Re: [PATCH] delay bibfileCache first update

2007-01-08 Thread Abdelrazak Younes
Jürgen Spitzmüller wrote: Abdelrazak Younes wrote: And this one: // Cache the labels typedef std::map CachedMap; static CachedMap cached_keys; Well, this could be the culprit indeed. Did I say already that static variables are evil? I'm sure you did. Please feel fr

Re: [PATCH] delay bibfileCache first update

2007-01-08 Thread Georg Baum
Abdelrazak Younes wrote: > Abdelrazak Younes wrote: >> Jürgen Spitzmüller wrote: >>> The only case where it doesn't work is if you close and reopen a file >>> without closing LyX, but this is unrelated to your patch (maybe you >>> have an idea nevertheless?) >> >> Does natbib support code uses so

Re: [PATCH] delay bibfileCache first update

2007-01-08 Thread Jürgen Spitzmüller
Abdelrazak Younes wrote: > And this one: > > // Cache the labels > typedef std::map CachedMap; > static CachedMap cached_keys; Well, this could be the culprit indeed. > Did I say already that static variables are evil? I'm sure you did. Please feel free to change it (or t

Re: [PATCH] delay bibfileCache first update

2007-01-08 Thread Abdelrazak Younes
Abdelrazak Younes wrote: Jürgen Spitzmüller wrote: Abdelrazak Younes wrote: I am not sure I sent out the complete patch earlier and I might have gone too fast with the last commit. Could you please svn update and test a file with natbib citations? In principle this should be OK as the cache is

Re: [PATCH] delay bibfileCache first update

2007-01-08 Thread Abdelrazak Younes
Abdelrazak Younes wrote: Jürgen Spitzmüller wrote: Abdelrazak Younes wrote: I am not sure I sent out the complete patch earlier and I might have gone too fast with the last commit. Could you please svn update and test a file with natbib citations? In principle this should be OK as the cache is

Re: [PATCH] delay bibfileCache first update

2007-01-08 Thread Abdelrazak Younes
Jürgen Spitzmüller wrote: Abdelrazak Younes wrote: I am not sure I sent out the complete patch earlier and I might have gone too fast with the last commit. Could you please svn update and test a file with natbib citations? In principle this should be OK as the cache is private and is always acce

Re: [PATCH] delay bibfileCache first update

2007-01-08 Thread Jürgen Spitzmüller
Abdelrazak Younes wrote: > I am not sure I sent out the complete patch earlier and I might have > gone too fast with the last commit. Could you please svn update and test > a file with natbib citations? In principle this should be OK as the > cache is private and is always accessed through Buffer::

Re: [Cvslog] r16516 - /lyx-devel/trunk/lib/ui/stdmenus.ui

2007-01-08 Thread Bo Peng
Thanks for the explanation. As I see it, 1 could go, but 2 and 3 are useful. There is where current svn at. If they don't make sense on windows, hide the entries there. Since they only work for external selection (am I right here, Georg?), it makes sense to hide them under windows and mac. I

Re: [Cvslog] r16516 - /lyx-devel/trunk/lib/ui/stdmenus.ui

2007-01-08 Thread Jürgen Spitzmüller
Bo Peng wrote: > Therefore, 1 does not make sense (so I did not add it yesterday) and 2 > == partial middle button paste (work only for external selection) and > 3 can be replaced by a shortcut, or middle-button-paste + C-x + paste > clipboard as paragraph. > > IMHO, only 3 has a reason to stay, bu

Re: [PATCH] delay bibfileCache first update

2007-01-08 Thread Abdelrazak Younes
Jürgen Spitzmüller wrote: Jürgen Spitzmüller wrote: The bibfiles cache is needed when you load a document with natbib citations (to correctly display the natbib style in the citation insets). I suspect your patch will break this, and then it'll be not acceptable IMHO. No, it seems to work neve

Re: [Cvslog] r16516 - /lyx-devel/trunk/lib/ui/stdmenus.ui

2007-01-08 Thread Bo Peng
On 1/9/07, Jürgen Spitzmüller <[EMAIL PROTECTED]> wrote: Bo Peng wrote: > --> Paste selection > --> Paste selection as lines > --> Paste selection as paragraph Could you enlighten me what "Paste selection" is in contrast to the other two? Otherwise this looks o.k. to me (though I don't like "pas

Re: 1.5svn: Tidying up LyX/Mac

2007-01-08 Thread Bennett Helm
On Jan 8, 2007, at 9:14 AM, Jean-Marc Lasgouttes wrote: "Bennett" == Bennett Helm <[EMAIL PROTECTED]> writes: Bennett> However, I'm not sure that I'm doing it correctly. open-x11 Bennett> is supposed to start up X11.app, which is the GUI for the X Bennett> server, and previously open-x11 would

Re: Bug 3062 AGAIN! (Re: [PATCH] bug 3062 and getStatus cleanup)

2007-01-08 Thread Bo Peng
The only part that is really relevant to the bug is that I use an ASSERT when the bookmark is not valid in BOOKMARK_GOTO. Using "break;" there is not a good idea, since the problem should never happen. Maybe I understood the problem wrong. It appears to me that bookmark will always be valid thro

Re: [Cvslog] r16597 - /lyx-devel/trunk/src/dociterator.h

2007-01-08 Thread Abdelrazak Younes
Georg Baum wrote: Abdelrazak Younes wrote: From a compiler POV, this should not matter really. It matters a lot. During the compile, the compiler sees only what is in the .h file. It does not know at all in which .C file the code of only declared functions is, so it can't inline it. If that

Re: [patch] bug 3062

2007-01-08 Thread Bo Peng
As I said, it's used if you back from a label to its reference. We have the shortcut Ctrl-< for this (and C-> for the other way round), so it's not wrong. bookmark 0 is used for two internal purposes, and label is one of them. I now see why it is useful to you. I will close the ticket. Bo

Re: [Cvslog] r16597 - /lyx-devel/trunk/src/dociterator.h

2007-01-08 Thread Georg Baum
Jean-Marc Lasgouttes wrote: > Did you manage to do something with insetlatexaccent? Yes. It is basically finished, but lyx2lyx needs a bit of testing. I'll send it when it is finished. Georg

Re: SVN changeset 16589: remove shortcuts to bookmark-save 2/3/4/5

2007-01-08 Thread Bo Peng
Uwe> Bo, please revert the shortcut remove for bookmarks. I really Uwe> need them! Why did you cange it? I agree. What was the rationale for removing them. Do they hurt? Because there is no such thing as 'bookmark save 2/3/4/5' now. Bookmarks are stored in a stack so you only have 'bookmark-sav

Re: [Cvslog] r16597 - /lyx-devel/trunk/src/dociterator.h

2007-01-08 Thread Jean-Marc Lasgouttes
> "Georg" == Georg Baum <[EMAIL PROTECTED]> writes: Georg> Georg, whos holidays are over and who has therefore very little Georg> spare time again. Did you manage to do something with insetlatexaccent? JMarc

Re: [Cvslog] r16597 - /lyx-devel/trunk/src/dociterator.h

2007-01-08 Thread Jean-Marc Lasgouttes
> "Abdelrazak" == Abdelrazak Younes <[EMAIL PROTECTED]> writes: Abdelrazak> Jean-Marc Lasgouttes wrote: >>> "Abdelrazak" == Abdelrazak Younes <[EMAIL PROTECTED]> writes: >> Abdelrazak> Jean-Marc Lasgouttes wrote: > "younes" == younes <[EMAIL PROTECTED]> writes: younes> + /// are we

Re: [Cvslog] r16597 - /lyx-devel/trunk/src/dociterator.h

2007-01-08 Thread Georg Baum
Abdelrazak Younes wrote: > Jean-Marc Lasgouttes wrote: >>> "Abdelrazak" == Abdelrazak Younes >>> <[EMAIL PROTECTED]> writes: >> Abdelrazak> By the way, 'insetlatexaccent.h' uses the same syntax: >> >> Abdelrazak> inline bool canDisplay(); >> >> Abdelrazak> Don't you have a warning for t

Re: [Cvslog] r16597 - /lyx-devel/trunk/src/dociterator.h

2007-01-08 Thread Abdelrazak Younes
Jean-Marc Lasgouttes wrote: It does link, but I do not like the warnings. I will put the code in the header. Abdel.

Re: 1.5svn: Tidying up LyX/Mac

2007-01-08 Thread Jean-Marc Lasgouttes
> "Bennett" == Bennett Helm <[EMAIL PROTECTED]> writes: Bennett> However, I'm not sure that I'm doing it correctly. open-x11 Bennett> is supposed to start up X11.app, which is the GUI for the X Bennett> server, and previously open-x11 would work on its own. Now Bennett> (at least on my Intel M

Re: [Cvslog] r16597 - /lyx-devel/trunk/src/dociterator.h

2007-01-08 Thread Abdelrazak Younes
Jean-Marc Lasgouttes wrote: "Abdelrazak" == Abdelrazak Younes <[EMAIL PROTECTED]> writes: Abdelrazak> Jean-Marc Lasgouttes wrote: "younes" == younes <[EMAIL PROTECTED]> writes: younes> + /// are we in texted?. younes> + /// inlined out because of profiling results under linux when younes> +

Re: LyX's main window frozen when exporting/viewing documents

2007-01-08 Thread Jean-Marc Lasgouttes
> "Abdelrazak" == Abdelrazak Younes <[EMAIL PROTECTED]> writes: >> Maybe a nice progress support would be enough. And make export >> faster, of course. Abdelrazak> What is slow is LateX compilation, not LyX export to Abdelrazak> LateX. It should be OK to allow editing while the LateX Abdelraz

  1   2   >