Re: Unit testing: The Small Plan

2013-05-07 Thread Elmar Hinz
Hello Cyrille, On Wed, May 8, 2013 at 1:28 AM, Cyrille Artho wrote: > Hi Elmar, > I think your plan covers the question "HOW do we want to unit test the > software" well. However, we have not thought much about the "WHAT do we > want to test?" question. Essentially, we need to think about which

Re: growing menu

2013-05-07 Thread Stephan Witt
Am 07.05.2013 um 23:13 schrieb Jean-Marc Lasgouttes : > Le 07/05/13 22:13, Stephan Witt a écrit : >>> I remember that we shared some ideas abot fixing Qt for this \omega >>> problem. Did you find time to try it? >> >> Yes, but it was neither funny nor successful. After learning how to debug the >

Re: Unit testing: The Small Plan

2013-05-07 Thread Cyrille Artho
Hi Elmar, I think your plan covers the question "HOW do we want to unit test the software" well. However, we have not thought much about the "WHAT do we want to test?" question. Essentially, we need to think about which classes/functions to test first. I think it is not realistic to aim for a

Re: Fwd: [Bug 347378] Re: Two columns in Hebrew is in LTR

2013-05-07 Thread Jean-Marc Lasgouttes
Le 07/05/13 23:26, Vincent van Ravesteijn a écrit : >> Yes, I 'fixed' it. >> >> It isn't about tables, it is about a two column document. >> >> It means that you read the right side of the page before the left side. > > Do you have a pointer? Bug 6389. Ouch. I'm glad I did not see it at

Re: DIFFICULTY WITH PASTING IMAGE IN LYX

2013-05-07 Thread Scott Kostyshak
On Wed, May 1, 2013 at 1:26 PM, Vincent van Ravesteijn wrote: > Op 1-5-2013 18:03, Kamal Garg schreef: > > I know Only one way of pasting pictures in lyx, that is by selecting insert > graphic option in toolbar.(shown in image) > > i am trying to copy image(*.jpg).but direct simple way:ctrl+c(cop

Re: Fwd: [Bug 347378] Re: Two columns in Hebrew is in LTR

2013-05-07 Thread Vincent van Ravesteijn
Op 7 mei 2013 23:15 schreef "Jean-Marc Lasgouttes" het volgende: > > Le 07/05/13 22:41, Vincent van Ravesteijn a écrit : > >> Op 7-5-2013 22:31, Jean-Marc Lasgouttes schreef: >>> >>> Does anybody know somethng about this bug? Is it true that tables in >>> ltr mode should have ltr columns? What doe

Re: Fwd: [Bug 347378] Re: Two columns in Hebrew is in LTR

2013-05-07 Thread Jean-Marc Lasgouttes
Le 07/05/13 22:41, Vincent van Ravesteijn a écrit : Op 7-5-2013 22:31, Jean-Marc Lasgouttes schreef: Does anybody know somethng about this bug? Is it true that tables in ltr mode should have ltr columns? What does this mean anyway? JMarc Yes, I 'fixed' it. It isn't about tables, it is about

Re: growing menu

2013-05-07 Thread Jean-Marc Lasgouttes
Le 07/05/13 22:13, Stephan Witt a écrit : I remember that we shared some ideas abot fixing Qt for this \omega problem. Did you find time to try it? Yes, but it was neither funny nor successful. After learning how to debug the Qt frameworks I thought I can fix it. But 1. I cannot find the locati

Re: Fwd: [Bug 347378] Re: Two columns in Hebrew is in LTR

2013-05-07 Thread Vincent van Ravesteijn
Op 7-5-2013 22:31, Jean-Marc Lasgouttes schreef: Does anybody know somethng about this bug? Is it true that tables in ltr mode should have ltr columns? What does this mean anyway? JMarc Yes, I 'fixed' it. It isn't about tables, it is about a two column document. It means that you read the r

Fwd: [Bug 347378] Re: Two columns in Hebrew is in LTR

2013-05-07 Thread Jean-Marc Lasgouttes
Does anybody know somethng about this bug? Is it true that tables in ltr mode should have ltr columns? What does this mean anyway? JMarc Message original Sujet: [Bug 347378] Re: Two columns in Hebrew is in LTR Date : Tue, 07 May 2013 19:08:00 - De : Bug Watch Updater <347

Re: Unit testing: The Small Plan

2013-05-07 Thread Elmar Hinz
> Ideally, one would not need to care about private variables because we are only interested in that the public interface does what it is supposed to do. Right ? Yes, at least as far as it concerns the testing. Denpendency Injection has other aspects. As an example, if there is a class that prin

Re: growing menu

2013-05-07 Thread Stephan Witt
Am 07.05.2013 um 21:50 schrieb Jean-Marc Lasgouttes : > Le 07/05/13 21:46, Stephan Witt a écrit : >> Am 07.05.2013 um 15:47 schrieb Edwin Leuven : >> >>> everytime i close a document, i get a new "reconfigure" item in the >>> LyX menu on my mac >>> >>> again: am i alone? >> >> No. This and the

Re: [2.0.x] compatibility with automake 1.13

2013-05-07 Thread Jean-Marc Lasgouttes
Le 07/05/13 22:04, Jean-Marc Lasgouttes a écrit : Richard, what about this for 2.0.x? JMarc Now with the patches >From c76a91a23261b0f919838461ce23cadfc5ebb519 Mon Sep 17 00:00:00 2001 From: Stephan Witt Date: Fri, 18 Jan 2013 21:17:18 +0100 Subject: [PATCH 1/2] add support for automake 1.13

Re: Unit testing: The Small Plan

2013-05-07 Thread Elmar Hinz
> I would like to see some examples of mocking and injection. > > Thank you, Vincent, > I tried to write some tests using the google framework, and started with > the Buffer class. This immediately gives you the problem that it is > dependent on a large number of other classes. So, this would me

[2.0.x] compatibility with automake 1.13

2013-05-07 Thread Jean-Marc Lasgouttes
Richard, what about this for 2.0.x? JMarc

Re: growing menu

2013-05-07 Thread Jean-Marc Lasgouttes
Le 07/05/13 21:46, Stephan Witt a écrit : Am 07.05.2013 um 15:47 schrieb Edwin Leuven : everytime i close a document, i get a new "reconfigure" item in the LyX menu on my mac again: am i alone? No. This and the crashes are caused by using the Cocoa framework and the code moving the menu item

Re: growing menu

2013-05-07 Thread Stephan Witt
Am 07.05.2013 um 15:47 schrieb Edwin Leuven : > everytime i close a document, i get a new "reconfigure" item in the LyX menu > on my mac > > again: am i alone? No. This and the crashes are caused by using the Cocoa framework and the code moving the menu items from the Tools to the LyX menu. Th

Re: Unit testing: The Small Plan

2013-05-07 Thread Elmar Hinz
On Tue, May 7, 2013 at 9:20 PM, Pavel Sanda wrote: > Elmar Hinz wrote: > > If somebody can give improvements to the plan, it's welcome. > > I guess people will let you do almost anything what you like in test/* > but they will become much more picky when it comes to changes in src/. > Perhaps the

Re: Unit testing: The Small Plan

2013-05-07 Thread Vincent van Ravesteijn
Op 7-5-2013 10:57, Elmar Hinz schreef: Hello list, I'd like to come up with a small plan for getting started with unit testing: I would like to see some examples of mocking and injection. I tried to write some tests using the google framework, and started with the Buffer class. This immedi

Re: Unit testing: The Small Plan

2013-05-07 Thread Pavel Sanda
Elmar Hinz wrote: > If somebody can give improvements to the plan, it's welcome. I guess people will let you do almost anything what you like in test/* but they will become much more picky when it comes to changes in src/. Perhaps the best way is to try example, post patch here and and look what p

Re: growing menu

2013-05-07 Thread Pavel Sanda
Edwin Leuven wrote: > everytime i close a document, i get a new "reconfigure" item in the LyX menu > on my mac > > again: am i alone? IIRC more times reported and nothing new, try bugzilla or archives. I even thought that it was already fixed. Pavel

Re: Unit testing: The Small Plan

2013-05-07 Thread Elmar Hinz
On Tue, May 7, 2013 at 5:58 PM, Richard Heck wrote: > On 05/07/2013 04:57 AM, Elmar Hinz wrote: > >> Hello list, >> >> I'd like to come up with a small plan for getting started with unit >> testing: >> > > I am a total ignoramus when it comes to unit testing, so I will leave it > to others > who

Re: Unit testing: The Small Plan

2013-05-07 Thread Richard Heck
On 05/07/2013 04:57 AM, Elmar Hinz wrote: Hello list, I'd like to come up with a small plan for getting started with unit testing: I am a total ignoramus when it comes to unit testing, so I will leave it to others who actually know something to express a view. Richard

Re: [2.0.x] Some potential bugs spotted by llvm

2013-05-07 Thread Richard Heck
On 05/07/2013 11:38 AM, Jean-Marc Lasgouttes wrote: Richard, Here is a backport of some of my llvm warning squashing effort already applied to master. I selected only the warnings that can lead to bugs. OK to apply to branch? Yes, this looks fine. Richard

[2.0.x] Some potential bugs spotted by llvm

2013-05-07 Thread Jean-Marc Lasgouttes
Richard, Here is a backport of some of my llvm warning squashing effort already applied to master. I selected only the warnings that can lead to bugs. OK to apply to branch? JMarc >From 6e4460ab4c2c8783b664070cf2d1c693106ed8c2 Mon Sep 17 00:00:00 2001 From: Jean-Marc Lasgouttes Date: Fri, 3

Branch Open Again

2013-05-07 Thread Richard Heck
Branch is open again for commits. The official release of 2.0.6 will be tomorrow. Richard

Re: regular crashes on OSX

2013-05-07 Thread Richard Heck
On 05/07/2013 10:03 AM, Anders Ekberg wrote: Same for me. But when I quit LyX, not when only closing a document. Been aiming to post a bug report, but as you I can't really find any consistency in the behavior (or a minimum example). LyX 2.0.5.1 on OS X 10.8.3. Stephan is aware of these problem

Re: regular crashes on OSX

2013-05-07 Thread Anders Ekberg
Same for me. But when I quit LyX, not when only closing a document. Been aiming to post a bug report, but as you I can't really find any consistency in the behavior (or a minimum example). LyX 2.0.5.1 on OS X 10.8.3. /Anders On 2013-05-07 15:45, "Edwin Leuven" wrote: >hi guys, > >i have been e

growing menu

2013-05-07 Thread Edwin Leuven
everytime i close a document, i get a new "reconfigure" item in the LyX menu on my mac again: am i alone? thanks, ed.

regular crashes on OSX

2013-05-07 Thread Edwin Leuven
hi guys, i have been experiencing regular crashes on my mac (see below) they seem to happen when i open or close a document, but not in a systematic way (or at least i haven't found a reproducible way to trigger the bug) am i the only one experiencing these? i am using lyx 2.0.5 from the offic

Unit testing: The Small Plan

2013-05-07 Thread Elmar Hinz
Hello list, I'd like to come up with a small plan for getting started with unit testing: == 1.) Directory structure: "tests/unit/" == * Unit tests stay their own directory separated from src/. * Below "tests/unit" the directory structure mirrors th

Re: Source view window

2013-05-07 Thread Jean-Marc Lasgouttes
Le 07/05/13 06:13, Pavel Sanda a écrit : Jean-Marc Lasgouttes wrote: What about this different logic instead? It relies on the size/height of the window, not on the dock position. No strong preference here. P The advantage is that it also does something reasonable when the widget is not doc