Re: Re: [patch] Introduce abstraction from LaTeX for -- and --- (needed for bug 3647)

José Matos wrote: One cosmetic change that I would like to propose is to change the condition + if len(words) 1 and words[0] == \\begin_inset and \ +(words[1] == ERT or words[1] == Formula or words[1] == IPA): to + if len(words) 1 and words[0] == \\begin_inset and \ +

Re: [patches] Improve error reporting and log parsing

On Tue, Feb 24, 2015 at 1:22 PM, Richard Heck rgh...@lyx.org wrote: On 02/24/2015 12:01 PM, Scott Kostyshak wrote: On Tue, Feb 24, 2015 at 9:30 AM, Richard Heck rgh...@lyx.org wrote: On 02/22/2015 03:45 PM, Scott Kostyshak wrote: 0004-Allow-cloned-buffers-to-give-alerts-in-runLaTeX.patch -

Re: [patch] Introduce abstraction from LaTeX for -- and --- (needed for bug 3647)

Jean-Marc Lasgouttes wrote: Some remarks: * in Text::insertChar, you do not test for typewriter font. Why is that? What do you expect with LyX-Code, for example? You are right, I forgot that. * I still think that cycling would be good, that is \emdash+minus=minus. OK, I'll implement

Re: [LyX/master] Do not mix several names for the same variable

Jean-Marc Lasgouttes wrote: Georg, please check, this is recent code of yours. The new code works as well as the old one. I think this is an area where coverity could improve. Georg

Re: [patches] Improve error reporting and log parsing

On 02/22/2015 03:45 PM, Scott Kostyshak wrote: 0004-Allow-cloned-buffers-to-give-alerts-in-runLaTeX.patch - This is the patch I am least confident about. Conditioning on !buffer.isClone() caused the condition to always fail so the alerts were never shown. Is that conditioning still needed? I

Re: [patches] Improve error reporting and log parsing

On Tue, Feb 24, 2015 at 9:30 AM, Richard Heck rgh...@lyx.org wrote: On 02/22/2015 03:45 PM, Scott Kostyshak wrote: 0004-Allow-cloned-buffers-to-give-alerts-in-runLaTeX.patch - This is the patch I am least confident about. Conditioning on !buffer.isClone() caused the condition to always fail

Re: [patches] Improve error reporting and log parsing

On 02/24/2015 12:01 PM, Scott Kostyshak wrote: On Tue, Feb 24, 2015 at 9:30 AM, Richard Heck rgh...@lyx.org wrote: On 02/22/2015 03:45 PM, Scott Kostyshak wrote: 0004-Allow-cloned-buffers-to-give-alerts-in-runLaTeX.patch - This is the patch I am least confident about. Conditioning on

Re: [LyX/master] Some performance stuff reported by cppcheck

On Tue, Feb 24, 2015 at 12:38 PM, Jean-Marc Lasgouttes lasgout...@lyx.org wrote: commit b627b8701b6598f5402cbab55a83026c9e3b1e86 Author: Jean-Marc Lasgouttes lasgout...@lyx.org Date: Tue Feb 24 10:17:45 2015 +0100 Some performance stuff reported by cppcheck I cannot use left and right

Re: [LyX/master] Some performance stuff reported by cppcheck

On 02/24/2015 05:45 PM, Scott Kostyshak wrote: On Tue, Feb 24, 2015 at 12:38 PM, Jean-Marc Lasgouttes lasgout...@lyx.org wrote: commit b627b8701b6598f5402cbab55a83026c9e3b1e86 Author: Jean-Marc Lasgouttes lasgout...@lyx.org Date: Tue Feb 24 10:17:45 2015 +0100 Some performance stuff

cursor movement / usability annoyances

I am a LyX lover. However ... :) ... inside equations and tables, Lyx's cursor movement rules drive me nuts! I dislike mousing, and prefer cursor-movement keys as more predictable and requiring less conscious control. But the key-based motion actually feels quite unpredictable and---

Re: [patches] Improve error reporting and log parsing

On 02/22/2015 03:45 PM, Scott Kostyshak wrote: 0004-Allow-cloned-buffers-to-give-alerts-in-runLaTeX.patch - This is the patch I am least confident about. Conditioning on !buffer.isClone() caused the condition to always fail so the alerts were never shown. Is that conditioning still needed? I

Re: [patches] Improve error reporting and log parsing

On Tue, Feb 24, 2015 at 9:30 AM, Richard Heck wrote: > On 02/22/2015 03:45 PM, Scott Kostyshak wrote: >> >> 0004-Allow-cloned-buffers-to-give-alerts-in-runLaTeX.patch >> - This is the patch I am least confident about. Conditioning on >> !buffer.isClone() caused the condition to

Re: [patches] Improve error reporting and log parsing

On 02/24/2015 12:01 PM, Scott Kostyshak wrote: On Tue, Feb 24, 2015 at 9:30 AM, Richard Heck wrote: On 02/22/2015 03:45 PM, Scott Kostyshak wrote: 0004-Allow-cloned-buffers-to-give-alerts-in-runLaTeX.patch - This is the patch I am least confident about. Conditioning on

Re: [LyX/master] Do not mix several names for the same variable

Jean-Marc Lasgouttes wrote: > Georg, please check, this is recent code of yours. The new code works as well as the old one. I think this is an area where coverity could improve. Georg

Re: Re: [patch] Introduce abstraction from LaTeX for -- and --- (needed for bug 3647)

José Matos wrote: > One cosmetic change that I would like to propose is to change the > condition > > + if len(words) > 1 and words[0] == "\\begin_inset" and \ > +(words[1] == "ERT" or words[1] == "Formula" or words[1] == "IPA"): > > to > > + if len(words) > 1 and words[0] ==

Re: [patch] Introduce abstraction from LaTeX for -- and --- (needed for bug 3647)

Jean-Marc Lasgouttes wrote: > Some remarks: > > * in Text::insertChar, you do not test for typewriter font. Why is that? > What do you expect with LyX-Code, for example? You are right, I forgot that. > * I still think that cycling would be good, that is \emdash+minus=>minus. OK, I'll

Re: [patches] Improve error reporting and log parsing

On Tue, Feb 24, 2015 at 1:22 PM, Richard Heck wrote: > On 02/24/2015 12:01 PM, Scott Kostyshak wrote: >> >> On Tue, Feb 24, 2015 at 9:30 AM, Richard Heck wrote: >>> >>> On 02/22/2015 03:45 PM, Scott Kostyshak wrote:

cursor movement / usability annoyances

I am a LyX lover. However ... :) ... inside equations and tables, Lyx's cursor movement "rules" drive me nuts! I dislike mousing, and prefer cursor-movement keys as more predictable and requiring less conscious control. But the key-based motion actually feels quite unpredictable and---

Re: [LyX/master] Some performance stuff reported by cppcheck

On Tue, Feb 24, 2015 at 12:38 PM, Jean-Marc Lasgouttes wrote: > commit b627b8701b6598f5402cbab55a83026c9e3b1e86 > Author: Jean-Marc Lasgouttes > Date: Tue Feb 24 10:17:45 2015 +0100 > > Some performance stuff reported by cppcheck I cannot use left

Re: [LyX/master] Some performance stuff reported by cppcheck

On 02/24/2015 05:45 PM, Scott Kostyshak wrote: On Tue, Feb 24, 2015 at 12:38 PM, Jean-Marc Lasgouttes wrote: commit b627b8701b6598f5402cbab55a83026c9e3b1e86 Author: Jean-Marc Lasgouttes Date: Tue Feb 24 10:17:45 2015 +0100 Some performance stuff