Re: [LyX/master] Follow some of the performance advice from cppcheck

2019-09-13 Thread Kornel Benko
Am Freitag, 13. September 2019, 19:01:14 CEST schrieb Jean-Marc Lasgouttes: > Le 13/09/2019 à 17:29, Kornel Benko a écrit : > > Am Freitag, 13. September 2019, 16:15:52 CEST schrieb Jean-Marc Lasgouttes: > >> commit 714113655ad434f9a73d0101038568d59311af72 > >> Author: Jean-Marc Lasgouttes > >>

Possible bug found by cppcheck

2019-09-13 Thread Jean-Marc Lasgouttes
In DocFileNamefilename::mangledFileName, I see: string const name = absFileName(); // Now the real work string mname = os::internal_path(name); // Remove the extension. mname = support::changeExtension(name, string()); So the assignment of internal_path

Re: [LyX/master] Follow some of the performance advice from cppcheck

2019-09-13 Thread Jean-Marc Lasgouttes
Le 13/09/2019 à 17:29, Kornel Benko a écrit : Am Freitag, 13. September 2019, 16:15:52 CEST schrieb Jean-Marc Lasgouttes: commit 714113655ad434f9a73d0101038568d59311af72 Author: Jean-Marc Lasgouttes Date: Fri Sep 13 16:23:49 2019 +0200 Follow some of the performance advice from

Re: [LyX/master] Follow some of the performance advice from cppcheck

2019-09-13 Thread Jürgen Spitzmüller
Am Freitag, den 13.09.2019, 11:49 -0400 schrieb Richard Kimberly Heck: > Looking at git blame, it definitely looks like just an oversight. If blame blames me, this is most certainly true. Jürgen signature.asc Description: This is a digitally signed message part

Re: [LyX/master] Follow some of the performance advice from cppcheck

2019-09-13 Thread Richard Kimberly Heck
On 9/13/19 11:09 AM, Jean-Marc Lasgouttes wrote: > Le 13 septembre 2019 16:15:52 GMT+02:00, Jean-Marc Lasgouttes > a écrit : >> commit 714113655ad434f9a73d0101038568d59311af72 >> Author: Jean-Marc Lasgouttes >> Date: Fri Sep 13 16:23:49 2019 +0200 >> >>Follow some of the performance

Re: [LyX/master] Follow some of the performance advice from cppcheck

2019-09-13 Thread Kornel Benko
Am Freitag, 13. September 2019, 16:15:52 CEST schrieb Jean-Marc Lasgouttes: > commit 714113655ad434f9a73d0101038568d59311af72 > Author: Jean-Marc Lasgouttes > Date: Fri Sep 13 16:23:49 2019 +0200 > > Follow some of the performance advice from cppcheck > > Most of that is changing

Re: [LyX/master] Follow some of the performance advice from cppcheck

2019-09-13 Thread Jean-Marc Lasgouttes
Le 13 septembre 2019 16:15:52 GMT+02:00, Jean-Marc Lasgouttes a écrit : >commit 714113655ad434f9a73d0101038568d59311af72 >Author: Jean-Marc Lasgouttes >Date: Fri Sep 13 16:23:49 2019 +0200 > >Follow some of the performance advice from cppcheck > >Most of that is changing string to

Re: Notes inherit surrounding font

2019-09-13 Thread Daniel
On 2019-09-13 10:51, Jean-Marc Lasgouttes wrote: Le 13/09/2019 à 10:01, Daniel a écrit : Did I answer all questions? ;) Yes, but "let me say it again" in a strange way. ;) Sorry for that, I was running out of wise words due to the impression that we are talking past each other. This was

Re: LinkBack support (on MacOS)

2019-09-13 Thread Patrick De Visschere
> On 12 Sep 2019, at 18:23, Stephan Witt wrote: > > Am 08.09.2019 um 10:57 schrieb Stephan Witt : >> >> Am 25.09.2018 um 17:21 schrieb Stephan Witt : >>> >>> Am 25.09.2018 um 17:10 schrieb Jürgen Spitzmüller : Am Freitag, den 21.09.2018, 15:55 +0200 schrieb pdv: > I came

Re: Notes inherit surrounding font

2019-09-13 Thread Jean-Marc Lasgouttes
Le 13/09/2019 à 10:01, Daniel a écrit : Did I answer all questions? ;) Yes, but "let me say it again" in a strange way. ;) Sorry for that, I was running out of wise words due to the impression that we are talking past each other. This was unwarranted. JMarc

Re: Notes inherit surrounding font

2019-09-13 Thread Daniel
On 13/9/19 9:23, Jean-Marc Lasgouttes wrote: Le 13/09/2019 à 07:07, Daniel a écrit : On 2019-09-04 16:30, Jean-Marc Lasgouttes wrote: I propose in the following patch to reset the outer layout to Plain if it only contains the newly insert inset. It seems to me that my original example had

Re: Added docker image for LyX on Dockerhub

2019-09-13 Thread Jean-Marc Lasgouttes
Le 13/09/2019 à 09:38, Timo Kluck a écrit : Hi LyX developers, I just added a docker image for LyX to dockerhub: https://hub.docker.com/r/tkluck/lyx . It's just Ubuntu's packaged version, including TeX Live and inkscape, and it's intended use is to build exports from your LyX source

Added docker image for LyX on Dockerhub

2019-09-13 Thread Timo Kluck
Hi LyX developers, I just added a docker image for LyX to dockerhub: https://hub.docker.com/r/tkluck/lyx . It's just Ubuntu's packaged version, including TeX Live and inkscape, and it's intended use is to build exports from your LyX source reproducibly. For example, I have my thesis sources in a

Re: [LyX/master] Reset layout when inserting an inset over full paragraph(s)

2019-09-13 Thread Jean-Marc Lasgouttes
Le 13/09/2019 à 05:00, Pavel Sanda a écrit : On Thu, Sep 12, 2019 at 10:04:19AM +0200, Jean-Marc Lasgouttes wrote: But if there is a consensus about 2.3, I am OK with it. I was not actually suggesting to push it into official 2.3.x, just wanted to know whether putting into my private patchset

Re: [LyX/master] Reset layout when inserting an inset over full paragraph(s)

2019-09-13 Thread Jean-Marc Lasgouttes
Le 13/09/2019 à 00:55, Richard Kimberly Heck a écrit : We are sorely lacking daily builds for stable releases. If we knew how to automate these, that could be done by our CI tools. I have taken a look at the Ubuntu side of things, and ran away screaming. I do not have the time to invest in even

Re: Notes inherit surrounding font

2019-09-13 Thread Jean-Marc Lasgouttes
Le 13/09/2019 à 07:07, Daniel a écrit : On 2019-09-04 16:30, Jean-Marc Lasgouttes wrote: I propose in the following patch to reset the outer layout to Plain if it only contains the newly insert inset. It seems to me that my original example had some specific features that triggered a