Re: [LyX/master] Fix the way the top and bottom selection are drawn

2022-01-27 Thread Daniel
On 2022-01-27 15:52, Jean-Marc Lasgouttes wrote: Le 27/01/2022 à 14:59, Daniel a écrit : I guess in Scott's after.png the selection looks a bit confusing (as in unexpected because other applications don't highlight that way). Isn't there another way to select the "Chapter" label? Do you have

Re: Failure to compile with gcc-12 (2.3.x)

2022-01-27 Thread Scott Kostyshak
On Thu, Jan 27, 2022 at 03:07:25PM +, José Abílio Matos wrote: > On Thursday, 27 January 2022 13.09.09 WET Scott Kostyshak wrote: > > Except for that issue does it build with -Werror ? > > > > Scott > > As Jean-Marc said the compilation has lots of warnings. Some of them are not > our fault,

Re: SIGSEGV on master regarding math completion

2022-01-27 Thread Scott Kostyshak
On Thu, Jan 27, 2022 at 05:26:33PM +0100, Jean-Marc Lasgouttes wrote: > Le 10/01/2022 à 03:49, Scott Kostyshak a écrit : > > To reproduce: > > > > 1. Start a new document. > > 2. Ctrl + m to start math inset. > > 3. Type \phantomx. Note that \phantomx is not a command so don't > > expect it to

Re: [LyX/master] Fix the way the top and bottom selection are drawn

2022-01-27 Thread Scott Kostyshak
On Thu, Jan 27, 2022 at 03:52:14PM +0100, Jean-Marc Lasgouttes wrote: > > Le 27/01/2022 à 14:59, Daniel a écrit : > > I guess in Scott's after.png the selection looks a bit confusing (as in > > unexpected because other applications don't highlight that way). Isn't > > there another way to select t

Re: [LyX/master] Fix compilation with gcc-12

2022-01-27 Thread Kornel Benko
Am Thu, 27 Jan 2022 16:27:26 + schrieb José Abílio Matos : > On Thursday, 27 January 2022 15.44.56 WET José Abílio Matos wrote: > > The previous patch was all that it was required to compile lyx-2.4 with > > gcc-12. :-) > > But then it does not run: > > $ src/lyx > src/lyx: /lib64/libstdc++.

Re: Failure to compile with gcc-12 (2.3.x)

2022-01-27 Thread Kornel Benko
Am Thu, 27 Jan 2022 16:22:18 + schrieb José Abílio Matos : > On Thursday, 27 January 2022 15.48.33 WET Kornel Benko wrote: > > This one may be needed for 2.4.0 version of lyxfind.cpp too. > > You are right but for some reason I got away without this fix, only the > cstring of the other threa

Re: [LyX/master] Fix compilation with gcc-12

2022-01-27 Thread José Abílio Matos
On Thursday, 27 January 2022 15.44.56 WET José Abílio Matos wrote: > The previous patch was all that it was required to compile lyx-2.4 with > gcc-12. :-) But then it does not run: $ src/lyx src/lyx: /lib64/libstdc++.so.6: version `GLIBCXX_3.4.30' not found (required by src/lyx) it is not using

Re: SIGSEGV on master regarding math completion

2022-01-27 Thread Jean-Marc Lasgouttes
Le 10/01/2022 à 03:49, Scott Kostyshak a écrit : To reproduce: 1. Start a new document. 2. Ctrl + m to start math inset. 3. Type \phantomx. Note that \phantomx is not a command so don't expect it to be recognized. 4. Press , , to delete the "x" and the "m". 5. Type "m" to finish "phantom".

Re: Failure to compile with gcc-12 (2.3.x)

2022-01-27 Thread José Abílio Matos
On Thursday, 27 January 2022 15.48.33 WET Kornel Benko wrote: > This one may be needed for 2.4.0 version of lyxfind.cpp too. You are right but for some reason I got away without this fix, only the cstring of the other thread. (BTW I am puzzled) The reason could be some change in the code between

Re: Failure to compile with gcc-12 (2.3.x)

2022-01-27 Thread Kornel Benko
Am Thu, 27 Jan 2022 15:05:34 + schrieb José Abílio Matos : > lyxfind.cpp:55:1: note: 'std::ostream_iterator' is defined in header > ''; did > you forget to '#include '? > >    54 | #include "support/regex.h" > >   +++ |+#include > >    55 | This one may be needed for 2.4.0 version of lyx

Re: [LyX/master] Fix compilation with gcc-12

2022-01-27 Thread José Abílio Matos
On Thursday, 27 January 2022 15.06.43 WET José Matos wrote: > commit b73ab0256d113571174fed4b2a3405fe8c44d297 > Author: José Matos > Date: Thu Jan 27 15:37:45 2022 + > > Fix compilation with gcc-12 > --- > src/insets/InsetListings.cpp |1 + > 1 files changed, 1 insertions(+), 0 de

Re: Failure to compile with gcc-12 (2.3.x)

2022-01-27 Thread José Abílio Matos
On Thursday, 27 January 2022 13.09.09 WET Scott Kostyshak wrote: > Except for that issue does it build with -Werror ? > > Scott As Jean-Marc said the compilation has lots of warnings. Some of them are not our fault, so I am not sure if it is possible to filter system warnings from - Werror. :-)

Re: Failure to compile with gcc-12 (2.3.x)

2022-01-27 Thread José Abílio Matos
On Thursday, 27 January 2022 13.52.56 WET Jean-Marc Lasgouttes wrote: > This one is a warning, but you cut part of it out. For complete sake the complete diagnose (warnings and errors) is here: make[4]: Entering directory '/builddir/build/BUILD/lyx-2.3.6.1/src' g++ -DHAVE_CONFIG_H -I. -I.. -I../

Re: [LyX/master] Fix the way the top and bottom selection are drawn

2022-01-27 Thread Jean-Marc Lasgouttes
Le 27/01/2022 à 14:59, Daniel a écrit : I guess in Scott's after.png the selection looks a bit confusing (as in unexpected because other applications don't highlight that way). Isn't there another way to select the "Chapter" label? Do you have examples of applications that show labels on top

Re: [LyX/master] Fix the way the top and bottom selection are drawn

2022-01-27 Thread Daniel
On 27/01/2022 14:34, Jean-Marc Lasgouttes wrote: Le 27/01/2022 à 14:06, Scott Kostyshak a écrit : On Tue, Dec 07, 2021 at 05:50:09PM +0100, Jean-Marc Lasgouttes wrote: commit 2fd8b6fc2a402c00e78f71d7d6ad986270283a3e Author: Jean-Marc Lasgouttes Date:   Tue Dec 7 18:15:01 2021 +0100 Fix t

Re: Failure to compile with gcc-12 (2.3.x)

2022-01-27 Thread Jean-Marc Lasgouttes
Le 27/01/2022 à 14:09, Scott Kostyshak a écrit : On Thu, Jan 27, 2022 at 01:04:12PM +, José Abílio Matos wrote: Hi, we are at the time of year again. :-) The gcc project will release version 12 and in Fedora we are rebuilding all packages with it. There is a failure to build 2.3.x (e.g.

Re: [LyX/master] Fix the way the top and bottom selection are drawn

2022-01-27 Thread Jean-Marc Lasgouttes
Le 27/01/2022 à 14:06, Scott Kostyshak a écrit : On Tue, Dec 07, 2021 at 05:50:09PM +0100, Jean-Marc Lasgouttes wrote: commit 2fd8b6fc2a402c00e78f71d7d6ad986270283a3e Author: Jean-Marc Lasgouttes Date: Tue Dec 7 18:15:01 2021 +0100 Fix the way the top and bottom selection are drawn

Re: Failure to compile with gcc-12 (2.3.x)

2022-01-27 Thread Scott Kostyshak
On Thu, Jan 27, 2022 at 01:04:12PM +, José Abílio Matos wrote: > Hi, > we are at the time of year again. :-) > > The gcc project will release version 12 and in Fedora we are rebuilding all > packages with it. > > There is a failure to build 2.3.x (e.g. on x86-54): > https://kojipkgs.fedora

Re: [LyX/master] Fix the way the top and bottom selection are drawn

2022-01-27 Thread Scott Kostyshak
On Tue, Dec 07, 2021 at 05:50:09PM +0100, Jean-Marc Lasgouttes wrote: > commit 2fd8b6fc2a402c00e78f71d7d6ad986270283a3e > Author: Jean-Marc Lasgouttes > Date: Tue Dec 7 18:15:01 2021 +0100 > > Fix the way the top and bottom selection are drawn > > When a selection extends on more t

Failure to compile with gcc-12 (2.3.x)

2022-01-27 Thread José Abílio Matos
Hi, we are at the time of year again. :-) The gcc project will release version 12 and in Fedora we are rebuilding all packages with it. There is a failure to build 2.3.x (e.g. on x86-54): https://kojipkgs.fedoraproject.org//work/tasks/4412/81984412/build.log 73 | class MatchString : public