Re: [PATCH] Making Update::SinglePar work inside insets

2023-07-17 Thread Scott Kostyshak
On Mon, Jul 17, 2023 at 11:19:22PM +0200, Jean-Marc Lasgouttes wrote: > What I cannot fix easily, though is that if I insert characters just before > the branch (in same paragraph), things are ugly again because the whole > branch has to be typeset again and again. Indeed, that is still slow. In

Re: [PATCH] Making Update::SinglePar work inside insets

2023-07-17 Thread Jean-Marc Lasgouttes
Le 17/07/2023 à 18:00, Scott Kostyshak a écrit : On Mon, Jul 17, 2023 at 04:03:32PM +0200, Jean-Marc Lasgouttes wrote: Hello, This patch tries to address #12297, where typing in the big branch in the attached big-inset.23.lyx file is painfully slow. Works well! I just did some brief testing.

Re: ./configure goes through, build fails with no library

2023-07-17 Thread Jean-Marc Lasgouttes
Le 17/07/2023 à 21:14, Enrico Forestieri a écrit : Take into account that modules differ from a Qt version to another, so we would still need 3 different paths. A helper function with parameters? Moreover, I think that the Qt4 version would need a different approach, even if the info can be

Re: ./configure goes through, build fails with no library

2023-07-17 Thread Enrico Forestieri
On Mon, Jul 17, 2023 at 08:59:13PM +0200, Jean-Marc Lasgouttes wrote: Le 17/07/2023 à 20:56, Enrico Forestieri a écrit : I expect it to work with Qt5, at least. But why should we do that? Remember: don't fix it if it ain't broken. Because the rest is a mess and we have now 3 different paths

Re: ./configure goes through, build fails with no library

2023-07-17 Thread Jean-Marc Lasgouttes
Le 17/07/2023 à 20:56, Enrico Forestieri a écrit : I expect it to work with Qt5, at least. But why should we do that? Remember: don't fix it if it ain't broken. Because the rest is a mess and we have now 3 different paths to do the same thing. Are there known cases where qmake is not enough

Re: ./configure goes through, build fails with no library

2023-07-17 Thread Enrico Forestieri
On Mon, Jul 17, 2023 at 03:56:40PM +0200, Jean-Marc Lasgouttes wrote: This is great. Concerning replacing most of the qt.m4 code with the qmake-based solution, would you expect it to work? This is post-2.4, of course. I expect it to work with Qt5, at least. But why should we do that?

Re: [LyX/master] Support protected and thin space in simple search (#12836)

2023-07-17 Thread Kornel Benko
Am Mon, 17 Jul 2023 15:46:34 +0200 (CEST) schrieb Juergen Spitzmueller : > commit f6f936e3d049c05ad0795c32696df895d8b61313 > Author: Juergen Spitzmueller > Date: Mon Jul 17 16:58:04 2023 +0200 > > Support protected and thin space in simple search (#12836) Thanks. Kornel

Re: [PATCH] Making Update::SinglePar work inside insets

2023-07-17 Thread Scott Kostyshak
On Mon, Jul 17, 2023 at 04:03:32PM +0200, Jean-Marc Lasgouttes wrote: > Hello, > > This patch tries to address #12297, where typing in the big branch in the > attached big-inset.23.lyx file is painfully slow. > > To this end, I made BufferView::singleParUpdate, and the result looks great. >

Re: ./configure goes through, build fails with no library

2023-07-17 Thread Jean-Marc Lasgouttes
Le 15/07/2023 à 15:31, Enrico Forestieri a écrit : On Sat, Jul 15, 2023 at 01:47:56PM +0200, Jean-Marc Lasgouttes wrote: Le 15/07/2023 à 13:44, Enrico Forestieri a écrit : It suffices replacing LYX_WARNING with AC_MSG_ERROR. However, in this case configure stops there. This is whaty we do

Re: [LyX/master] Assure language is properly closed before non-inheriting inset.

2023-07-17 Thread Scott Kostyshak
On Mon, Jul 17, 2023 at 01:21:07PM +0200, Jürgen Spitzmüller wrote: > Am Sonntag, dem 16.07.2023 um 17:00 -0400 schrieb Scott Kostyshak: > > I only get the exception when compiling the ja Math.lyx from the > > 2.3.x branch. > > I see, thanks. Should be fixed. Thanks, looks good. I took a look at

Re: [LyX/master] Assure language is properly closed before non-inheriting inset.

2023-07-17 Thread Jürgen Spitzmüller
Am Sonntag, dem 16.07.2023 um 17:00 -0400 schrieb Scott Kostyshak: > I only get the exception when compiling the ja Math.lyx from the > 2.3.x branch. I see, thanks. Should be fixed. -- Jürgen signature.asc Description: This is a digitally signed message part -- lyx-devel mailing list