On Fri, Jan 12, 2007 at 11:09:03PM +0100, Abdelrazak Younes wrote:
Andre Poenitz wrote:
Does this actually help?
I would have expected that moving the method definition to the header
would have been needed, too (possiby causing additional header pulled
in)
Year, that's what I ended up
Andre Poenitz wrote:
On Fri, Jan 12, 2007 at 11:09:03PM +0100, Abdelrazak Younes wrote:
Andre Poenitz wrote:
Does this actually help?
I would have expected that moving the method definition to the header
would have been needed, too (possiby causing additional header pulled
in)
Year, that's
On Fri, Jan 12, 2007 at 11:09:03PM +0100, Abdelrazak Younes wrote:
> Andre Poenitz wrote:
> >Does this actually help?
> >
> >I would have expected that moving the method definition to the header
> >would have been needed, too (possiby causing additional header pulled
> >in)
>
> Year, that's what
Andre Poenitz wrote:
On Fri, Jan 12, 2007 at 11:09:03PM +0100, Abdelrazak Younes wrote:
Andre Poenitz wrote:
Does this actually help?
I would have expected that moving the method definition to the header
would have been needed, too (possiby causing additional header pulled
in)
Year, that's
On Mon, Jan 08, 2007 at 10:50:17AM -, [EMAIL PROTECTED] wrote:
Author: younes
Date: Mon Jan 8 11:50:15 2007
New Revision: 16597
URL: http://www.lyx.org/trac/changeset/16597
Log:
performance fix.
Modified:
lyx-devel/trunk/src/dociterator.h
Modified:
Abdelrazak Younes wrote:
Hum, maybe gcc needs the 'virtual' keyword. Could you try it please:
inline virtual bool inMathed() const;
inline virtual bool inTexted() const;
I think virtual methods cannot be inlined because the decision which
method to call is done at runtime but for
Andre Poenitz wrote:
Does this actually help?
I would have expected that moving the method definition to the header
would have been needed, too (possiby causing additional header pulled
in)
Year, that's what I ended up doing in a following commit.
Abdel.
On Mon, Jan 08, 2007 at 10:50:17AM -, [EMAIL PROTECTED] wrote:
> Author: younes
> Date: Mon Jan 8 11:50:15 2007
> New Revision: 16597
>
> URL: http://www.lyx.org/trac/changeset/16597
> Log:
> performance fix.
>
> Modified:
> lyx-devel/trunk/src/dociterator.h
>
> Modified:
Abdelrazak Younes wrote:
Hum, maybe gcc needs the 'virtual' keyword. Could you try it please:
inline virtual bool inMathed() const;
inline virtual bool inTexted() const;
I think virtual methods cannot be inlined because the decision which
method to call is done at runtime but for
Andre Poenitz wrote:
Does this actually help?
I would have expected that moving the method definition to the header
would have been needed, too (possiby causing additional header pulled
in)
Year, that's what I ended up doing in a following commit.
Abdel.
younes == younes [EMAIL PROTECTED] writes:
younes + /// are we in texted?.
younes + /// inlined out because of profiling results under linux when
younes + // opening a document.
younes + inline bool inTexted() const;
Abdel, are you sure this is a proper syntax? My compiler complains
with
Jean-Marc Lasgouttes wrote:
younes == younes [EMAIL PROTECTED] writes:
younes + /// are we in texted?.
younes + /// inlined out because of profiling results under linux when
younes + // opening a document.
younes + inline bool inTexted() const;
Abdel, are you sure this is a proper
Jean-Marc Lasgouttes wrote:
younes == younes [EMAIL PROTECTED] writes:
younes + /// are we in texted?.
younes + /// inlined out because of profiling results under linux when
younes + // opening a document.
younes + inline bool inTexted() const;
Abdel, are you sure this is a proper
Jean-Marc Lasgouttes wrote:
Abdelrazak == Abdelrazak Younes [EMAIL PROTECTED] writes:
Abdelrazak Jean-Marc Lasgouttes wrote:
younes == younes [EMAIL PROTECTED] writes:
younes + /// are we in texted?. younes + /// inlined out because
of profiling results under linux when younes + // opening
Jean-Marc Lasgouttes wrote:
It does link, but I do not like the warnings.
I will put the code in the header.
Abdel.
Abdelrazak Younes wrote:
Jean-Marc Lasgouttes wrote:
Abdelrazak == Abdelrazak Younes
[EMAIL PROTECTED] writes:
Abdelrazak By the way, 'insetlatexaccent.h' uses the same syntax:
Abdelrazak inline bool canDisplay();
Abdelrazak Don't you have a warning for this one?
No, because this
Abdelrazak == Abdelrazak Younes [EMAIL PROTECTED] writes:
Abdelrazak Jean-Marc Lasgouttes wrote:
Abdelrazak == Abdelrazak Younes [EMAIL PROTECTED] writes:
Abdelrazak Jean-Marc Lasgouttes wrote:
younes == younes [EMAIL PROTECTED] writes:
younes + /// are we in texted?. younes + /// inlined out
Georg == Georg Baum [EMAIL PROTECTED] writes:
Georg Georg, whos holidays are over and who has therefore very little
Georg spare time again.
Did you manage to do something with insetlatexaccent?
JMarc
Jean-Marc Lasgouttes wrote:
Did you manage to do something with insetlatexaccent?
Yes. It is basically finished, but lyx2lyx needs a bit of testing. I'll send
it when it is finished.
Georg
Georg Baum wrote:
Abdelrazak Younes wrote:
From a compiler POV, this should not matter really.
It matters a lot. During the compile, the compiler sees only what is in
the .h file. It does not know at all in which .C file the code of only
declared functions is, so it can't inline it.
If that
Jean-Marc Lasgouttes wrote:
Abdelrazak Please try to link in order to make sure.
It does link, but I do not like the warnings.
It does not here:
BufferView.o: In function `lyx::BufferView::getStatus(lyx::FuncRequest
const)':
/home/juergen/lyx/lyx-qt/src/BufferView.C:611: undefined reference
> "younes" == younes <[EMAIL PROTECTED]> writes:
younes> + /// are we in texted?.
younes> + /// inlined out because of profiling results under linux when
younes> + // opening a document.
younes> + inline bool inTexted() const;
Abdel, are you sure this is a proper syntax? My compiler
Jean-Marc Lasgouttes wrote:
"younes" == younes <[EMAIL PROTECTED]> writes:
younes> + /// are we in texted?.
younes> + /// inlined out because of profiling results under linux when
younes> + // opening a document.
younes> + inline bool inTexted() const;
Abdel, are you sure this is a
Jean-Marc Lasgouttes wrote:
"younes" == younes <[EMAIL PROTECTED]> writes:
younes> + /// are we in texted?.
younes> + /// inlined out because of profiling results under linux when
younes> + // opening a document.
younes> + inline bool inTexted() const;
Abdel, are you sure this is a
Jean-Marc Lasgouttes wrote:
"Abdelrazak" == Abdelrazak Younes <[EMAIL PROTECTED]> writes:
Abdelrazak> Jean-Marc Lasgouttes wrote:
"younes" == younes <[EMAIL PROTECTED]> writes:
younes> + /// are we in texted?. younes> + /// inlined out because
of profiling results under linux when younes> +
Jean-Marc Lasgouttes wrote:
It does link, but I do not like the warnings.
I will put the code in the header.
Abdel.
Abdelrazak Younes wrote:
> Jean-Marc Lasgouttes wrote:
>>> "Abdelrazak" == Abdelrazak Younes
>>> <[EMAIL PROTECTED]> writes:
>> Abdelrazak> By the way, 'insetlatexaccent.h' uses the same syntax:
>>
>> Abdelrazak> inline bool canDisplay();
>>
>> Abdelrazak> Don't you have a warning for
> "Abdelrazak" == Abdelrazak Younes <[EMAIL PROTECTED]> writes:
Abdelrazak> Jean-Marc Lasgouttes wrote:
>>> "Abdelrazak" == Abdelrazak Younes <[EMAIL PROTECTED]> writes:
>>
Abdelrazak> Jean-Marc Lasgouttes wrote:
> "younes" == younes <[EMAIL PROTECTED]> writes:
younes> + /// are
> "Georg" == Georg Baum <[EMAIL PROTECTED]> writes:
Georg> Georg, whos holidays are over and who has therefore very little
Georg> spare time again.
Did you manage to do something with insetlatexaccent?
JMarc
Jean-Marc Lasgouttes wrote:
> Did you manage to do something with insetlatexaccent?
Yes. It is basically finished, but lyx2lyx needs a bit of testing. I'll send
it when it is finished.
Georg
Georg Baum wrote:
Abdelrazak Younes wrote:
From a compiler POV, this should not matter really.
It matters a lot. During the compile, the compiler sees only what is in
the .h file. It does not know at all in which .C file the code of only
declared functions is, so it can't inline it.
If that
Jean-Marc Lasgouttes wrote:
> Abdelrazak> Please try to link in order to make sure.
>
> It does link, but I do not like the warnings.
It does not here:
BufferView.o: In function `lyx::BufferView::getStatus(lyx::FuncRequest
const&)':
/home/juergen/lyx/lyx-qt/src/BufferView.C:611: undefined
32 matches
Mail list logo
