Re: [LyX/2.3.x] Fix caret painting

2018-10-19 Thread Scott Kostyshak
On Fri, Oct 19, 2018 at 10:12:54AM +0200, Jean-Marc Lasgouttes wrote: > Le 19/10/2018 à 03:28, Scott Kostyshak a écrit : > > On Thu, Oct 18, 2018 at 05:20:38PM +0200, Jean-Marc Lasgouttes wrote: > > > Le 14/10/2018 à 05:36, Scott Kostyshak a écrit : > > > > For some reason,

Re: [LyX/2.3.x] Fix caret painting

2018-10-19 Thread Jean-Marc Lasgouttes
Le 19/10/2018 à 03:28, Scott Kostyshak a écrit : On Thu, Oct 18, 2018 at 05:20:38PM +0200, Jean-Marc Lasgouttes wrote: Le 14/10/2018 à 05:36, Scott Kostyshak a écrit : For some reason, PreviewLoader::Impl::refreshPreviews() is no longer called for me. Enrico, can you reproduce? Do you have an

Re: [LyX/2.3.x] Fix caret painting

2018-10-18 Thread Scott Kostyshak
On Thu, Oct 18, 2018 at 05:20:38PM +0200, Jean-Marc Lasgouttes wrote: > Le 14/10/2018 à 05:36, Scott Kostyshak a écrit : > > For some reason, PreviewLoader::Impl::refreshPreviews() is no longer > > called for me. Enrico, can you reproduce? Do you have an idea if the > > code that takes care of the

Re: [LyX/2.3.x] Fix caret painting

2018-10-18 Thread Jean-Marc Lasgouttes
Le 14/10/2018 à 05:36, Scott Kostyshak a écrit : For some reason, PreviewLoader::Impl::refreshPreviews() is no longer called for me. Enrico, can you reproduce? Do you have an idea if the code that takes care of the preview regeneration on zoom change could have been broken by something? Could

Re: [LyX/2.3.x] Fix caret painting

2018-10-14 Thread Scott Kostyshak
On Sun, Oct 14, 2018 at 11:21:21PM +0200, Jean-Marc Lasgouttes wrote: > Le 14/10/2018 à 16:56, Scott Kostyshak a écrit : > > Ah good to know. JMarc, could the cursor placement observation that > > Enrico mentions above be a clue for something that changed related to > > this commit or the previous

Re: [LyX/2.3.x] Fix caret painting

2018-10-14 Thread Jean-Marc Lasgouttes
Le 14/10/2018 à 16:56, Scott Kostyshak a écrit : Ah good to know. JMarc, could the cursor placement observation that Enrico mentions above be a clue for something that changed related to this commit or the previous commit (7b8b3e38)? I do not know yet, I did not have the time to look at it.

Re: [LyX/2.3.x] Fix caret painting

2018-10-14 Thread Scott Kostyshak
On Sun, Oct 14, 2018 at 12:56:34PM +0200, Enrico Forestieri wrote: > On Sat, Oct 13, 2018 at 11:36:46PM -0400, Scott Kostyshak wrote: > > On Sun, Oct 07, 2018 at 11:56:45AM -0400, Scott Kostyshak wrote: > > > On Sun, Oct 07, 2018 at 01:59:39PM +0200, Jean-Marc Lasgouttes wrote: > > > > Le

Re: [LyX/2.3.x] Fix caret painting

2018-10-14 Thread Enrico Forestieri
On Sat, Oct 13, 2018 at 11:36:46PM -0400, Scott Kostyshak wrote: > On Sun, Oct 07, 2018 at 11:56:45AM -0400, Scott Kostyshak wrote: > > On Sun, Oct 07, 2018 at 01:59:39PM +0200, Jean-Marc Lasgouttes wrote: > > > Le 04/09/2018 à 03:55, Scott Kostyshak a écrit : > > > > If I have an ERT in a preview

Re: [LyX/2.3.x] Fix caret painting

2018-10-13 Thread Scott Kostyshak
On Sun, Oct 07, 2018 at 11:56:45AM -0400, Scott Kostyshak wrote: > On Sun, Oct 07, 2018 at 01:59:39PM +0200, Jean-Marc Lasgouttes wrote: > > Le 04/09/2018 à 03:55, Scott Kostyshak a écrit : > > > If I have an ERT in a preview inset, it previews when I open LyX. But if > > > I zoom in or out, the

Re: [LyX/2.3.x] Fix caret painting

2018-10-07 Thread Scott Kostyshak
On Sun, Oct 07, 2018 at 01:59:39PM +0200, Jean-Marc Lasgouttes wrote: > Le 04/09/2018 à 03:55, Scott Kostyshak a écrit : > > If I have an ERT in a preview inset, it previews when I open LyX. But if > > I zoom in or out, the preview is not refreshed. > > > > I did a bisect that lead me here. Note

Re: [LyX/2.3.x] Fix caret painting

2018-10-07 Thread Jean-Marc Lasgouttes
Le 04/09/2018 à 03:55, Scott Kostyshak a écrit : If I have an ERT in a preview inset, it previews when I open LyX. But if I zoom in or out, the preview is not refreshed. I did a bisect that lead me here. Note that I did the bisect on 2.3.x. Can anyone reproduce? I also have issues with

Re: [LyX/2.3.x] Fix caret painting

2018-09-03 Thread Scott Kostyshak
On Sun, Apr 15, 2018 at 05:58:17AM +0200, Jean-Marc Lasgouttes wrote: > commit ef1d50207088bc40cd0fbbd27229df9e8400e932 > Author: Jean-Marc Lasgouttes > Date: Thu Jul 20 23:31:05 2017 +0200 > > Fix caret painting > > The trick is to remember in BufferView what has been done at the