Re: [LyX/master] Install a new compressor

2018-02-03 Thread Jürgen Spitzmüller
Am Freitag, den 02.02.2018, 22:55 -0500 schrieb Scott Kostyshak: > > Yes, you need Jürgen's fix. > > OK. Done. Jürgen signature.asc Description: This is a digitally signed message part

Re: [LyX/master] Install a new compressor

2018-02-02 Thread Guillaume MM
Le 01/02/2018 à 22:23, Scott Kostyshak a écrit : On Thu, Feb 01, 2018 at 07:19:03PM +, Guillaume MM wrote: Le 01/02/2018 à 18:21, Scott Kostyshak a écrit : On Thu, Feb 01, 2018 at 02:00:43PM +, Jürgen Spitzmüller wrote: Am Donnerstag, den 01.02.2018, 11:40 +0100 schrieb Jürgen

Re: [LyX/master] Install a new compressor

2018-02-01 Thread Jürgen Spitzmüller
Am Donnerstag, den 01.02.2018, 20:19 +0100 schrieb Guillaume MM: > I would not have proposed it for 2.3, Note that we had to act, since our old pseudo key compressor code broke completely with Qt 5.10. Jürgen > > Guillaume > signature.asc Description: This is a digitally signed message part

Re: [LyX/master] Install a new compressor

2018-02-01 Thread Scott Kostyshak
On Thu, Feb 01, 2018 at 07:19:03PM +, Guillaume MM wrote: > Le 01/02/2018 à 18:21, Scott Kostyshak a écrit : > > On Thu, Feb 01, 2018 at 02:00:43PM +, Jürgen Spitzmüller wrote: > > > Am Donnerstag, den 01.02.2018, 11:40 +0100 schrieb Jürgen Spitzmüller: > > > > Am Donnerstag, den

Re: [LyX/master] Install a new compressor

2018-02-01 Thread Guillaume MM
Le 01/02/2018 à 18:21, Scott Kostyshak a écrit : On Thu, Feb 01, 2018 at 02:00:43PM +, Jürgen Spitzmüller wrote: Am Donnerstag, den 01.02.2018, 11:40 +0100 schrieb Jürgen Spitzmüller: Am Donnerstag, den 01.02.2018, 11:22 +0100 schrieb Jean-Marc Lasgouttes: This makes much sense. You could

Re: [LyX/master] Install a new compressor

2018-02-01 Thread Scott Kostyshak
On Thu, Feb 01, 2018 at 02:00:43PM +, Jürgen Spitzmüller wrote: > Am Donnerstag, den 01.02.2018, 11:40 +0100 schrieb Jürgen Spitzmüller: > > Am Donnerstag, den 01.02.2018, 11:22 +0100 schrieb Jean-Marc > > Lasgouttes: > > > This makes much sense. You could probably move the new line to the > >

Re: [LyX/master] Install a new compressor

2018-02-01 Thread Jürgen Spitzmüller
Am Donnerstag, den 01.02.2018, 11:22 +0100 schrieb Jean-Marc Lasgouttes: > This makes much sense. You could probably move the new line to the > other > GuiWorkArea constructor... Yes, this seems to work as well. > Some more things seem weird in this code (like the w argument to the >

Re: [LyX/master] Install a new compressor

2018-02-01 Thread Jean-Marc Lasgouttes
Le 01/02/2018 à 10:50, Jürgen Spitzmüller a écrit : The attached patch fixes it for me. But since this is not my code, I am not that confident it is the correct fix. This makes much sense. You could probably move the new line to the other GuiWorkArea constructor... Some more things seem

Re: [LyX/master] Install a new compressor

2018-02-01 Thread Kornel Benko
Am Donnerstag, 1. Februar 2018 10:50:42 CET schrieb Jürgen Spitzmüller : > Am Mittwoch, den 31.01.2018, 22:12 -0500 schrieb Scott Kostyshak: > > git bisect suggests this caused the issue reported on lyx-users [1]. > > > > To reproduce: > > > > 1. Open LyX > > 2. Start a new

Re: [LyX/master] Install a new compressor

2018-02-01 Thread Jürgen Spitzmüller
Am Mittwoch, den 31.01.2018, 22:12 -0500 schrieb Scott Kostyshak: > git bisect suggests this caused the issue reported on lyx-users [1]. > > To reproduce: > > 1. Open LyX > 2. Start a new document > 3. Go to Edit > Find & Replace (Advanced) > 4. Try to type something in the "Find" text area. >

Re: [LyX/master] Install a new compressor

2018-01-31 Thread Scott Kostyshak
On Fri, Jan 12, 2018 at 10:03:54AM +, Juergen Spitzmueller wrote: > commit 43e4b8073445d147be353013e3a7e081e11653ba > Author: Guillaume MM > Date: Fri Jan 12 10:58:31 2018 +0100 > > Install a new compressor > > A brand new event compressor based on Kuba Ober's

Re: [LyX/master] Install a new compressor

2018-01-12 Thread Scott Kostyshak
On Fri, Jan 12, 2018 at 10:03:54AM +, Juergen Spitzmueller wrote: > commit 43e4b8073445d147be353013e3a7e081e11653ba > Author: Guillaume MM > Date: Fri Jan 12 10:58:31 2018 +0100 > > Install a new compressor > > A brand new event compressor based on Kuba Ober's

Re: [LyX/master] Install a new compressor

2018-01-12 Thread Jürgen Spitzmüller
Am Freitag, den 12.01.2018, 11:49 +0100 schrieb Jean-Marc Lasgouttes: > This breaks compilation here with Qt4 (Qt5 is OK). Fixed. Jürgen signature.asc Description: This is a digitally signed message part

Re: [LyX/master] Install a new compressor

2018-01-12 Thread Jürgen Spitzmüller
Am Freitag, den 12.01.2018, 12:17 +0100 schrieb Jean-Marc Lasgouttes: > Yes, but the fact that the code was supposed to be portable may hint > to > a simpler solution. Unfortunately, I understand nothing about this > signal/slot stuff. The problem seems to be only that a qt5-only

Re: [LyX/master] Install a new compressor

2018-01-12 Thread Jean-Marc Lasgouttes
Le 12/01/2018 à 11:59, Jürgen Spitzmüller a écrit : Am Freitag, den 12.01.2018, 11:49 +0100 schrieb Jean-Marc Lasgouttes: This breaks compilation here with Qt4 (Qt5 is OK). I am not sure what we are supposed to do, but the original code was supposed to be portable to Qt5. I see. We need to do

Re: [LyX/master] Install a new compressor

2018-01-12 Thread Jürgen Spitzmüller
Am Freitag, den 12.01.2018, 11:49 +0100 schrieb Jean-Marc Lasgouttes: > This breaks compilation here with Qt4 (Qt5 is OK). I am not sure what > we > are supposed to do, but the original code was supposed to be portable > to > Qt5. I see. We need to do something, however, the old code does not

Re: [LyX/master] Install a new compressor

2018-01-12 Thread Jean-Marc Lasgouttes
Le 12/01/2018 à 11:03, Juergen Spitzmueller a écrit : commit 43e4b8073445d147be353013e3a7e081e11653ba Author: Guillaume MM Date: Fri Jan 12 10:58:31 2018 +0100 Install a new compressor A brand new event compressor based on Kuba Ober's cleverly simple