Re: [PATCH] Branches and ToC bug

2007-01-21 Thread Martin Vermeer
On Fri, Jan 19, 2007 at 08:55:06PM +, José Matos wrote: On Friday 19 January 2007 4:02:43 pm Jean-Marc Lasgouttes wrote: OK, I'll apply it and tell Jose' that you made me do it if he complains. Abdel... hum. How were you capable of such thing? ;-) It's his pretty face. Who can

Re: [PATCH] Branches and ToC bug

2007-01-21 Thread Martin Vermeer
On Fri, Jan 19, 2007 at 08:55:06PM +, José Matos wrote: > On Friday 19 January 2007 4:02:43 pm Jean-Marc Lasgouttes wrote: > > OK, I'll apply it and tell Jose' that you made me do it if he > > complains. > > Abdel... hum. How were you capable of such thing? ;-) It's his pretty face. Who

Re: [PATCH] Branches and ToC bug

2007-01-20 Thread Martin Vermeer
Great, thanks! - Martin On Fri, 19 Jan 2007, Jean-Marc Lasgouttes wrote: Jean-Marc == Jean-Marc Lasgouttes [EMAIL PROTECTED] writes: Jean-Marc OK, the trivial version is what I propose for 1.4.x: Jean-Marc besides implementing InsetBranch::textString, it fixes an Jean-Marc output order bug

Re: [PATCH] Branches and ToC bug

2007-01-20 Thread Martin Vermeer
Great, thanks! - Martin On Fri, 19 Jan 2007, Jean-Marc Lasgouttes wrote: "Jean-Marc" == Jean-Marc Lasgouttes <[EMAIL PROTECTED]> writes: Jean-Marc> OK, the trivial version is what I propose for 1.4.x: Jean-Marc> besides implementing InsetBranch::textString, it fixes an Jean-Marc> output

Re: [PATCH] Branches and ToC bug

2007-01-19 Thread Jean-Marc Lasgouttes
Martin == Martin Vermeer [EMAIL PROTECTED] writes: Martin My original patch is still needed and fixes a useability bug. Martin As I wrote earlier,a ToC containing only numbers is unuseable Martin for navigation or outlining. I verified that it does the job. I know see what the bug you reported

Re: [PATCH] Branches and ToC bug

2007-01-19 Thread Martin Vermeer
On Fri, 2007-01-19 at 10:03 +0100, Jean-Marc Lasgouttes wrote: Martin == Martin Vermeer [EMAIL PROTECTED] writes: Martin My original patch is still needed and fixes a useability bug. Martin As I wrote earlier,a ToC containing only numbers is unuseable Martin for navigation or outlining. I

Re: [PATCH] Branches and ToC bug

2007-01-19 Thread Jean-Marc Lasgouttes
Martin == Martin Vermeer [EMAIL PROTECTED] writes: Martin This is _much_ better. BTW did you notice Martin InsetBranch::plaintext()? The infrastructure is there, waiting Martin to be used... My problem was to know whether we should restrict ourselves to the first paragraph. Martin Does anyone

Re: [PATCH] Branches and ToC bug

2007-01-19 Thread Jean-Marc Lasgouttes
Martin == Martin Vermeer [EMAIL PROTECTED] writes: Martin Jean-Marc, could you do this, as it is near-trivial? I'm again Martin having access problems (i.e., its near-complete absence) over Martin the extended weekend :-( OK, the trivial version is what I propose for 1.4.x: besides implementing

Re: [PATCH] Branches and ToC bug

2007-01-19 Thread Abdelrazak Younes
Jean-Marc Lasgouttes wrote: Martin == Martin Vermeer [EMAIL PROTECTED] writes: Martin Jean-Marc, could you do this, as it is near-trivial? I'm again Martin having access problems (i.e., its near-complete absence) over Martin the extended weekend :-( OK, the trivial version is what I propose

Re: [PATCH] Branches and ToC bug

2007-01-19 Thread Jean-Marc Lasgouttes
Abdelrazak == Abdelrazak Younes [EMAIL PROTECTED] writes: The 1.5 version is more complicated because I took the liberty to cleanup Paragraph::asString (remove two useless versions) and to simplify the InsetBase::textString method. Abdelrazak Whaou! Breaking news! JMarc is taking some

Re: [PATCH] Branches and ToC bug

2007-01-19 Thread Jean-Marc Lasgouttes
Jean-Marc == Jean-Marc Lasgouttes [EMAIL PROTECTED] writes: Jean-Marc OK, the trivial version is what I propose for 1.4.x: Jean-Marc besides implementing InsetBranch::textString, it fixes an Jean-Marc output order bug in writePlaintextParagraph. Jean-Marc The 1.5 version is more complicated

Re: [PATCH] Branches and ToC bug

2007-01-19 Thread José Matos
On Friday 19 January 2007 4:02:43 pm Jean-Marc Lasgouttes wrote: OK, I'll apply it and tell Jose' that you made me do it if he complains. Abdel... hum. How were you capable of such thing? ;-) JMarc -- José Abílio

Re: [PATCH] Branches and ToC bug

2007-01-19 Thread José Matos
On Friday 19 January 2007 4:24:55 pm Jean-Marc Lasgouttes wrote: I applied both. Thanks. JMarc -- José Abílio

Re: [PATCH] Branches and ToC bug

2007-01-19 Thread Jean-Marc Lasgouttes
> "Martin" == Martin Vermeer <[EMAIL PROTECTED]> writes: Martin> My original patch is still needed and fixes a useability bug. Martin> As I wrote earlier,a ToC containing only numbers is unuseable Martin> for navigation or outlining. I verified that it does the job. I know see what the bug

Re: [PATCH] Branches and ToC bug

2007-01-19 Thread Martin Vermeer
On Fri, 2007-01-19 at 10:03 +0100, Jean-Marc Lasgouttes wrote: > > "Martin" == Martin Vermeer <[EMAIL PROTECTED]> writes: > > Martin> My original patch is still needed and fixes a useability bug. > Martin> As I wrote earlier,a ToC containing only numbers is unuseable > Martin> for navigation

Re: [PATCH] Branches and ToC bug

2007-01-19 Thread Jean-Marc Lasgouttes
> "Martin" == Martin Vermeer <[EMAIL PROTECTED]> writes: Martin> This is _much_ better. BTW did you notice Martin> InsetBranch::plaintext()? The infrastructure is there, waiting Martin> to be used... My problem was to know whether we should restrict ourselves to the first paragraph. Martin>

Re: [PATCH] Branches and ToC bug

2007-01-19 Thread Jean-Marc Lasgouttes
> "Martin" == Martin Vermeer <[EMAIL PROTECTED]> writes: Martin> Jean-Marc, could you do this, as it is near-trivial? I'm again Martin> having access problems (i.e., its near-complete absence) over Martin> the extended weekend :-( OK, the trivial version is what I propose for 1.4.x: besides

Re: [PATCH] Branches and ToC bug

2007-01-19 Thread Abdelrazak Younes
Jean-Marc Lasgouttes wrote: "Martin" == Martin Vermeer <[EMAIL PROTECTED]> writes: Martin> Jean-Marc, could you do this, as it is near-trivial? I'm again Martin> having access problems (i.e., its near-complete absence) over Martin> the extended weekend :-( OK, the trivial version is what I

Re: [PATCH] Branches and ToC bug

2007-01-19 Thread Jean-Marc Lasgouttes
> "Abdelrazak" == Abdelrazak Younes <[EMAIL PROTECTED]> writes: >> The 1.5 version is more complicated because I took the liberty to >> cleanup Paragraph::asString (remove two useless versions) and to >> simplify the InsetBase::textString method. Abdelrazak> Whaou! Breaking news! JMarc is

Re: [PATCH] Branches and ToC bug

2007-01-19 Thread Jean-Marc Lasgouttes
> "Jean-Marc" == Jean-Marc Lasgouttes <[EMAIL PROTECTED]> writes: Jean-Marc> OK, the trivial version is what I propose for 1.4.x: Jean-Marc> besides implementing InsetBranch::textString, it fixes an Jean-Marc> output order bug in writePlaintextParagraph. Jean-Marc> The 1.5 version is more

Re: [PATCH] Branches and ToC bug

2007-01-19 Thread José Matos
On Friday 19 January 2007 4:02:43 pm Jean-Marc Lasgouttes wrote: > OK, I'll apply it and tell Jose' that you made me do it if he > complains. Abdel... hum. How were you capable of such thing? ;-) > JMarc -- José Abílio

Re: [PATCH] Branches and ToC bug

2007-01-19 Thread José Matos
On Friday 19 January 2007 4:24:55 pm Jean-Marc Lasgouttes wrote: > I applied both. Thanks. > JMarc -- José Abílio

[PATCH] Branches and ToC bug

2007-01-18 Thread Martin Vermeer
When I translate the section headers using branches, nothing appears in the ToC, just the number. Text inside a branch inset does not make it to the ToC or nav menu. Attached a fix. With this, the active/selected branch(es) will be used to create the ToC entry. - Martin Index: TocBackend.C

Re: [PATCH] Branches and ToC bug

2007-01-18 Thread Jean-Marc Lasgouttes
Martin == Martin Vermeer [EMAIL PROTECTED] writes: Martin When I translate the section headers using branches, nothing Martin appears in the ToC, just the number. Text inside a branch Martin inset does not make it to the ToC or nav menu. Martin Attached a fix. With this, the active/selected

Re: [PATCH] Branches and ToC bug

2007-01-18 Thread Martin Vermeer
On Thu, Jan 18, 2007 at 03:46:22PM +0100, Jean-Marc Lasgouttes wrote: Martin == Martin Vermeer [EMAIL PROTECTED] writes: Martin When I translate the section headers using branches, nothing Martin appears in the ToC, just the number. Text inside a branch Martin inset does not make it to the

Re: [PATCH] Branches and ToC bug

2007-01-18 Thread Martin Vermeer
On Thu, Jan 18, 2007 at 03:46:22PM +0100, Jean-Marc Lasgouttes wrote: Martin == Martin Vermeer [EMAIL PROTECTED] writes: Martin When I translate the section headers using branches, nothing Martin appears in the ToC, just the number. Text inside a branch Martin inset does not make it to the

Re: [PATCH] Branches and ToC bug

2007-01-18 Thread Jean-Marc Lasgouttes
Martin == Martin Vermeer [EMAIL PROTECTED] writes: If you want to take in account branches (or more generally nested textinset), you should do it completely, I can't believe it is so difficult. Martin I think branches are the main problem. We don't really need to Martin see footnotes and the

Re: [PATCH] Branches and ToC bug

2007-01-18 Thread Martin Vermeer
On Thu, Jan 18, 2007 at 05:02:20PM +0100, Jean-Marc Lasgouttes wrote: Martin == Martin Vermeer [EMAIL PROTECTED] writes: If you want to take in account branches (or more generally nested textinset), you should do it completely, I can't believe it is so difficult. Martin I think

Re: [PATCH] Branches and ToC bug

2007-01-18 Thread Martin Vermeer
On Thu, Jan 18, 2007 at 06:59:10PM +0200, Martin Vermeer wrote: On Thu, Jan 18, 2007 at 05:02:20PM +0100, Jean-Marc Lasgouttes wrote: Martin == Martin Vermeer [EMAIL PROTECTED] writes: If you want to take in account branches (or more generally nested textinset), you should do it

Re: [PATCH] Branches and ToC bug

2007-01-18 Thread Martin Vermeer
On Thu, 2007-01-18 at 21:09 +0200, Martin Vermeer wrote: On Thu, Jan 18, 2007 at 06:59:10PM +0200, Martin Vermeer wrote: On Thu, Jan 18, 2007 at 05:02:20PM +0100, Jean-Marc Lasgouttes wrote: Martin == Martin Vermeer [EMAIL PROTECTED] writes: If you want to take in account branches

[PATCH] Branches and ToC bug

2007-01-18 Thread Martin Vermeer
When I translate the section headers using branches, nothing appears in the ToC, just the number. Text inside a branch inset does not make it to the ToC or nav menu. Attached a fix. With this, the active/selected branch(es) will be used to create the ToC entry. - Martin Index: TocBackend.C

Re: [PATCH] Branches and ToC bug

2007-01-18 Thread Jean-Marc Lasgouttes
> "Martin" == Martin Vermeer <[EMAIL PROTECTED]> writes: Martin> When I translate the section headers using branches, nothing Martin> appears in the ToC, just the number. Text inside a branch Martin> inset does not make it to the ToC or nav menu. Martin> Attached a fix. With this, the

Re: [PATCH] Branches and ToC bug

2007-01-18 Thread Martin Vermeer
On Thu, Jan 18, 2007 at 03:46:22PM +0100, Jean-Marc Lasgouttes wrote: > > "Martin" == Martin Vermeer <[EMAIL PROTECTED]> writes: > > Martin> When I translate the section headers using branches, nothing > Martin> appears in the ToC, just the number. Text inside a branch > Martin> inset does

Re: [PATCH] Branches and ToC bug

2007-01-18 Thread Martin Vermeer
On Thu, Jan 18, 2007 at 03:46:22PM +0100, Jean-Marc Lasgouttes wrote: > > "Martin" == Martin Vermeer <[EMAIL PROTECTED]> writes: > > Martin> When I translate the section headers using branches, nothing > Martin> appears in the ToC, just the number. Text inside a branch > Martin> inset does

Re: [PATCH] Branches and ToC bug

2007-01-18 Thread Jean-Marc Lasgouttes
> "Martin" == Martin Vermeer <[EMAIL PROTECTED]> writes: >> If you want to take in account branches (or more generally nested >> textinset), you should do it completely, I can't believe it is so >> difficult. Martin> I think branches are the main problem. We don't really need to Martin> see

Re: [PATCH] Branches and ToC bug

2007-01-18 Thread Martin Vermeer
On Thu, Jan 18, 2007 at 05:02:20PM +0100, Jean-Marc Lasgouttes wrote: > > "Martin" == Martin Vermeer <[EMAIL PROTECTED]> writes: > > >> If you want to take in account branches (or more generally nested > >> textinset), you should do it completely, I can't believe it is so > >> difficult. > >

Re: [PATCH] Branches and ToC bug

2007-01-18 Thread Martin Vermeer
On Thu, Jan 18, 2007 at 06:59:10PM +0200, Martin Vermeer wrote: > On Thu, Jan 18, 2007 at 05:02:20PM +0100, Jean-Marc Lasgouttes wrote: > > > "Martin" == Martin Vermeer <[EMAIL PROTECTED]> writes: > > > > >> If you want to take in account branches (or more generally nested > > >> textinset),

Re: [PATCH] Branches and ToC bug

2007-01-18 Thread Martin Vermeer
On Thu, 2007-01-18 at 21:09 +0200, Martin Vermeer wrote: > On Thu, Jan 18, 2007 at 06:59:10PM +0200, Martin Vermeer wrote: > > On Thu, Jan 18, 2007 at 05:02:20PM +0100, Jean-Marc Lasgouttes wrote: > > > > "Martin" == Martin Vermeer <[EMAIL PROTECTED]> writes: > > > > > > >> If you want to