[PATCH] GUII Timeout class

2001-02-07 Thread John Levon
The attached implements GUII timeout for xforms and KDE. It also removes the duplicate OkViewPolicy and tidies up a little in BufferView_pimpl.C thanks john -- "IBM's decision to choose the Intel 80x86 processor over the Motorola 680x0 probably set the personal computer industry back 10 yea

Re: [PATCH] GUII Timeout class

2001-02-07 Thread Lars Gullik Bjønnes
John Levon <[EMAIL PROTECTED]> writes: | + if (!lyxrc.cursor_follows_scrollbar) { | + waitForX(); | + return; | } | + | + LyXText * vbt = bv_->text; | + | + int height = vbt->DefaultHeight(); | + int first = static_cast((bv_->text->first + height))

Re: [PATCH] GUII Timeout class

2001-02-07 Thread John Levon
On 7 Feb 2001, Lars Gullik Bjønnes wrote: > | + int height = vbt->DefaultHeight(); > | + int first = static_cast((bv_->text->first + height)); > | + int last = static_cast((bv_->text->first + > | workarea_->height() - height)); > > Can these int be const? If so make them so. OK > | + i

Re: [PATCH] GUII Timeout class

2001-02-07 Thread Allan Rae
On Wed, 7 Feb 2001, John Levon wrote: > > | + * Timeout.C > > | + * (C) 2001 LyX Team > > | + * John Levon, [EMAIL PROTECTED] > > > > ha! > > > > Very sorry, I didn't mean to imply anything by this. > > How should I write it ? > > I put my name there so someone knows who to blame, like I have all

Re: [PATCH] GUII Timeout class

2001-02-07 Thread John Levon
On Wed, 7 Feb 2001, Allan Rae wrote: > (C) means nothing. It's a couple parentheses around a capital C. > Write "Copyright" out in full. And "The LyX Team". OK > See some of the other copyright notices around for a template. They are far too wordy. The existence of COPYING should suffice, al

Re: [PATCH] GUII Timeout class

2001-02-07 Thread Lars Gullik Bjønnes
John Levon <[EMAIL PROTECTED]> writes: | > Wouldn't it be more natural to do "if (value == 0.0)", than using a | > cast? | | It would be more natural to not compare floating point values using == | ... Unless 0.0 usually means that we explcit set it to 0.0. | | I'll back these bits out none

Re: [PATCH] GUII Timeout class

2001-02-07 Thread Lars Gullik Bjønnes
John Levon <[EMAIL PROTECTED]> writes: | On Wed, 7 Feb 2001, Allan Rae wrote: | | > (C) means nothing. It's a couple parentheses around a capital C. | > Write "Copyright" out in full. And "The LyX Team". | | OK | | > See some of the other copyright notices around for a template. | | They ar

Re: [PATCH] GUII Timeout class

2001-02-07 Thread John Levon
On 7 Feb 2001, Lars Gullik Bjønnes wrote: > | /* > | * File.C > | * Copyright 2001 The LyX Team > * Read COPYING OK > * @author NN And for unknown previous authors ? Timeout.C mentions Matthias, but that's it; however the dates go up to 2000. What should I do here ? I do not want to get t

Re: [PATCH] GUII Timeout class

2001-02-07 Thread Lars Gullik Bjønnes
John Levon <[EMAIL PROTECTED]> writes: | On 7 Feb 2001, Lars Gullik Bjønnes wrote: | | > | /* | > | * File.C | > | * Copyright 2001 The LyX Team | > * Read COPYING | | OK | | > * @author NN | | And for unknown previous authors ? "NN" | | Timeout.C mentions Matthias, but that's it; Matth