Re: [PATCH] Re: Here you go

2002-04-30 Thread Dekel Tsur
On Mon, Apr 29, 2002 at 10:38:50PM +0100, John Levon wrote: On Mon, Apr 29, 2002 at 03:23:59PM +0300, Dekel Tsur wrote: So I call others to test it. Can you make a clean diff against current CVS and I will test it. Here is a new patch and a test file. Note that preparing this test file I

Re: [PATCH] Re: Here you go

2002-04-30 Thread John Levon
On Tue, Apr 30, 2002 at 04:59:17PM +0300, Dekel Tsur wrote: Here is a new patch and a test file. I am building now. Looking at the patch I have a couple of minor comments ... + // check if the float type exist + if (argument == figure) { I guess one day we will

Re: [PATCH] Re: Here you go

2002-04-30 Thread John Levon
On Tue, Apr 30, 2002 at 04:59:17PM +0300, Dekel Tsur wrote: So I call others to test it. What sense does it make to be able to toggle default placement and also set left/middle/right ? I don't get it. Where's the menu entry for inserting a new floatingfigure ? john -- Please let's not

Re: [PATCH] Re: Here you go

2002-04-30 Thread Dekel Tsur
On Tue, Apr 30, 2002 at 06:10:14PM +0100, John Levon wrote: On Tue, Apr 30, 2002 at 04:59:17PM +0300, Dekel Tsur wrote: So I call others to test it. What sense does it make to be able to toggle default placement and also set left/middle/right ? I don't get it. This is an error. The

Re: [PATCH] Re: Here you go

2002-04-30 Thread Dekel Tsur
On Tue, Apr 30, 2002 at 05:32:27PM +0100, John Levon wrote: Looking at the patch I have a couple of minor comments ... + // check if the float type exist + if (argument == figure) { I guess one day we will support floatingtable ?? Perhaps. {

Re: [PATCH] Re: Here you go

2002-04-30 Thread Dekel Tsur
On Mon, Apr 29, 2002 at 10:38:50PM +0100, John Levon wrote: > On Mon, Apr 29, 2002 at 03:23:59PM +0300, Dekel Tsur wrote: > > > So I call others to test it. > > Can you make a clean diff against current CVS and I will test it. Here is a new patch and a test file. Note that preparing this test

Re: [PATCH] Re: Here you go

2002-04-30 Thread John Levon
On Tue, Apr 30, 2002 at 04:59:17PM +0300, Dekel Tsur wrote: > Here is a new patch and a test file. I am building now. Looking at the patch I have a couple of minor comments ... + // check if the float type exist + if (argument == "figure") { I guess one day we

Re: [PATCH] Re: Here you go

2002-04-30 Thread John Levon
On Tue, Apr 30, 2002 at 04:59:17PM +0300, Dekel Tsur wrote: > > > So I call others to test it. What sense does it make to be able to toggle default placement and also set left/middle/right ? I don't get it. Where's the menu entry for inserting a new floatingfigure ? john -- "Please let's

Re: [PATCH] Re: Here you go

2002-04-30 Thread Dekel Tsur
On Tue, Apr 30, 2002 at 06:10:14PM +0100, John Levon wrote: > On Tue, Apr 30, 2002 at 04:59:17PM +0300, Dekel Tsur wrote: > > > > > So I call others to test it. > > What sense does it make to be able to toggle default placement and also > set left/middle/right ? I don't get it. This is an

Re: [PATCH] Re: Here you go

2002-04-30 Thread Dekel Tsur
On Tue, Apr 30, 2002 at 05:32:27PM +0100, John Levon wrote: > > Looking at the patch I have a couple of minor comments ... > > + // check if the float type exist > + if (argument == "figure") { > > I guess one day we will support floatingtable ?? Perhaps. > >

Re: [PATCH] Re: Here you go

2002-04-29 Thread Dekel Tsur
On Sun, Apr 28, 2002 at 03:27:01PM +0200, Lars Gullik Bjønnes wrote: Dekel Tsur [EMAIL PROTECTED] writes: | On Sat, Apr 27, 2002 at 09:09:13PM +0200, Lars Gullik Bjønnes wrote: | Here is a patch :) | Can I apply it ? No. | Why? Untested. Make others test it verify that lyx

Re: [PATCH] Re: Here you go

2002-04-29 Thread Lars Gullik Bjønnes
Dekel Tsur [EMAIL PROTECTED] writes: | Currently, lyx-1.2.0 doesn't read correctly 1.1.6 files which is very bad. Perhaps... I do not expect to find a lot of 1.1.6 lyx files that used floatflt... | Even if this feature wasn't widely used, it is still bad to drop support for | it. I can

Re: [PATCH] Re: Here you go

2002-04-29 Thread Juergen Vigna
On 29-Apr-2002 Lars Gullik Bjønnes wrote: | Even if this feature wasn't widely used, it is still bad to drop support for | it. I can agree with that. It's the same for the indented paragraphs also. We droped that too and it doesn't seem someone wants it back (appart from me as I think it's

Re[2]: [PATCH] Re: Here you go

2002-04-29 Thread Soeren Pietsch
Juergen It's the same for the indented paragraphs also. We droped that too and it doesn't Juergen seem someone wants it back (appart from me as I think it's pretty usefull, but one Juergen can always use an office software ;) he you are not the only one! But one can always drop LyX in favor

Re: [PATCH] Re: Here you go

2002-04-29 Thread John Levon
On Mon, Apr 29, 2002 at 03:23:59PM +0300, Dekel Tsur wrote: So I call others to test it. Can you make a clean diff against current CVS and I will test it. Even if this feature wasn't widely used, it is still bad to drop support for it. You are probably right after all thanks john --

Re: [PATCH] Re: Here you go

2002-04-29 Thread Dekel Tsur
On Sun, Apr 28, 2002 at 03:27:01PM +0200, Lars Gullik Bjønnes wrote: > Dekel Tsur <[EMAIL PROTECTED]> writes: > > | On Sat, Apr 27, 2002 at 09:09:13PM +0200, Lars Gullik Bjønnes wrote: > >> | Here is a patch :) > >> | Can I apply it ? > >> > >> No. > > > | Why? > > Untested. Make others test

Re: [PATCH] Re: Here you go

2002-04-29 Thread Lars Gullik Bjønnes
Dekel Tsur <[EMAIL PROTECTED]> writes: >> | Currently, lyx-1.2.0 doesn't read correctly 1.1.6 files which is very bad. >> >> Perhaps... I do not expect to find a lot of 1.1.6 lyx files that used >> floatflt... > | Even if this feature wasn't widely used, it is still bad to drop support for |

Re: [PATCH] Re: Here you go

2002-04-29 Thread Juergen Vigna
On 29-Apr-2002 Lars Gullik Bjønnes wrote: >| Even if this feature wasn't widely used, it is still bad to drop support for >| it. > > I can agree with that. It's the same for the indented paragraphs also. We droped that too and it doesn't seem someone wants it back (appart from me as I think

Re[2]: [PATCH] Re: Here you go

2002-04-29 Thread Soeren Pietsch
Juergen> It's the same for the indented paragraphs also. We droped that too and it doesn't Juergen> seem someone wants it back (appart from me as I think it's pretty usefull, but one Juergen> can always use an office software ;) he you are not the only one! But one can always drop LyX in favor

Re: [PATCH] Re: Here you go

2002-04-29 Thread John Levon
On Mon, Apr 29, 2002 at 03:23:59PM +0300, Dekel Tsur wrote: > So I call others to test it. Can you make a clean diff against current CVS and I will test it. > Even if this feature wasn't widely used, it is still bad to drop support for > it. You are probably right after all thanks john --

Re: [PATCH] Re: Here you go

2002-04-28 Thread Lars Gullik Bjønnes
Dekel Tsur [EMAIL PROTECTED] writes: | On Sat, Apr 27, 2002 at 09:09:13PM +0200, Lars Gullik Bjønnes wrote: | Here is a patch :) | Can I apply it ? No. | Why? Untested. Make others test it verify that lyx files form 1.1.6 load correctly. Then if all tests work out we can commit it. |

Re: [PATCH] Re: Here you go

2002-04-28 Thread Andre Poenitz
On Sat, Apr 27, 2002 at 10:49:56PM +0300, Dekel Tsur wrote: The patch to UPGRADING: ... LyX 1.2.0 does not handle correctly older files. After the upgrade, you will need to spend several hours to manually fix your files. But LyX 1.2.0 is so wonderful, so it is worth your time! Not too bad

Re: [PATCH] Re: Here you go

2002-04-28 Thread Lars Gullik Bjønnes
Dekel Tsur <[EMAIL PROTECTED]> writes: | On Sat, Apr 27, 2002 at 09:09:13PM +0200, Lars Gullik Bjønnes wrote: >> | Here is a patch :) >> | Can I apply it ? >> >> No. > | Why? Untested. Make others test it verify that lyx files form 1.1.6 load correctly. Then if all tests work out we can commit

Re: [PATCH] Re: Here you go

2002-04-28 Thread Andre Poenitz
On Sat, Apr 27, 2002 at 10:49:56PM +0300, Dekel Tsur wrote: > The patch to UPGRADING: > > ... LyX 1.2.0 does not handle correctly older files. After the upgrade, > you will need to spend several hours to manually fix your files. > But LyX 1.2.0 is so wonderful, so it is worth your time! Not too

Re: [PATCH] Re: Here you go

2002-04-27 Thread Lars Gullik Bjønnes
Dekel Tsur [EMAIL PROTECTED] writes: | On Fri, Apr 26, 2002 at 12:44:34PM +0200, Lars Gullik Bjønnes wrote: | Why we don't have a floatingfigure inset ? Because you have not created one. | Here is a patch :) | Can I apply it ? No. -- Lgb

Re: [PATCH] Re: Here you go

2002-04-27 Thread Dekel Tsur
On Sat, Apr 27, 2002 at 09:09:13PM +0200, Lars Gullik Bjønnes wrote: | Here is a patch :) | Can I apply it ? No. Why? Currently, lyx-1.2.0 doesn't read correctly 1.1.6 files which is very bad.

Re: [PATCH] Re: Here you go

2002-04-27 Thread John Levon
On Sat, Apr 27, 2002 at 10:14:08PM +0300, Dekel Tsur wrote: Currently, lyx-1.2.0 doesn't read correctly 1.1.6 files which is very bad. Is it ? What's wrong exactly ? Don't we want 1.2.0 to come out ?? john -- Taste is predicated on discrimination.

Re: [PATCH] Re: Here you go

2002-04-27 Thread Dekel Tsur
On Sat, Apr 27, 2002 at 08:18:01PM +0100, John Levon wrote: On Sat, Apr 27, 2002 at 10:14:08PM +0300, Dekel Tsur wrote: Currently, lyx-1.2.0 doesn't read correctly 1.1.6 files which is very bad. Is it ? What's wrong exactly ? If you had a floatingfigure in a 1.1.6 file, lyx-1.2.0 will

Re: [PATCH] Re: Here you go

2002-04-27 Thread John Levon
On Sat, Apr 27, 2002 at 10:23:45PM +0300, Dekel Tsur wrote: If you had a floatingfigure in a 1.1.6 file, lyx-1.2.0 will read is as a standard figure. Therefore, the DVI output will be wrong. This is not my definition of very bad to be honest. I think a patch to UPGRADING would be much better

Re: [PATCH] Re: Here you go

2002-04-27 Thread Dekel Tsur
On Sat, Apr 27, 2002 at 08:28:18PM +0100, John Levon wrote: On Sat, Apr 27, 2002 at 10:23:45PM +0300, Dekel Tsur wrote: If you had a floatingfigure in a 1.1.6 file, lyx-1.2.0 will read is as a standard figure. Therefore, the DVI output will be wrong. This is not my definition of very

Re: [PATCH] Re: Here you go

2002-04-27 Thread John Levon
On Sat, Apr 27, 2002 at 10:49:56PM +0300, Dekel Tsur wrote: The patch to UPGRADING: ... LyX 1.2.0 does not handle correctly older files. After the upgrade, you will need to spend several hours to manually fix your files. But LyX 1.2.0 is so wonderful, so it is worth your time! Oh come on,

Re: [PATCH] Re: Here you go

2002-04-27 Thread Dekel Tsur
On Sat, Apr 27, 2002 at 08:52:14PM +0100, John Levon wrote: On Sat, Apr 27, 2002 at 10:49:56PM +0300, Dekel Tsur wrote: The patch to UPGRADING: ... LyX 1.2.0 does not handle correctly older files. After the upgrade, you will need to spend several hours to manually fix your files.

Re: [PATCH] Re: Here you go

2002-04-27 Thread John Levon
On Sat, Apr 27, 2002 at 10:54:59PM +0300, Dekel Tsur wrote: If this is such a big issue why didn't you do this patch 6 months or a year ago ? I wasn't aware of the problem You really managed to miss all the extra par stuff getting removed ?? didn't have time. well ... it's not my

Re: [PATCH] Re: Here you go

2002-04-27 Thread Lars Gullik Bjønnes
Dekel Tsur <[EMAIL PROTECTED]> writes: | On Fri, Apr 26, 2002 at 12:44:34PM +0200, Lars Gullik Bjønnes wrote: >> > >> | Why we don't have a floatingfigure inset ? >> >> Because you have not created one. > | Here is a patch :) | Can I apply it ? No. -- Lgb

Re: [PATCH] Re: Here you go

2002-04-27 Thread Dekel Tsur
On Sat, Apr 27, 2002 at 09:09:13PM +0200, Lars Gullik Bjønnes wrote: > | Here is a patch :) > | Can I apply it ? > > No. Why? Currently, lyx-1.2.0 doesn't read correctly 1.1.6 files which is very bad.

Re: [PATCH] Re: Here you go

2002-04-27 Thread John Levon
On Sat, Apr 27, 2002 at 10:14:08PM +0300, Dekel Tsur wrote: > Currently, lyx-1.2.0 doesn't read correctly 1.1.6 files which is very bad. Is it ? What's wrong exactly ? Don't we want 1.2.0 to come out ?? john -- "Taste is predicated on discrimination."

Re: [PATCH] Re: Here you go

2002-04-27 Thread Dekel Tsur
On Sat, Apr 27, 2002 at 08:18:01PM +0100, John Levon wrote: > On Sat, Apr 27, 2002 at 10:14:08PM +0300, Dekel Tsur wrote: > > > Currently, lyx-1.2.0 doesn't read correctly 1.1.6 files which is very bad. > > Is it ? What's wrong exactly ? If you had a floatingfigure in a 1.1.6 file, lyx-1.2.0

Re: [PATCH] Re: Here you go

2002-04-27 Thread John Levon
On Sat, Apr 27, 2002 at 10:23:45PM +0300, Dekel Tsur wrote: > If you had a floatingfigure in a 1.1.6 file, lyx-1.2.0 will read is as > a standard figure. Therefore, the DVI output will be wrong. This is not my definition of "very bad" to be honest. I think a patch to UPGRADING would be much

Re: [PATCH] Re: Here you go

2002-04-27 Thread Dekel Tsur
On Sat, Apr 27, 2002 at 08:28:18PM +0100, John Levon wrote: > On Sat, Apr 27, 2002 at 10:23:45PM +0300, Dekel Tsur wrote: > > > If you had a floatingfigure in a 1.1.6 file, lyx-1.2.0 will read is as > > a standard figure. Therefore, the DVI output will be wrong. > > This is not my definition

Re: [PATCH] Re: Here you go

2002-04-27 Thread John Levon
On Sat, Apr 27, 2002 at 10:49:56PM +0300, Dekel Tsur wrote: > The patch to UPGRADING: > > ... LyX 1.2.0 does not handle correctly older files. After the upgrade, > you will need to spend several hours to manually fix your files. > But LyX 1.2.0 is so wonderful, so it is worth your time! Oh

Re: [PATCH] Re: Here you go

2002-04-27 Thread Dekel Tsur
On Sat, Apr 27, 2002 at 08:52:14PM +0100, John Levon wrote: > On Sat, Apr 27, 2002 at 10:49:56PM +0300, Dekel Tsur wrote: > > > The patch to UPGRADING: > > > > ... LyX 1.2.0 does not handle correctly older files. After the upgrade, > > you will need to spend several hours to manually fix your

Re: [PATCH] Re: Here you go

2002-04-27 Thread John Levon
On Sat, Apr 27, 2002 at 10:54:59PM +0300, Dekel Tsur wrote: > > If this is such a big issue why didn't you do this patch 6 months or a > > year ago ? > > I wasn't aware of the problem You really managed to miss all the extra par stuff getting removed ?? > didn't have time. well ... it's not

[PATCH] Re: Here you go

2002-04-26 Thread John Levon
On Wed, Apr 24, 2002 at 01:05:19PM +0100, John Levon wrote: Everyone, 1.1.6 documents that use floatingfigure will work there because (I assume) lyx adds \usepackage{floatflt} itself for the old extra para stuff. Please apply ! john -- I continue to be amazed at what Andrei can make

Re: [PATCH] Re: Here you go

2002-04-26 Thread Lars Gullik Bjønnes
John Levon [EMAIL PROTECTED] writes: | On Wed, Apr 24, 2002 at 01:05:19PM +0100, John Levon wrote: Everyone, 1.1.6 documents that use floatingfigure will work there because (I assume) lyx adds \usepackage{floatflt} itself for the old extra para stuff. | Please apply ! done. --

Re: [PATCH] Re: Here you go

2002-04-26 Thread Dekel Tsur
On Fri, Apr 26, 2002 at 11:04:10AM +0100, John Levon wrote: On Wed, Apr 24, 2002 at 01:05:19PM +0100, John Levon wrote: Everyone, 1.1.6 documents that use floatingfigure will work there because (I assume) lyx adds \usepackage{floatflt} itself for the old extra para stuff. Please apply

Re: [PATCH] Re: Here you go

2002-04-26 Thread Lars Gullik Bjønnes
Dekel Tsur [EMAIL PROTECTED] writes: | On Fri, Apr 26, 2002 at 11:04:10AM +0100, John Levon wrote: On Wed, Apr 24, 2002 at 01:05:19PM +0100, John Levon wrote: Everyone, 1.1.6 documents that use floatingfigure will work there because (I assume) lyx adds \usepackage{floatflt} itself for the

Re: [PATCH] Re: Here you go

2002-04-26 Thread John Levon
On Fri, Apr 26, 2002 at 01:41:55PM +0300, Dekel Tsur wrote: Why we don't have a floatingfigure inset ? because nobody's coded it yet ? john -- I continue to be amazed at what Andrei can make templates do. Some of it still makes my head hurt. - Herb Sutter

[PATCH] Re: Here you go

2002-04-26 Thread John Levon
On Wed, Apr 24, 2002 at 01:05:19PM +0100, John Levon wrote: > Everyone, 1.1.6 documents that use floatingfigure will work there because (I > assume) lyx adds \usepackage{floatflt} itself for the old extra para > stuff. Please apply ! john -- "I continue to be amazed at what Andrei can make

Re: [PATCH] Re: Here you go

2002-04-26 Thread Lars Gullik Bjønnes
John Levon <[EMAIL PROTECTED]> writes: | On Wed, Apr 24, 2002 at 01:05:19PM +0100, John Levon wrote: > >> Everyone, 1.1.6 documents that use floatingfigure will work there because (I >> assume) lyx adds \usepackage{floatflt} itself for the old extra para >> stuff. > | Please apply ! done. --

Re: [PATCH] Re: Here you go

2002-04-26 Thread Dekel Tsur
On Fri, Apr 26, 2002 at 11:04:10AM +0100, John Levon wrote: > On Wed, Apr 24, 2002 at 01:05:19PM +0100, John Levon wrote: > > > Everyone, 1.1.6 documents that use floatingfigure will work there because (I > > assume) lyx adds \usepackage{floatflt} itself for the old extra para > > stuff. > >

Re: [PATCH] Re: Here you go

2002-04-26 Thread Lars Gullik Bjønnes
Dekel Tsur <[EMAIL PROTECTED]> writes: | On Fri, Apr 26, 2002 at 11:04:10AM +0100, John Levon wrote: >> On Wed, Apr 24, 2002 at 01:05:19PM +0100, John Levon wrote: >> >> > Everyone, 1.1.6 documents that use floatingfigure will work there because (I >> > assume) lyx adds \usepackage{floatflt}

Re: [PATCH] Re: Here you go

2002-04-26 Thread John Levon
On Fri, Apr 26, 2002 at 01:41:55PM +0300, Dekel Tsur wrote: > Why we don't have a floatingfigure inset ? because nobody's coded it yet ? john -- "I continue to be amazed at what Andrei can make templates do. Some of it still makes my head hurt." - Herb Sutter