Re: [PATCH] bug 2614: crash or error when loading file with bogus changes

2006-06-08 Thread Jean-Marc Lasgouttes
Jean-Marc == Jean-Marc Lasgouttes [EMAIL PROTECTED] writes: Jean-Marc This patch tries to fix bug 2614. Basically, dur to bug Jean-Marc 2007, it was possible to create files not under change Jean-Marc tracking that would contain \change_inserted tags. In this Jean-Marc case, the autor id is not

Re: [PATCH] bug 2614: crash or error when loading file with bogus changes

2006-06-08 Thread Michael Gerz
Jean-Marc Lasgouttes wrote: Jean-Marc Michael, I think this is orthogonal to your CT work, right? I committed the patch on both 1.4 branch and trunk. Michael, you almost tricked me into using an assert for 1.5 instead :) Actually, crashing on invalid lyx files is considered as bad taste

Re: [PATCH] bug 2614: crash or error when loading file with bogus changes

2006-06-08 Thread Jean-Marc Lasgouttes
> "Jean-Marc" == Jean-Marc Lasgouttes <[EMAIL PROTECTED]> writes: Jean-Marc> This patch tries to fix bug 2614. Basically, dur to bug Jean-Marc> 2007, it was possible to create files not under change Jean-Marc> tracking that would contain \change_inserted tags. In this Jean-Marc> case, the

Re: [PATCH] bug 2614: crash or error when loading file with bogus changes

2006-06-08 Thread Michael Gerz
Jean-Marc Lasgouttes wrote: Jean-Marc> Michael, I think this is orthogonal to your CT work, right? I committed the patch on both 1.4 branch and trunk. Michael, you almost tricked me into using an assert for 1.5 instead :) Actually, crashing on invalid lyx files is considered as bad taste

Re: [PATCH] bug 2614: crash or error when loading file with bogus changes

2006-05-31 Thread Jean-Marc Lasgouttes
Michael == Michael Gerz [EMAIL PROTECTED] writes: Michael in LyX 1.5, any document may have changes, no matter whether Michael CT is currently activated or not. The described problem Michael should not occur at all. Even when the changes_inserted tag contains an author id that does not exist?

Re: [PATCH] bug 2614: crash or error when loading file with bogus changes

2006-05-31 Thread Jean-Marc Lasgouttes
> "Michael" == Michael Gerz <[EMAIL PROTECTED]> writes: Michael> in LyX 1.5, any document may have changes, no matter whether Michael> CT is currently activated or not. The described problem Michael> should not occur at all. Even when the changes_inserted tag contains an author id that does

[PATCH] bug 2614: crash or error when loading file with bogus changes

2006-05-30 Thread Jean-Marc Lasgouttes
This patch tries to fix bug 2614. Basically, dur to bug 2007, it was possible to create files not under change tracking that would contain \change_inserted tags. In this case, the autor id is not meaningful and this creates a crash. Please test this patch on the various files that have been

Re: [PATCH] bug 2614: crash or error when loading file with bogus changes

2006-05-30 Thread Michael Gerz
Jean-Marc Lasgouttes wrote: Please test this patch on the various files that have been floating around. Michael, I think this is orthogonal to your CT work, right? Hi Jean-Marc, in LyX 1.5, any document may have changes, no matter whether CT is currently activated or not. The described

[PATCH] bug 2614: crash or error when loading file with bogus changes

2006-05-30 Thread Jean-Marc Lasgouttes
This patch tries to fix bug 2614. Basically, dur to bug 2007, it was possible to create files not under change tracking that would contain \change_inserted tags. In this case, the autor id is not meaningful and this creates a crash. Please test this patch on the various files that have been

Re: [PATCH] bug 2614: crash or error when loading file with bogus changes

2006-05-30 Thread Michael Gerz
Jean-Marc Lasgouttes wrote: Please test this patch on the various files that have been floating around. Michael, I think this is orthogonal to your CT work, right? Hi Jean-Marc, in LyX 1.5, any document may have changes, no matter whether CT is currently activated or not. The described