Abdelrazak Younes wrote:
please do you think i'm worthy enough to gain commit access ?
is not the only pending patch from me which is obsolete now just because
nobody has time to commit it.
I've warned about this bad situation many times. And this is not
affecting only you.
In case that
Abdelrazak Younes wrote:
>> please do you think i'm worthy enough to gain commit access ?
>> is not the only pending patch from me which is obsolete now just because
>> nobody has time to commit it.
>
> I've warned about this bad situation many times. And this is not
> affecting only you.
>
>
Pavel Sanda [EMAIL PROTECTED] writes:
JMarc, do you plan to commit it ?
Me? No, I did not! But if nobody did anything on monday, I'll do it.
please.
Arghh! I get rejects for PrefUi.ui and WorkArea.cpp!
JMarc
Jean-Marc Lasgouttes wrote:
Arghh! I get rejects for PrefUi.ui and WorkArea.cpp!
sorry about that.
Jürgen
JMarc, do you plan to commit it ?
Me? No, I did not! But if nobody did anything on monday, I'll do it.
please.
Arghh! I get rejects for PrefUi.ui and WorkArea.cpp!
please do you think i'm worthy enough to gain commit access ?
is not the only pending patch from me which is obsolete
Pavel Sanda wrote:
JMarc, do you plan to commit it ?
Me? No, I did not! But if nobody did anything on monday, I'll do it.
please.
Arghh! I get rejects for PrefUi.ui and WorkArea.cpp!
please do you think i'm worthy enough to gain commit access ?
is not the only pending patch from me which is
Pavel Sanda <[EMAIL PROTECTED]> writes:
>> > JMarc, do you plan to commit it ?
>>
>> Me? No, I did not! But if nobody did anything on monday, I'll do it.
>
> please.
Arghh! I get rejects for PrefUi.ui and WorkArea.cpp!
JMarc
Jean-Marc Lasgouttes wrote:
> Arghh! I get rejects for PrefUi.ui and WorkArea.cpp!
sorry about that.
Jürgen
> >> > JMarc, do you plan to commit it ?
> >>
> >> Me? No, I did not! But if nobody did anything on monday, I'll do it.
> >
> > please.
>
> Arghh! I get rejects for PrefUi.ui and WorkArea.cpp!
please do you think i'm worthy enough to gain commit access ?
is not the only pending patch from me
Pavel Sanda wrote:
JMarc, do you plan to commit it ?
Me? No, I did not! But if nobody did anything on monday, I'll do it.
please.
Arghh! I get rejects for PrefUi.ui and WorkArea.cpp!
please do you think i'm worthy enough to gain commit access ?
is not the only pending patch from me which is
JMarc, do you plan to commit it ?
Me? No, I did not! But if nobody did anything on monday, I'll do it.
please.
pavel
> > JMarc, do you plan to commit it ?
>
> Me? No, I did not! But if nobody did anything on monday, I'll do it.
please.
pavel
below is the patch polished according to the comments and i consider
it to be the fix for 2739.
i dropped on-top feature and will look on the suggestion above
later and as separate issue. what do you think ?
Looks good. A few comments below.
JMarc, do you plan to commit it ?
pavel
Pavel Sanda [EMAIL PROTECTED] writes:
below is the patch polished according to the comments and i consider
it to be the fix for 2739.
i dropped on-top feature and will look on the suggestion above
later and as separate issue. what do you think ?
Looks good. A few comments below.
> > below is the patch polished according to the comments and i consider
> > it to be the fix for 2739.
> >
> > i dropped on-top feature and will look on the suggestion above
> > later and as separate issue. what do you think ?
>
> Looks good. A few comments below.
JMarc, do you plan to commit
Pavel Sanda <[EMAIL PROTECTED]> writes:
>> > below is the patch polished according to the comments and i consider
>> > it to be the fix for 2739.
>> >
>> > i dropped on-top feature and will look on the suggestion above
>> > later and as separate issue. what do you think ?
>>
>> Looks good. A few
besides all the previous comments i see now one problem, which has
to be resolved before the patch can go in.
aha, this problem is in trunk itself. so use the last posted patch.
pavel
> besides all the previous comments i see now one problem, which has
> to be resolved before the patch can go in.
aha, this problem is in trunk itself. so use the last posted patch.
pavel
Looks good. A few comments below.
updated patch attached.
+void GuiLayoutBox::addSortItem(QString const item, bool sorted)
The name is strange. I'd rather keep addItem if possible, or
addSortedItem or addItemSort. (this is a minor complaint...)
changed to addItemSort.
+ //set
Pavel Sanda [EMAIL PROTECTED] writes:
| Looks good. A few comments below.
|
| updated patch attached.
I have not looked at parent, but wonder a bit about the use case
anyway. But...
| diff --git a/src/frontends/qt4/GuiToolbar.cpp
b/src/frontends/qt4/GuiToolbar.cpp
| index 9b727be..5889509
| + if (!sorted || end2 || !(item[0].category() ==
QChar::Letter_Uppercase)) {
'!=' does not work?
leftover from past.
Space after '//', but the comment in-itself looks strange? Do we have
misnamed function? setDefaultIndex? then we could ditch comment as
well.
removed.
the rest of
Pavel Sanda [EMAIL PROTECTED] writes:
I am a nit-pick and I know it...
| diff --git a/src/frontends/qt4/GuiToolbar.cpp
b/src/frontends/qt4/GuiToolbar.cpp
| index 9b727be..b518c54 100644
| --- a/src/frontends/qt4/GuiToolbar.cpp
| +++ b/src/frontends/qt4/GuiToolbar.cpp
| @@ -271,6 +272,29 @@
And now we are in multi-line terrritory, so add braces. :-)
omg :D
pavel
diff --git a/src/LyXFunc.cpp b/src/LyXFunc.cpp
index 2471363..f29782e 100644
--- a/src/LyXFunc.cpp
+++ b/src/LyXFunc.cpp
@@ -1947,6 +1947,9 @@ void LyXFunc::dispatch(FuncRequest const cmd)
besides all the previous comments i see now one problem, which has
to be resolved before the patch can go in.
p
> Looks good. A few comments below.
updated patch attached.
> > +void GuiLayoutBox::addSortItem(QString const & item, bool sorted)
>
> The name is strange. I'd rather keep addItem if possible, or
> addSortedItem or addItemSort. (this is a minor complaint...)
changed to addItemSort.
> > +
Pavel Sanda <[EMAIL PROTECTED]> writes:
| > Looks good. A few comments below.
|
| updated patch attached.
I have not looked at parent, but wonder a bit about the use case
anyway. But...
| diff --git a/src/frontends/qt4/GuiToolbar.cpp
b/src/frontends/qt4/GuiToolbar.cpp
| index 9b727be..5889509
> | + if (!sorted || end<2 || !(item[0].category() ==
> QChar::Letter_Uppercase)) {
>
> '!=' does not work?
leftover from past.
> Space after '//', but the comment in-itself looks strange? Do we have
> misnamed function? setDefaultIndex? then we could ditch comment as
> well.
removed.
the
Pavel Sanda <[EMAIL PROTECTED]> writes:
I am a nit-pick and I know it...
| diff --git a/src/frontends/qt4/GuiToolbar.cpp
b/src/frontends/qt4/GuiToolbar.cpp
| index 9b727be..b518c54 100644
| --- a/src/frontends/qt4/GuiToolbar.cpp
| +++ b/src/frontends/qt4/GuiToolbar.cpp
| @@ -271,6 +272,29 @@
> And now we are in multi-line terrritory, so add braces. :-)
omg :D
pavel
diff --git a/src/LyXFunc.cpp b/src/LyXFunc.cpp
index 2471363..f29782e 100644
--- a/src/LyXFunc.cpp
+++ b/src/LyXFunc.cpp
@@ -1947,6 +1947,9 @@ void LyXFunc::dispatch(FuncRequest const & cmd)
besides all the previous comments i see now one problem, which has
to be resolved before the patch can go in.
p
Pavel Sanda [EMAIL PROTECTED] writes:
below is the patch polished according to the comments and i consider
it to be the fix for 2739.
i dropped on-top feature and will look on the suggestion above
later and as separate issue. what do you think ?
Looks good. A few comments below.
+void
Pavel Sanda <[EMAIL PROTECTED]> writes:
> below is the patch polished according to the comments and i consider
> it to be the fix for 2739.
>
> i dropped on-top feature and will look on the suggestion above
> later and as separate issue. what do you think ?
Looks good. A few comments below.
>
Andre'? Is there a way to obtain this feature in Qt?
From a theoretical point of view there is
void QComboBox::setItemDelegate(QAbstractItemDelegate *)
which in turn has
void paint(QPainter * painter, const QStyleOptionViewItem option,
const QModelIndex index) const;
> > Andre'? Is there a way to obtain this feature in Qt?
>
> From a theoretical point of view there is
>
> void QComboBox::setItemDelegate(QAbstractItemDelegate *)
>
> which in turn has
>
> void paint(QPainter * painter, const QStyleOptionViewItem & option,
> const QModelIndex &
I do not have much time to think about it but I would say:
- a few (5?) entries at the top, followed by a horiz line
- below that, the normal entries, /including/ the ones that are already on
top.
There are probably more things to do to make it work right. Playing
with OO.o or
Pavel Sanda [EMAIL PROTECTED] writes:
Also, there may be a version of QComboBox that does that.
QComboBox does not seem to have such parallel, moreover it seems
that it has not support for horizontal line, which means one
of three possibilities:
- use string as '-' (ugly)
- use
On Wed, Oct 10, 2007 at 11:45:58AM +0200, Jean-Marc Lasgouttes wrote:
Pavel Sanda [EMAIL PROTECTED] writes:
Also, there may be a version of QComboBox that does that.
QComboBox does not seem to have such parallel, moreover it seems
that it has not support for horizontal line, which means
> I do not have much time to think about it but I would say:
>
> - a few (5?) entries at the top, followed by a horiz line
>
> - below that, the normal entries, /including/ the ones that are already on
> top.
>
> There are probably more things to do to make it work right. Playing
> with OO.o
Pavel Sanda <[EMAIL PROTECTED]> writes:
>> Also, there may be a version of QComboBox that does that.
>
> QComboBox does not seem to have such parallel, moreover it seems
> that it has not support for horizontal line, which means one
> of three possibilities:
> - use string as '-' (ugly)
>
On Wed, Oct 10, 2007 at 11:45:58AM +0200, Jean-Marc Lasgouttes wrote:
> Pavel Sanda <[EMAIL PROTECTED]> writes:
>
> >> Also, there may be a version of QComboBox that does that.
> >
> > QComboBox does not seem to have such parallel, moreover it seems
> > that it has not support for horizontal
Some people have asked for sorting the layouts, and we could indeed
add that to the prefs. I have no hard feelings on the question.
However, I totally dislike the hardcoded test for '-'.
would you feel comfortable with some test eg isalpha(string[0]) instead ?
pavel
Pavel Sanda [EMAIL PROTECTED] writes:
Some people have asked for sorting the layouts, and we could indeed
add that to the prefs. I have no hard feelings on the question.
However, I totally dislike the hardcoded test for '-'.
would you feel comfortable with some test eg isalpha(string[0])
> Some people have asked for sorting the layouts, and we could indeed
> add that to the prefs. I have no hard feelings on the question.
> However, I totally dislike the hardcoded test for '-'.
would you feel comfortable with some test eg isalpha(string[0]) instead ?
pavel
Pavel Sanda <[EMAIL PROTECTED]> writes:
>> Some people have asked for sorting the layouts, and we could indeed
>> add that to the prefs. I have no hard feelings on the question.
>> However, I totally dislike the hardcoded test for '-'.
>
> would you feel comfortable with some test eg
On Thu, Sep 27, 2007 at 01:58:39AM +0200, Pavel Sanda wrote:
hi,
one thing which is annoying for me when working with lyx is lenghty
locating of a given environement in environment box for certain
classes which have many items, even more that i usually use only few
of these items.
now i
Pavel Sanda [EMAIL PROTECTED] writes:
now i have working skeleton for bug 2739, which introduces two
preference options - one for alphabetical sorting and the second
which put environment used during the current editation on the top
of the envi list.
before spending time on some gui coding
now i have working skeleton for bug 2739, which introduces two preference
options - one for alphabetical sorting and the second which put
environment used during the current editation on the top of the envi list.
Is it still possible to use the current, thematic sorting with that?
until
Some people have asked for sorting the layouts, and we could indeed
add that to the prefs. I have no hard feelings on the question.
However, I totally dislike the hardcoded test for '-'.
i'm not happy about that either. have you another idea how to get
rid off --Separator-- on the top of the
Pavel Sanda ha scritto:
hi,
one thing which is annoying for me when working with lyx is lenghty locating
of a given environement in environment box for certain classes which have
many items, even more that i usually use only few of these items.
now i have working skeleton for bug 2739, which
Pavel Sanda [EMAIL PROTECTED] writes:
could you describe more precisely how would the on top feature look like
to be useful ?
I do not have much time to think about it but I would say:
- a few (5?) entries at the top, followed by a horiz line
- below that, the normal entries, /including/
I do not have much time to think about it but I would say:
- a few (5?) entries at the top, followed by a horiz line
Yes. In a few applications (word?), recently used fonts and styles are
put on top like this, followed by a separator and then a full list.
I dislike the idea of sorting and I
I would suggest making both of these options enabled by default
i dont think we should change the default behaviour.
pavel
I do not have much time to think about it but I would say:
- a few (5?) entries at the top, followed by a horiz line
Yes. In a few applications (word?), recently used fonts and styles are
put on top like this, followed by a separator and then a full list.
I dislike the idea of sorting
I dislike the idea of sorting and I think the above would be enough
the sorting is optional and turned off by default in preferences.
if some people (including me) find it helpful to keep it sorted in certain
circumstances, i dont see why not to allow them.
If there is an acceptable
I dislike the idea of sorting and I think the above would be enough
the sorting is optional and turned off by default in preferences.
if some people (including me) find it helpful to keep it sorted in certain
circumstances, i dont see why not to allow them.
If there is an acceptable
On Thu, Sep 27, 2007 at 01:58:39AM +0200, Pavel Sanda wrote:
> hi,
>
> one thing which is annoying for me when working with lyx is lenghty
> locating of a given environement in environment box for certain
> classes which have many items, even more that i usually use only few
> of these items.
>
Pavel Sanda <[EMAIL PROTECTED]> writes:
> now i have working skeleton for bug 2739, which introduces two
> preference options - one for alphabetical sorting and the second
> which put environment used during the current editation on the top
> of the envi list.
>
> before spending time on some gui
> > now i have working skeleton for bug 2739, which introduces two preference
> > options - one for alphabetical sorting and the second which put
> > environment used during the current editation on the top of the envi list.
>
> Is it still possible to use the current, thematic sorting with that?
> Some people have asked for sorting the layouts, and we could indeed
> add that to the prefs. I have no hard feelings on the question.
> However, I totally dislike the hardcoded test for '-'.
i'm not happy about that either. have you another idea how to get
rid off --Separator-- on the top of
Pavel Sanda ha scritto:
hi,
one thing which is annoying for me when working with lyx is lenghty locating
of a given environement in environment box for certain classes which have
many items, even more that i usually use only few of these items.
now i have working skeleton for bug 2739, which
Pavel Sanda <[EMAIL PROTECTED]> writes:
> could you describe more precisely how would the on top feature look like
> to be useful ?
I do not have much time to think about it but I would say:
- a few (5?) entries at the top, followed by a horiz line
- below that, the normal entries,
> I do not have much time to think about it but I would say:
>
> - a few (5?) entries at the top, followed by a horiz line
Yes. In a few applications (word?), recently used fonts and styles are
put on top like this, followed by a separator and then a full list.
I dislike the idea of sorting and
> I would suggest making both of these options enabled by default
i dont think we should change the default behaviour.
pavel
> > I do not have much time to think about it but I would say:
> >
> > - a few (5?) entries at the top, followed by a horiz line
>
> Yes. In a few applications (word?), recently used fonts and styles are
> put on top like this, followed by a separator and then a full list.
>
> I dislike the idea
> > I dislike the idea of sorting and I think the above would be enough
>
> the sorting is optional and turned off by default in preferences.
> if some people (including me) find it helpful to keep it sorted in certain
> circumstances, i dont see why not to allow them.
If there is an acceptable
> > > I dislike the idea of sorting and I think the above would be enough
> >
> > the sorting is optional and turned off by default in preferences.
> > if some people (including me) find it helpful to keep it sorted in certain
> > circumstances, i dont see why not to allow them.
>
> If there is
hi,
one thing which is annoying for me when working with lyx is lenghty locating
of a given environement in environment box for certain classes which have
many items, even more that i usually use only few of these items.
now i have working skeleton for bug 2739, which introduces two preference
Pavel Sanda wrote:
now i have working skeleton for bug 2739, which introduces two preference
options - one for alphabetical sorting and the second which put
environment used during the current editation on the top of the envi list.
Is it still possible to use the current, thematic sorting
hi,
one thing which is annoying for me when working with lyx is lenghty locating
of a given environement in environment box for certain classes which have
many items, even more that i usually use only few of these items.
now i have working skeleton for bug 2739, which introduces two preference
Pavel Sanda wrote:
> now i have working skeleton for bug 2739, which introduces two preference
> options - one for alphabetical sorting and the second which put
> environment used during the current editation on the top of the envi list.
Is it still possible to use the current, thematic sorting
70 matches
Mail list logo
