Georg, Andre, Lars,
Please review this patch; I am not quite sure these are the correct
fixes for the MSVC warning. But it seems to parse math correctly.
Abdel.
Index: MathParser.C
===
--- MathParser.C(revision 15714)
+++
Abdelrazak Younes wrote:
Please review this patch; I am not quite sure these are the correct
fixes for the MSVC warning. But it seems to parse math correctly.
-CatCode theCatcode[256];
+CatCode theCatcode[sizeof(lyx::char_type)];
Hm, is sizeof(lyx::char_type) not 4? I think you mean
1
Asger Ottar Alstrup wrote:
Abdelrazak Younes wrote:
Please review this patch; I am not quite sure these are the correct
fixes for the MSVC warning. But it seems to parse math correctly.
-CatCode theCatcode[256];
+CatCode theCatcode[sizeof(lyx::char_type)];
Hm, is sizeof(lyx::char_type)
Abdelrazak Younes wrote:
Georg, Andre, Lars,
Please review this patch; I am not quite sure these are the correct
fixes for the MSVC warning. But it seems to parse math correctly.
It was not (due to the size problem pointed out by Asger). What do you
think of this one?
IIRC, this will
Am Samstag, 4. November 2006 11:24 schrieb Abdelrazak Younes:
Abdelrazak Younes wrote:
Georg, Andre, Lars,
Please review this patch; I am not quite sure these are the correct
fixes for the MSVC warning. But it seems to parse math correctly.
It was not (due to the size problem pointed
Georg Baum wrote:
Am Samstag, 4. November 2006 11:24 schrieb Abdelrazak Younes:
Abdelrazak Younes wrote:
Georg, Andre, Lars,
Please review this patch; I am not quite sure these are the correct
fixes for the MSVC warning. But it seems to parse math correctly.
It was not (due to the size
On Sat, Nov 04, 2006 at 11:43:18AM +0100, Georg Baum wrote:
Am Samstag, 4. November 2006 11:24 schrieb Abdelrazak Younes:
Abdelrazak Younes wrote:
Georg, Andre, Lars,
Please review this patch; I am not quite sure these are the correct
fixes for the MSVC warning. But it seems to
Georg, Andre, Lars,
Please review this patch; I am not quite sure these are the correct
fixes for the MSVC warning. But it seems to parse math correctly.
Abdel.
Index: MathParser.C
===
--- MathParser.C(revision 15714)
+++
Abdelrazak Younes wrote:
Please review this patch; I am not quite sure these are the correct
fixes for the MSVC warning. But it seems to parse math correctly.
>
-CatCode theCatcode[256];
+CatCode theCatcode[sizeof(lyx::char_type)];
Hm, is sizeof(lyx::char_type) not 4? I think you mean
1
Asger Ottar Alstrup wrote:
Abdelrazak Younes wrote:
Please review this patch; I am not quite sure these are the correct
fixes for the MSVC warning. But it seems to parse math correctly.
>
-CatCode theCatcode[256];
+CatCode theCatcode[sizeof(lyx::char_type)];
Hm, is sizeof(lyx::char_type)
Abdelrazak Younes wrote:
Georg, Andre, Lars,
Please review this patch; I am not quite sure these are the correct
fixes for the MSVC warning. But it seems to parse math correctly.
It was not (due to the size problem pointed out by Asger). What do you
think of this one?
IIRC, this will
Am Samstag, 4. November 2006 11:24 schrieb Abdelrazak Younes:
> Abdelrazak Younes wrote:
> > Georg, Andre, Lars,
> >
> > Please review this patch; I am not quite sure these are the correct
> > fixes for the MSVC warning. But it seems to parse math correctly.
>
> It was not (due to the size
Georg Baum wrote:
Am Samstag, 4. November 2006 11:24 schrieb Abdelrazak Younes:
Abdelrazak Younes wrote:
Georg, Andre, Lars,
Please review this patch; I am not quite sure these are the correct
fixes for the MSVC warning. But it seems to parse math correctly.
It was not (due to the size
On Sat, Nov 04, 2006 at 11:43:18AM +0100, Georg Baum wrote:
> Am Samstag, 4. November 2006 11:24 schrieb Abdelrazak Younes:
> > Abdelrazak Younes wrote:
> > > Georg, Andre, Lars,
> > >
> > > Please review this patch; I am not quite sure these are the correct
> > > fixes for the MSVC warning.
Georg Baum wrote:
This patch actually compiles.
Here is a patch that goes farther...
Abdel.
Index: src/cursor.C
===
--- src/cursor.C(revision 15352)
+++ src/cursor.C(working copy)
@@ -699,7 +699,8 @@
void
Georg Baum wrote:
This patch actually compiles.
Here is a patch that goes farther...
Abdel.
Index: src/cursor.C
===
--- src/cursor.C(revision 15352)
+++ src/cursor.C(working copy)
@@ -699,7 +699,8 @@
void
Will commit soon.
Abdel.
Index: insetbox.C
===
--- insetbox.C (revision 15262)
+++ insetbox.C (working copy)
@@ -147,18 +147,19 @@
BoxType btype = boxtranslator().find(params_.type);
- string label;
+
Am Sonntag, 8. Oktober 2006 11:25 schrieb Abdelrazak Younes:
- string label;
+ docstring label;
// FIXME UNICODE
- label += lyx::to_utf8(_(Box));
- label += (;
+ label += _(Box);
+ label += lyx::from_utf8( ();
No. Never use from_utf8 for pure
Georg Baum wrote:
Am Sonntag, 8. Oktober 2006 11:25 schrieb Abdelrazak Younes:
- string label;
+ docstring label;
// FIXME UNICODE
- label += lyx::to_utf8(_(Box));
- label += (;
+ label += _(Box);
+ label += lyx::from_utf8( ();
No. Never use
Am Sonntag, 8. Oktober 2006 11:51 schrieb Abdelrazak Younes:
Very good. I've tried that actually and was deceived that it was still
not in.
I simply forgot it (and now dug out a wrong version which returned a copy
of the string. This is fixed now).
For other cases we have from_ascii.
Will commit soon.
Abdel.
Index: insetbox.C
===
--- insetbox.C (revision 15262)
+++ insetbox.C (working copy)
@@ -147,18 +147,19 @@
BoxType btype = boxtranslator().find(params_.type);
- string label;
+
Am Sonntag, 8. Oktober 2006 11:25 schrieb Abdelrazak Younes:
> - string label;
> + docstring label;
> // FIXME UNICODE
> - label += lyx::to_utf8(_("Box"));
> - label += " (";
> + label += _("Box");
> + label += lyx::from_utf8(" (");
No. Never use
Georg Baum wrote:
Am Sonntag, 8. Oktober 2006 11:25 schrieb Abdelrazak Younes:
- string label;
+ docstring label;
// FIXME UNICODE
- label += lyx::to_utf8(_("Box"));
- label += " (";
+ label += _("Box");
+ label += lyx::from_utf8(" (");
No. Never
Am Sonntag, 8. Oktober 2006 11:51 schrieb Abdelrazak Younes:
> Very good. I've tried that actually and was deceived that it was still
> not in.
I simply forgot it (and now dug out a wrong version which returned a copy
of the string. This is fixed now).
> > For other cases we have from_ascii.
>
Lars Gullik Bjønnes wrote:
This is the convert patch I am going to commit unless I hear a lot of
bad language.
Is it Friday? Then you're cheating.
(There are some testing code that is not visible here that will also
be committed)
This is ancient history. path_defines.C.in has gone. Remove
Angus Leeming [EMAIL PROTECTED] writes:
| Lars Gullik Bjønnes wrote:
This is the convert patch I am going to commit unless I hear a lot of
bad language.
| Is it Friday? Then you're cheating.
(There are some testing code that is not visible here that will also
be committed)
| This is
Lars Gullik Bjønnes wrote:
> This is the convert patch I am going to commit unless I hear a lot of
> bad language.
Is it Friday? Then you're cheating.
> (There are some testing code that is not visible here that will also
> be committed)
This is ancient history. path_defines.C.in has gone.
Angus Leeming <[EMAIL PROTECTED]> writes:
| Lars Gullik Bjønnes wrote:
>
>> This is the convert patch I am going to commit unless I hear a lot of
>> bad language.
>
| Is it Friday? Then you're cheating.
>
>> (There are some testing code that is not visible here that will also
>> be committed)
>
|
This is the convert patch I am going to commit unless I hear a lot of
bad language.
(There are some testing code that is not visible here that will also
be committed)
? Config
? convert-1.diff
? convert-2.diff
? convert-3.diff
? cppflags-1.diff
? idxupdown2-1.diff
? includes-1.diff
?
This is the convert patch I am going to commit unless I hear a lot of
bad language.
(There are some testing code that is not visible here that will also
be committed)
? Config
? convert-1.diff
? convert-2.diff
? convert-3.diff
? cppflags-1.diff
? idxupdown2-1.diff
? includes-1.diff
?
Hi Lars,
here comes the converter patch that is necessary due to Angus's last patch.
Kind regards, Michael
PS: Could you please also check my other patches???
- Trivial mouse wheel patch
- Fix of CTRL-Pos1/End in mathed
- Fix for spacing around previewed formula
Index:
Hi Lars,
here comes the converter patch that is necessary due to Angus's last patch.
Kind regards, Michael
PS: Could you please also check my other patches???
- Trivial mouse wheel patch
- Fix of CTRL-Pos1/End in mathed
- Fix for spacing around previewed formula
Index:
32 matches
Mail list logo