Re: [Updated Patch] Toc model/view separation (was Re: [patch] qt4: toc tweak)

2006-04-26 Thread Abdelrazak Younes
Andre Poenitz a écrit : On Wed, Apr 26, 2006 at 09:49:01AM +0200, Abdelrazak Younes wrote: Andre Poenitz a écrit : Not in my vi. The previous lines uses a tab for indentation (as they should) and the 'insertColums' line uses four spaces. Believe it or not, that _is_ a difference. Two people

Re: [Updated Patch] Toc model/view separation (was Re: [patch] qt4: toc tweak)

2006-04-26 Thread Andre Poenitz
On Wed, Apr 26, 2006 at 09:49:01AM +0200, Abdelrazak Younes wrote: > Andre Poenitz a écrit : > >On Mon, Apr 17, 2006 at 07:54:04PM +0200, Abdelrazak Younes wrote: > >>+void TocModel::populate(toc::Toc const & toc_list) > >>+{ > >>+ clear(); > >>+ > >>+ if (toc_list.empty()) > >>+ retu

Re: [Updated Patch] Toc model/view separation (was Re: [patch] qt4: toc tweak)

2006-04-26 Thread Abdelrazak Younes
Lars Gullik Bjønnes a écrit : Abdelrazak Younes <[EMAIL PROTECTED]> writes: | Andre Poenitz a écrit : | > On Mon, Apr 17, 2006 at 07:54:04PM +0200, Abdelrazak Younes wrote: | >> +void TocModel::populate(toc::Toc const & toc_list) | >> +{ | >> +clear(); | >> + | >> +if (toc_list.empty())

Re: [Updated Patch] Toc model/view separation (was Re: [patch] qt4: toc tweak)

2006-04-26 Thread Lars Gullik Bjønnes
Abdelrazak Younes <[EMAIL PROTECTED]> writes: | Andre Poenitz a écrit : | > On Mon, Apr 17, 2006 at 07:54:04PM +0200, Abdelrazak Younes wrote: | >> +void TocModel::populate(toc::Toc const & toc_list) | >> +{ | >> + clear(); | >> + | >> + if (toc_list.empty()) | >> + return; | >> + | >>

Re: [Updated Patch] Toc model/view separation (was Re: [patch] qt4: toc tweak)

2006-04-26 Thread Abdelrazak Younes
Andre Poenitz a écrit : On Mon, Apr 17, 2006 at 07:54:04PM +0200, Abdelrazak Younes wrote: +void TocModel::populate(toc::Toc const & toc_list) +{ + clear(); + + if (toc_list.empty()) + return; + + int current_row; + QModelIndex top_level_item; + + toc:

Re: [Updated Patch] Toc model/view separation (was Re: [patch] qt4: toc tweak)

2006-04-25 Thread Andre Poenitz
On Mon, Apr 17, 2006 at 07:54:04PM +0200, Abdelrazak Younes wrote: > +void TocModel::populate(toc::Toc const & toc_list) > +{ > + clear(); > + > + if (toc_list.empty()) > + return; > + > + int current_row; > + QModelIndex top_level_item; > + > + toc::Toc::const_itera

Re: [Updated Patch] Toc model/view separation (was Re: [patch] qt4: toc tweak)

2006-04-18 Thread Abdelrazak Younes
Juergen Spitzmueller a écrit : Abdelrazak Younes wrote: Any opinion against me committing this? As there doesn't seem to be any and the current state is already better than before the model/view split, I am going to commit it. I'd say so, too. done. Abdel.

Re: [Updated Patch] Toc model/view separation (was Re: [patch] qt4: toc tweak)

2006-04-18 Thread Abdelrazak Younes
Martin Vermeer a écrit : On Tue, 2006-04-18 at 10:57 +0200, Abdelrazak Younes wrote: Martin Vermeer a écrit : On Mon, Apr 17, 2006 at 07:54:04PM +0200, Abdelrazak Younes wrote: Abdelrazak Younes a écrit : ... Side question about outline for Martin: The outline function takes no argument.

Re: [Updated Patch] Toc model/view separation (was Re: [patch] qt4: toc tweak)

2006-04-18 Thread Juergen Spitzmueller
Abdelrazak Younes wrote: >> Any opinion against me committing this? > > As there doesn't seem to be any and the current state is already better > than before the model/view split, I am going to commit it. I'd say so, too. Jürgen

Re: [Updated Patch] Toc model/view separation (was Re: [patch] qt4: toc tweak)

2006-04-18 Thread Abdelrazak Younes
Abdelrazak Younes a écrit : Abdelrazak Younes a écrit : For the rest, here is a status: - slider depth: not yet implemented - navigating: only with mouse-click for now, the connection to the selectionModel doesn't work... solved by reconnecting the selectionModel at each update. - outline: s

Re: [Updated Patch] Toc model/view separation (was Re: [patch] qt4: toc tweak)

2006-04-18 Thread Martin Vermeer
On Tue, 2006-04-18 at 10:57 +0200, Abdelrazak Younes wrote: > Martin Vermeer a écrit : > > On Mon, Apr 17, 2006 at 07:54:04PM +0200, Abdelrazak Younes wrote: > >> Abdelrazak Younes a écrit : > > > > ... > > > >> Side question about outline for Martin: > >> > >> The outline function takes no argu

Re: [Updated Patch] Toc model/view separation (was Re: [patch] qt4: toc tweak)

2006-04-18 Thread Abdelrazak Younes
Martin Vermeer a écrit : On Mon, Apr 17, 2006 at 07:54:04PM +0200, Abdelrazak Younes wrote: Abdelrazak Younes a écrit : ... Side question about outline for Martin: The outline function takes no argument. It moves or transforms the section where the cursor is. I think it should instead tak

Re: [Updated Patch] Toc model/view separation (was Re: [patch] qt4: toc tweak)

2006-04-17 Thread Martin Vermeer
On Mon, Apr 17, 2006 at 07:54:04PM +0200, Abdelrazak Younes wrote: > Abdelrazak Younes a écrit : ... > Side question about outline for Martin: > > The outline function takes no argument. It moves or transforms the > section where the cursor is. I think it should instead take a pit or a > uid

[Updated Patch] Toc model/view separation (was Re: [patch] qt4: toc tweak)

2006-04-17 Thread Abdelrazak Younes
Abdelrazak Younes a écrit : Juergen Spitzmueller a écrit : Abdelrazak Younes wrote: Please don't wait too much time on this as you motivated me to do the mode/view separation (see attached) ;-) Nice, but please don't tell me that you removed the slider now. Not in the GUI but it is not impl