[patch]: clean-up InsetGraphics::Cache and make it accessible to all

2003-06-04 Thread Angus Leeming
This cleans up InsetGraphics::Cache and renames it as GraphicsInset so that the external inset can use it too. -- AngusIndex: src/insets/graphicinset.h === RCS file: src/insets/graphicinset.h diff -N src/insets/graphicinset.h ---

Re: [patch]: clean-up InsetGraphics::Cache and make it accessible to all

2003-06-04 Thread Andre Poenitz
On Tue, Jun 03, 2003 at 06:17:10PM +, Angus Leeming wrote: This cleans up InsetGraphics::Cache and renames it as GraphicsInset so that the external inset can use it too. What do you need old_ascent_ for? + old_ascent_ = (type == IMAGE) ? loader_.image()-getHeight() : 50; + +

Re: [patch]: clean-up InsetGraphics::Cache and make it accessible to all

2003-06-04 Thread Angus Leeming
Andre Poenitz wrote: On Tue, Jun 03, 2003 at 06:17:10PM +, Angus Leeming wrote: This cleans up InsetGraphics::Cache and renames it as GraphicsInset so that the external inset can use it too. What do you need old_ascent_ for? + old_ascent_ = (type == IMAGE) ?

Re: [patch]: clean-up InsetGraphics::Cache and make it accessible to all

2003-06-04 Thread Andre Poenitz
On Wed, Jun 04, 2003 at 08:49:55AM +, Angus Leeming wrote: Andre Poenitz wrote: On Tue, Jun 03, 2003 at 06:17:10PM +, Angus Leeming wrote: This cleans up InsetGraphics::Cache and renames it as GraphicsInset so that the external inset can use it too. What do you need

Re: [patch]: clean-up InsetGraphics::Cache and make it accessible to all

2003-06-04 Thread Angus Leeming
Angus Leeming wrote: Andre Poenitz wrote: On Tue, Jun 03, 2003 at 06:17:10PM +, Angus Leeming wrote: This cleans up InsetGraphics::Cache and renames it as GraphicsInset so that the external inset can use it too. What do you need old_ascent_ for? + old_ascent_ = (type ==

Re: [patch]: clean-up InsetGraphics::Cache and make it accessible to all

2003-06-04 Thread Andre Poenitz
On Wed, Jun 04, 2003 at 09:17:19AM +, Angus Leeming wrote: Ok, the question becomes: can dim_.asc change between it being set in GraphicInset::metrics and it being used in GraphicInset::draw? I don't think so. That is what this piece of code is testing for. I think not but I don't know

[patch]: clean-up InsetGraphics::Cache and make it accessible to all

2003-06-04 Thread Angus Leeming
This cleans up InsetGraphics::Cache and renames it as GraphicsInset so that the external inset can use it too. -- AngusIndex: src/insets/graphicinset.h === RCS file: src/insets/graphicinset.h diff -N src/insets/graphicinset.h ---

Re: [patch]: clean-up InsetGraphics::Cache and make it accessible to all

2003-06-04 Thread Andre Poenitz
On Tue, Jun 03, 2003 at 06:17:10PM +, Angus Leeming wrote: > This cleans up InsetGraphics::Cache and renames it as GraphicsInset so that > the external inset can use it too. What do you need old_ascent_ for? + old_ascent_ = (type == IMAGE) ? loader_.image()->getHeight() : 50; + +

Re: [patch]: clean-up InsetGraphics::Cache and make it accessible to all

2003-06-04 Thread Angus Leeming
Andre Poenitz wrote: > On Tue, Jun 03, 2003 at 06:17:10PM +, Angus Leeming wrote: >> This cleans up InsetGraphics::Cache and renames it as GraphicsInset so >> that the external inset can use it too. > > What do you need old_ascent_ for? > > + old_ascent_ = (type == IMAGE) ?

Re: [patch]: clean-up InsetGraphics::Cache and make it accessible to all

2003-06-04 Thread Andre Poenitz
On Wed, Jun 04, 2003 at 08:49:55AM +, Angus Leeming wrote: > Andre Poenitz wrote: > > > On Tue, Jun 03, 2003 at 06:17:10PM +, Angus Leeming wrote: > >> This cleans up InsetGraphics::Cache and renames it as GraphicsInset so > >> that the external inset can use it too. > > > > What do you

Re: [patch]: clean-up InsetGraphics::Cache and make it accessible to all

2003-06-04 Thread Angus Leeming
Angus Leeming wrote: > Andre Poenitz wrote: > >> On Tue, Jun 03, 2003 at 06:17:10PM +, Angus Leeming wrote: >>> This cleans up InsetGraphics::Cache and renames it as GraphicsInset so >>> that the external inset can use it too. >> >> What do you need old_ascent_ for? >> >> +

Re: [patch]: clean-up InsetGraphics::Cache and make it accessible to all

2003-06-04 Thread Andre Poenitz
On Wed, Jun 04, 2003 at 09:17:19AM +, Angus Leeming wrote: > Ok, the question becomes: > can dim_.asc change between it being set in GraphicInset::metrics and it > being used in GraphicInset::draw? I don't think so. > That is what this piece of code is testing for. I think not but I don't >