On Monday 04 June 2007 07:20:15 Jürgen Spitzmüller wrote:
OK here's a start.
convert_graphics_rotation seems to work (but I'm not sure it really does),
however, revert_graphics_rotation does not.
I really don't know what I'm doing here, so please help.
I took some time to look this
José Matos wrote:
I took some time to look this problem.
The logic seems right, there are one place where there is a off by one,
because in python range(a,b), assuming a and b integers goes from a to b-1.
This logic may seems strange but it pays because.
range(a,b) + range(b,c) ==
On Monday 04 June 2007 07:20:15 Jürgen Spitzmüller wrote:
> OK here's a start.
> convert_graphics_rotation seems to work (but I'm not sure it really does),
> however, revert_graphics_rotation does not.
>
> I really don't know what I'm doing here, so please help.
I took some time to look this
José Matos wrote:
> I took some time to look this problem.
>
> The logic seems right, there are one place where there is a off by one,
> because in python range(a,b), assuming a and b integers goes from a to b-1.
> This logic may seems strange but it pays because.
>
> range(a,b) + range(b,c)
Jean-Marc Lasgouttes wrote:
Jürgen BTW I find the separation useful, because I don't want to have
Jürgen large figures in my workarea (I usually scale them down to
Jürgen thumbnail sice). However, I understand your request; maybe we
Jürgen should have a selection scale: as in output|custom or
Jean-Marc Lasgouttes wrote:
Jürgen> BTW I find the separation useful, because I don't want to have
Jürgen> large figures in my workarea (I usually scale them down to
Jürgen> thumbnail sice). However, I understand your request; maybe we
Jürgen> should have a selection scale: "as in
Jürgen Spitzmüller wrote:
maybe someone else has?
The following needs to be done:
def convert_graphics_rotation(document):
if we have a graphics inset that has the rotateAngle param and either the
width, height or scaled param, then add the param scaleBeforeRotation. Else
do nothing.
Jürgen == Jürgen Spitzmüller [EMAIL PROTECTED] writes:
Jürgen http://bugzilla.lyx.org/show_bug.cgi?id=1749 Since this is a
Jürgen file format change and a long-standing bug, I decided to have
Jürgen a go before 1.5.0.
Jürgen Attached is the fix minus the actual lyx2lyx change (i.e., I
Jürgen
Jean-Marc Lasgouttes wrote:
Don't you need also some code to modify the on-screen preview??
Don't think so. The on-screen scaling is independent from the output scaling
(and rotation).
Jürgen
Jürgen == Jürgen Spitzmüller [EMAIL PROTECTED] writes:
Jürgen Jean-Marc Lasgouttes wrote:
Don't you need also some code to modify the on-screen preview??
Jürgen Don't think so. The on-screen scaling is independent from the
Jürgen output scaling (and rotation).
At least the rotation is shown
Jean-Marc Lasgouttes wrote:
Jürgen Don't think so. The on-screen scaling is independent from the
Jürgen output scaling (and rotation).
At least the rotation is shown on screen. And if the scaling is not
done, I think this is a bug...
We have a separate scale setting for screen display. The
Jürgen == Jürgen Spitzmüller [EMAIL PROTECTED] writes:
Jürgen Jean-Marc Lasgouttes wrote: Don't think so. The on-screen
Jürgen scaling is independent from the output scaling (and rotation).
At least the rotation is shown on screen. And if the scaling is
not done, I think this is a bug...
Jean-Marc Lasgouttes wrote:
It matters if you fix the width.
You're right, but it still doesn't matter on screen.
Jürgen
Jürgen == Jürgen Spitzmüller [EMAIL PROTECTED] writes:
Jürgen Jean-Marc Lasgouttes wrote:
It matters if you fix the width.
Jürgen You're right, but it still doesn't matter on screen.
I like to see figure adapted on screen as they are supposed to be on
paper. I do not understand actually why
Jean-Marc Lasgouttes wrote:
I like to see figure adapted on screen as they are supposed to be on
paper. I do not understand actually why we have a separate on-screen
setting.
Right, but this would be a separate issue (enhancement request or whatever),
unrelated to my patch.
Jürgen
Jürgen == Jürgen Spitzmüller [EMAIL PROTECTED] writes:
Jürgen Jean-Marc Lasgouttes wrote:
I like to see figure adapted on screen as they are supposed to be
on paper. I do not understand actually why we have a separate
on-screen setting.
Jürgen Right, but this would be a separate issue
Jean-Marc Lasgouttes wrote:
Jürgen Right, but this would be a separate issue (enhancement request
Jürgen or whatever), unrelated to my patch.
Indeed.
BTW I find the separation useful, because I don't want to have large figures
in my workarea (I usually scale them down to thumbnail sice).
Jürgen == Jürgen Spitzmüller [EMAIL PROTECTED] writes:
Jürgen Jean-Marc Lasgouttes wrote: Right, but this would be a
Jürgen separate issue (enhancement request or whatever), unrelated to
Jürgen my patch.
Indeed.
Jürgen BTW I find the separation useful, because I don't want to have
Jürgen
Jürgen Spitzmüller wrote:
> maybe someone else has?
>
> The following needs to be done:
>
>
> def convert_graphics_rotation(document):
>
> if we have a graphics inset that has the rotateAngle param and either the
> width, height or scaled param, then add the param scaleBeforeRotation. Else
> do
> "Jürgen" == Jürgen Spitzmüller <[EMAIL PROTECTED]> writes:
Jürgen> http://bugzilla.lyx.org/show_bug.cgi?id=1749 Since this is a
Jürgen> file format change and a long-standing bug, I decided to have
Jürgen> a go before 1.5.0.
Jürgen> Attached is the fix minus the actual lyx2lyx change
Jean-Marc Lasgouttes wrote:
> Don't you need also some code to modify the on-screen preview??
Don't think so. The on-screen scaling is independent from the output scaling
(and rotation).
Jürgen
> "Jürgen" == Jürgen Spitzmüller <[EMAIL PROTECTED]> writes:
Jürgen> Jean-Marc Lasgouttes wrote:
>> Don't you need also some code to modify the on-screen preview??
Jürgen> Don't think so. The on-screen scaling is independent from the
Jürgen> output scaling (and rotation).
At least the
Jean-Marc Lasgouttes wrote:
> Jürgen> Don't think so. The on-screen scaling is independent from the
> Jürgen> output scaling (and rotation).
>
> At least the rotation is shown on screen. And if the scaling is not
> done, I think this is a bug...
We have a separate "scale" setting for screen
> "Jürgen" == Jürgen Spitzmüller <[EMAIL PROTECTED]> writes:
Jürgen> Jean-Marc Lasgouttes wrote: Don't think so. The on-screen
Jürgen> scaling is independent from the output scaling (and rotation).
>> At least the rotation is shown on screen. And if the scaling is
>> not done, I think this
Jean-Marc Lasgouttes wrote:
> It matters if you fix the width.
You're right, but it still doesn't matter on screen.
Jürgen
> "Jürgen" == Jürgen Spitzmüller <[EMAIL PROTECTED]> writes:
Jürgen> Jean-Marc Lasgouttes wrote:
>> It matters if you fix the width.
Jürgen> You're right, but it still doesn't matter on screen.
I like to see figure adapted on screen as they are supposed to be on
paper. I do not understand
Jean-Marc Lasgouttes wrote:
> I like to see figure adapted on screen as they are supposed to be on
> paper. I do not understand actually why we have a separate on-screen
> setting.
Right, but this would be a separate issue (enhancement request or whatever),
unrelated to my patch.
Jürgen
> "Jürgen" == Jürgen Spitzmüller <[EMAIL PROTECTED]> writes:
Jürgen> Jean-Marc Lasgouttes wrote:
>> I like to see figure adapted on screen as they are supposed to be
>> on paper. I do not understand actually why we have a separate
>> on-screen setting.
Jürgen> Right, but this would be a
Jean-Marc Lasgouttes wrote:
> Jürgen> Right, but this would be a separate issue (enhancement request
> Jürgen> or whatever), unrelated to my patch.
>
> Indeed.
BTW I find the separation useful, because I don't want to have large figures
in my workarea (I usually scale them down to thumbnail
> "Jürgen" == Jürgen Spitzmüller <[EMAIL PROTECTED]> writes:
Jürgen> Jean-Marc Lasgouttes wrote: Right, but this would be a
Jürgen> separate issue (enhancement request or whatever), unrelated to
Jürgen> my patch.
>> Indeed.
Jürgen> BTW I find the separation useful, because I don't want to
http://bugzilla.lyx.org/show_bug.cgi?id=1749
Since this is a file format change and a long-standing bug, I decided to have
a go before 1.5.0.
Attached is the fix minus the actual lyx2lyx change (i.e., I added an empty
lyx2lyx conversion/reversion).
What it does is adding a new graphics param
On Saturday 02 June 2007 09:18:56 Jürgen Spitzmüller wrote:
OK to go in?
Jürgen
It seems OK but I don't have time now to look into the lyx2lyx part.
--
José Abílio
Jürgen == Jürgen Spitzmüller [EMAIL PROTECTED] writes:
Jürgen http://bugzilla.lyx.org/show_bug.cgi?id=1749 Since this is a
Jürgen file format change and a long-standing bug, I decided to have
Jürgen a go before 1.5.0.
This looks like a good idea.
Jürgen Attached is the fix minus the actual
Jean-Marc Lasgouttes wrote:
I'd think that the right default is the opposite of what 1.4 does...
OK, I'll change the default then.
Jürgen
José Matos wrote:
I don't have time now to look into the lyx2lyx part.
maybe someone else has?
The following needs to be done:
def convert_graphics_rotation(document):
if we have a graphics inset that has the rotateAngle param and either the
width, height or scaled param, then add the param
http://bugzilla.lyx.org/show_bug.cgi?id=1749
Since this is a file format change and a long-standing bug, I decided to have
a go before 1.5.0.
Attached is the fix minus the actual lyx2lyx change (i.e., I added an empty
lyx2lyx conversion/reversion).
What it does is adding a new graphics param
On Saturday 02 June 2007 09:18:56 Jürgen Spitzmüller wrote:
> OK to go in?
>
> Jürgen
It seems OK but I don't have time now to look into the lyx2lyx part.
--
José Abílio
> "Jürgen" == Jürgen Spitzmüller <[EMAIL PROTECTED]> writes:
Jürgen> http://bugzilla.lyx.org/show_bug.cgi?id=1749 Since this is a
Jürgen> file format change and a long-standing bug, I decided to have
Jürgen> a go before 1.5.0.
This looks like a good idea.
Jürgen> Attached is the fix minus
Jean-Marc Lasgouttes wrote:
> I'd think that the right default is the opposite of what 1.4 does...
OK, I'll change the default then.
Jürgen
José Matos wrote:
> I don't have time now to look into the lyx2lyx part.
maybe someone else has?
The following needs to be done:
def convert_graphics_rotation(document):
if we have a graphics inset that has the rotateAngle param and either the
width, height or scaled param, then add the
40 matches
Mail list logo
