Re: [patch] tex2lyx crash when full path is given from commandline on Win32

2007-07-01 Thread José Matos
On Saturday 30 June 2007 11:34:34 Abdelrazak Younes wrote: > To me too. > > Abdel. +1 -- José Abílio

Re: [patch] tex2lyx crash when full path is given from commandline on Win32

2007-06-30 Thread hangzai luo
Sorry for the late response. I'm out of town and can't check e-mail in time. And here is the authorization to the LyX devel group: I hereby grant permission to licence my contributions to LyX under the Gnu General Public Licence, version 2 or later Thanks! Hangzai Luo On 6/30/07, Jürgen Spi

Re: [patch] tex2lyx crash when full path is given from commandline on Win32

2007-06-30 Thread Jürgen Spitzmüller
Abdelrazak Younes wrote: > > What about this patch? It looks good to me. > > To me too. Thanks. I'll commit if I get another OK. Hangzai, could you please send a message to lyx-devel in the meantime, stating something like "I hereby grant permission to licence my contributions to LyX under the

Re: [patch] tex2lyx crash when full path is given from commandline on Win32

2007-06-30 Thread Abdelrazak Younes
Jürgen Spitzmüller wrote: hzluo wrote: This patch addresses problem of bug: http://bugzilla.lyx.org/show_bug.cgi?id=3788 What about this patch? It looks good to me. To me too. Abdel.

Re: [patch] tex2lyx crash when full path is given from commandline on Win32

2007-06-30 Thread Jürgen Spitzmüller
hzluo wrote: > This patch addresses problem of bug: > > http://bugzilla.lyx.org/show_bug.cgi?id=3788 What about this patch? It looks good to me. Can I apply it (the attached, slightly modified version)? Jürgen Index: src/tex2lyx/tex2lyx.cpp ===

Re: [patch] tex2lyx crash when full path is given from commandline on Win32

2007-06-16 Thread hzluo
full path is given from commandline on Win32 What was from with the five lines or so I posted that uses QCoreApplication::arguments()? Andre'

Re: [patch] tex2lyx crash when full path is given from commandline on Win32

2007-06-16 Thread Alfredo Braunstein
Andre Poenitz wrote: > On Sat, Jun 16, 2007 at 12:10:27PM +0200, Andre Poenitz wrote: >> What was from with the five lines or so I posted that uses >> QCoreApplication::arguments()? > > s/from/wrong with/ > > Andre' s=/wrong\ with=/wrong= ;-) A/

Re: [patch] tex2lyx crash when full path is given from commandline on Win32

2007-06-16 Thread Andre Poenitz
On Sat, Jun 16, 2007 at 12:10:27PM +0200, Andre Poenitz wrote: > What was from with the five lines or so I posted that uses > QCoreApplication::arguments()? s/from/wrong with/ Andre'

Re: [patch] tex2lyx crash when full path is given from commandline on Win32

2007-06-16 Thread Andre Poenitz
On Fri, Jun 15, 2007 at 11:39:23PM -0400, hzluo wrote: > >We've been relaxing the rules lately; support/ uses > >QtCore for a number of things and I think it would > >be much saner at this point to use QFileInfo, QProcess > >and QNetwork to replace our hand-made local code. > >If somebody steps up

Re: [patch] tex2lyx crash when full path is given from commandline on Win32

2007-06-15 Thread hzluo
We've been relaxing the rules lately; support/ uses QtCore for a number of things and I think it would be much saner at this point to use QFileInfo, QProcess and QNetwork to replace our hand-made local code. If somebody steps up to encapsulate this Qt API in our API (forkedControllers, Socket and

Re: [patch] tex2lyx crash when full path is given from commandline on Win32

2007-06-14 Thread Abdelrazak Younes
Andre Poenitz wrote: PS: I wonder whether delegating that kind of mess to an external library would be politically correct in this universe ;-} We've been relaxing the rules lately; support/ uses QtCore for a number of things and I think it would be much saner at this point to use QFileInfo,

Re: [patch] tex2lyx crash when full path is given from commandline on Win32

2007-06-13 Thread Andre Poenitz
On Wed, Jun 13, 2007 at 09:18:22PM -0400, hzluo wrote: > I just tested and found that it's the Qt or M$'s stdc++ lib > that made the mistake. LyX call Qt to convert filenames to > UTF-32, and then call Qt again to convert it to local 8bit. A working [untested] solution using Qt is vector getArgum

Re: [patch] tex2lyx crash when full path is given from commandline on Win32

2007-06-13 Thread hzluo
Message - From: "Andre Poenitz" <[EMAIL PROTECTED]> To: "hzluo" <[EMAIL PROTECTED]> Cc: ; <[EMAIL PROTECTED]> Sent: Wednesday, June 13, 2007 3:54 PM Subject: Re: [patch] tex2lyx crash when full path is given from commandline on Win32 On Wed, Jun 13, 2

Re: [patch] tex2lyx crash when full path is given from commandline on Win32

2007-06-13 Thread Andre Poenitz
On Wed, Jun 13, 2007 at 02:23:21PM -0400, hzluo wrote: > I just tested it, and the answer is no... > At least on Windows XP with local set to Simplified Chinese, > LyX does not accept any filename with Chinese characters. > Neither lyx.exe nor tex2lyx.exe can propertly handle such files. I suspec

Re: [patch] tex2lyx crash when full path is given from commandline on Win32

2007-06-13 Thread hzluo
I just tested it, and the answer is no... At least on Windows XP with local set to Simplified Chinese, LyX does not accept any filename with Chinese characters. Neither lyx.exe nor tex2lyx.exe can propertly handle such files. I'm trying to make a patch for this problem. Hangzai Not related to

Re: [patch] tex2lyx crash when full path is given from commandline on Win32

2007-06-12 Thread Andre Poenitz
On Tue, Jun 12, 2007 at 06:30:41PM -0400, hzluo wrote: > This patch addresses problem of bug: > > http://bugzilla.lyx.org/show_bug.cgi?id=3788 > > The commandline parameters are supposed to be converted > to internal path via os::internal_path(), but tex2lyx > forgot to call it. Then an assertion

[patch] tex2lyx crash when full path is given from commandline on Win32

2007-06-12 Thread hzluo
This patch addresses problem of bug: http://bugzilla.lyx.org/show_bug.cgi?id=3788 The commandline parameters are supposed to be converted to internal path via os::internal_path(), but tex2lyx forgot to call it. Then an assertion in FileName::FileName() is triggled due to '\\' in the path. This p