Re: r30395 - lyx-devel/trunk/src/mathed

2009-07-09 Thread Enrico Forestieri
On Wed, Jul 08, 2009 at 11:23:11AM +0200, Vincent van Ravesteijn - TNW wrote: Your commits at r30396 and r30398 were not correct. On one hand, one could still position the cursor with the mouse and perform a change, on the other hand, the user should be able to edit the macro at any

Re: r30425 - lyx-devel/trunk/src/mathed

2009-07-09 Thread Enrico Forestieri
On Thu, Jul 09, 2009 at 05:25:02PM +0200, Vincent van Ravesteijn - TNW wrote: Better fix for bug #5923. Now the macro name can be freely edited. I was by the way experiencing difficulties with Undo. After pressing backspace in a macro, there was no way to undo changes before hitting

Re: r30425 - lyx-devel/trunk/src/mathed

2009-07-09 Thread Enrico Forestieri
when *adding* characters to a macro name, as no undo information is recorded. However, this is independent of my patch and the attached seems to cure it. -- Enrico Index: src/mathed/InsetMathNest.cpp === --- src/mathed

Re: r30425 - lyx-devel/trunk/src/mathed

2009-07-09 Thread Enrico Forestieri
, but the implementation didn't follow it :) -- Enrico Index: src/mathed/InsetMathNest.cpp === --- src/mathed/InsetMathNest.cpp(revisione 30424) +++ src/mathed/InsetMathNest.cpp(copia locale) @@ -808,7 +808,7 @@ void

Re: r30425 - lyx-devel/trunk/src/mathed

2009-07-09 Thread Enrico Forestieri
On Thu, Jul 09, 2009 at 05:21:22PM +0200, for...@lyx.org wrote: Author: forenr Date: Thu Jul 9 17:21:21 2009 New Revision: 30425 URL: http://www.lyx.org/trac/changeset/30425 Log: Better fix for bug #5923. Now the macro name can be freely edited. Jürgen, this one and r30434 are candidates

Re: r30338 - in lyx-devel/trunk: lib src src/insets src/mathed

2009-07-09 Thread Enrico Forestieri
On Mon, Jul 06, 2009 at 10:55:12AM +0200, Jürgen Spitzmüller wrote: Enrico Forestieri wrote: Jürgen, I think we can risk backporting this to branch. Whatever problem may show up, I deem it easily solvable. OK. Some intense testing would be most welcome, though. All my tests didn't reveal

RE: r30425 - lyx-devel/trunk/src/mathed

2009-07-09 Thread Vincent van Ravesteijn - TNW
>Better fix for bug #5923. Now the macro name can be freely edited. I was by the way experiencing difficulties with Undo. After pressing backspace in a macro, there was no way to undo changes before hitting backspace. Don't know whether that's still a problem. Vincent

Re: r30395 - lyx-devel/trunk/src/mathed

2009-07-09 Thread Enrico Forestieri
On Wed, Jul 08, 2009 at 11:23:11AM +0200, Vincent van Ravesteijn - TNW wrote: > > > Your commits at r30396 and r30398 were not correct. On > > one hand, one could still position the cursor with the > > mouse and perform a change, on the other hand, the user > > should be able to edit the macro

Re: r30425 - lyx-devel/trunk/src/mathed

2009-07-09 Thread Enrico Forestieri
On Thu, Jul 09, 2009 at 05:25:02PM +0200, Vincent van Ravesteijn - TNW wrote: > > >Better fix for bug #5923. Now the macro name can be freely edited. > > I was by the way experiencing difficulties with Undo. After pressing > backspace in a macro, there was no way to undo changes before hitting >

Re: r30425 - lyx-devel/trunk/src/mathed

2009-07-09 Thread Enrico Forestieri
or a better fix. I don't see any problem now (famous last words). Indeed, I see an issue when *adding* characters to a macro name, as no undo information is recorded. However, this is independent of my patch and the attached seems to cure it. -- Enrico Index: src/mathed/InsetMathNest.cpp

Re: r30425 - lyx-devel/trunk/src/mathed

2009-07-09 Thread Enrico Forestieri
gt; undo information is recorded. However, this is independent of my patch > and the attached seems to cure it. Here is the proper patch. The comment was clear, but the implementation didn't follow it :) -- Enrico Index: src/mathed/InsetMathNest.cpp ====

Re: r30425 - lyx-devel/trunk/src/mathed

2009-07-09 Thread Enrico Forestieri
On Thu, Jul 09, 2009 at 05:21:22PM +0200, for...@lyx.org wrote: > Author: forenr > Date: Thu Jul 9 17:21:21 2009 > New Revision: 30425 > URL: http://www.lyx.org/trac/changeset/30425 > > Log: > Better fix for bug #5923. Now the macro name can be freely edited. Jürgen, this one and r30434 are

Re: r30338 - in lyx-devel/trunk: lib src src/insets src/mathed

2009-07-09 Thread Enrico Forestieri
On Mon, Jul 06, 2009 at 10:55:12AM +0200, Jürgen Spitzmüller wrote: > Enrico Forestieri wrote: > > Jürgen, I think we can risk backporting this to branch. Whatever problem > > may show up, I deem it easily solvable. > > OK. Some intense testing would be most welcome, though. All my tests didn't

RE: r30395 - lyx-devel/trunk/src/mathed

2009-07-08 Thread Vincent van Ravesteijn - TNW
I suggest reverting r30398, r30396, r30395, r30393, r30392, r29387, and trying to find the correct fix for #5923. I did that in r30409 and r30410. Let's start from here for fixing remaining issues. Good, I never said that my fix was the best, most proper fix, but I hope it contributed in

RE: r30395 - lyx-devel/trunk/src/mathed

2009-07-08 Thread Vincent van Ravesteijn - TNW
>> I suggest reverting r30398, r30396, r30395, r30393, >> r30392, r29387, and trying to find the correct fix >> for #5923. > > I did that in r30409 and r30410. Let's start from here > for fixing remaining issues. Good, I never said that my fix was the best, most proper fix, but I hope it

Re: r30395 - lyx-devel/trunk/src/mathed

2009-07-07 Thread Jürgen Spitzmüller
vfr wrote: Author: vfr Date: Tue Jul 7 10:13:07 2009 New Revision: 30395 URL: http://www.lyx.org/trac/changeset/30395 Log: Fix crash when selecting part of a macro and trying to resume macro-mode editing. Please let me know whatever of these macro fixes is to be considered for branch.

Re: r30395 - lyx-devel/trunk/src/mathed

2009-07-07 Thread Vincent van Ravesteijn
Jürgen Spitzmüller schreef: vfr wrote: Author: vfr Date: Tue Jul 7 10:13:07 2009 New Revision: 30395 URL: http://www.lyx.org/trac/changeset/30395 Log: Fix crash when selecting part of a macro and trying to resume macro-mode editing. Please let me know whatever of these macro fixes

Re: r30395 - lyx-devel/trunk/src/mathed

2009-07-07 Thread Jürgen Spitzmüller
Vincent van Ravesteijn wrote: r30392, r30393, and r30395 are fixes problems that were introduced by the fix for bug 5923. To be safe, I didn't backport this fix for the previous release, but it might be a candidate for branch now. Could you come up with a complete patch for branch that

Re: r30395 - lyx-devel/trunk/src/mathed

2009-07-07 Thread Enrico Forestieri
On Tue, Jul 07, 2009 at 10:56:38AM +0200, Jürgen Spitzmüller wrote: Vincent van Ravesteijn wrote: r30392, r30393, and r30395 are fixes problems that were introduced by the fix for bug 5923. To be safe, I didn't backport this fix for the previous release, but it might be a candidate for

RE: r30395 - lyx-devel/trunk/src/mathed

2009-07-07 Thread Vincent van Ravesteijn - TNW
Vincent van Ravesteijn wrote: r30392, r30393, and r30395 are fixes problems that were introduced by the fix for bug 5923. To be safe, I didn't backport this fix for the previous release, but it might be a candidate for branch now. Could you come up with a complete patch for branch

Re: r30395 - lyx-devel/trunk/src/mathed

2009-07-07 Thread Vincent van Ravesteijn
Enrico Forestieri schreef: On Tue, Jul 07, 2009 at 10:56:38AM +0200, Jürgen Spitzmüller wrote: Vincent van Ravesteijn wrote: r30392, r30393, and r30395 are fixes problems that were introduced by the fix for bug 5923. To be safe, I didn't backport this fix for the previous release, but

Re: r30395 - lyx-devel/trunk/src/mathed

2009-07-07 Thread Enrico Forestieri
On Tue, Jul 07, 2009 at 09:37:14PM +0200, Vincent van Ravesteijn wrote: Enrico Forestieri schreef: On Tue, Jul 07, 2009 at 10:56:38AM +0200, Jürgen Spitzmüller wrote: Vincent van Ravesteijn wrote: r30392, r30393, and r30395 are fixes problems that were introduced by the fix

Re: r30395 - lyx-devel/trunk/src/mathed

2009-07-07 Thread Enrico Forestieri
On Tue, Jul 07, 2009 at 10:52:11PM +0200, Enrico Forestieri wrote: I suggest reverting r30398, r30396, r30395, r30393, r30392, r29387, and trying to find the correct fix for #5923. I did that in r30409 and r30410. Let's start from here for fixing remaining issues. Your commits at r30396 and

Re: r30395 - lyx-devel/trunk/src/mathed

2009-07-07 Thread Jürgen Spitzmüller
vfr wrote: > Author: vfr > Date: Tue Jul 7 10:13:07 2009 > New Revision: 30395 > URL: http://www.lyx.org/trac/changeset/30395 > > Log: > Fix crash when selecting part of a macro and trying to resume macro-mode > editing. Please let me know whatever of these macro fixes is to be considered for

Re: r30395 - lyx-devel/trunk/src/mathed

2009-07-07 Thread Vincent van Ravesteijn
Jürgen Spitzmüller schreef: vfr wrote: Author: vfr Date: Tue Jul 7 10:13:07 2009 New Revision: 30395 URL: http://www.lyx.org/trac/changeset/30395 Log: Fix crash when selecting part of a macro and trying to resume macro-mode editing. Please let me know whatever of these macro fixes

Re: r30395 - lyx-devel/trunk/src/mathed

2009-07-07 Thread Jürgen Spitzmüller
Vincent van Ravesteijn wrote: > r30392, r30393, and r30395 are fixes problems that were introduced by > the fix for bug 5923. To be safe, I didn't backport this fix for the > previous release, but it might be a candidate for branch now. Could you come up with a complete patch for branch that

Re: r30395 - lyx-devel/trunk/src/mathed

2009-07-07 Thread Enrico Forestieri
On Tue, Jul 07, 2009 at 10:56:38AM +0200, Jürgen Spitzmüller wrote: > Vincent van Ravesteijn wrote: > > r30392, r30393, and r30395 are fixes problems that were introduced by > > the fix for bug 5923. To be safe, I didn't backport this fix for the > > previous release, but it might be a candidate

RE: r30395 - lyx-devel/trunk/src/mathed

2009-07-07 Thread Vincent van Ravesteijn - TNW
>> Vincent van Ravesteijn wrote: >> > r30392, r30393, and r30395 are fixes problems that were introduced >> > by the fix for bug 5923. To be safe, I didn't backport this fix for >> > the previous release, but it might be a candidate for branch now. >> >> Could you come up with a complete patch

Re: r30395 - lyx-devel/trunk/src/mathed

2009-07-07 Thread Vincent van Ravesteijn
Enrico Forestieri schreef: On Tue, Jul 07, 2009 at 10:56:38AM +0200, Jürgen Spitzmüller wrote: Vincent van Ravesteijn wrote: r30392, r30393, and r30395 are fixes problems that were introduced by the fix for bug 5923. To be safe, I didn't backport this fix for the previous release, but

Re: r30395 - lyx-devel/trunk/src/mathed

2009-07-07 Thread Enrico Forestieri
On Tue, Jul 07, 2009 at 09:37:14PM +0200, Vincent van Ravesteijn wrote: > Enrico Forestieri schreef: > > On Tue, Jul 07, 2009 at 10:56:38AM +0200, Jürgen Spitzmüller wrote: > > > >> Vincent van Ravesteijn wrote: > >> > >>> r30392, r30393, and r30395 are fixes problems that were introduced

Re: r30395 - lyx-devel/trunk/src/mathed

2009-07-07 Thread Enrico Forestieri
On Tue, Jul 07, 2009 at 10:52:11PM +0200, Enrico Forestieri wrote: > I suggest reverting r30398, r30396, r30395, r30393, r30392, r29387, > and trying to find the correct fix for #5923. I did that in r30409 and r30410. Let's start from here for fixing remaining issues. Your commits at r30396 and

Re: r30338 - in lyx-devel/trunk: lib src src/insets src/mathed

2009-07-06 Thread Enrico Forestieri
On Fri, Jul 03, 2009 at 02:05:59AM +0200, for...@lyx.org wrote: Author: forenr Date: Fri Jul 3 02:05:58 2009 New Revision: 30338 URL: http://www.lyx.org/trac/changeset/30338 Log: Fix bugs #6047, #4043, and #5394. 6047: Lyx 1.6.3 unable to typeset the third chemical equation of the

Re: r30338 - in lyx-devel/trunk: lib src src/insets src/mathed

2009-07-06 Thread Jürgen Spitzmüller
Enrico Forestieri wrote: Jürgen, I think we can risk backporting this to branch. Whatever problem may show up, I deem it easily solvable. OK. Some intense testing would be most welcome, though. Jürgen

Re: r30338 - in lyx-devel/trunk: lib src src/insets src/mathed

2009-07-06 Thread Enrico Forestieri
On Fri, Jul 03, 2009 at 02:05:59AM +0200, for...@lyx.org wrote: > Author: forenr > Date: Fri Jul 3 02:05:58 2009 > New Revision: 30338 > URL: http://www.lyx.org/trac/changeset/30338 > > Log: > Fix bugs #6047, #4043, and #5394. > 6047: Lyx 1.6.3 unable to typeset the third chemical equation of

Re: r30338 - in lyx-devel/trunk: lib src src/insets src/mathed

2009-07-06 Thread Jürgen Spitzmüller
Enrico Forestieri wrote: > Jürgen, I think we can risk backporting this to branch. Whatever problem > may show up, I deem it easily solvable. OK. Some intense testing would be most welcome, though. Jürgen

Re: r30363 - lyx-devel/trunk/src/mathed

2009-07-05 Thread Jürgen Spitzmüller
forenr wrote: Log: Fix bug #6041: tabular-feature align- in a math-matrix. Also for branch, I guess? Jürgen

Re: r30363 - lyx-devel/trunk/src/mathed

2009-07-05 Thread Jean-Marc Lasgouttes
Le 5 juil. 09 à 02:24, for...@lyx.org a écrit : Author: forenr Date: Sun Jul 5 02:24:17 2009 New Revision: 30363 URL: http://www.lyx.org/trac/changeset/30363 Log: Fix bug #6041: tabular-feature align- in a math-matrix. Oops! Looks like it was my fault. JMarc

Re: r30363 - lyx-devel/trunk/src/mathed

2009-07-05 Thread Enrico Forestieri
On Sun, Jul 05, 2009 at 10:29:24AM +0200, Jürgen Spitzmüller wrote: forenr wrote: Log: Fix bug #6041: tabular-feature align- in a math-matrix. Also for branch, I guess? Yep. I also committed a subsequent fix for the correct display of centered vertical alignment status in math matrices.

Re: r30363 - lyx-devel/trunk/src/mathed

2009-07-05 Thread Jürgen Spitzmüller
Enrico Forestieri wrote: Also for branch, I guess? Yep. I also committed a subsequent fix for the correct display of centered vertical alignment status in math matrices. Thanks. Jürgen

Re: r30363 - lyx-devel/trunk/src/mathed

2009-07-05 Thread Jürgen Spitzmüller
forenr wrote: > Log: > Fix bug #6041: "tabular-feature align-" in a math-matrix. Also for branch, I guess? Jürgen

Re: r30363 - lyx-devel/trunk/src/mathed

2009-07-05 Thread Jean-Marc Lasgouttes
Le 5 juil. 09 à 02:24, for...@lyx.org a écrit : Author: forenr Date: Sun Jul 5 02:24:17 2009 New Revision: 30363 URL: http://www.lyx.org/trac/changeset/30363 Log: Fix bug #6041: "tabular-feature align-" in a math-matrix. Oops! Looks like it was my fault. JMarc

Re: r30363 - lyx-devel/trunk/src/mathed

2009-07-05 Thread Enrico Forestieri
On Sun, Jul 05, 2009 at 10:29:24AM +0200, Jürgen Spitzmüller wrote: > forenr wrote: > > Log: > > Fix bug #6041: "tabular-feature align-" in a math-matrix. > > Also for branch, I guess? Yep. I also committed a subsequent fix for the correct display of centered vertical alignment status in math

Re: r30363 - lyx-devel/trunk/src/mathed

2009-07-05 Thread Jürgen Spitzmüller
Enrico Forestieri wrote: > > Also for branch, I guess? > > Yep. I also committed a subsequent fix for the correct display of centered > vertical alignment status in math matrices. Thanks. Jürgen

Re: r30246 - in lyx-devel/trunk/src: . mathed

2009-06-23 Thread Enrico Forestieri
On Tue, Jun 23, 2009 at 08:01:31PM +0200, forenr wrote: Author: forenr Date: Tue Jun 23 20:01:31 2009 New Revision: 30246 URL: http://www.lyx.org/trac/changeset/30246 Log: Fix bug #6033: Initial character sometimes eaten by math-insert OK for branch? -- Enrico

Re: r30246 - in lyx-devel/trunk/src: . mathed

2009-06-23 Thread Jürgen Spitzmüller
Enrico Forestieri wrote: Log: Fix bug #6033: Initial character sometimes eaten by math-insert OK for branch? Yes. Jürgen

Re: r30246 - in lyx-devel/trunk/src: . mathed

2009-06-23 Thread Enrico Forestieri
On Tue, Jun 23, 2009 at 08:01:31PM +0200, forenr wrote: > Author: forenr > Date: Tue Jun 23 20:01:31 2009 > New Revision: 30246 > URL: http://www.lyx.org/trac/changeset/30246 > > Log: > Fix bug #6033: Initial character sometimes eaten by math-insert OK for branch? -- Enrico

Re: r30246 - in lyx-devel/trunk/src: . mathed

2009-06-23 Thread Jürgen Spitzmüller
Enrico Forestieri wrote: > > Log: > > Fix bug #6033: Initial character sometimes eaten by math-insert > > OK for branch? Yes. Jürgen

Re: r30145 - lyx-devel/trunk/src/mathed

2009-06-17 Thread Jürgen Spitzmüller
Enrico Forestieri wrote: Log: Reintroduce workaround due to nested math hulls as it is not guaranteed that LyX is always able to replace $...$ constructs with \ensuremath{...}. Should also go to branch. OK. Jürgen

Re: r30145 - lyx-devel/trunk/src/mathed

2009-06-17 Thread Jürgen Spitzmüller
Enrico Forestieri wrote: > > Log: > > Reintroduce workaround due to nested math hulls as it is not > > guaranteed that LyX is always able to replace $...$ constructs > > with \ensuremath{...}. > > Should also go to branch. OK. Jürgen

Re: r30145 - lyx-devel/trunk/src/mathed

2009-06-16 Thread Enrico Forestieri
$...$ constructs with \ensuremath{...}. Should also go to branch. Modified: lyx-devel/trunk/src/mathed/InsetMathHull.cpp Modified: lyx-devel/trunk/src/mathed/InsetMathHull.cpp == --- lyx-devel/trunk/src/mathed

Re: r30145 - lyx-devel/trunk/src/mathed

2009-06-16 Thread Enrico Forestieri
that LyX is always able to replace $...$ constructs > with \ensuremath{...}. Should also go to branch. > Modified: >lyx-devel/trunk/src/mathed/InsetMathHull.cpp > > Modified: lyx-devel/trunk/src/mathed/InsetMathHull.cpp >

Re: r29746 - lyx-devel/trunk/src/mathed

2009-05-20 Thread Enrico Forestieri
. Ok for branch? This is pretty safe and only allows entering an EnsureMath inset by Ctrl-m instead of typing \ensuremath. Modified: lyx-devel/trunk/src/mathed/InsetMathNest.cpp Modified: lyx-devel/trunk/src/mathed/InsetMathNest.cpp

Re: r29746 - lyx-devel/trunk/src/mathed

2009-05-20 Thread Jürgen Spitzmüller
Enrico Forestieri wrote: Fix bug #1435. Now Ctrl-m enters math mode when in text-in-math mode, instead of producing nested text boxes. Ok for branch? This is pretty safe and only allows entering an EnsureMath inset by Ctrl-m instead of typing \ensuremath. Fine with me. Jürgen

Re: r29746 - lyx-devel/trunk/src/mathed

2009-05-20 Thread Enrico Forestieri
tead of producing nested text boxes. Ok for branch? This is pretty safe and only allows entering an EnsureMath inset by Ctrl-m instead of typing \ensuremath. > Modified: >lyx-devel/trunk/src/mathed/InsetMathNest.cpp > > Modified: lyx-deve

Re: r29746 - lyx-devel/trunk/src/mathed

2009-05-20 Thread Jürgen Spitzmüller
Enrico Forestieri wrote: > > Fix bug #1435. Now Ctrl-m enters math mode when in text-in-math mode, > > instead of producing nested text boxes. > > Ok for branch? This is pretty safe and only allows entering an EnsureMath > inset by Ctrl-m instead of typing \ensuremath. Fine with me. Jürgen

Re: r29114 - in lyx-devel/trunk: lib/ui src/mathed

2009-04-07 Thread Abdelrazak Younes
Uwe Stöhr wrote: Abdelrazak Younes schrieb: I don't understand, what do you propose? This... not tested nor compiled... I understand now. But I think its a matter of taste. Well, it's matter of good taste ;-) Good taste in programming is something that you develop continuously, not

Re: r29114 - in lyx-devel/trunk: lib/ui src/mathed

2009-04-07 Thread Enrico Forestieri
On Tue, Apr 07, 2009 at 02:07:52AM +0200, Uwe Stöhr wrote: Uwe Stöhr schrieb: You are doing it the wrong way, IMHO. You should introduce \cfracleft and \cfracright in place of \cfracthree and give visual feedback for the position of the numerator. I think that your solution is

Re: r29114 - in lyx-devel/trunk: lib/ui src/mathed

2009-04-07 Thread Abdelrazak Younes
Uwe Stöhr wrote: Abdelrazak Younes schrieb: I don't understand, what do you propose? This... not tested nor compiled... I understand now. But I think its a matter of taste. Well, it's matter of good taste ;-) Good taste in programming is something that you develop continuously, not

Re: r29114 - in lyx-devel/trunk: lib/ui src/mathed

2009-04-07 Thread Enrico Forestieri
On Tue, Apr 07, 2009 at 02:07:52AM +0200, Uwe Stöhr wrote: > Uwe Stöhr schrieb: > > >> You are doing it the wrong way, IMHO. You should introduce \cfracleft > >> and \cfracright in place of \cfracthree and give visual feedback for > >> the position of the numerator. > > > > I think that your

Re: r29118 - lyx-devel/trunk/src/mathed

2009-04-06 Thread Jürgen Spitzmüller
Enrico Forestieri wrote: Log: Don't create nested text-in-math environments. Jürgen, Ok for branch? Without this, when pasting \text{§} you woud get \text{\text{§}}. OK. Jürgen

Re: r29114 - in lyx-devel/trunk: lib/ui src/mathed

2009-04-06 Thread Abdelrazak Younes
Uwe Stöhr wrote: I am not criticizing the merge, perhaps this is needed and better but in effect you are replacing many small functions by a single big fat one (metrics method I guess)... which is not so pretty. We already had the different fraction typed as kind of the InsetMathFraction

Re: r28981 - in lyx-devel/trunk: lib src src/mathed

2009-04-06 Thread Guenter Milde
On 2009-04-05, Enrico Forestieri wrote: On Fri, Apr 03, 2009 at 08:27:23AM +, Guenter Milde wrote: I think I found a resonable compromise: http://www.lyx.org/trac/changeset/29096 Now all unicode symbols entered (or normally pasted) into a math environment are automatically wrapped by

Re: r29114 - in lyx-devel/trunk: lib/ui src/mathed

2009-04-06 Thread Enrico Forestieri
On Sun, Apr 05, 2009 at 09:52:54PM +0200, uwesto...@lyx.org wrote: - support for the optional argument of \cfrac (cursor position still needs to be fixed, see post in mailing list) You are doing it the wrong way, IMHO. You should introduce \cfracleft and \cfracright in place of

Re: r29118 - lyx-devel/trunk/src/mathed

2009-04-06 Thread Enrico Forestieri
On Mon, Apr 06, 2009 at 08:25:32AM +0200, Jürgen Spitzmüller wrote: Enrico Forestieri wrote: Log: Don't create nested text-in-math environments. J�rgen, Ok for branch? Without this, when pasting \text{�} you woud get \text{\text{�}}. OK. I also backported r29121, as the

Re: r29114 - in lyx-devel/trunk: lib/ui src/mathed

2009-04-06 Thread Uwe Stöhr
optional arguments the way I implemented if for \cfrac for \makebox and \framebox in mathed. Nevertheless, I think that your solution is more intuitive and I'll implement this instead the next days. \makebox and \framebox will stay as they are because there we have two optional arguments

Re: r29114 - in lyx-devel/trunk: lib/ui src/mathed

2009-04-06 Thread Uwe Stöhr
Abdelrazak Younes schrieb: As I said, I am not discussing the merging. I would just prefer many small methods instead of a big fat one. I don't understand, what do you propose? regards Uwe

Re: r29114 - in lyx-devel/trunk: lib/ui src/mathed

2009-04-06 Thread Abdelrazak Younes
const * our_branch = branchlist.find(params_.branch); +if (!our_branch) break; - ourBranch-setSelected(cmd.action == LFUN_BRANCH_ACTIVATE); +const_castBranch *(our_branch)-setSelected(cmd.action == LFUN_BRANCH_ACTIVATE); break; } Index: mathed/InsetMathFrac.h

Re: r29130 - lyx-devel/trunk/src/mathed

2009-04-06 Thread Enrico Forestieri
On Tue, Apr 07, 2009 at 12:12:22AM +0200, for...@lyx.org wrote: Author: forenr Date: Tue Apr 7 00:12:22 2009 New Revision: 29130 URL: http://www.lyx.org/trac/changeset/29130 Log: Introduce a helper function and use it. Ok for branch? -- Enrico

Re: r29114 - in lyx-devel/trunk: lib/ui src/mathed

2009-04-06 Thread Uwe Stöhr
Uwe Stöhr schrieb: You are doing it the wrong way, IMHO. You should introduce \cfracleft and \cfracright in place of \cfracthree and give visual feedback for the position of the numerator. I think that your solution is more intuitive and I'll implement this instead the next days. I've

Re: r29114 - in lyx-devel/trunk: lib/ui src/mathed

2009-04-06 Thread Uwe Stöhr
Abdelrazak Younes schrieb: I don't understand, what do you propose? This... not tested nor compiled... I understand now. But I think its a matter of taste. Having a void for every inset kind is doubling code but might lead to a better overview. I now cleaned up the code a bit and think it

Re: r29130 - lyx-devel/trunk/src/mathed

2009-04-06 Thread Jürgen Spitzmüller
Enrico Forestieri wrote: Introduce a helper function and use it. Ok for branch? OK. Jürgen

Re: r29118 - lyx-devel/trunk/src/mathed

2009-04-06 Thread Jürgen Spitzmüller
Enrico Forestieri wrote: > > Log: > > Don't create nested text-in-math environments. > > Jürgen, Ok for branch? > > Without this, when pasting "\text{§}" you woud get "\text{\text{§}}". OK. Jürgen

Re: r29114 - in lyx-devel/trunk: lib/ui src/mathed

2009-04-06 Thread Abdelrazak Younes
Uwe Stöhr wrote: > I am not criticizing the merge, perhaps this is needed and better but in effect you are replacing > many small functions by a single big fat one (metrics method I guess)... which is not so pretty. We already had the different fraction typed as kind of the InsetMathFraction

Re: r28981 - in lyx-devel/trunk: lib src src/mathed

2009-04-06 Thread Guenter Milde
On 2009-04-05, Enrico Forestieri wrote: > On Fri, Apr 03, 2009 at 08:27:23AM +, Guenter Milde wrote: > I think I found a resonable compromise: > http://www.lyx.org/trac/changeset/29096 > Now all unicode symbols entered (or normally pasted) into a math > environment are automatically wrapped

Re: r29114 - in lyx-devel/trunk: lib/ui src/mathed

2009-04-06 Thread Enrico Forestieri
On Sun, Apr 05, 2009 at 09:52:54PM +0200, uwesto...@lyx.org wrote: > - support for the optional argument of \cfrac (cursor position still > needs to be fixed, see post in mailing list) You are doing it the wrong way, IMHO. You should introduce \cfracleft and \cfracright in place of

Re: r29118 - lyx-devel/trunk/src/mathed

2009-04-06 Thread Enrico Forestieri
On Mon, Apr 06, 2009 at 08:25:32AM +0200, Jürgen Spitzmüller wrote: > Enrico Forestieri wrote: > > > Log: > > > Don't create nested text-in-math environments. > > > > J�rgen, Ok for branch? > > > > Without this, when pasting "\text{�}" you woud get "\text{\text{�}}". > > OK. I also backported

Re: r29114 - in lyx-devel/trunk: lib/ui src/mathed

2009-04-06 Thread Uwe Stöhr
e already treat optional arguments the way I implemented if for \cfrac for \makebox and \framebox in mathed. Nevertheless, I think that your solution is more intuitive and I'll implement this instead the next days. \makebox and \framebox will stay as they are because there we have two optional

Re: r29114 - in lyx-devel/trunk: lib/ui src/mathed

2009-04-06 Thread Uwe Stöhr
Abdelrazak Younes schrieb: As I said, I am not discussing the merging. I would just prefer many small methods instead of a big fat one. I don't understand, what do you propose? regards Uwe

Re: r29114 - in lyx-devel/trunk: lib/ui src/mathed

2009-04-06 Thread Abdelrazak Younes
Branch const * our_branch = branchlist.find(params_.branch); +if (!our_branch) break; - ourBranch->setSelected(cmd.action == LFUN_BRANCH_ACTIVATE); +const_cast(our_branch)->setSelected(cmd.action == LFUN_BRANCH_ACTIVATE); break; } Index: ma

Re: r29130 - lyx-devel/trunk/src/mathed

2009-04-06 Thread Enrico Forestieri
On Tue, Apr 07, 2009 at 12:12:22AM +0200, for...@lyx.org wrote: > Author: forenr > Date: Tue Apr 7 00:12:22 2009 > New Revision: 29130 > URL: http://www.lyx.org/trac/changeset/29130 > > Log: > Introduce a helper function and use it. Ok for branch? -- Enrico

Re: r29114 - in lyx-devel/trunk: lib/ui src/mathed

2009-04-06 Thread Uwe Stöhr
Uwe Stöhr schrieb: You are doing it the wrong way, IMHO. You should introduce \cfracleft and \cfracright in place of \cfracthree and give visual feedback for >> the position of the numerator. I think that your solution is more intuitive and I'll implement this instead the next days. I've

Re: r29114 - in lyx-devel/trunk: lib/ui src/mathed

2009-04-06 Thread Uwe Stöhr
Abdelrazak Younes schrieb: I don't understand, what do you propose? This... not tested nor compiled... I understand now. But I think its a matter of taste. Having a void for every inset kind is doubling code but might lead to a better overview. I now cleaned up the code a bit and think it

Re: r29130 - lyx-devel/trunk/src/mathed

2009-04-06 Thread Jürgen Spitzmüller
Enrico Forestieri wrote: > > Introduce a helper function and use it. > > Ok for branch? OK. Jürgen

Re: r29096 - lyx-devel/trunk/src/mathed

2009-04-05 Thread Jürgen Spitzmüller
Enrico Forestieri wrote: Unicode symbols entered or pasted in math are wrapped in \text{} by default. Unwrapped symbols can be obtained either by dissolving the text inset or by verbatim paste (Ctrl+Shift+V). In such a case, the symbols are wrapped in \lyxmathsym when exporting to latex,

Re: r29114 - in lyx-devel/trunk: lib/ui src/mathed

2009-04-05 Thread Abdelrazak Younes
On 05/04/2009 21:52, uwesto...@lyx.org wrote: Author: uwestoehr Date: Sun Apr 5 21:52:53 2009 New Revision: 29114 URL: http://www.lyx.org/trac/changeset/29114 Log: major code cleanup for fractions: - InsetMathFrac.cpp/h: - InsetCFrac, InsetDFrac, and InsetTFrac are now included as kind

Re: r29114 - in lyx-devel/trunk: lib/ui src/mathed

2009-04-05 Thread Uwe Stöhr
I am not criticizing the merge, perhaps this is needed and better but in effect you are replacing many small functions by a single big fat one (metrics method I guess)... which is not so pretty. We already had the different fraction typed as kind of the InsetMathFraction inset, only the types

Re: r29118 - lyx-devel/trunk/src/mathed

2009-04-05 Thread Enrico Forestieri
{§} you woud get \text{\text{§}}. Modified: lyx-devel/trunk/src/mathed/MathParser.cpp Modified: lyx-devel/trunk/src/mathed/MathParser.cpp == --- lyx-devel/trunk/src/mathed/MathParser.cpp Mon Apr 6 00:32:24 2009

Re: r29096 - lyx-devel/trunk/src/mathed

2009-04-05 Thread Jürgen Spitzmüller
Enrico Forestieri wrote: > > Unicode symbols entered or pasted in math are wrapped in \text{} by > > default. Unwrapped symbols can be obtained either by dissolving the text > > inset or by verbatim paste (Ctrl+Shift+V). In such a case, the symbols > > are wrapped in \lyxmathsym when exporting to

Re: r29114 - in lyx-devel/trunk: lib/ui src/mathed

2009-04-05 Thread Abdelrazak Younes
On 05/04/2009 21:52, uwesto...@lyx.org wrote: Author: uwestoehr Date: Sun Apr 5 21:52:53 2009 New Revision: 29114 URL: http://www.lyx.org/trac/changeset/29114 Log: major code cleanup for fractions: - InsetMathFrac.cpp/h: - InsetCFrac, InsetDFrac, and InsetTFrac are now included as kind

Re: r29114 - in lyx-devel/trunk: lib/ui src/mathed

2009-04-05 Thread Uwe Stöhr
> I am not criticizing the merge, perhaps this is needed and better but in effect you are replacing > many small functions by a single big fat one (metrics method I guess)... which is not so pretty. We already had the different fraction typed as kind of the InsetMathFraction inset, only the

Re: r29118 - lyx-devel/trunk/src/mathed

2009-04-05 Thread Enrico Forestieri
ut this, when pasting "\text{§}" you woud get "\text{\text{§}}". > Modified: >lyx-devel/trunk/src/mathed/MathParser.cpp > > Modified: lyx-devel/trunk/src/mathed/MathParser.cpp > ====== >

Re: r28981 - in lyx-devel/trunk: lib src src/mathed

2009-04-04 Thread Enrico Forestieri
On Fri, Apr 03, 2009 at 08:27:23AM +, Guenter Milde wrote: On 2009-04-02, Enrico Forestieri wrote: On Thu, Apr 02, 2009 at 01:49:21PM +, Guenter Milde wrote: it would add the auto-switch to text-in-math feature, saving some keystrokes. Keystrokes are already saved, I think.

Re: r29096 - lyx-devel/trunk/src/mathed

2009-04-04 Thread Enrico Forestieri
On Sun, Apr 05, 2009 at 03:14:12AM +0200, for...@lyx.org wrote: Author: forenr Date: Sun Apr 5 03:14:10 2009 New Revision: 29096 URL: http://www.lyx.org/trac/changeset/29096 Log: Unicode symbols entered or pasted in math are wrapped in \text{} by default. Unwrapped symbols can be

Re: r29098 - lyx-devel/trunk/src/mathed

2009-04-04 Thread Enrico Forestieri
On Sun, Apr 05, 2009 at 04:11:08AM +0200, for...@lyx.org wrote: Author: forenr Date: Sun Apr 5 04:11:07 2009 New Revision: 29098 URL: http://www.lyx.org/trac/changeset/29098 Log: The \text macro does not require the full AMS package. Also load amstext when a text-in-math environment is

Re: r28981 - in lyx-devel/trunk: lib src src/mathed

2009-04-04 Thread Enrico Forestieri
On Fri, Apr 03, 2009 at 08:27:23AM +, Guenter Milde wrote: > On 2009-04-02, Enrico Forestieri wrote: > > On Thu, Apr 02, 2009 at 01:49:21PM +, Guenter Milde wrote: > > >> it would add the auto-switch to text-in-math feature, saving some > >> keystrokes. > > > Keystrokes are already

Re: r29096 - lyx-devel/trunk/src/mathed

2009-04-04 Thread Enrico Forestieri
On Sun, Apr 05, 2009 at 03:14:12AM +0200, for...@lyx.org wrote: > Author: forenr > Date: Sun Apr 5 03:14:10 2009 > New Revision: 29096 > URL: http://www.lyx.org/trac/changeset/29096 > > Log: > Unicode symbols entered or pasted in math are wrapped in \text{} by default. > Unwrapped symbols can

Re: r29098 - lyx-devel/trunk/src/mathed

2009-04-04 Thread Enrico Forestieri
On Sun, Apr 05, 2009 at 04:11:08AM +0200, for...@lyx.org wrote: > Author: forenr > Date: Sun Apr 5 04:11:07 2009 > New Revision: 29098 > URL: http://www.lyx.org/trac/changeset/29098 > > Log: > The \text macro does not require the full AMS package. Also load amstext > when a text-in-math

Re: r28981 - in lyx-devel/trunk: lib src src/mathed

2009-04-03 Thread Guenter Milde
On 2009-04-02, Enrico Forestieri wrote: On Thu, Apr 02, 2009 at 01:49:21PM +, Guenter Milde wrote: it would add the auto-switch to text-in-math feature, saving some keystrokes. Keystrokes are already saved, I think. No, if I insert a Cyrillic (or Georgian or ...) letter, and want to

Re: r28981 - in lyx-devel/trunk: lib src src/mathed

2009-04-03 Thread Guenter Milde
On 2009-04-02, Enrico Forestieri wrote: > On Thu, Apr 02, 2009 at 01:49:21PM +, Guenter Milde wrote: >> it would add the auto-switch to text-in-math feature, saving some >> keystrokes. > Keystrokes are already saved, I think. No, if I insert a Cyrillic (or Georgian or ...) letter, and want

Re: r28981 - in lyx-devel/trunk: lib src src/mathed

2009-04-02 Thread Guenter Milde
On 2009-04-01, Enrico Forestieri wrote: On Wed, Apr 01, 2009 at 10:15:39AM +, Guenter Milde wrote: On 2009-03-31, Enrico Forestieri wrote: On Tue, Mar 31, 2009 at 12:40:43PM +, Guenter Milde wrote: * it allows Strg-E for italic, Strg-B for bold, and all the other text styles and

<    1   2   3   4   5   6   7   8   9   10   >