Re: -std=c++11 and [PATCH] Improve the display of the source (bugs #6501,#7359)

Le 05/09/15 00:42, Guillaume Munch a écrit : In any case I uploaded the final version of these patches here : Who can review/commit those patches? I am not competent in GUI stuff. Just a note: in ViewSourceWidget::realUpdateView() the else if

Re: -std=c++11 and [PATCH] Improve the display of the source (bugs #6501,#7359)

Le 10/09/2015 16:17, Jean-Marc Lasgouttes a écrit : Le 05/09/15 00:42, Guillaume Munch a écrit : In any case I uploaded the final version of these patches here : Who can review/commit those patches? I am not competent in GUI stuff. Just a note: in

Re: -std=c++11 and [PATCH] Improve the display of the source (bugs #6501,#7359)

Le 10/09/2015 18:28, Guillaume Munch a écrit : AFAIU Kornel and Scott have tested these patches and are in favour of committing them. I can do it myself, though if I am to make the change you suggest it will have to wait a very short while. It was just a remark in this case, not a demand. Do

Re: -std=c++11 and [PATCH] Improve the display of the source (bugs #6501,#7359)

Am Donnerstag, 10. September 2015 um 17:29:22, schrieb Guillaume Munch > Le 10/09/2015 16:17, Jean-Marc Lasgouttes a écrit : > > Le 05/09/15 00:42, Guillaume Munch a écrit : > >> In any case I uploaded the final version of these patches here : > >>

Re: -std=c++11 and [PATCH] Improve the display of the source (bugs #6501,#7359)

Le 02/09/2015 22:19, Georg Baum a écrit : Jean-Marc Lasgouttes wrote: Le 27/08/2015 22:00, Georg Baum a écrit : We can at least turn c++11 on automatically for "non-weird" compilers (and I think we should do it). The following patch (on top of the previous one) does this. OK? Yes, this

Re: -std=c++11 and [PATCH] Improve the display of the source (bugs #6501,#7359)

Le 30/08/15 11:56, Kornel Benko a écrit : I don't think Guillaume has commit rights yet. Scott He deserves it IMHO. I agree with that. Guillaume, if you send to me your desired login name (gadmm will do I guess) and a ssh public key, I will set up a @lyx.org address and git write access.

Re: -std=c++11 and [PATCH] Improve the display of the source (bugs #6501,#7359)

In any case I uploaded the final version of these patches here : Le 30/08/2015 14:00, Scott Kostyshak a écrit : On Sun, Aug 30, 2015 at 5:56 AM, Kornel Benko wrote: Am Samstag, 29. August 2015 um 16:56:23, schrieb Scott Kostyshak

Re: [PATCH] Re: -std=c++11 and [PATCH] Improve the display of the source (bugs #6501,#7359)

Am Donnerstag, 3. September 2015 um 10:53:58, schrieb Jean-Marc Lasgouttes > Le 02/09/2015 22:18, Georg Baum a écrit : > >> Georg, does this make sense to you? Also I use c++11 mode instead of > >> gnu++11; we do not need any extension. > > > > Yes, the automatic detection by

Re: [PATCH] Re: -std=c++11 and [PATCH] Improve the display of the source (bugs #6501,#7359)

Le 02/09/2015 22:18, Georg Baum a écrit : Georg, does this make sense to you? Also I use c++11 mode instead of gnu++11; we do not need any extension. Yes, the automatic detection by preprocessor macros is the best method IMHO. However, since we do not know whether we'll need to modify the

Re: [PATCH] Re: -std=c++11 and [PATCH] Improve the display of the source (bugs #6501,#7359)

Jean-Marc Lasgouttes wrote: > Le 27/08/2015 22:00, Georg Baum a écrit : One problem that we have is that the compiler has to be in c++11 mode _and_ the configure script has to be aware of it. Currently weird compilers are not handled at all. >> >> We can at least turn c++11 on

Re: -std=c++11 and [PATCH] Improve the display of the source (bugs #6501,#7359)

Jean-Marc Lasgouttes wrote: > Le 27/08/2015 22:00, Georg Baum a écrit : >> We can at least turn c++11 on automatically for "non-weird" compilers >> (and I think we should do it). > > The following patch (on top of the previous one) does this. OK? Yes, this looks good. Georg

Re: -std=c++11 and [PATCH] Improve the display of the source (bugs #6501,#7359)

Le 27/08/2015 22:00, Georg Baum a écrit : We can at least turn c++11 on automatically for "non-weird" compilers (and I think we should do it). The following patch (on top of the previous one) does this. OK? JMarc >From 28cbe60e390afccaf38ff275825aa22d20dfb51a Mon Sep 17 00:00:00 2001 From:

Re: [PATCH] Re: -std=c++11 and [PATCH] Improve the display of the source (bugs #6501,#7359)

Le 31/08/2015 19:28, Kornel Benko a écrit : Am Montag, 31. August 2015 um 17:50:23, schrieb Jean-Marc Lasgouttes Kornel, if we apply that, you will be able to remove the LYX_USE_CXX11 hack from cmake too. Why? It is automatically set iff the compiler supports it.

[PATCH] Re: -std=c++11 and [PATCH] Improve the display of the source (bugs #6501,#7359)

Le 27/08/2015 22:00, Georg Baum a écrit : One problem that we have is that the compiler has to be in c++11 mode _and_ the configure script has to be aware of it. Currently weird compilers are not handled at all. We can at least turn c++11 on automatically for "non-weird" compilers (and I think

Re: [PATCH] Re: -std=c++11 and [PATCH] Improve the display of the source (bugs #6501,#7359)

Am Montag, 31. August 2015 um 17:50:23, schrieb Jean-Marc Lasgouttes > Le 27/08/2015 22:00, Georg Baum a écrit : > >>> One problem that we have is that the compiler has to be in c++11 mode > >>> _and_ the configure script has to be aware of it. Currently weird > >>> compilers

[PATCH] Re: -std=c++11 and [PATCH] Improve the display of the source (bugs #6501,#7359)

Le 27/08/2015 22:00, Georg Baum a écrit : One problem that we have is that the compiler has to be in c++11 mode _and_ the configure script has to be aware of it. Currently weird compilers are not handled at all. We can at least turn c++11 on automatically for "non-weird" compilers (and I think

Re: [PATCH] Re: -std=c++11 and [PATCH] Improve the display of the source (bugs #6501,#7359)

Am Montag, 31. August 2015 um 17:50:23, schrieb Jean-Marc Lasgouttes > Le 27/08/2015 22:00, Georg Baum a écrit : > >>> One problem that we have is that the compiler has to be in c++11 mode > >>> _and_ the configure script has to be aware of it. Currently weird > >>> compilers

Re: -std=c++11 and [PATCH] Improve the display of the source (bugs #6501,#7359)

Am Samstag, 29. August 2015 um 16:56:23, schrieb Scott Kostyshak skost...@lyx.org On Sat, Aug 29, 2015 at 3:13 PM, Kornel Benko kor...@lyx.org wrote: Am Samstag, 29. August 2015 um 19:12:58, schrieb Guillaume Munch ga...@free.fr I thought I read somewhere that patches for translations had

Re: -std=c++11 and [PATCH] Improve the display of the source (bugs #6501,#7359)

On Sun, Aug 30, 2015 at 5:56 AM, Kornel Benko kor...@lyx.org wrote: Am Samstag, 29. August 2015 um 16:56:23, schrieb Scott Kostyshak skost...@lyx.org He deserves it IMHO. I agree. But I think, he already got commit rights, see commit d88e40158912e0205d2aaf21abbc9de7a6addbfc

Re: -std=c++11 and [PATCH] Improve the display of the source (bugs #6501,#7359)

Am Samstag, 29. August 2015 um 16:56:23, schrieb Scott Kostyshak > On Sat, Aug 29, 2015 at 3:13 PM, Kornel Benko wrote: > > Am Samstag, 29. August 2015 um 19:12:58, schrieb Guillaume Munch > > > >> I thought I read somewhere that patches for

Re: -std=c++11 and [PATCH] Improve the display of the source (bugs #6501,#7359)

On Sun, Aug 30, 2015 at 5:56 AM, Kornel Benko wrote: > Am Samstag, 29. August 2015 um 16:56:23, schrieb Scott Kostyshak > > He deserves it IMHO. I agree. > But I think, he already got commit rights, see > commit

Re: -std=c++11 and [PATCH] Improve the display of the source (bugs #6501,#7359)

Am Donnerstag, 27. August 2015 um 01:42:12, schrieb Guillaume Munch ga...@free.fr Dear list, Here are all my patches to the View Source panel including the ones from a preview thread with QTimers. This is for the latest master and it compiles without --enable-cxx11. Anybody curious

Re: -std=c++11 and [PATCH] Improve the display of the source (bugs #6501,#7359)

Le 29/08/2015 15:14, Kornel Benko a écrit : Am Donnerstag, 27. August 2015 um 01:42:12, schrieb Guillaume Munch ga...@free.fr Dear list, Here are all my patches to the View Source panel including the ones from a preview thread with QTimers. This is for the latest master and it compiles

Re: -std=c++11 and [PATCH] Improve the display of the source (bugs #6501,#7359)

On Sat, Aug 29, 2015 at 3:13 PM, Kornel Benko kor...@lyx.org wrote: Am Samstag, 29. August 2015 um 19:12:58, schrieb Guillaume Munch ga...@free.fr I thought I read somewhere that patches for translations had to be against stable. Do you want them against stable or master? Oh, I expected it

Re: -std=c++11 and [PATCH] Improve the display of the source (bugs #6501,#7359)

Am Samstag, 29. August 2015 um 19:12:58, schrieb Guillaume Munch ga...@free.fr I thought I read somewhere that patches for translations had to be against stable. Do you want them against stable or master? Oh, I expected it against master. IMHO, if you can create fr.gmo without errors you are

Re: -std=c++11 and [PATCH] Improve the display of the source (bugs #6501,#7359)

Am Donnerstag, 27. August 2015 um 01:42:12, schrieb Guillaume Munch > Dear list, > > > Here are all my patches to the View Source panel including the ones from > a preview thread with QTimers. This is for the latest master and it > compiles without --enable-cxx11. > > Anybody

Re: -std=c++11 and [PATCH] Improve the display of the source (bugs #6501,#7359)

Le 29/08/2015 15:14, Kornel Benko a écrit : Am Donnerstag, 27. August 2015 um 01:42:12, schrieb Guillaume Munch Dear list, Here are all my patches to the View Source panel including the ones from a preview thread with QTimers. This is for the latest master and it compiles

Re: -std=c++11 and [PATCH] Improve the display of the source (bugs #6501,#7359)

Am Samstag, 29. August 2015 um 19:12:58, schrieb Guillaume Munch > I thought I read somewhere that patches for translations had to be > against stable. Do you want them against stable or master? > Oh, I expected it against master. IMHO, if you can create fr.gmo without errors

Re: -std=c++11 and [PATCH] Improve the display of the source (bugs #6501,#7359)

On Sat, Aug 29, 2015 at 3:13 PM, Kornel Benko wrote: > Am Samstag, 29. August 2015 um 19:12:58, schrieb Guillaume Munch > >> I thought I read somewhere that patches for translations had to be >> against stable. Do you want them against stable or master? >> > > Oh,

Re: -std=c++11 and [PATCH] Improve the display of the source (bugs #6501,#7359)

Le 27/08/2015 22:00, Georg Baum a écrit : I do not know that much about auto_ptr and unique_ptr, but would it be possible to use auto_ptr as a poor man's unique_ptr? If yes, is it dangerous? This is possible in some use cases. IMHO having a lyx::unique_ptr which is either std::unique_ptr or

Re: -std=c++11 and [PATCH] Improve the display of the source (bugs #6501,#7359)

Le 27/08/2015 22:00, Georg Baum a écrit : I do not know that much about auto_ptr and unique_ptr, but would it be possible to use auto_ptr as a poor man's unique_ptr? If yes, is it dangerous? This is possible in some use cases. IMHO having a lyx::unique_ptr which is either std::unique_ptr or

Re: -std=c++11 and [PATCH] Improve the display of the source (bugs #6501,#7359)

Guillaume Munch wrote: More specific answers follow. Le 26/08/2015 13:18, Jean-Marc Lasgouttes a écrit : Le 24/08/2015 21:19, Georg Baum a écrit : Thanks. By the way, Georg, is there any plan to backport 125a2977 and 27f067dd? IMHO we should not backport much at this phase of the 2.2

Re: -std=c++11 and [PATCH] Improve the display of the source (bugs #6501,#7359)

Guillaume Munch wrote: > More specific answers follow. > > Le 26/08/2015 13:18, Jean-Marc Lasgouttes a écrit : >> Le 24/08/2015 21:19, Georg Baum a écrit : > > Thanks. By the way, Georg, is there any plan to backport 125a2977 and > 27f067dd? IMHO we should not backport much at this phase of

Re: -std=c++11 and [PATCH] Improve the display of the source (bugs #6501,#7359)

Le 24/08/2015 21:19, Georg Baum a écrit : I am a bit confused, maybe because my french is not good enough anymore;-) My current understanding is this: Well, your French is not that bad actually. - qt5 + --enable-cxx11 does not compile. I verified this and that the patch fixes the issue and

Re: -std=c++11 and [PATCH] Improve the display of the source (bugs #6501,#7359)

Dear list, Here are all my patches to the View Source panel including the ones from a preview thread with QTimers. This is for the latest master and it compiles without --enable-cxx11. Anybody curious can test the patches (please) and make suggestions while it is still on the stove. See

Re: -std=c++11 and [PATCH] Improve the display of the source (bugs #6501,#7359)

On Wed, Aug 26, 2015 at 8:42 PM, Guillaume Munch ga...@free.fr wrote: Anybody curious can test the patches (please) and make suggestions while it is still on the stove. See more detail about the changes in the commit messages. I look forward to these improvements, Guillaume. Thanks for this

Re: -std=c++11 and [PATCH] Improve the display of the source (bugs #6501,#7359)

Le 27/08/2015 02:12, Scott Kostyshak a écrit : On Wed, Aug 26, 2015 at 8:42 PM, Guillaume Munch ga...@free.fr wrote: Anybody curious can test the patches (please) and make suggestions while it is still on the stove. See more detail about the changes in the commit messages. I look forward to

Re: -std=c++11 and [PATCH] Improve the display of the source (bugs #6501,#7359)

Le 24/08/2015 21:19, Georg Baum a écrit : I am a bit confused, maybe because my french is not good enough anymore;-) My current understanding is this: Well, your French is not that bad actually. - qt5 + --enable-cxx11 does not compile. I verified this and that the patch fixes the issue and

Re: -std=c++11 and [PATCH] Improve the display of the source (bugs #6501,#7359)

Dear list, Here are all my patches to the View Source panel including the ones from a preview thread with QTimers. This is for the latest master and it compiles without --enable-cxx11. Anybody curious can test the patches (please) and make suggestions while it is still on the stove. See

Re: -std=c++11 and [PATCH] Improve the display of the source (bugs #6501,#7359)

On Wed, Aug 26, 2015 at 8:42 PM, Guillaume Munch wrote: > Anybody curious can test the patches (please) and make suggestions while it > is still on the stove. See more detail about the changes in the commit > messages. I look forward to these improvements, Guillaume. Thanks for

Re: -std=c++11 and [PATCH] Improve the display of the source (bugs #6501,#7359)

Le 27/08/2015 02:12, Scott Kostyshak a écrit : On Wed, Aug 26, 2015 at 8:42 PM, Guillaume Munch wrote: Anybody curious can test the patches (please) and make suggestions while it is still on the stove. See more detail about the changes in the commit messages. I look forward

Re: -std=c++11 and [PATCH] Improve the display of the source (bugs #6501,#7359)

Guillaume Munch wrote: Then, I must translate for people who do not read French. Essentially, if the plan is to use c++11 features starting from 2.3, and 2.2 requires c++98 compatibility, then backporting new code is going to involve unusual efforts, or discourage using the features as long

Re: -std=c++11 and [PATCH] Improve the display of the source (bugs #6501,#7359)

Guillaume Munch wrote: > Then, I must translate for people who do not read French. Essentially, > if the plan is to use c++11 features starting from 2.3, and 2.2 requires > c++98 compatibility, then backporting new code is going to involve > unusual efforts, or discourage using the features as

Re: -std=c++11 and [PATCH] Improve the display of the source (bugs #6501,#7359)

Hello, Le 13/08/2015 22:32, Jean-Marc Lasgouttes a écrit : Hi Guillaume, Please keep technical discussions on the list even if it seems that we are the only ones concerned. At least Georg will want to chime in at some point and it is better to keep everything available. OK. (It was a reply

Re: -std=c++11 and [PATCH] Improve the display of the source (bugs #6501,#7359)

Sorry about the private message, it was not intended... Did I say already how much I hate email on a tablet? Concerning whether the backport strategy, I am not convinced that the effort will be so important, but I'll let others with better understanding comment. JMarc Le 14 août 2015

Re: -std=c++11 and [PATCH] Improve the display of the source (bugs #6501,#7359)

Hello, Le 13/08/2015 22:32, Jean-Marc Lasgouttes a écrit : Hi Guillaume, Please keep technical discussions on the list even if it seems that we are the only ones concerned. At least Georg will want to chime in at some point and it is better to keep everything available. OK. (It was a reply

Re: -std=c++11 and [PATCH] Improve the display of the source (bugs #6501,#7359)

Sorry about the private message, it was not intended... Did I say already how much I hate email on a tablet? Concerning whether the backport strategy, I am not convinced that the effort will be so important, but I'll let others with better understanding comment. JMarc Le 14 août 2015

Re: -std=c++11 and [PATCH] Improve the display of the source (bugs #6501,#7359)

Hi Guillaume, Please keep technical discussions on the list even if it seems that we are the only ones concerned. At least Georg will want to chime in at some point and it is better to keep everything available. I agree that unique_ptr cannot really be implemented without c++11 move

Re: -std=c++11 and [PATCH] Improve the display of the source (bugs #6501,#7359)

Hi Guillaume, Please keep technical discussions on the list even if it seems that we are the only ones concerned. At least Georg will want to chime in at some point and it is better to keep everything available. I agree that unique_ptr cannot really be implemented without c++11 move

Re: -std=c++11 and [PATCH] Improve the display of the source (bugs #6501,#7359)

Le 5 août 2015 03:18:37 UTC+02:00, Guillaume Munch ga...@free.fr a écrit : Hello, Here is a patch that I would like to discuss. It brings some improvements to the source view panel and it fixes http://www.lyx.org/trac/ticket/6501 (Cursor in LaTeX Source pane does not follow cursor in Editor

Re: -std=c++11 and [PATCH] Improve the display of the source (bugs #6501,#7359)

Le 06/08/2015 22:44, Jean-Marc Lasgouttes a écrit : Le 5 août 2015 03:18:37 UTC+02:00, Guillaume Munch ga...@free.fr a écrit : Hello, Here is a patch that I would like to discuss. It brings some improvements to the source view panel and it fixes http://www.lyx.org/trac/ticket/6501 (Cursor in

Re: -std=c++11 and [PATCH] Improve the display of the source (bugs #6501,#7359)

Le 5 août 2015 03:18:37 UTC+02:00, Guillaume Munch a écrit : >Hello, > > >Here is a patch that I would like to discuss. It brings some >improvements to the source view panel and it fixes > (Cursor in "LaTeX Source" pane >does not follow

Re: -std=c++11 and [PATCH] Improve the display of the source (bugs #6501,#7359)

Le 06/08/2015 22:44, Jean-Marc Lasgouttes a écrit : Le 5 août 2015 03:18:37 UTC+02:00, Guillaume Munch a écrit : Hello, Here is a patch that I would like to discuss. It brings some improvements to the source view panel and it fixes (Cursor

-std=c++11 and [PATCH] Improve the display of the source (bugs #6501,#7359)

Hello, Here is a patch that I would like to discuss. It brings some improvements to the source view panel and it fixes http://www.lyx.org/trac/ticket/6501 (Cursor in LaTeX Source pane does not follow cursor in Editor window). I use a unique_ptr because it was the best way to do. Because of

-std=c++11 and [PATCH] Improve the display of the source (bugs #6501,#7359)

Hello, Here is a patch that I would like to discuss. It brings some improvements to the source view panel and it fixes (Cursor in "LaTeX Source" pane does not follow cursor in Editor window). I use a unique_ptr because it was the best way to do.