On Friday 25 May 2007 09:17:45 Dov Feldstern wrote:
Find attached a revised patch (cursor_left_2.diff) with a one-line
comment (I don't want to get rid of it altogether).
Dov
I intend to commit cursor_left_2.diff, any objection?
--
José Abílio
José Matos wrote:
On Friday 25 May 2007 09:17:45 Dov Feldstern wrote:
Find attached a revised patch (cursor_left_2.diff) with a one-line
comment (I don't want to get rid of it altogether).
Dov
I intend to commit cursor_left_2.diff, any objection?
Stefan has already added it, in a slightly
On Thursday 31 May 2007 17:09:17 Dov Feldstern wrote:
Stefan has already added it, in a slightly modified form
(http://www.lyx.org/trac/changeset/18532)
I will not complain. :-)
--
José Abílio
On Friday 25 May 2007 09:17:45 Dov Feldstern wrote:
> Find attached a revised patch (cursor_left_2.diff) with a one-line
> comment (I don't want to get rid of it altogether).
>
> Dov
I intend to commit cursor_left_2.diff, any objection?
--
José Abílio
José Matos wrote:
On Friday 25 May 2007 09:17:45 Dov Feldstern wrote:
Find attached a revised patch (cursor_left_2.diff) with a one-line
comment (I don't want to get rid of it altogether).
Dov
I intend to commit cursor_left_2.diff, any objection?
Stefan has already added it, in a slightly
On Thursday 31 May 2007 17:09:17 Dov Feldstern wrote:
> Stefan has already added it, in a slightly modified form
> (http://www.lyx.org/trac/changeset/18532)
I will not complain. :-)
--
José Abílio
The attached patch (also attached in bugzilla http://
bugzilla.lyx.org/show_bug.cgi?id=3720) solves this issue. As I
explain there, I would really just as soon get rid of the condition
altogether (I tested both options, both seem to work)...
Stefan, I hope you don't mind my butting in
Stefan Schimanski wrote:
The attached patch (also attached in bugzilla
http://bugzilla.lyx.org/show_bug.cgi?id=3720) solves this issue. As I
explain there, I would really just as soon get rid of the condition
altogether (I tested both options, both seem to work)...
Stefan, I hope you don't
Am 25.05.2007 um 08:55 schrieb Abdelrazak Younes:
Stefan Schimanski wrote:
The attached patch (also attached in bugzilla http://
bugzilla.lyx.org/show_bug.cgi?id=3720) solves this issue. As I
explain there, I would really just as soon get rid of the
condition altogether (I tested both
Stefan Schimanski wrote:
Am 25.05.2007 um 08:55 schrieb Abdelrazak Younes:
But please shorten the comment a bit. It's not that tricky here
anyway.
Why shorten the comment? We should strieve for more comments not less.
Particularly in place like this where a _logical_ decision is made.
Stefan
Stefan, I guess you're right --- I like comments, so I do tend to
be wordy...
Find attached a revised patch (cursor_left_2.diff) with a one-line
comment
Much better :)
(I don't want to get rid of it altogether).
However, I'm in favor of cursor_left_1.diff --- that solves the
Stefan Schimanski wrote:
Stefan
Stefan, I guess you're right --- I like comments, so I do tend to be
wordy...
Find attached a revised patch (cursor_left_2.diff) with a one-line
comment
Much better :)
(I don't want to get rid of it altogether).
However, I'm in favor of
Stefan Schimanski wrote:
In this special case the comment isn't saying anything else than what is
visible in the if-statement directly already: we're coming from the
front = front, we are at the paragraph end = pos=lastpos, we
don't check any further, we will not enter = return false. Comments
The attached patch (also attached in bugzilla http://
bugzilla.lyx.org/show_bug.cgi?id=3720) solves this issue. As I
explain there, I would really just as soon get rid of the condition
altogether (I tested both options, both seem to work)...
Stefan, I hope you don't mind my butting in
Stefan Schimanski wrote:
The attached patch (also attached in bugzilla
http://bugzilla.lyx.org/show_bug.cgi?id=3720) solves this issue. As I
explain there, I would really just as soon get rid of the condition
altogether (I tested both options, both seem to work)...
Stefan, I hope you don't
Am 25.05.2007 um 08:55 schrieb Abdelrazak Younes:
Stefan Schimanski wrote:
The attached patch (also attached in bugzilla http://
bugzilla.lyx.org/show_bug.cgi?id=3720) solves this issue. As I
explain there, I would really just as soon get rid of the
condition altogether (I tested both
Stefan Schimanski wrote:
Am 25.05.2007 um 08:55 schrieb Abdelrazak Younes:
But please shorten the comment a bit. It's not that tricky here
anyway.
Why shorten the comment? We should strieve for more comments not less.
Particularly in place like this where a _logical_ decision is made.
Stefan
Stefan, I guess you're right --- I like comments, so I do tend to
be wordy...
Find attached a revised patch (cursor_left_2.diff) with a one-line
comment
Much better :)
(I don't want to get rid of it altogether).
However, I'm in favor of cursor_left_1.diff --- that solves the
Stefan Schimanski wrote:
Stefan
Stefan, I guess you're right --- I like comments, so I do tend to be
wordy...
Find attached a revised patch (cursor_left_2.diff) with a one-line
comment
Much better :)
(I don't want to get rid of it altogether).
However, I'm in favor of
Stefan Schimanski wrote:
In this special case the comment isn't saying anything else than what is
visible in the if-statement directly already: "we're coming from the
front" = "front", "we are at the paragraph end" = "pos=lastpos", "we
don't check any further, we will not enter" = return
Hi!
Is it a bug or a feature that the cursor does not enter insets from
the right in the text? In Text::cursorLeft the checkAndActivateInset
(cur, false) call comes before moving the cursor from the right.
Though checkAndActivateInset expects the cursor to be left of the
inset to enter. I
Stefan Schimanski wrote:
Hi!
Is it a bug or a feature that the cursor does not enter insets from the
right in the text?
Bug IMHO. But I seem to recall that if there is some text just after the
inset in the same line, this works properly.
Abdel.
Stefan Schimanski schrieb:
Hi!
Is it a bug or a feature that the cursor does not enter insets from
the right in the text? In Text::cursorLeft the
checkAndActivateInset(cur, false) call comes before moving the cursor
from the right. Though checkAndActivateInset expects the cursor to be
left
Stefan == Stefan Schimanski [EMAIL PROTECTED] writes:
Stefan Hi! Is it a bug or a feature that the cursor does not enter
Stefan insets from the right in the text? In Text::cursorLeft the
Stefan checkAndActivateInset (cur, false) call comes before moving
Stefan the cursor from the right. Though
Abdelrazak Younes wrote:
Stefan Schimanski wrote:
Is it a bug or a feature that the cursor does not enter insets from
the right in the text?
Bug IMHO. But I seem to recall that if there is some text just after
the inset in the same line, this works properly.
Bug. And yes, the problem only
Stefan Schimanski wrote:
Hi!
Is it a bug or a feature that the cursor does not enter insets from the
right in the text? In Text::cursorLeft the checkAndActivateInset(cur,
false) call comes before moving the cursor from the right. Though
checkAndActivateInset expects the cursor to be left of
Dov Feldstern wrote:
Stefan Schimanski wrote:
Hi!
Is it a bug or a feature that the cursor does not enter insets from
the right in the text? In Text::cursorLeft the
checkAndActivateInset(cur, false) call comes before moving the cursor
from the right. Though checkAndActivateInset expects the
Am 24.05.2007 um 23:56 schrieb Dov Feldstern:
Dov Feldstern wrote:
Stefan Schimanski wrote:
Hi!
Is it a bug or a feature that the cursor does not enter insets
from the right in the text? In Text::cursorLeft the
checkAndActivateInset(cur, false) call comes before moving the
cursor from
Stefan Schimanski wrote:
Am 24.05.2007 um 23:56 schrieb Dov Feldstern:
Dov Feldstern wrote:
Stefan Schimanski wrote:
Hi!
Is it a bug or a feature that the cursor does not enter insets from
the right in the text? In Text::cursorLeft the
checkAndActivateInset(cur, false) call comes before
Dov Feldstern wrote:
Stefan Schimanski wrote:
Please don't spend too much time. I have a working version I think
here now and only workout some target_x bugs. Will probably send the
patch to the list tomorrow.
Stefan
Thanks, but I actually think I've got a solution, too: the cause (I
Hi!
Is it a bug or a feature that the cursor does not enter insets from
the right in the text? In Text::cursorLeft the checkAndActivateInset
(cur, false) call comes before moving the cursor from the right.
Though checkAndActivateInset expects the cursor to be left of the
inset to enter. I
Stefan Schimanski wrote:
Hi!
Is it a bug or a feature that the cursor does not enter insets from the
right in the text?
Bug IMHO. But I seem to recall that if there is some text just after the
inset in the same line, this works properly.
Abdel.
Stefan Schimanski schrieb:
Hi!
Is it a bug or a feature that the cursor does not enter insets from
the right in the text? In Text::cursorLeft the
checkAndActivateInset(cur, false) call comes before moving the cursor
from the right. Though checkAndActivateInset expects the cursor to be
left
> "Stefan" == Stefan Schimanski <[EMAIL PROTECTED]> writes:
Stefan> Hi! Is it a bug or a feature that the cursor does not enter
Stefan> insets from the right in the text? In Text::cursorLeft the
Stefan> checkAndActivateInset (cur, false) call comes before moving
Stefan> the cursor from the
Abdelrazak Younes wrote:
> Stefan Schimanski wrote:
>> Is it a bug or a feature that the cursor does not enter insets from
>> the right in the text?
> Bug IMHO. But I seem to recall that if there is some text just after
> the inset in the same line, this works properly.
Bug. And yes, the problem
Stefan Schimanski wrote:
Hi!
Is it a bug or a feature that the cursor does not enter insets from the
right in the text? In Text::cursorLeft the checkAndActivateInset(cur,
false) call comes before moving the cursor from the right. Though
checkAndActivateInset expects the cursor to be left of
Dov Feldstern wrote:
Stefan Schimanski wrote:
Hi!
Is it a bug or a feature that the cursor does not enter insets from
the right in the text? In Text::cursorLeft the
checkAndActivateInset(cur, false) call comes before moving the cursor
from the right. Though checkAndActivateInset expects the
Am 24.05.2007 um 23:56 schrieb Dov Feldstern:
Dov Feldstern wrote:
Stefan Schimanski wrote:
Hi!
Is it a bug or a feature that the cursor does not enter insets
from the right in the text? In Text::cursorLeft the
checkAndActivateInset(cur, false) call comes before moving the
cursor from
Stefan Schimanski wrote:
Am 24.05.2007 um 23:56 schrieb Dov Feldstern:
Dov Feldstern wrote:
Stefan Schimanski wrote:
Hi!
Is it a bug or a feature that the cursor does not enter insets from
the right in the text? In Text::cursorLeft the
checkAndActivateInset(cur, false) call comes before
Dov Feldstern wrote:
Stefan Schimanski wrote:
Please don't spend too much time. I have a working version I think
here now and only workout some target_x bugs. Will probably send the
patch to the list tomorrow.
Stefan
Thanks, but I actually think I've got a solution, too: the cause (I
40 matches
Mail list logo
