Re: Currently working on a patch to address deprecations that trigger -Werror with Qt 5.14.1

On Fri, Mar 20, 2020 at 03:08:20PM +0100, Jean-Marc Lasgouttes wrote: > Le 20/03/2020 à 14:49, Scott Kostyshak a écrit : > > > I would say that we don't care, so width() is better since is is shorter > > > and > > > easier to understand :) > > > > Just to double-check: By width() you mean

Re: Currently working on a patch to address deprecations that trigger -Werror with Qt 5.14.1

Le 20/03/2020 à 14:49, Scott Kostyshak a écrit : I would say that we don't care, so width() is better since is is shorter and easier to understand :) Just to double-check: By width() you mean boundingRect().width(), and yes you are saying it is shorter than horizontalAdvance() because we do

Re: Currently working on a patch to address deprecations that trigger -Werror with Qt 5.14.1

On Fri, Mar 20, 2020 at 10:17:51AM +0100, Jean-Marc Lasgouttes wrote: > Le 20/03/2020 à 03:41, Scott Kostyshak a écrit : > > > The entry in the change log hints (from my understanding) that it is a > > > renaming, but the blog article I linked to suggests things could be more > > > complicated. >

Re: Currently working on a patch to address deprecations that trigger -Werror with Qt 5.14.1

Le 20/03/2020 à 03:41, Scott Kostyshak a écrit : The entry in the change log hints (from my understanding) that it is a renaming, but the blog article I linked to suggests things could be more complicated. Looking at the code, it does seem to be equivalent: qreal QFontMetricsF::width(const

Re: Currently working on a patch to address deprecations that trigger -Werror with Qt 5.14.1

On Mon, Mar 02, 2020 at 10:00:18AM -0500, Scott Kostyshak wrote: > On Sun, Mar 01, 2020 at 08:04:47PM +0100, Jean-Marc Lasgouttes wrote: > > Le 29/02/2020 à 18:27, Scott Kostyshak a écrit : > > > In Qt 5.11, horizontalAdvance() was added "to replace the confusingly > > > named width() function",

Re: Currently working on a patch to address deprecations that trigger -Werror with Qt 5.14.1

Fix deprecation warnings from use of qSort() in master at 14f369b4. Scott signature.asc Description: PGP signature -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel

Re: Currently working on a patch to address deprecations that trigger -Werror with Qt 5.14.1

On Tue, Mar 03, 2020 at 02:24:39PM -0500, Scott Kostyshak wrote: > On Fri, Feb 28, 2020 at 02:35:18PM -0500, Scott Kostyshak wrote: > > Compiling LyX with Qt 5.14.1 gives deprecation warnings, which breaks > > compilation of LyX with -Werror. I'm working on a patch to address > > these. I'm

Re: Currently working on a patch to address deprecations that trigger -Werror with Qt 5.14.1

On Thu, Mar 05, 2020 at 12:00:32PM +0100, Pavel Sanda wrote: > On Tue, Mar 03, 2020 at 08:40:38PM -0500, Scott Kostyshak wrote: > > When you dereference an iterator, isn't it usually expected to return the > > object, not a pointer to the object? > > It might be we don't use that in lyx codebase,

Re: Currently working on a patch to address deprecations that trigger -Werror with Qt 5.14.1

On Tue, Mar 03, 2020 at 08:40:38PM -0500, Scott Kostyshak wrote: > When you dereference an iterator, isn't it usually expected to return the > object, not a pointer to the object? It might be we don't use that in lyx codebase, but I don't have any particular expectations for the underlying type.

Re: Currently working on a patch to address deprecations that trigger -Werror with Qt 5.14.1

On Tue, Mar 03, 2020 at 11:32:51PM +0100, Pavel Sanda wrote: > On Tue, Mar 03, 2020 at 02:24:39PM -0500, Scott Kostyshak wrote: > > understand what "**it" is, or how it works. Does this mean that somehow > > a QTreeWidgetItem::operator* is defined or something like that? > > Yes,

Re: Currently working on a patch to address deprecations that trigger -Werror with Qt 5.14.1

On Tue, Mar 03, 2020 at 02:24:39PM -0500, Scott Kostyshak wrote: > understand what "**it" is, or how it works. Does this mean that somehow > a QTreeWidgetItem::operator* is defined or something like that? Yes, https://doc.qt.io/qt-5/qtreewidgetitemiterator.html#operator-2a P -- lyx-devel

Re: Currently working on a patch to address deprecations that trigger -Werror with Qt 5.14.1

On Fri, Feb 28, 2020 at 02:35:18PM -0500, Scott Kostyshak wrote: > Compiling LyX with Qt 5.14.1 gives deprecation warnings, which breaks > compilation of LyX with -Werror. I'm working on a patch to address > these. I'm sending this message just to avoid duplication of effort in > case anyone else

Re: Currently working on a patch to address deprecations that trigger -Werror with Qt 5.14.1

On Sun, Mar 01, 2020 at 08:04:47PM +0100, Jean-Marc Lasgouttes wrote: > Le 29/02/2020 à 18:27, Scott Kostyshak a écrit : > > In Qt 5.11, horizontalAdvance() was added "to replace the confusingly > > named width() function", which was deprecated in the same release. [1] > > Do you know whether

Re: Currently working on a patch to address deprecations that trigger -Werror with Qt 5.14.1

Le 29/02/2020 à 18:27, Scott Kostyshak a écrit : In Qt 5.11, horizontalAdvance() was added "to replace the confusingly named width() function", which was deprecated in the same release. [1] Do you know whether they are equivalent, or subtly different? "I am pretty sure that in most cases

Re: Currently working on a patch to address deprecations that trigger -Werror with Qt 5.14.1

On Fri, Feb 28, 2020 at 02:35:18PM -0500, Scott Kostyshak wrote: > Compiling LyX with Qt 5.14.1 gives deprecation warnings, which breaks > compilation of LyX with -Werror. I'm working on a patch to address > these. I'm sending this message just to avoid duplication of effort in > case anyone else

Currently working on a patch to address deprecations that trigger -Werror with Qt 5.14.1

Compiling LyX with Qt 5.14.1 gives deprecation warnings, which breaks compilation of LyX with -Werror. I'm working on a patch to address these. I'm sending this message just to avoid duplication of effort in case anyone else comes across these warnings. I'll hopefully finish the patch next week.