Drawing Error

2007-08-28 Thread Richard Heck
Abdel, Know you're working on the drawing stuff, and not trying to make your life more difficult...rather, trying to help. Open a document, put the cursor at the beginning of a word in the middle of a sentence, hit space (which you're not allowed to do). The line becomes oddly darker. This

Drawing Error

2007-08-28 Thread Richard Heck
Abdel, Know you're working on the drawing stuff, and not trying to make your life more difficult...rather, trying to help. Open a document, put the cursor at the beginning of a word in the middle of a sentence, hit space (which you're not allowed to do). The line becomes oddly darker. This

drawing error with insets

2007-02-20 Thread John Levon
Insert two footnotes side by side. Open the first footnote and place a note inside it. The box for the not extends past the footnote to the edge of the document. regards john

drawing error with insets

2007-02-20 Thread John Levon
Insert two footnotes side by side. Open the first footnote and place a note inside it. The box for the not extends past the footnote to the edge of the document. regards john

Re: [Still better patch] Re: [New patch] Re: [Patch] Re: Drawing error with collapsable insets.

2006-06-29 Thread Martin Vermeer
On Thu, Jun 22, 2006 at 12:23:38PM +0200, Jean-Marc Lasgouttes wrote: Martin == Martin Vermeer [EMAIL PROTECTED] writes: ... Martin Attached the tabular background patch for 1.4 (still not Martin applied) This part is OK. Checked it in, so it isn't forgotten. Log: *

Re: [Still better patch] Re: [New patch] Re: [Patch] Re: Drawing error with collapsable insets.

2006-06-29 Thread Martin Vermeer
On Thu, Jun 22, 2006 at 12:23:38PM +0200, Jean-Marc Lasgouttes wrote: > > "Martin" == Martin Vermeer <[EMAIL PROTECTED]> writes: ... > Martin> Attached the tabular background patch for 1.4 (still not > Martin> applied) > > This part is OK. Checked it in, so it isn't forgotten. Log:

Re: [Still better patch] Re: [New patch] Re: [Patch] Re: Drawing error with collapsable insets.

2006-06-26 Thread Martin Vermeer
On Fri, Jun 23, 2006 at 12:04:33PM +0200, Jean-Marc Lasgouttes wrote: Martin == Martin Vermeer [EMAIL PROTECTED] writes: I do not know whether this is related to your patch(es): try to insert a collapsable inset in a tabular cell; the right margin of the inset is outside of the screen.

Re: [Still better patch] Re: [New patch] Re: [Patch] Re: Drawing error with collapsable insets.

2006-06-26 Thread Martin Vermeer
On Fri, Jun 23, 2006 at 12:04:33PM +0200, Jean-Marc Lasgouttes wrote: > > "Martin" == Martin Vermeer <[EMAIL PROTECTED]> writes: > > >> I do not know whether this is related to your patch(es): try to > >> insert a collapsable inset in a tabular cell; the right margin of > >> the inset is

Re: [Still better patch] Re: [New patch] Re: [Patch] Re: Drawing error with collapsable insets.

2006-06-23 Thread Jean-Marc Lasgouttes
Martin == Martin Vermeer [EMAIL PROTECTED] writes: I do not know whether this is related to your patch(es): try to insert a collapsable inset in a tabular cell; the right margin of the inset is outside of the screen. Martin I suppose the speed-up patch exposed this bug, Umm, I am not able

Re: [Still better patch] Re: [New patch] Re: [Patch] Re: Drawing error with collapsable insets.

2006-06-23 Thread Jean-Marc Lasgouttes
> "Martin" == Martin Vermeer <[EMAIL PROTECTED]> writes: >> I do not know whether this is related to your patch(es): try to >> insert a collapsable inset in a tabular cell; the right margin of >> the inset is outside of the screen. Martin> I suppose the speed-up patch exposed this bug,

Re: [Still better patch] Re: [New patch] Re: [Patch] Re: Drawing error with collapsable insets.

2006-06-22 Thread Jean-Marc Lasgouttes
Martin == Martin Vermeer [EMAIL PROTECTED] writes: Martin I suppose the speed-up patch exposed this bug, i.e., that a Martin tabular cell with a non-fixed width does not transmit a Martin sensible mi.base.textwidth to any textinsets it contains. Now Martin that we use this (or the derived

Re: [Still better patch] Re: [New patch] Re: [Patch] Re: Drawing error with collapsable insets.

2006-06-22 Thread Martin Vermeer
On Thu, 2006-06-22 at 12:23 +0200, Jean-Marc Lasgouttes wrote: Martin == Martin Vermeer [EMAIL PROTECTED] writes: Martin I suppose the speed-up patch exposed this bug, i.e., that a Martin tabular cell with a non-fixed width does not transmit a Martin sensible mi.base.textwidth to any

Re: [Still better patch] Re: [New patch] Re: [Patch] Re: Drawing error with collapsable insets.

2006-06-22 Thread Jean-Marc Lasgouttes
Martin == Martin Vermeer [EMAIL PROTECTED] writes: And do you think it would be too difficult to fix the real cause? Martin My patch does that... imperfectly. The value is now sensible, Martin but often a bit generous. Yes, I saw that afterwards, but failed to edit the message correctly :)

Re: [Still better patch] Re: [New patch] Re: [Patch] Re: Drawing error with collapsable insets.

2006-06-22 Thread Martin Vermeer
On Thu, Jun 22, 2006 at 04:05:34PM +0200, Jean-Marc Lasgouttes wrote: Martin == Martin Vermeer [EMAIL PROTECTED] writes: ... Running under gdb, I noticed that InsetCollapsable::metrics is called twice when creating a new note inset. The reason is that it is called twice in

Re: [Still better patch] Re: [New patch] Re: [Patch] Re: Drawing error with collapsable insets.

2006-06-22 Thread Jean-Marc Lasgouttes
> "Martin" == Martin Vermeer <[EMAIL PROTECTED]> writes: Martin> I suppose the speed-up patch exposed this bug, i.e., that a Martin> tabular cell with a non-fixed width does not transmit a Martin> sensible mi.base.textwidth to any textinsets it contains. Now Martin> that we use this (or the

Re: [Still better patch] Re: [New patch] Re: [Patch] Re: Drawing error with collapsable insets.

2006-06-22 Thread Martin Vermeer
On Thu, 2006-06-22 at 12:23 +0200, Jean-Marc Lasgouttes wrote: > > "Martin" == Martin Vermeer <[EMAIL PROTECTED]> writes: > > Martin> I suppose the speed-up patch exposed this bug, i.e., that a > Martin> tabular cell with a non-fixed width does not transmit a > Martin> sensible

Re: [Still better patch] Re: [New patch] Re: [Patch] Re: Drawing error with collapsable insets.

2006-06-22 Thread Jean-Marc Lasgouttes
> "Martin" == Martin Vermeer <[EMAIL PROTECTED]> writes: >> And do you think it would be too difficult to fix the real cause? Martin> My patch does that... imperfectly. The value is now sensible, Martin> but often a bit generous. Yes, I saw that afterwards, but failed to edit the message

Re: [Still better patch] Re: [New patch] Re: [Patch] Re: Drawing error with collapsable insets.

2006-06-22 Thread Martin Vermeer
On Thu, Jun 22, 2006 at 04:05:34PM +0200, Jean-Marc Lasgouttes wrote: > > "Martin" == Martin Vermeer <[EMAIL PROTECTED]> writes: ... > Running under gdb, I noticed that InsetCollapsable::metrics is called > twice when creating a new note inset. The reason is that it is called > twice in

Re: [Still better patch] Re: [New patch] Re: [Patch] Re: Drawing error with collapsable insets.

2006-06-21 Thread Jean-Marc Lasgouttes
Martin == Martin Vermeer [EMAIL PROTECTED] writes: Martin In my newfound tradition of making everything simpler :-) If Martin you paint the whole tabular background, you don't have to Martin figure out what cell you're in... Martin Please give it some exercise before the go-ahead for 1.4. I do

Re: [Better patch] Re: [Patch] Re: Drawing error with collapsable insets.

2006-06-21 Thread Jean-Marc Lasgouttes
Martin == Martin Vermeer [EMAIL PROTECTED] writes: Martin Sure... but how does rowpainter (i.e., the surrounding row) Martin tell the inset that it is Wide? This is a good question :) I tested the patch, and it seems to work very well. I am OK with putting this in 1.4. Also, I notice

Re: [Better patch] Re: [Patch] Re: Drawing error with collapsable insets.

2006-06-21 Thread Martin Vermeer
On Tue, 2006-06-20 at 15:00 +0200, Jean-Marc Lasgouttes wrote: Martin == Martin Vermeer [EMAIL PROTECTED] writes: Martin Your question presupposes that these two mechanisms would have Martin anything in common. They have not. display() is a property of Martin the inset (or in math, a mode

Re: [Better patch] Re: [Patch] Re: Drawing error with collapsable insets.

2006-06-21 Thread Jean-Marc Lasgouttes
Martin == Martin Vermeer [EMAIL PROTECTED] writes: Martin So done. Thanks. Martin Don't think it requires anything in status.14x. Why? I try to put everything there. JMarc

Re: [Still better patch] Re: [New patch] Re: [Patch] Re: Drawing error with collapsable insets.

2006-06-21 Thread Martin Vermeer
On Wed, Jun 21, 2006 at 12:17:41PM +0200, Jean-Marc Lasgouttes wrote: Martin == Martin Vermeer [EMAIL PROTECTED] writes: Martin In my newfound tradition of making everything simpler :-) If Martin you paint the whole tabular background, you don't have to Martin figure out what cell you're

Re: [Still better patch] Re: [New patch] Re: [Patch] Re: Drawing error with collapsable insets.

2006-06-21 Thread Jean-Marc Lasgouttes
> "Martin" == Martin Vermeer <[EMAIL PROTECTED]> writes: Martin> In my newfound tradition of making everything simpler :-) If Martin> you paint the whole tabular background, you don't have to Martin> figure out what cell you're in... Martin> Please give it some exercise before the go-ahead

Re: [Better patch] Re: [Patch] Re: Drawing error with collapsable insets.

2006-06-21 Thread Jean-Marc Lasgouttes
> "Martin" == Martin Vermeer <[EMAIL PROTECTED]> writes: Martin> Sure... but how does rowpainter (i.e., the surrounding row) Martin> tell the inset that it is Wide? This is a good question :) >> I tested the patch, and it seems to work very well. I am OK with >> putting this in 1.4. >> >>

Re: [Better patch] Re: [Patch] Re: Drawing error with collapsable insets.

2006-06-21 Thread Martin Vermeer
On Tue, 2006-06-20 at 15:00 +0200, Jean-Marc Lasgouttes wrote: > > "Martin" == Martin Vermeer <[EMAIL PROTECTED]> writes: > > Martin> Your question presupposes that these two mechanisms would have > Martin> anything in common. They have not. display() is a property of > Martin> the inset (or

Re: [Better patch] Re: [Patch] Re: Drawing error with collapsable insets.

2006-06-21 Thread Jean-Marc Lasgouttes
> "Martin" == Martin Vermeer <[EMAIL PROTECTED]> writes: Martin> So done. Thanks. Martin> Don't think it requires anything in status.14x. Why? I try to put everything there. JMarc

Re: [Still better patch] Re: [New patch] Re: [Patch] Re: Drawing error with collapsable insets.

2006-06-21 Thread Martin Vermeer
On Wed, Jun 21, 2006 at 12:17:41PM +0200, Jean-Marc Lasgouttes wrote: > > "Martin" == Martin Vermeer <[EMAIL PROTECTED]> writes: > > Martin> In my newfound tradition of making everything simpler :-) If > Martin> you paint the whole tabular background, you don't have to > Martin> figure out

Re: [Still better patch] Re: [New patch] Re: [Patch] Re: Drawing error with collapsable insets.

2006-06-20 Thread Martin Vermeer
On Mon, 2006-06-19 at 15:05 +0300, Martin Vermeer wrote: On Mon, 2006-06-19 at 11:21 +0200, Jean-Marc Lasgouttes wrote: Martin == Martin Vermeer [EMAIL PROTECTED] writes: Done. I propose this for trunk and 1.4 (Jean-Marc?), as it fixes a rendering bug. Martin Committed for trunk.

Re: [Still better patch] Re: [New patch] Re: [Patch] Re: Drawing error with collapsable insets.

2006-06-20 Thread Martin Vermeer
On Tue, 2006-06-20 at 13:41 +0300, Martin Vermeer wrote: On Tue, 2006-06-20 at 11:55 +0200, Jean-Marc Lasgouttes wrote: Martin == Martin Vermeer [EMAIL PROTECTED] writes: Martin In my newfound tradition of making everything simpler :-) If Martin you paint the whole tabular background,

Re: [Better patch] Re: [Patch] Re: Drawing error with collapsable insets.

2006-06-20 Thread Martin Vermeer
On Mon, 2006-06-19 at 10:44 -0400, Bennett Helm wrote: On Jun 18, 2006, at 5:24 AM, Martin Vermeer wrote: On Sat, Jun 17, 2006 at 11:24:51PM +0300, Martin Vermeer wrote: On Wed, Jun 14, 2006 at 11:14:19AM +0300, Martin Vermeer wrote: ... PS Getting rid of Wide() would only be

Re: [Better patch] Re: [Patch] Re: Drawing error with collapsable insets.

2006-06-20 Thread Jean-Marc Lasgouttes
Martin == Martin Vermeer [EMAIL PROTECTED] writes: Martin Your question presupposes that these two mechanisms would have Martin anything in common. They have not. display() is a property of Martin the inset (or in math, a mode of the inset). Wide() is a Martin status element of text insets only

Re: [Better patch] Re: [Patch] Re: Drawing error with collapsable insets.

2006-06-20 Thread Bennett Helm
On Jun 20, 2006, at 9:00 AM, Jean-Marc Lasgouttes wrote: Finally, when typing random text in a footnote, everytime the text gets near the right margin, the all the lines of the footnote move right and left. Is that the effect that you described, Bennett? I think so. You're typing at the end

Re: [Better patch] Re: [Patch] Re: Drawing error with collapsable insets.

2006-06-20 Thread Martin Vermeer
On Tue, Jun 20, 2006 at 09:14:20AM -0400, Bennett Helm wrote: On Jun 20, 2006, at 9:00 AM, Jean-Marc Lasgouttes wrote: Finally, when typing random text in a footnote, everytime the text gets near the right margin, the all the lines of the footnote move right and left. Is that the effect that

Re: [Better patch] Re: [Patch] Re: Drawing error with collapsable insets.

2006-06-20 Thread Bennett Helm
On Jun 20, 2006, at 9:27 AM, Martin Vermeer wrote: On Tue, Jun 20, 2006 at 09:14:20AM -0400, Bennett Helm wrote: On Jun 20, 2006, at 9:00 AM, Jean-Marc Lasgouttes wrote: Finally, when typing random text in a footnote, everytime the text gets near the right margin, the all the lines of the

Re: [Better patch] Re: [Patch] Re: Drawing error with collapsable insets.

2006-06-20 Thread Martin Vermeer
On Tue, Jun 20, 2006 at 03:00:41PM +0200, Jean-Marc Lasgouttes wrote: Martin == Martin Vermeer [EMAIL PROTECTED] writes: Martin Your question presupposes that these two mechanisms would have Martin anything in common. They have not. display() is a property of Martin the inset (or in math, a

Re: [Still better patch] Re: [New patch] Re: [Patch] Re: Drawing error with collapsable insets.

2006-06-20 Thread Martin Vermeer
On Mon, 2006-06-19 at 15:05 +0300, Martin Vermeer wrote: > On Mon, 2006-06-19 at 11:21 +0200, Jean-Marc Lasgouttes wrote: > > > "Martin" == Martin Vermeer <[EMAIL PROTECTED]> writes: > > > > >> Done. I propose this for trunk and 1.4 (Jean-Marc?), as it fixes a > > >> rendering bug. > > > >

Re: [Still better patch] Re: [New patch] Re: [Patch] Re: Drawing error with collapsable insets.

2006-06-20 Thread Martin Vermeer
On Tue, 2006-06-20 at 13:41 +0300, Martin Vermeer wrote: > On Tue, 2006-06-20 at 11:55 +0200, Jean-Marc Lasgouttes wrote: > > > "Martin" == Martin Vermeer <[EMAIL PROTECTED]> writes: > > > > Martin> In my newfound tradition of making everything simpler :-) If > > Martin> you paint the whole

Re: [Better patch] Re: [Patch] Re: Drawing error with collapsable insets.

2006-06-20 Thread Martin Vermeer
On Mon, 2006-06-19 at 10:44 -0400, Bennett Helm wrote: > On Jun 18, 2006, at 5:24 AM, Martin Vermeer wrote: > > > On Sat, Jun 17, 2006 at 11:24:51PM +0300, Martin Vermeer wrote: > >> On Wed, Jun 14, 2006 at 11:14:19AM +0300, Martin Vermeer wrote: > >> > >> ... > >> > >>> PS Getting rid of Wide()

Re: [Better patch] Re: [Patch] Re: Drawing error with collapsable insets.

2006-06-20 Thread Jean-Marc Lasgouttes
> "Martin" == Martin Vermeer <[EMAIL PROTECTED]> writes: Martin> Your question presupposes that these two mechanisms would have Martin> anything in common. They have not. display() is a property of Martin> the inset (or in math, a mode of the inset). Wide() is a Martin> status element of text

Re: [Better patch] Re: [Patch] Re: Drawing error with collapsable insets.

2006-06-20 Thread Bennett Helm
On Jun 20, 2006, at 9:00 AM, Jean-Marc Lasgouttes wrote: Finally, when typing random text in a footnote, everytime the text gets near the right margin, the all the lines of the footnote move right and left. Is that the effect that you described, Bennett? I think so. You're typing at the end

Re: [Better patch] Re: [Patch] Re: Drawing error with collapsable insets.

2006-06-20 Thread Martin Vermeer
On Tue, Jun 20, 2006 at 09:14:20AM -0400, Bennett Helm wrote: > On Jun 20, 2006, at 9:00 AM, Jean-Marc Lasgouttes wrote: > > >Finally, when typing random text in a footnote, everytime the text > >gets near the right margin, the all the lines of the footnote move > >right and left. Is that the

Re: [Better patch] Re: [Patch] Re: Drawing error with collapsable insets.

2006-06-20 Thread Bennett Helm
On Jun 20, 2006, at 9:27 AM, Martin Vermeer wrote: On Tue, Jun 20, 2006 at 09:14:20AM -0400, Bennett Helm wrote: On Jun 20, 2006, at 9:00 AM, Jean-Marc Lasgouttes wrote: Finally, when typing random text in a footnote, everytime the text gets near the right margin, the all the lines of the

Re: [Better patch] Re: [Patch] Re: Drawing error with collapsable insets.

2006-06-20 Thread Martin Vermeer
On Tue, Jun 20, 2006 at 03:00:41PM +0200, Jean-Marc Lasgouttes wrote: > > "Martin" == Martin Vermeer <[EMAIL PROTECTED]> writes: > > Martin> Your question presupposes that these two mechanisms would have > Martin> anything in common. They have not. display() is a property of > Martin> the

Re: [New patch] Re: [Patch] Re: Drawing error with collapsable insets.

2006-06-19 Thread Jean-Marc Lasgouttes
Martin == Martin Vermeer [EMAIL PROTECTED] writes: Done. I propose this for trunk and 1.4 (Jean-Marc?), as it fixes a rendering bug. Martin Committed for trunk. Jean-Marc? OK. JMarc

Re: [Better patch] Re: [Patch] Re: Drawing error with collapsable insets.

2006-06-19 Thread Jean-Marc Lasgouttes
Martin == Martin Vermeer [EMAIL PROTECTED] writes: Martin Here's the patch you've been looking for... it simplifies Martin things which is always a good sign. Instead of using Wide(), isn't it possible to use display()? I agree this is better, nevertheless. JMarc

[Still better patch] Re: [New patch] Re: [Patch] Re: Drawing error with collapsable insets.

2006-06-19 Thread Martin Vermeer
On Mon, 2006-06-19 at 11:21 +0200, Jean-Marc Lasgouttes wrote: Martin == Martin Vermeer [EMAIL PROTECTED] writes: Done. I propose this for trunk and 1.4 (Jean-Marc?), as it fixes a rendering bug. Martin Committed for trunk. Jean-Marc? OK. No. I found a better way to do this. See

Re: [Better patch] Re: [Patch] Re: Drawing error with collapsable insets.

2006-06-19 Thread Martin Vermeer
On Mon, 2006-06-19 at 12:52 +0200, Jean-Marc Lasgouttes wrote: Martin == Martin Vermeer [EMAIL PROTECTED] writes: Martin Here's the patch you've been looking for... it simplifies Martin things which is always a good sign. Instead of using Wide(), isn't it possible to use display()? No,

Re: [Better patch] Re: [Patch] Re: Drawing error with collapsable insets.

2006-06-19 Thread Jean-Marc Lasgouttes
Martin == Martin Vermeer [EMAIL PROTECTED] writes: Martin On Mon, 2006-06-19 at 12:52 +0200, Jean-Marc Lasgouttes wrote: Martin == Martin Vermeer [EMAIL PROTECTED] writes: Martin Here's the patch you've been looking for... it simplifies Martin things which is always a good sign. Instead of

Re: [Better patch] Re: [Patch] Re: Drawing error with collapsable insets.

2006-06-19 Thread Bennett Helm
On Jun 18, 2006, at 5:24 AM, Martin Vermeer wrote: On Sat, Jun 17, 2006 at 11:24:51PM +0300, Martin Vermeer wrote: On Wed, Jun 14, 2006 at 11:14:19AM +0300, Martin Vermeer wrote: ... PS Getting rid of Wide() would only be possible if you have, inside insettext, access to the _maximum_ left

Re: [Better patch] Re: [Patch] Re: Drawing error with collapsable insets.

2006-06-19 Thread Martin Vermeer
On Mon, Jun 19, 2006 at 04:16:20PM +0200, Jean-Marc Lasgouttes wrote: Martin == Martin Vermeer [EMAIL PROTECTED] writes: Martin On Mon, 2006-06-19 at 12:52 +0200, Jean-Marc Lasgouttes wrote: Martin == Martin Vermeer [EMAIL PROTECTED] writes: Martin Here's the patch you've been looking

Re: [Better patch] Re: [Patch] Re: Drawing error with collapsable insets.

2006-06-19 Thread Martin Vermeer
On Mon, Jun 19, 2006 at 10:44:27AM -0400, Bennett Helm wrote: On Jun 18, 2006, at 5:24 AM, Martin Vermeer wrote: ... Here's the patch you've been looking for... it simplifies things which is always a good sign. This is much faster on Mac than the previous patches, but still a bit

Re: [Better patch] Re: [Patch] Re: Drawing error with collapsable insets.

2006-06-19 Thread Bennett Helm
On Jun 19, 2006, at 12:36 PM, Martin Vermeer wrote: On Mon, Jun 19, 2006 at 10:44:27AM -0400, Bennett Helm wrote: On Jun 18, 2006, at 5:24 AM, Martin Vermeer wrote: ... Here's the patch you've been looking for... it simplifies things which is always a good sign. This is much faster on

Re: [New patch] Re: [Patch] Re: Drawing error with collapsable insets.

2006-06-19 Thread Jean-Marc Lasgouttes
> "Martin" == Martin Vermeer <[EMAIL PROTECTED]> writes: >> Done. I propose this for trunk and 1.4 (Jean-Marc?), as it fixes a >> rendering bug. Martin> Committed for trunk. Jean-Marc? OK. JMarc

Re: [Better patch] Re: [Patch] Re: Drawing error with collapsable insets.

2006-06-19 Thread Jean-Marc Lasgouttes
> "Martin" == Martin Vermeer <[EMAIL PROTECTED]> writes: Martin> Here's the patch you've been looking for... it simplifies Martin> things which is always a good sign. Instead of using Wide(), isn't it possible to use display()? I agree this is better, nevertheless. JMarc

[Still better patch] Re: [New patch] Re: [Patch] Re: Drawing error with collapsable insets.

2006-06-19 Thread Martin Vermeer
On Mon, 2006-06-19 at 11:21 +0200, Jean-Marc Lasgouttes wrote: > > "Martin" == Martin Vermeer <[EMAIL PROTECTED]> writes: > > >> Done. I propose this for trunk and 1.4 (Jean-Marc?), as it fixes a > >> rendering bug. > > Martin> Committed for trunk. Jean-Marc? > > OK. No. I found a better

Re: [Better patch] Re: [Patch] Re: Drawing error with collapsable insets.

2006-06-19 Thread Martin Vermeer
On Mon, 2006-06-19 at 12:52 +0200, Jean-Marc Lasgouttes wrote: > > "Martin" == Martin Vermeer <[EMAIL PROTECTED]> writes: > > Martin> Here's the patch you've been looking for... it simplifies > Martin> things which is always a good sign. > > Instead of using Wide(), isn't it possible to use

Re: [Better patch] Re: [Patch] Re: Drawing error with collapsable insets.

2006-06-19 Thread Jean-Marc Lasgouttes
> "Martin" == Martin Vermeer <[EMAIL PROTECTED]> writes: Martin> On Mon, 2006-06-19 at 12:52 +0200, Jean-Marc Lasgouttes wrote: >> > "Martin" == Martin Vermeer <[EMAIL PROTECTED]> writes: >> Martin> Here's the patch you've been looking for... it simplifies Martin> things which is always

Re: [Better patch] Re: [Patch] Re: Drawing error with collapsable insets.

2006-06-19 Thread Bennett Helm
On Jun 18, 2006, at 5:24 AM, Martin Vermeer wrote: On Sat, Jun 17, 2006 at 11:24:51PM +0300, Martin Vermeer wrote: On Wed, Jun 14, 2006 at 11:14:19AM +0300, Martin Vermeer wrote: ... PS Getting rid of Wide() would only be possible if you have, inside insettext, access to the _maximum_ left

Re: [Better patch] Re: [Patch] Re: Drawing error with collapsable insets.

2006-06-19 Thread Martin Vermeer
On Mon, Jun 19, 2006 at 04:16:20PM +0200, Jean-Marc Lasgouttes wrote: > > "Martin" == Martin Vermeer <[EMAIL PROTECTED]> writes: > > Martin> On Mon, 2006-06-19 at 12:52 +0200, Jean-Marc Lasgouttes wrote: > >> > "Martin" == Martin Vermeer <[EMAIL PROTECTED]> writes: > >> > Martin> Here's

Re: [Better patch] Re: [Patch] Re: Drawing error with collapsable insets.

2006-06-19 Thread Martin Vermeer
On Mon, Jun 19, 2006 at 10:44:27AM -0400, Bennett Helm wrote: > On Jun 18, 2006, at 5:24 AM, Martin Vermeer wrote: ... > >Here's the patch you've been looking for... it simplifies things which > >is always a good sign. > > This is much faster on Mac than the previous patches, but still a bit

Re: [Better patch] Re: [Patch] Re: Drawing error with collapsable insets.

2006-06-19 Thread Bennett Helm
On Jun 19, 2006, at 12:36 PM, Martin Vermeer wrote: On Mon, Jun 19, 2006 at 10:44:27AM -0400, Bennett Helm wrote: On Jun 18, 2006, at 5:24 AM, Martin Vermeer wrote: ... Here's the patch you've been looking for... it simplifies things which is always a good sign. This is much faster on

[Better patch] Re: [Patch] Re: Drawing error with collapsable insets.

2006-06-18 Thread Martin Vermeer
On Sat, Jun 17, 2006 at 11:24:51PM +0300, Martin Vermeer wrote: On Wed, Jun 14, 2006 at 11:14:19AM +0300, Martin Vermeer wrote: ... PS Getting rid of Wide() would only be possible if you have, inside insettext, access to the _maximum_ left and right edges of the contained text, rather

Re: [New patch] Re: [Patch] Re: Drawing error with collapsable insets.

2006-06-18 Thread Martin Vermeer
On Thu, Jun 15, 2006 at 01:31:55PM +0300, Martin Vermeer wrote: On Wed, 2006-06-14 at 20:58 +0200, Andre Poenitz wrote: On Wed, Jun 14, 2006 at 09:35:23PM +0300, Martin Vermeer wrote: (BTW what should I use instead of 99? No, don't say 42...) size_t(-1) [Or the equivalent from

Re: [Better patch] Re: [Patch] Re: Drawing error with collapsable insets.

2006-06-18 Thread Lars Gullik Bjønnes
Martin Vermeer [EMAIL PROTECTED] writes: | On Sat, Jun 17, 2006 at 11:24:51PM +0300, Martin Vermeer wrote: | On Wed, Jun 14, 2006 at 11:14:19AM +0300, Martin Vermeer wrote: | | ... | | PS Getting rid of Wide() would only be possible if you have, inside | insettext, access to the

Re: [Better patch] Re: [Patch] Re: Drawing error with collapsable insets.

2006-06-18 Thread Martin Vermeer
On Mon, Jun 19, 2006 at 02:54:16AM +0200, Lars Gullik Bjønnes wrote: Martin Vermeer [EMAIL PROTECTED] writes: | On Sat, Jun 17, 2006 at 11:24:51PM +0300, Martin Vermeer wrote: | On Wed, Jun 14, 2006 at 11:14:19AM +0300, Martin Vermeer wrote: | | ... | | PS Getting rid of Wide()

[Better patch] Re: [Patch] Re: Drawing error with collapsable insets.

2006-06-18 Thread Martin Vermeer
On Sat, Jun 17, 2006 at 11:24:51PM +0300, Martin Vermeer wrote: > On Wed, Jun 14, 2006 at 11:14:19AM +0300, Martin Vermeer wrote: > > ... > > > PS Getting rid of Wide() would only be possible if you have, inside > > insettext, access to the _maximum_ left and right edges of the contained > >

Re: [New patch] Re: [Patch] Re: Drawing error with collapsable insets.

2006-06-18 Thread Martin Vermeer
On Thu, Jun 15, 2006 at 01:31:55PM +0300, Martin Vermeer wrote: > On Wed, 2006-06-14 at 20:58 +0200, Andre Poenitz wrote: > > On Wed, Jun 14, 2006 at 09:35:23PM +0300, Martin Vermeer wrote: > > > (BTW what should I use instead of 99? No, don't say 42...) > > > > size_t(-1) > > > > [Or the

Re: [Better patch] Re: [Patch] Re: Drawing error with collapsable insets.

2006-06-18 Thread Lars Gullik Bjønnes
Martin Vermeer <[EMAIL PROTECTED]> writes: | On Sat, Jun 17, 2006 at 11:24:51PM +0300, Martin Vermeer wrote: | > On Wed, Jun 14, 2006 at 11:14:19AM +0300, Martin Vermeer wrote: | > | > ... | > | > > PS Getting rid of Wide() would only be possible if you have, inside | > > insettext, access to

Re: [Better patch] Re: [Patch] Re: Drawing error with collapsable insets.

2006-06-18 Thread Martin Vermeer
On Mon, Jun 19, 2006 at 02:54:16AM +0200, Lars Gullik Bjønnes wrote: > Martin Vermeer <[EMAIL PROTECTED]> writes: > > | On Sat, Jun 17, 2006 at 11:24:51PM +0300, Martin Vermeer wrote: > | > On Wed, Jun 14, 2006 at 11:14:19AM +0300, Martin Vermeer wrote: > | > > | > ... > | > > | > > PS Getting

Re: [Patch] Re: Drawing error with collapsable insets.

2006-06-17 Thread Martin Vermeer
On Wed, Jun 14, 2006 at 11:14:19AM +0300, Martin Vermeer wrote: ... PS Getting rid of Wide() would only be possible if you have, inside insettext, access to the _maximum_ left and right edges of the contained text, rather than the _actual_ ones... Yesss! This is precisely the solution.

Re: [Patch] Re: Drawing error with collapsable insets.

2006-06-17 Thread Martin Vermeer
On Wed, Jun 14, 2006 at 11:14:19AM +0300, Martin Vermeer wrote: ... > PS Getting rid of Wide() would only be possible if you have, inside > insettext, access to the _maximum_ left and right edges of the contained > text, rather than the _actual_ ones... Yesss! This is precisely the solution.

Re: [Patch] Re: Drawing error with collapsable insets.

2006-06-16 Thread Jean-Marc Lasgouttes
Abdelrazak == Abdelrazak Younes [EMAIL PROTECTED] writes: Abdelrazak Bennett Helm wrote: here? ... I'm guessing not: I have Jean-Marc's font caching patch applied to 1.4.x (which noticeably improves things), but not to 1.5.x; perhaps that accounts for the difference. Abdelrazak Jean-Marc,

[PATCH] cache font width on OSX (was Re: [Patch] Re: Drawing error with collapsable insets.)

2006-06-16 Thread Jean-Marc Lasgouttes
Jean-Marc == Jean-Marc Lasgouttes [EMAIL PROTECTED] writes: Abdelrazak == Abdelrazak Younes [EMAIL PROTECTED] writes: Abdelrazak Bennett Helm wrote: here? ... I'm guessing not: I have Jean-Marc's font caching patch applied to 1.4.x (which noticeably improves things), but not to 1.5.x;

Re: [Patch] Re: Drawing error with collapsable insets.

2006-06-16 Thread Enrico Forestieri
On Fri, Jun 16, 2006 at 11:25:58AM +0200, Jean-Marc Lasgouttes wrote: Abdelrazak == Abdelrazak Younes [EMAIL PROTECTED] writes: Abdelrazak Bennett Helm wrote: here? ... I'm guessing not: I have Jean-Marc's font caching patch applied to 1.4.x (which noticeably improves things), but not to

Re: [Patch] Re: Drawing error with collapsable insets.

2006-06-16 Thread Jean-Marc Lasgouttes
Enrico == Enrico Forestieri [EMAIL PROTECTED] writes: Enrico I tried the patch on Windows and saw no appreciable (if any) Enrico speedup. What windows? JMarc

Re: [Patch] Re: Drawing error with collapsable insets.

2006-06-16 Thread Enrico Forestieri
On Fri, Jun 16, 2006 at 03:46:05PM +0200, Jean-Marc Lasgouttes wrote: Enrico == Enrico Forestieri [EMAIL PROTECTED] writes: Enrico I tried the patch on Windows and saw no appreciable (if any) Enrico speedup. What windows? The usual one ;-) Win2k with both qt3/win32 and qt3/cygwin. --

Re: [Patch] Re: Drawing error with collapsable insets.

2006-06-16 Thread Jean-Marc Lasgouttes
Enrico == Enrico Forestieri [EMAIL PROTECTED] writes: Enrico The usual one ;-) Enrico Win2k with both qt3/win32 and qt3/cygwin. This is what I wanted to know, thanks. JMarc

Re: [PATCH] cache font width on OSX (was Re: [Patch] Re: Drawing error with collapsable insets.)

2006-06-16 Thread Bennett Helm
On Jun 16, 2006, at 6:19 AM, Jean-Marc Lasgouttes wrote: Jean-Marc == Jean-Marc Lasgouttes [EMAIL PROTECTED] writes: Abdelrazak == Abdelrazak Younes [EMAIL PROTECTED] writes: Abdelrazak Bennett Helm wrote: here? ... I'm guessing not: I have Jean-Marc's font caching patch applied to 1.4.x

Re: [Patch] Re: Drawing error with collapsable insets.

2006-06-16 Thread Jean-Marc Lasgouttes
> "Abdelrazak" == Abdelrazak Younes <[EMAIL PROTECTED]> writes: Abdelrazak> Bennett Helm wrote: >> here? ... I'm guessing not: I have Jean-Marc's font caching patch >> applied to 1.4.x (which noticeably improves things), but not to >> 1.5.x; perhaps that accounts for the difference.

[PATCH] cache font width on OSX (was Re: [Patch] Re: Drawing error with collapsable insets.)

2006-06-16 Thread Jean-Marc Lasgouttes
> "Jean-Marc" == Jean-Marc Lasgouttes <[EMAIL PROTECTED]> writes: > "Abdelrazak" == Abdelrazak Younes <[EMAIL PROTECTED]> writes: Abdelrazak> Bennett Helm wrote: >>> here? ... I'm guessing not: I have Jean-Marc's font caching patch >>> applied to 1.4.x (which noticeably improves things),

Re: [Patch] Re: Drawing error with collapsable insets.

2006-06-16 Thread Enrico Forestieri
On Fri, Jun 16, 2006 at 11:25:58AM +0200, Jean-Marc Lasgouttes wrote: > > "Abdelrazak" == Abdelrazak Younes <[EMAIL PROTECTED]> writes: > > Abdelrazak> Bennett Helm wrote: > >> here? ... I'm guessing not: I have Jean-Marc's font caching patch > >> applied to 1.4.x (which noticeably improves

Re: [Patch] Re: Drawing error with collapsable insets.

2006-06-16 Thread Jean-Marc Lasgouttes
> "Enrico" == Enrico Forestieri <[EMAIL PROTECTED]> writes: Enrico> I tried the patch on Windows and saw no appreciable (if any) Enrico> speedup. What windows? JMarc

Re: [Patch] Re: Drawing error with collapsable insets.

2006-06-16 Thread Enrico Forestieri
On Fri, Jun 16, 2006 at 03:46:05PM +0200, Jean-Marc Lasgouttes wrote: > > "Enrico" == Enrico Forestieri <[EMAIL PROTECTED]> writes: > > Enrico> I tried the patch on Windows and saw no appreciable (if any) > Enrico> speedup. > > What windows? The usual one ;-) Win2k with both qt3/win32

Re: [Patch] Re: Drawing error with collapsable insets.

2006-06-16 Thread Jean-Marc Lasgouttes
> "Enrico" == Enrico Forestieri <[EMAIL PROTECTED]> writes: Enrico> The usual one ;-) Enrico> Win2k with both qt3/win32 and qt3/cygwin. This is what I wanted to know, thanks. JMarc

Re: [PATCH] cache font width on OSX (was Re: [Patch] Re: Drawing error with collapsable insets.)

2006-06-16 Thread Bennett Helm
On Jun 16, 2006, at 6:19 AM, Jean-Marc Lasgouttes wrote: "Jean-Marc" == Jean-Marc Lasgouttes <[EMAIL PROTECTED]> writes: "Abdelrazak" == Abdelrazak Younes <[EMAIL PROTECTED]> writes: Abdelrazak> Bennett Helm wrote: here? ... I'm guessing not: I have Jean-Marc's font caching patch applied

[New patch] Re: [Patch] Re: Drawing error with collapsable insets.

2006-06-15 Thread Martin Vermeer
On Wed, 2006-06-14 at 20:58 +0200, Andre Poenitz wrote: On Wed, Jun 14, 2006 at 09:35:23PM +0300, Martin Vermeer wrote: (BTW what should I use instead of 99? No, don't say 42...) size_t(-1) [Or the equivalent from numeric_limits...] Or a bool. Done. I propose this for trunk and 1.4

Re: [Patch] Re: Drawing error with collapsable insets.

2006-06-15 Thread Bennett Helm
On Jun 14, 2006, at 11:14 AM, Martin Vermeer wrote: On Wed, Jun 14, 2006 at 10:23:43AM -0400, Bennett Helm wrote: On Jun 14, 2006, at 4:14 AM, Martin Vermeer wrote: Attached a slightly better (less visually intrusive) solution. The logic is still the same, but now it draws a real box (with

Re: [Patch] Re: Drawing error with collapsable insets.

2006-06-15 Thread Martin Vermeer
On Thu, Jun 15, 2006 at 11:48:28AM -0400, Bennett Helm wrote: On Jun 14, 2006, at 11:14 AM, Martin Vermeer wrote: On Wed, Jun 14, 2006 at 10:23:43AM -0400, Bennett Helm wrote: On Jun 14, 2006, at 4:14 AM, Martin Vermeer wrote: Attached a slightly better (less visually intrusive) solution.

Re: [Patch] Re: Drawing error with collapsable insets.

2006-06-15 Thread Bennett Helm
On Jun 15, 2006, at 12:44 PM, Martin Vermeer wrote: It is much better than the previous patch: using the same test, I can type without any lag with 1 inset nested inside another (i.e., 2 nested insets) and only minimal lag with 3 nested insets. 4 or more nested insets gives me considerable lag.

Re: [Patch] Re: Drawing error with collapsable insets.

2006-06-15 Thread Abdelrazak Younes
Bennett Helm wrote: here? ... I'm guessing not: I have Jean-Marc's font caching patch applied to 1.4.x (which noticeably improves things), but not to 1.5.x; perhaps that accounts for the difference. Jean-Marc, IMHO you should check-in this patch for qt3 (trunk and 1.4). Abdel.

[New patch] Re: [Patch] Re: Drawing error with collapsable insets.

2006-06-15 Thread Martin Vermeer
On Wed, 2006-06-14 at 20:58 +0200, Andre Poenitz wrote: > On Wed, Jun 14, 2006 at 09:35:23PM +0300, Martin Vermeer wrote: > > (BTW what should I use instead of 99? No, don't say 42...) > > size_t(-1) > > [Or the equivalent from numeric_limits...] > > Or a bool. Done. I propose this for trunk

Re: [Patch] Re: Drawing error with collapsable insets.

2006-06-15 Thread Bennett Helm
On Jun 14, 2006, at 11:14 AM, Martin Vermeer wrote: On Wed, Jun 14, 2006 at 10:23:43AM -0400, Bennett Helm wrote: On Jun 14, 2006, at 4:14 AM, Martin Vermeer wrote: Attached a slightly better (less visually intrusive) solution. The logic is still the same, but now it draws a real box (with

Re: [Patch] Re: Drawing error with collapsable insets.

2006-06-15 Thread Martin Vermeer
On Thu, Jun 15, 2006 at 11:48:28AM -0400, Bennett Helm wrote: > On Jun 14, 2006, at 11:14 AM, Martin Vermeer wrote: > > >On Wed, Jun 14, 2006 at 10:23:43AM -0400, Bennett Helm wrote: > >>On Jun 14, 2006, at 4:14 AM, Martin Vermeer wrote: > >> > >>>Attached a slightly better (less visually

Re: [Patch] Re: Drawing error with collapsable insets.

2006-06-15 Thread Bennett Helm
On Jun 15, 2006, at 12:44 PM, Martin Vermeer wrote: It is much better than the previous patch: using the same test, I can type without any lag with 1 inset nested inside another (i.e., 2 nested insets) and only minimal lag with 3 nested insets. 4 or more nested insets gives me considerable lag.

Re: [Patch] Re: Drawing error with collapsable insets.

2006-06-15 Thread Abdelrazak Younes
Bennett Helm wrote: here? ... I'm guessing not: I have Jean-Marc's font caching patch applied to 1.4.x (which noticeably improves things), but not to 1.5.x; perhaps that accounts for the difference. Jean-Marc, IMHO you should check-in this patch for qt3 (trunk and 1.4). Abdel.

[Patch] Re: Drawing error with collapsable insets.

2006-06-14 Thread Martin Vermeer
On Mon, 2006-06-12 at 09:30 +0200, Lars Gullik Bjønnes wrote: Martin Vermeer [EMAIL PROTECTED] writes: | On Sat, 2006-06-10 at 15:22 +0200, Lars Gullik Bjønnes wrote: | [EMAIL PROTECTED] (Lars Gullik Bjønnes) writes: | | | We have a drawing error with insets. It is very easy to see

Re: [Patch] Re: Drawing error with collapsable insets.

2006-06-14 Thread Bennett Helm
On Jun 14, 2006, at 4:14 AM, Martin Vermeer wrote: Attached a slightly better (less visually intrusive) solution. The logic is still the same, but now it draws a real box (with fixed dimensions) not extending to the canvas edge. It appears to work OK in my limited testing. Note that now

Re: [Patch] Re: Drawing error with collapsable insets.

2006-06-14 Thread Martin Vermeer
On Wed, Jun 14, 2006 at 10:23:43AM -0400, Bennett Helm wrote: On Jun 14, 2006, at 4:14 AM, Martin Vermeer wrote: Attached a slightly better (less visually intrusive) solution. The logic is still the same, but now it draws a real box (with fixed dimensions) not extending to the canvas edge.

Re: [Patch] Re: Drawing error with collapsable insets.

2006-06-14 Thread Andre Poenitz
On Tue, Jun 13, 2006 at 08:49:57PM +0300, Martin Vermeer wrote: === --- insettabular.C(revision 14084) +++ insettabular.C(working copy) @@ -332,6 +332,29 @@ setPosCache(pi, x, y); LCursor cur =

  1   2   >