On Thu, Jun 22, 2006 at 12:23:38PM +0200, Jean-Marc Lasgouttes wrote:
> > "Martin" == Martin Vermeer <[EMAIL PROTECTED]> writes:
...
> Martin> Attached the tabular background patch for 1.4 (still not
> Martin> applied)
>
> This part is OK.
Checked it in, so it isn't forgotten.
Log:
On Fri, Jun 23, 2006 at 12:04:33PM +0200, Jean-Marc Lasgouttes wrote:
> > "Martin" == Martin Vermeer <[EMAIL PROTECTED]> writes:
>
> >> I do not know whether this is related to your patch(es): try to
> >> insert a collapsable inset in a tabular cell; the right margin of
> >> the inset is outs
> "Martin" == Martin Vermeer <[EMAIL PROTECTED]> writes:
>> I do not know whether this is related to your patch(es): try to
>> insert a collapsable inset in a tabular cell; the right margin of
>> the inset is outside of the screen.
Martin> I suppose the speed-up patch exposed this bug,
Umm
On Thu, Jun 22, 2006 at 04:05:34PM +0200, Jean-Marc Lasgouttes wrote:
> > "Martin" == Martin Vermeer <[EMAIL PROTECTED]> writes:
...
> Running under gdb, I noticed that InsetCollapsable::metrics is called
> twice when creating a new note inset. The reason is that it is called
> twice in Ins
> "Martin" == Martin Vermeer <[EMAIL PROTECTED]> writes:
>> And do you think it would be too difficult to fix the real cause?
Martin> My patch does that... imperfectly. The value is now sensible,
Martin> but often a bit generous.
Yes, I saw that afterwards, but failed to edit the message co
On Thu, 2006-06-22 at 12:23 +0200, Jean-Marc Lasgouttes wrote:
> > "Martin" == Martin Vermeer <[EMAIL PROTECTED]> writes:
>
> Martin> I suppose the speed-up patch exposed this bug, i.e., that a
> Martin> tabular cell with a non-fixed width does not transmit a
> Martin> sensible mi.base.textwid
> "Martin" == Martin Vermeer <[EMAIL PROTECTED]> writes:
Martin> I suppose the speed-up patch exposed this bug, i.e., that a
Martin> tabular cell with a non-fixed width does not transmit a
Martin> sensible mi.base.textwidth to any textinsets it contains. Now
Martin> that we use this (or the de
On Wed, Jun 21, 2006 at 12:17:41PM +0200, Jean-Marc Lasgouttes wrote:
> > "Martin" == Martin Vermeer <[EMAIL PROTECTED]> writes:
>
> Martin> In my newfound tradition of making everything simpler :-) If
> Martin> you paint the whole tabular background, you don't have to
> Martin> figure out wha
> "Martin" == Martin Vermeer <[EMAIL PROTECTED]> writes:
Martin> So done.
Thanks.
Martin> Don't think it requires anything in status.14x.
Why? I try to put everything there.
JMarc
On Tue, 2006-06-20 at 15:00 +0200, Jean-Marc Lasgouttes wrote:
> > "Martin" == Martin Vermeer <[EMAIL PROTECTED]> writes:
>
> Martin> Your question presupposes that these two mechanisms would have
> Martin> anything in common. They have not. display() is a property of
> Martin> the inset (or i
> "Martin" == Martin Vermeer <[EMAIL PROTECTED]> writes:
Martin> Sure... but how does rowpainter (i.e., the surrounding row)
Martin> tell the inset that it is Wide?
This is a good question :)
>> I tested the patch, and it seems to work very well. I am OK with
>> putting this in 1.4.
>>
>>
> "Martin" == Martin Vermeer <[EMAIL PROTECTED]> writes:
Martin> In my newfound tradition of making everything simpler :-) If
Martin> you paint the whole tabular background, you don't have to
Martin> figure out what cell you're in...
Martin> Please give it some exercise before the go-ahead fo
On Tue, Jun 20, 2006 at 03:00:41PM +0200, Jean-Marc Lasgouttes wrote:
> > "Martin" == Martin Vermeer <[EMAIL PROTECTED]> writes:
>
> Martin> Your question presupposes that these two mechanisms would have
> Martin> anything in common. They have not. display() is a property of
> Martin> the inse
On Jun 20, 2006, at 9:27 AM, Martin Vermeer wrote:
On Tue, Jun 20, 2006 at 09:14:20AM -0400, Bennett Helm wrote:
On Jun 20, 2006, at 9:00 AM, Jean-Marc Lasgouttes wrote:
Finally, when typing random text in a footnote, everytime the text
gets near the right margin, the all the lines of the foo
On Tue, Jun 20, 2006 at 09:14:20AM -0400, Bennett Helm wrote:
> On Jun 20, 2006, at 9:00 AM, Jean-Marc Lasgouttes wrote:
>
> >Finally, when typing random text in a footnote, everytime the text
> >gets near the right margin, the all the lines of the footnote move
> >right and left. Is that the effe
On Jun 20, 2006, at 9:00 AM, Jean-Marc Lasgouttes wrote:
Finally, when typing random text in a footnote, everytime the text
gets near the right margin, the all the lines of the footnote move
right and left. Is that the effect that you described, Bennett?
I think so. You're typing at the end of
> "Martin" == Martin Vermeer <[EMAIL PROTECTED]> writes:
Martin> Your question presupposes that these two mechanisms would have
Martin> anything in common. They have not. display() is a property of
Martin> the inset (or in math, a mode of the inset). Wide() is a
Martin> status element of text
On Mon, 2006-06-19 at 10:44 -0400, Bennett Helm wrote:
> On Jun 18, 2006, at 5:24 AM, Martin Vermeer wrote:
>
> > On Sat, Jun 17, 2006 at 11:24:51PM +0300, Martin Vermeer wrote:
> >> On Wed, Jun 14, 2006 at 11:14:19AM +0300, Martin Vermeer wrote:
> >>
> >> ...
> >>
> >>> PS Getting rid of Wide() w
On Tue, 2006-06-20 at 13:41 +0300, Martin Vermeer wrote:
> On Tue, 2006-06-20 at 11:55 +0200, Jean-Marc Lasgouttes wrote:
> > > "Martin" == Martin Vermeer <[EMAIL PROTECTED]> writes:
> >
> > Martin> In my newfound tradition of making everything simpler :-) If
> > Martin> you paint the whole ta
On Tue, 2006-06-20 at 11:55 +0200, Jean-Marc Lasgouttes wrote:
> > "Martin" == Martin Vermeer <[EMAIL PROTECTED]> writes:
>
> Martin> In my newfound tradition of making everything simpler :-) If
> Martin> you paint the whole tabular background, you don't have to
> Martin> figure out what cell
> "Martin" == Martin Vermeer <[EMAIL PROTECTED]> writes:
Martin> In my newfound tradition of making everything simpler :-) If
Martin> you paint the whole tabular background, you don't have to
Martin> figure out what cell you're in...
You are saying it is not a problem because you repaint the
On Mon, 2006-06-19 at 15:05 +0300, Martin Vermeer wrote:
> On Mon, 2006-06-19 at 11:21 +0200, Jean-Marc Lasgouttes wrote:
> > > "Martin" == Martin Vermeer <[EMAIL PROTECTED]> writes:
> >
> > >> Done. I propose this for trunk and 1.4 (Jean-Marc?), as it fixes a
> > >> rendering bug.
> >
> > Ma
On Jun 19, 2006, at 12:36 PM, Martin Vermeer wrote:
On Mon, Jun 19, 2006 at 10:44:27AM -0400, Bennett Helm wrote:
On Jun 18, 2006, at 5:24 AM, Martin Vermeer wrote:
...
Here's the patch you've been looking for... it simplifies things
which
is always a good sign.
This is much faster on M
On Mon, Jun 19, 2006 at 10:44:27AM -0400, Bennett Helm wrote:
> On Jun 18, 2006, at 5:24 AM, Martin Vermeer wrote:
...
> >Here's the patch you've been looking for... it simplifies things which
> >is always a good sign.
>
> This is much faster on Mac than the previous patches, but still a bit
On Mon, Jun 19, 2006 at 04:16:20PM +0200, Jean-Marc Lasgouttes wrote:
> > "Martin" == Martin Vermeer <[EMAIL PROTECTED]> writes:
>
> Martin> On Mon, 2006-06-19 at 12:52 +0200, Jean-Marc Lasgouttes wrote:
> >> > "Martin" == Martin Vermeer <[EMAIL PROTECTED]> writes:
> >>
> Martin> Here's t
On Jun 18, 2006, at 5:24 AM, Martin Vermeer wrote:
On Sat, Jun 17, 2006 at 11:24:51PM +0300, Martin Vermeer wrote:
On Wed, Jun 14, 2006 at 11:14:19AM +0300, Martin Vermeer wrote:
...
PS Getting rid of Wide() would only be possible if you have, inside
insettext, access to the _maximum_ left a
> "Martin" == Martin Vermeer <[EMAIL PROTECTED]> writes:
Martin> On Mon, 2006-06-19 at 12:52 +0200, Jean-Marc Lasgouttes wrote:
>> > "Martin" == Martin Vermeer <[EMAIL PROTECTED]> writes:
>>
Martin> Here's the patch you've been looking for... it simplifies
Martin> things which is always a
On Mon, 2006-06-19 at 12:52 +0200, Jean-Marc Lasgouttes wrote:
> > "Martin" == Martin Vermeer <[EMAIL PROTECTED]> writes:
>
> Martin> Here's the patch you've been looking for... it simplifies
> Martin> things which is always a good sign.
>
> Instead of using Wide(), isn't it possible to use d
On Mon, 2006-06-19 at 11:21 +0200, Jean-Marc Lasgouttes wrote:
> > "Martin" == Martin Vermeer <[EMAIL PROTECTED]> writes:
>
> >> Done. I propose this for trunk and 1.4 (Jean-Marc?), as it fixes a
> >> rendering bug.
>
> Martin> Committed for trunk. Jean-Marc?
>
> OK.
No.
I found a better w
> "Martin" == Martin Vermeer <[EMAIL PROTECTED]> writes:
Martin> Here's the patch you've been looking for... it simplifies
Martin> things which is always a good sign.
Instead of using Wide(), isn't it possible to use display()?
I agree this is better, nevertheless.
JMarc
> "Martin" == Martin Vermeer <[EMAIL PROTECTED]> writes:
>> Done. I propose this for trunk and 1.4 (Jean-Marc?), as it fixes a
>> rendering bug.
Martin> Committed for trunk. Jean-Marc?
OK.
JMarc
On Mon, Jun 19, 2006 at 02:54:16AM +0200, Lars Gullik Bjønnes wrote:
> Martin Vermeer <[EMAIL PROTECTED]> writes:
>
> | On Sat, Jun 17, 2006 at 11:24:51PM +0300, Martin Vermeer wrote:
> | > On Wed, Jun 14, 2006 at 11:14:19AM +0300, Martin Vermeer wrote:
> | >
> | > ...
> | >
> | > > PS Getting
Martin Vermeer <[EMAIL PROTECTED]> writes:
| On Sat, Jun 17, 2006 at 11:24:51PM +0300, Martin Vermeer wrote:
| > On Wed, Jun 14, 2006 at 11:14:19AM +0300, Martin Vermeer wrote:
| >
| > ...
| >
| > > PS Getting rid of Wide() would only be possible if you have, inside
| > > insettext, access to t
On Thu, Jun 15, 2006 at 01:31:55PM +0300, Martin Vermeer wrote:
> On Wed, 2006-06-14 at 20:58 +0200, Andre Poenitz wrote:
> > On Wed, Jun 14, 2006 at 09:35:23PM +0300, Martin Vermeer wrote:
> > > (BTW what should I use instead of 99? No, don't say 42...)
> >
> > size_t(-1)
> >
> > [Or the equival
On Sat, Jun 17, 2006 at 11:24:51PM +0300, Martin Vermeer wrote:
> On Wed, Jun 14, 2006 at 11:14:19AM +0300, Martin Vermeer wrote:
>
> ...
>
> > PS Getting rid of Wide() would only be possible if you have, inside
> > insettext, access to the _maximum_ left and right edges of the contained
> > tex
On Wed, Jun 14, 2006 at 11:14:19AM +0300, Martin Vermeer wrote:
...
> PS Getting rid of Wide() would only be possible if you have, inside
> insettext, access to the _maximum_ left and right edges of the contained
> text, rather than the _actual_ ones...
Yesss! This is precisely the solution. P
On Jun 16, 2006, at 6:19 AM, Jean-Marc Lasgouttes wrote:
"Jean-Marc" == Jean-Marc Lasgouttes <[EMAIL PROTECTED]> writes:
"Abdelrazak" == Abdelrazak Younes <[EMAIL PROTECTED]> writes:
Abdelrazak> Bennett Helm wrote:
here? ... I'm guessing not: I have Jean-Marc's font caching patch
applied to
> "Enrico" == Enrico Forestieri <[EMAIL PROTECTED]> writes:
Enrico> The usual one ;-)
Enrico> Win2k with both qt3/win32 and qt3/cygwin.
This is what I wanted to know, thanks.
JMarc
On Fri, Jun 16, 2006 at 03:46:05PM +0200, Jean-Marc Lasgouttes wrote:
> > "Enrico" == Enrico Forestieri <[EMAIL PROTECTED]> writes:
>
> Enrico> I tried the patch on Windows and saw no appreciable (if any)
> Enrico> speedup.
>
> What windows?
The usual one ;-)
Win2k with both qt3/win32 and
> "Enrico" == Enrico Forestieri <[EMAIL PROTECTED]> writes:
Enrico> I tried the patch on Windows and saw no appreciable (if any)
Enrico> speedup.
What windows?
JMarc
On Fri, Jun 16, 2006 at 11:25:58AM +0200, Jean-Marc Lasgouttes wrote:
> > "Abdelrazak" == Abdelrazak Younes <[EMAIL PROTECTED]> writes:
>
> Abdelrazak> Bennett Helm wrote:
> >> here? ... I'm guessing not: I have Jean-Marc's font caching patch
> >> applied to 1.4.x (which noticeably improves t
> "Jean-Marc" == Jean-Marc Lasgouttes <[EMAIL PROTECTED]> writes:
> "Abdelrazak" == Abdelrazak Younes <[EMAIL PROTECTED]> writes:
Abdelrazak> Bennett Helm wrote:
>>> here? ... I'm guessing not: I have Jean-Marc's font caching patch
>>> applied to 1.4.x (which noticeably improves things), b
> "Abdelrazak" == Abdelrazak Younes <[EMAIL PROTECTED]> writes:
Abdelrazak> Bennett Helm wrote:
>> here? ... I'm guessing not: I have Jean-Marc's font caching patch
>> applied to 1.4.x (which noticeably improves things), but not to
>> 1.5.x; perhaps that accounts for the difference.
Abdelraza
Bennett Helm wrote:
here? ... I'm guessing not: I have Jean-Marc's font caching patch
applied to 1.4.x (which noticeably improves things), but not to 1.5.x;
perhaps that accounts for the difference.
Jean-Marc, IMHO you should check-in this patch for qt3 (trunk and 1.4).
Abdel.
On Jun 15, 2006, at 12:44 PM, Martin Vermeer wrote:
It is much better than the previous patch: using the same test, I can
type without any lag with 1 inset nested inside another (i.e., 2
nested insets) and only minimal lag with 3 nested insets. 4 or more
nested insets gives me considerable lag.
On Thu, Jun 15, 2006 at 11:48:28AM -0400, Bennett Helm wrote:
> On Jun 14, 2006, at 11:14 AM, Martin Vermeer wrote:
>
> >On Wed, Jun 14, 2006 at 10:23:43AM -0400, Bennett Helm wrote:
> >>On Jun 14, 2006, at 4:14 AM, Martin Vermeer wrote:
> >>
> >>>Attached a slightly better (less visually intrusiv
On Jun 14, 2006, at 11:14 AM, Martin Vermeer wrote:
On Wed, Jun 14, 2006 at 10:23:43AM -0400, Bennett Helm wrote:
On Jun 14, 2006, at 4:14 AM, Martin Vermeer wrote:
Attached a slightly better (less visually intrusive) solution.
The logic is still the same, but now it draws a real box (with f
On Wed, 2006-06-14 at 20:58 +0200, Andre Poenitz wrote:
> On Wed, Jun 14, 2006 at 09:35:23PM +0300, Martin Vermeer wrote:
> > (BTW what should I use instead of 99? No, don't say 42...)
>
> size_t(-1)
>
> [Or the equivalent from numeric_limits...]
>
> Or a bool.
Done. I propose this for trunk an
On Wed, Jun 14, 2006 at 09:35:23PM +0300, Martin Vermeer wrote:
> (BTW what should I use instead of 99? No, don't say 42...)
size_t(-1)
[Or the equivalent from numeric_limits...]
Or a bool.
> Index: insettabular.C
> ===
> --- inset
On Wed, Jun 14, 2006 at 07:07:56PM +0200, Andre Poenitz wrote:
> On Tue, Jun 13, 2006 at 08:49:57PM +0300, Martin Vermeer wrote:
> > ===
> > --- insettabular.C (revision 14084)
> > +++ insettabular.C (working copy)
> > @@ -332,6 +332
On Tue, Jun 13, 2006 at 08:49:57PM +0300, Martin Vermeer wrote:
> ===
> --- insettabular.C(revision 14084)
> +++ insettabular.C(working copy)
> @@ -332,6 +332,29 @@
> setPosCache(pi, x, y);
>
> LCursor & cur = pi.
On Wed, Jun 14, 2006 at 10:23:43AM -0400, Bennett Helm wrote:
> On Jun 14, 2006, at 4:14 AM, Martin Vermeer wrote:
>
> >Attached a slightly better (less visually intrusive) solution.
> >
> >The logic is still the same, but now it draws a real box (with fixed
> >dimensions) not extending to the can
On Jun 14, 2006, at 4:14 AM, Martin Vermeer wrote:
Attached a slightly better (less visually intrusive) solution.
The logic is still the same, but now it draws a real box (with fixed
dimensions) not extending to the canvas edge.
It appears to work OK in my limited testing. Note that now insets
On Mon, 2006-06-12 at 09:30 +0200, Lars Gullik Bjønnes wrote:
> Martin Vermeer <[EMAIL PROTECTED]> writes:
>
> | On Sat, 2006-06-10 at 15:22 +0200, Lars Gullik Bjønnes wrote:
> | > [EMAIL PROTECTED] (Lars Gullik Bjønnes) writes:
> | >
> | > | We have a drawing error with insets. It is very easy
On Mon, Jun 12, 2006 at 11:42:25PM +0300, Martin Vermeer wrote:
> On Mon, Jun 12, 2006 at 10:18:04PM +0300, Martin Vermeer wrote:
> > On Mon, Jun 12, 2006 at 12:47:56PM +0200, Juergen Spitzmueller wrote:
> > > Juergen Spitzmueller wrote:
> > > > I'm seeing drawing errors in 1.4 every now and then w
On Mon, Jun 12, 2006 at 10:18:04PM +0300, Martin Vermeer wrote:
> On Mon, Jun 12, 2006 at 12:47:56PM +0200, Juergen Spitzmueller wrote:
> > Juergen Spitzmueller wrote:
> > > I'm seeing drawing errors in 1.4 every now and then with collapsable
> > > insets
> > > in tabular cells (that is, if you wr
On Mon, Jun 12, 2006 at 12:47:56PM +0200, Juergen Spitzmueller wrote:
> Juergen Spitzmueller wrote:
> > I'm seeing drawing errors in 1.4 every now and then with collapsable insets
> > in tabular cells (that is, if you write into the collapsable, the screen
> > does not get updated).
>
> I obviousl
On Mon, 2006-06-12 at 11:06 +0200, Lars Gullik Bjønnes wrote:
> Martin Vermeer <[EMAIL PROTECTED]> writes:
>
> | On Mon, 2006-06-12 at 09:30 +0200, Lars Gullik Bjønnes wrote:
> | > Martin Vermeer <[EMAIL PROTECTED]> writes:
> | >
> | > | On Sat, 2006-06-10 at 15:22 +0200, Lars Gullik Bjønnes
Juergen Spitzmueller wrote:
> I'm seeing drawing errors in 1.4 every now and then with collapsable insets
> in tabular cells (that is, if you write into the collapsable, the screen
> does not get updated).
I obviously mean something different:
- New table
- add some text in a cell
- change column
Enrico Forestieri <[EMAIL PROTECTED]> writes:
| On Mon, Jun 12, 2006 at 11:37:56AM +0300, Martin Vermeer wrote:
| > On Mon, 2006-06-12 at 09:30 +0200, Lars Gullik Bjønnes wrote:
|
| > > We should find a better solution. The Wide() thing really feels like a
| > > hack. (And there should be no reas
Martin Vermeer <[EMAIL PROTECTED]> writes:
| On Mon, 2006-06-12 at 09:30 +0200, Lars Gullik Bjønnes wrote:
| > Martin Vermeer <[EMAIL PROTECTED]> writes:
| >
| > | On Sat, 2006-06-10 at 15:22 +0200, Lars Gullik Bjønnes wrote:
| > | > [EMAIL PROTECTED] (Lars Gullik Bjønnes) writes:
| > | >
On Mon, Jun 12, 2006 at 11:37:56AM +0300, Martin Vermeer wrote:
> On Mon, 2006-06-12 at 09:30 +0200, Lars Gullik Bjønnes wrote:
> > We should find a better solution. The Wide() thing really feels like a
> > hack. (And there should be no reason why a Wide() non-Wide() have to
> > be drawn different
On Mon, 2006-06-12 at 09:30 +0200, Lars Gullik Bjønnes wrote:
> Martin Vermeer <[EMAIL PROTECTED]> writes:
>
> | On Sat, 2006-06-10 at 15:22 +0200, Lars Gullik Bjønnes wrote:
> | > [EMAIL PROTECTED] (Lars Gullik Bjønnes) writes:
> | >
> | > | We have a drawing error with insets. It is very easy
Martin Vermeer <[EMAIL PROTECTED]> writes:
| On Sat, 2006-06-10 at 15:22 +0200, Lars Gullik Bjønnes wrote:
| > [EMAIL PROTECTED] (Lars Gullik Bjønnes) writes:
| >
| > | We have a drawing error with insets. It is very easy to see with the
| > | note inset. Just load the userguide, look at the 'N
On Sat, 2006-06-10 at 15:22 +0200, Lars Gullik Bjønnes wrote:
> [EMAIL PROTECTED] (Lars Gullik Bjønnes) writes:
>
> | We have a drawing error with insets. It is very easy to see with the
> | note inset. Just load the userguide, look at the 'Note' inset near the
> | top, place the cursor within it
On Sat, Jun 10, 2006 at 03:22:38PM +0200, Lars Gullik Bjønnes wrote:
> [EMAIL PROTECTED] (Lars Gullik Bjønnes) writes:
>
> | We have a drawing error with insets. It is very easy to see with the
> | note inset. Just load the userguide, look at the 'Note' inset near the
> | top, place the cursor wit
[EMAIL PROTECTED] (Lars Gullik Bjønnes) writes:
| We have a drawing error with insets. It is very easy to see with the
| note inset. Just load the userguide, look at the 'Note' inset near the
| top, place the cursor within it and see the background and frame
| change.
|
| If the note is not the f
Lars Gullik Bjønnes wrote:
> Is this bug also present in 1.4?
I'm seeing drawing errors in 1.4 every now and then with collapsable insets in
tabular cells (that is, if you write into the collapsable, the screen does
not get updated).
I couldn't yet boil it down to a reproducible test case, thoug
We have a drawing error with insets. It is very easy to see with the
note inset. Just load the userguide, look at the 'Note' inset near the
top, place the cursor within it and see the background and frame
change.
If the note is not the first item in the paragraph -> no error
If the note contains
69 matches
Mail list logo
