Am Mon, 10 Jun 2024 12:51:34 -0400
schrieb Richard Kimberly Heck :
> On 6/10/24 08:40, Kornel Benko wrote:
> > commit 8c501308c3c9bf2389275837798ed6c62a9a17bf
> > Author: Alexander Dunlap
> > Date: Mon Jun 10 14:42:29 2024 +0200
> >
> > FindAdv: Omitting
On 6/10/24 08:40, Kornel Benko wrote:
commit 8c501308c3c9bf2389275837798ed6c62a9a17bf
Author: Alexander Dunlap
Date: Mon Jun 10 14:42:29 2024 +0200
FindAdv: Omitting cursor advance at start of search if in mathed.
Fixes #13070 Advanced S&R does not find math symbols at s
Commits 1464bd3f, 3576be9a, cd6d21eb, f845a4e9, 115d6cee, b0323628, 6c735efb,
895aa9cd,
4b41f545,
Sorry for the mess. I was unable to get it right on the first attempt.
Would be nice, if anyone could also stress advanced search.
Kornel
--
lyx-devel mailing list
lyx-devel@lists.lyx.org
h
p, thinspace, visible space, quad, ...
> > > and many more with regex?
> >
> > I'd expect \s covers them (except for visible space).
> >
>
> I too, if that were all unicode.
>
> Kornel
>
Nonetheless, good idea. Used now for findadv at 4b
Am Wed, 11 May 2022 17:21:52 +0200
schrieb Jürgen Spitzmüller :
> Am Mittwoch, dem 11.05.2022 um 14:18 +0200 schrieb Kornel Benko:
> > How to search for space like
> > hfill, medskip, thinspace, visible space, quad, ...
> > and many more with regex?
>
> I'd expect \s covers them (except for vis
Am Mittwoch, dem 11.05.2022 um 14:18 +0200 schrieb Kornel Benko:
> How to search for space like
> hfill, medskip, thinspace, visible space, quad, ...
> and many more with regex?
I'd expect \s covers them (except for visible space).
--
Jürgen
signature.asc
Description: This is a digitally signe
Am Wed, 11 May 2022 13:23:31 +0200
schrieb Jürgen Spitzmüller :
> Am Dienstag, dem 10.05.2022 um 16:50 +0200 schrieb Kornel Benko:
> > Does it make sense to add a checkbox to advanced find GUI like
> > 'Space-type'
> > which would treat all white spaces equal?
> > (Anything in src/insets/I
Am Dienstag, dem 10.05.2022 um 16:50 +0200 schrieb Kornel Benko:
> Does it make sense to add a checkbox to advanced find GUI like
> 'Space-type'
> which would treat all white spaces equal?
> (Anything in src/insets/InsetSpace.cpp)
Smells a bit like feature creep to me. Isn't this something
Does it make sense to add a checkbox to advanced find GUI like
'Space-type'
which would treat all white spaces equal?
(Anything in src/insets/InsetSpace.cpp)
If yes, then should it could go to lyx2.5?
Kornel
--
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/m
The problem:
Open new lyx-file
insert
unicode-insert 0x025c 0x1d08
Open adv-find dialog
search for unicode 0x025c OK
search for unicode 0x1d08 OK
search with regex for unicode 0x025c OK
search with regex for unicode 0x1d08 ==> NOT OK (because we are searching for
\textrevepsilon and this i
On Thu, Feb 11, 2021 at 04:30:32PM +0100, Kornel Benko wrote:
> Am Wed, 10 Feb 2021 00:38:15 -0500
> schrieb Scott Kostyshak :
> > That is, without a unit test
> > framework and an extensive set of unit tests, I would be hesitant to
> > change anything.
>
> Even with unit tests, you cannot be sur
Am Wed, 10 Feb 2021 00:38:15 -0500
schrieb Scott Kostyshak :
> On Mon, Jan 25, 2021 at 02:02:09PM +0100, Kornel Benko wrote:
> > Problems with FindAdv and search with not ignored format
> >
> > What we have now is something 'neither fish nor fowl'.
> >
On Mon, Jan 25, 2021 at 02:02:09PM +0100, Kornel Benko wrote:
> Problems with FindAdv and search with not ignored format
>
> What we have now is something 'neither fish nor fowl'.
>
> For instance for the search of characters with a specific size
> we use strings/r
Problems with FindAdv and search with not ignored format
What we have now is something 'neither fish nor fowl'.
For instance for the search of characters with a specific size
we use strings/regexes wrapped with the size-spec. All is nice, until the size
is the
default in the documen
Am Sat, 09 Jan 2021 12:58:16 +0100
schrieb Jürgen Spitzmüller :
> Am Freitag, dem 08.01.2021 um 11:39 +0100 schrieb Kornel Benko:
> > I have problems to _use_ matched substrings in replace-mode.
> >
> > For instance given regular expression containing some groups, like
> > '()()()
Am Freitag, dem 08.01.2021 um 11:39 +0100 schrieb Kornel Benko:
> I have problems to _use_ matched substrings in replace-mode.
>
> For instance given regular expression containing some groups, like
> '()()()'
> and I want to change the found value to '', so in regex I
Am Fri, 08 Jan 2021 12:15:00 +0100
schrieb Jürgen Spitzmüller :
> Am Freitag, dem 08.01.2021 um 12:10 +0100 schrieb Kornel Benko:
> > commit c3cda5ffd4e17d79c8fb09a2b122efa959418885
> > Author: Kornel Benko
> > Date: Fri Jan 8 12:05:51 2021 +0100
> >
> >
Am Freitag, dem 08.01.2021 um 12:10 +0100 schrieb Kornel Benko:
> commit c3cda5ffd4e17d79c8fb09a2b122efa959418885
> Author: Kornel Benko
> Date: Fri Jan 8 12:05:51 2021 +0100
>
> FindAdv: Save sub-matches in MatchStringAdv class
>
> Prepare fo
I have problems to _use_ matched substrings in replace-mode.
For instance given regular expression containing some groups, like
'()()()'
and I want to change the found value to '', so in regex I would
write
'\3\2\1'
Now the selection contains '\3\2\1', thi
Am Sonntag, 25. November 2018 15:12:38 CET schrieb Scott Kostyshak
:
> On Sun, Nov 25, 2018 at 06:14:11PM +0100, Kornel Benko wrote:
> > Am Samstag, 24. November 2018 20:58:25 CET schrieb Scott Kostyshak
> > :
> > > On Sun, Nov 25, 2018 at 12:46:35AM +0100, Kornel Benko wrote:
> > > > Am Samstag,
Am Sonntag, 25. November 2018 18:29:25 CET schrieb Tommaso Cucinotta
:
> On 25/11/18 00:46, Kornel Benko wrote:
> > Anyway, if one would want to 'ungreed', there will always exist the
> > possibility to use (in our case)
> > "regular.*?expres"
>
> once upon a time, I remember LyX could be co
On 25/11/18 00:46, Kornel Benko wrote:
Anyway, if one would want to 'ungreed', there will always exist the possibility
to use (in our case)
"regular.*?expres"
once upon a time, I remember LyX could be compiled with either std::regex, or boost::regex, with some differences in
what is s
Am Samstag, 24. November 2018 20:58:25 CET schrieb Scott Kostyshak
:
> On Sun, Nov 25, 2018 at 12:46:35AM +0100, Kornel Benko wrote:
> > Am Samstag, 24. November 2018 16:07:29 CET schrieb Scott Kostyshak
> > :
> > > On Sat, Nov 24, 2018 at 08:41:23PM +0100, Kornel Benko wrote:
> > >
> > > > Give
On Sun, Nov 25, 2018 at 12:46:35AM +0100, Kornel Benko wrote:
> Am Samstag, 24. November 2018 16:07:29 CET schrieb Scott Kostyshak
> :
> > On Sat, Nov 24, 2018 at 08:41:23PM +0100, Kornel Benko wrote:
> >
> > > Given a string
> > > "xxx regular expression some other text expression"
> > > and a
Am Samstag, 24. November 2018 16:07:29 CET schrieb Scott Kostyshak
:
> On Sat, Nov 24, 2018 at 08:41:23PM +0100, Kornel Benko wrote:
>
> > Given a string
> > "xxx regular expression some other text expression"
> > and a pattern
> > "regular.*expres"
> >
> > The question now: what should
On Sat, Nov 24, 2018 at 08:41:23PM +0100, Kornel Benko wrote:
> Given a string
> "xxx regular expression some other text expression"
> and a pattern
> "regular.*expres"
>
> The question now: what should be found?
> 1.) "regular expres"
> or
> 2.) "regular expression some other text
Am Samstag, 24. November 2018 18:53:34 CET schrieb Kornel Benko
:
> Am Samstag, 24. November 2018 12:28:48 CET schrieb Scott Kostyshak
> :
> > On Sat, Nov 24, 2018 at 04:52:37PM +0100, Kornel Benko wrote:
> >
> > > I am wondering too. The 0964ffb2 change affects only in case of 'not
> > > igno
Am Samstag, 24. November 2018 12:28:48 CET schrieb Scott Kostyshak
:
> On Sat, Nov 24, 2018 at 04:52:37PM +0100, Kornel Benko wrote:
>
> > I am wondering too. The 0964ffb2 change affects only in case of 'not
> > ignoring format'.
> > I cannot reproduce. Could you send me paper.lyx privately?
>
On Sat, Nov 24, 2018 at 04:52:37PM +0100, Kornel Benko wrote:
> I am wondering too. The 0964ffb2 change affects only in case of 'not
> ignoring format'.
> I cannot reproduce. Could you send me paper.lyx privately?
The example is actually with UserGuide.lyx. I use the UserGuide.lyx from
2.3.0 fo
Am Freitag, 23. November 2018 20:29:47 CET schrieb Scott Kostyshak
:
> On Fri, Nov 23, 2018 at 12:25:43PM +0100, Kornel Benko wrote:
> > Am Donnerstag, 22. November 2018 20:32:32 CET schrieb Scott Kostyshak
> > :
> > > On Thu, Nov 22, 2018 at 11:02:00AM +0100, Kornel Benko wrote:
> > >
> > > > >
On Fri, Nov 23, 2018 at 12:25:43PM +0100, Kornel Benko wrote:
> Am Donnerstag, 22. November 2018 20:32:32 CET schrieb Scott Kostyshak
> :
> > On Thu, Nov 22, 2018 at 11:02:00AM +0100, Kornel Benko wrote:
> >
> > > > You mean feedback from developers?
> > >
> > > Yes.
> >
> > I just tested and f
Am Donnerstag, 22. November 2018 20:32:32 CET schrieb Scott Kostyshak
:
> On Thu, Nov 22, 2018 at 11:02:00AM +0100, Kornel Benko wrote:
>
> > > You mean feedback from developers?
> >
> > Yes.
>
> I just tested and found one thing that might be a regression. See the
> attached screenshots. I can
Am Dienstag, 20. November 2018 19:18:52 CET schrieb Scott Kostyshak
:
...
> > That's the most scaring thing IMHO.
> > If I would have known how many problems were waiting in the process, I would
> > probably not have started. To mention, that the search is now faster and
> > more accurate,
> > do
wrote:
> > > > commit e9e3c50c650cddc816854a8e884f220639e1f3ef
> > > > Author: Kornel Benko
> > > > Date: Tue Nov 20 14:36:11 2018 +0100
> > > >
> > > > FindAdv: Optimization
> > > >
> > > > A try to
r: Kornel Benko
> > > Date: Tue Nov 20 14:36:11 2018 +0100
> > >
> > > FindAdv: Optimization
> > >
> > > A try to decrement the number of tests for a match.
> > >
> > > Also a try to handle Hebrew documents. Unfor
On Tue, Nov 20, 2018 at 01:34:38PM -0500, Scott Kostyshak wrote:
> On Tue, Nov 20, 2018 at 02:43:22PM +0100, Kornel Benko wrote:
> > commit e9e3c50c650cddc816854a8e884f220639e1f3ef
> > Author: Kornel Benko
> > Date: Tue Nov 20 14:36:11 2018 +0100
> >
&g
On Tue, Nov 20, 2018 at 02:43:22PM +0100, Kornel Benko wrote:
> commit e9e3c50c650cddc816854a8e884f220639e1f3ef
> Author: Kornel Benko
> Date: Tue Nov 20 14:36:11 2018 +0100
>
> FindAdv: Optimization
>
> A try to decrement the number of tests for a match.
&g
Am Montag, 5. November 2018 11:33:41 CET schrieb Richard Kimberly Heck
:
> On 11/4/18 8:57 AM, Kornel Benko wrote:
> > commit aa68dcefa0aa4818b2d01d69e33db4906017ebfc
> > Author: Kornel Benko
> > Date: Sun Nov 4 14:54:06 2018 +0100
> >
> > Findadv: '
On 11/4/18 8:57 AM, Kornel Benko wrote:
> commit aa68dcefa0aa4818b2d01d69e33db4906017ebfc
> Author: Kornel Benko
> Date: Sun Nov 4 14:54:06 2018 +0100
>
> Findadv: 'Optimized' detection of matched string
>
> This is clearly a hack, because I don'
The only drawback I can see is the slowness on large paragraphs ( > 500 chars)
which have the requested features set in the search pattern.
Please try it out.
Kornel
signature.asc
Description: This is a digitally signed message part.
On Fri, Oct 19, 2018 at 11:08:20AM +0200, Kornel Benko wrote:
> Am Freitag, 19. Oktober 2018 10:52:16 CEST schrieb Kornel Benko
> :
> > > Compilation with -Werror seems to be broken again at d6cc58f4.
> > >
> > > Scott
> >
> > I didn't see any error or warning. Could you give me a better hint?
>
Am Freitag, 19. Oktober 2018 10:52:16 CEST schrieb Kornel Benko
:
> > Compilation with -Werror seems to be broken again at d6cc58f4.
> >
> > Scott
>
> I didn't see any error or warning. Could you give me a better hint?
>
Retried with gnu 7.1, I see it now too.
Kornel
signature.asc
De
Am Freitag, 19. Oktober 2018 00:12:49 CEST schrieb Scott Kostyshak
:
> On Sun, Oct 14, 2018 at 04:58:51PM -0400, Scott Kostyshak wrote:
> > On Sun, Oct 14, 2018 at 08:48:33PM +0200, Kornel Benko wrote:
> > > Am Sonntag, 14. Oktober 2018 10:59:08 CEST schrieb Scott Kostyshak
> > > :
> > > > On Sun
On Sun, Oct 14, 2018 at 04:58:51PM -0400, Scott Kostyshak wrote:
> On Sun, Oct 14, 2018 at 08:48:33PM +0200, Kornel Benko wrote:
> > Am Sonntag, 14. Oktober 2018 10:59:08 CEST schrieb Scott Kostyshak
> > :
> > > On Sun, Oct 14, 2018 at 08:11:19AM +0200, Kornel Benko wrote:
> > >
> > > > I agree.
On Mon, Oct 15, 2018 at 07:11:16AM +0200, Kornel Benko wrote:
> Am Sonntag, 14. Oktober 2018 16:58:51 CEST schrieb Scott Kostyshak
> :
> > On Sun, Oct 14, 2018 at 08:48:33PM +0200, Kornel Benko wrote:
> > > Am Sonntag, 14. Oktober 2018 10:59:08 CEST schrieb Scott Kostyshak
> > > :
> > > > On Sun,
Am Sonntag, 14. Oktober 2018 16:58:51 CEST schrieb Scott Kostyshak
:
> On Sun, Oct 14, 2018 at 08:48:33PM +0200, Kornel Benko wrote:
> > Am Sonntag, 14. Oktober 2018 10:59:08 CEST schrieb Scott Kostyshak
> > :
> > > On Sun, Oct 14, 2018 at 08:11:19AM +0200, Kornel Benko wrote:
> > >
> > > > I ag
On Sun, Oct 14, 2018 at 08:48:33PM +0200, Kornel Benko wrote:
> Am Sonntag, 14. Oktober 2018 10:59:08 CEST schrieb Scott Kostyshak
> :
> > On Sun, Oct 14, 2018 at 08:11:19AM +0200, Kornel Benko wrote:
> >
> > > I agree. OTOH, I need it while debugging. Do you know how to trick the
> > > compiler
Am Sonntag, 14. Oktober 2018 10:59:08 CEST schrieb Scott Kostyshak
:
> On Sun, Oct 14, 2018 at 08:11:19AM +0200, Kornel Benko wrote:
>
> > I agree. OTOH, I need it while debugging. Do you know how to trick the
> > compiler?
> > For now, I will remove the routine
>
> Maybe this?
>
> https://sta
On Sun, Oct 14, 2018 at 08:11:19AM +0200, Kornel Benko wrote:
> I agree. OTOH, I need it while debugging. Do you know how to trick the
> compiler?
> For now, I will remove the routine
Maybe this?
https://stackoverflow.com/a/3394268/1376404
Scott
signature.asc
Description: PGP signature
Am Samstag, 13. Oktober 2018 21:31:16 CEST schrieb Scott Kostyshak
:
> On Sun, Oct 14, 2018 at 12:41:12AM +0200, Kornel Benko wrote:
> > Am Samstag, 13. Oktober 2018 18:09:50 CEST schrieb Scott Kostyshak
> > :
> > > On Sat, Oct 13, 2018 at 11:34:04PM +0200, Kornel Benko wrote:
> > >
> > > > The
On Sun, Oct 14, 2018 at 12:41:12AM +0200, Kornel Benko wrote:
> Am Samstag, 13. Oktober 2018 18:09:50 CEST schrieb Scott Kostyshak
> :
> > On Sat, Oct 13, 2018 at 11:34:04PM +0200, Kornel Benko wrote:
> >
> > > The search time is O(n^2), n being the count of chars in a paragraph.
> > > Anyway, I
Am Samstag, 13. Oktober 2018 18:09:50 CEST schrieb Scott Kostyshak
:
> On Sat, Oct 13, 2018 at 11:34:04PM +0200, Kornel Benko wrote:
>
> > The search time is O(n^2), n being the count of chars in a paragraph.
> > Anyway, I was able
> > to restrict the search to paragraphs containing all the need
On Sat, Oct 13, 2018 at 11:34:04PM +0200, Kornel Benko wrote:
> The search time is O(n^2), n being the count of chars in a paragraph. Anyway,
> I was able
> to restrict the search to paragraphs containing all the needed features.
> So, if the search contains something with German and bold, but th
Benko wrote:
> > > > Am Donnerstag, 4. Oktober 2018 10:17:43 CEST schrieb Kornel Benko
> > > > :
> > > > > Both, lyx2.4 and lyx2.3
> > > > > To reproduce:
> > > > >
> > > > > 1.) Open (or create) a small lyx-file. (Sa
> > > :
> > > > Both, lyx2.4 and lyx2.3
> > > > To reproduce:
> > > >
> > > > 1.) Open (or create) a small lyx-file. (Say 3 lines)
> > > > 2.) select the whole buffer
> > > > 3.) in findadv search for a string (
t; > >
> > > 1.) Open (or create) a small lyx-file. (Say 3 lines)
> > > 2.) select the whole buffer
> > > 3.) in findadv search for a string (ignore format or not)
> > > ==> crash
> > >
> > > LASSERT() is called at
On Thu, Oct 04, 2018 at 10:27:17AM +0200, Kornel Benko wrote:
> Am Donnerstag, 4. Oktober 2018 10:17:43 CEST schrieb Kornel Benko
> :
> > Both, lyx2.4 and lyx2.3
> > To reproduce:
> >
> > 1.) Open (or create) a small lyx-file. (Say 3 lines)
> > 2.) select
Am Donnerstag, 4. Oktober 2018 10:17:43 CEST schrieb Kornel Benko
:
> Both, lyx2.4 and lyx2.3
> To reproduce:
>
> 1.) Open (or create) a small lyx-file. (Say 3 lines)
> 2.) select the whole buffer
> 3.) in findadv search for a string (ignore format or not)
> ==>
Both, lyx2.4 and lyx2.3
To reproduce:
1.) Open (or create) a small lyx-file. (Say 3 lines)
2.) select the whole buffer
3.) in findadv search for a string (ignore format or not)
==> crash
LASSERT() is called at lyxfind.cpp in stringifyFromForSearch()
LASSERT(cur.pos() &
Hi Tommaso,
Insert
The Brown Fox Jumps
with 'Fox' emphasized.
Searchstring = emphasized regex '[a-z]*':
Selecting 'Case sensitive' and 'ignore format' it works OK (finding 'he',
rown', 'ox', 'umps')
Selecting 'not ignore format' it finds wrongly ('F', 'ox') but it should be
'ox'
this one consistently failing:
> >
> > findadv-02-in.txt: FAILED
> >
> > will dig shortly (I'm going off-line a few hours).
>
> this is what I found:
>
> 1) started from re-running all the findadv-*.txt tests, and got
> all passing, EXCEPT 02, 08, 20, 21, re-04
>
On 03/05/2017 17:42, Tommaso Cucinotta wrote:
On 03/05/2017 17:37, Tommaso Cucinotta wrote:
Kornel, would you mind to re-run the tests ?
I have this one consistently failing:
findadv-02-in.txt: FAILED
will dig shortly (I'm going off-line a few hours).
this is
On 03/05/2017 17:42, Tommaso Cucinotta wrote:
On 03/05/2017 17:37, Tommaso Cucinotta wrote:
Kornel, would you mind to re-run the tests ?
I have this one consistently failing:
findadv-02-in.txt: FAILED
will dig shortly (I'm going off-line a few hours).
this is
Am Mittwoch, 3. Mai 2017 um 17:42:25, schrieb Tommaso Cucinotta
> On 03/05/2017 17:37, Tommaso Cucinotta wrote:
> > Kornel, would you mind to re-run the tests ?
>
> I have this one consistently failing:
>
> findadv-02-in.txt: FAILED
This one passes
On 03/05/2017 17:37, Tommaso Cucinotta wrote:
Kornel, would you mind to re-run the tests ?
I have this one consistently failing:
findadv-02-in.txt: FAILED
will dig shortly (I'm going off-line a few hours).
T.
Am Mittwoch, 3. Mai 2017 um 17:20:17, schrieb Tommaso Cucinotta
> commit 100a7ee22ff44fd101af4e52bdb3d632244ba258
> Author: Tommaso Cucinotta
> Date: Wed May 3 16:37:11 2017 +0200
>
> Revert "findadv: hide word-findadv verb from the mini-buffer"
>
Le 03/05/2017 à 17:37, Tommaso Cucinotta a écrit :
As for the "word-findadv" verb, I don't have strong opinions about
hiding that, and
I don't know for sure what these "Edit" vs "Hidden" etc. flags are for
:(...
It is to know in what group the function
On 03/05/2017 11:26, Jean-Marc Lasgouttes wrote:
3610cdf66944dc790e2e3df666e99f33c45b1ede
Yes, this is much less surprising than to two other commits.
this is now (correctly) fixed in
commit cf6bbe21
Author: Tommaso Cucinotta
Date: Wed May 3 17:32:31 2017 +0200
findadv: amend
my bad, quite blind commits without testing, I just reverted the suppression of the
"word-findadv" lfun name,
but, as you just pointed out, it was actually the crash fix to break all tests
:-)! (just confirmed that
reverting that as well recovers a working findadv pane)
T.
Am Dienstag, 2. Mai 2017 um 17:56:21, schrieb Tommaso Cucinotta
> On 02/05/2017 11:19, Kornel Benko wrote:
> > Start lyx
> > select new file
> > type anything e.g. 'abcd'
> > Goto home position
> > in minibuffer type word-findadv a
> > Any (or no
Le 03/05/2017 à 10:44, Kornel Benko a écrit :
Testing manually, I see, that replace is not working. (E.g. findadv does not
find anything)
Hm, test passes after reverting also 3610cdf66944dc790e2e3df666e99f33c45b1ede
Yes, this is much less surprising than to two other commits.
JMarc
ng like the attached patch is needed!?
> >>
> >> Yes, I just did that.
> >>
> >> JMarc
> >
> > You did, but without test.
> > # ctest -R findadv
> > ...
> > 10% tests passed, 26 tests failed out of 29
>
> Indeed, be
Le 03/05/2017 à 10:05, Kornel Benko a écrit :
Am Mittwoch, 3. Mai 2017 um 09:41:08, schrieb Jean-Marc Lasgouttes
Le 03/05/2017 à 07:48, Stephan Witt a écrit :
Something like the attached patch is needed!?
Yes, I just did that.
JMarc
You did, but without test.
# ctest -R findadv
Am Mittwoch, 3. Mai 2017 um 09:41:08, schrieb Jean-Marc Lasgouttes
> Le 03/05/2017 à 07:48, Stephan Witt a écrit :
> > Something like the attached patch is needed!?
>
> Yes, I just did that.
>
> JMarc
You did, but without test.
# ctest -R findadv
...
Le 03/05/2017 à 07:48, Stephan Witt a écrit :
Something like the attached patch is needed!?
Yes, I just did that.
JMarc
5/2017 12:23, Kornel Benko wrote:
> > commit c4c989b9c8d687e6f52d44fc411cf2ad14b2f8c1
> > Author: Kornel Benko
> > Date: Tue May 2 12:22:09 2017 +0200
> >
> > Added testcase for crash with using function word-findadv
> > ---
Kornel
signature.asc
Description: This is a digitally signed message part.
Am 03.05.2017 um 01:34 schrieb Tommaso Cucinotta :
>
> commit 8c10182962efa643edfcfbe64fc830b5fc0d9a65
> Author: Tommaso Cucinotta
> Date: Wed May 3 01:29:36 2017 +0200
>
>findadv: hide word-findadv verb from the mini-buffer
>
>The current set of options to
hmm.., not sure if [8c101829/lyxgit] would need a rollback then...
T.
On 02/05/2017 12:23, Kornel Benko wrote:
commit c4c989b9c8d687e6f52d44fc411cf2ad14b2f8c1
Author: Kornel Benko
Date: Tue May 2 12:22:09 2017 +0200
Added testcase for crash with using function word-findadv
Le 02/05/2017 à 18:15, Tommaso Cucinotta a écrit :
On 02/05/2017 18:00, Jean-Marc Lasgouttes wrote:
Why not make the function internal, i.e. give it an empty name like
LFUN_FINISHED_BACKWARD?
u mean, just this [1] ? or, do we need "Hidden" ?
I would say we should use both.
JMarc
On 02/05/2017 18:10, Kornel Benko wrote:
It would still be nice to have the possibility to use minibuffer for scripted
findadv tests.
(The reason is that the minibuffer commands are language independent)
would make sense as a feature enh request, needs a syntax rethinking.
This is what we
.cpp b/src/LyXAction.cpp
index e9f45f58..4f65266d 100644
--- a/src/LyXAction.cpp
+++ b/src/LyXAction.cpp
@@ -4069,7 +4069,7 @@ void LyXAction::init()
* \li Origin: Tommaso, Nov 15 2007
* \endvar
*/
- { LFUN_WORD_FINDADV, "word-findadv", ReadO
Am Dienstag, 2. Mai 2017 um 17:56:21, schrieb Tommaso Cucinotta
> On 02/05/2017 11:19, Kornel Benko wrote:
> > Start lyx
> > select new file
> > type anything e.g. 'abcd'
> > Goto home position
> > in minibuffer type word-findadv a
> > Any (or no
ch options as a string; the regular word-find can be
hand-made, but the one needed by the word-findadv() requires a
multi-line options string including the name of the search and replace
internal buffers within theBuffers(), which are generally things
internal to LyX and not exposed to the user...
On 02/05/2017 11:19, Kornel Benko wrote:
Start lyx
select new file
type anything e.g. 'abcd'
Goto home position
in minibuffer type word-findadv a
Any (or no at all) parameter to this function leads to crash.
This is independent of active search dialog.
(would be great to have an au
On 02/05/2017 11:19, Kornel Benko wrote:
Start lyx
select new file
type anything e.g. 'abcd'
Goto home position
in minibuffer type word-findadv a
Any (or no at all) parameter to this function leads to crash.
confirmed...
T.
Start lyx
select new file
type anything e.g. 'abcd'
Goto home position
in minibuffer type word-findadv a
Any (or no at all) parameter to this function leads to crash.
This is independent of active search dialog.
For comparision, the function 'word-find' does not crash, but do
Am Dienstag, 18. April 2017 um 01:46:46, schrieb Tommaso Cucinotta
> On 18/04/2017 01:04, Kornel Benko wrote:
> >> So, I'd be in favor of using -SIGQUIT immediately on "TestEnd" in
> >> keytest.py, falling back to "kill -9" if LyX doesn't quit within 0.5
> >> secs ?
> >> (without adding th
Le 17/04/2017 à 23:35, Tommaso Cucinotta a écrit :
that's one of the drawbacks of a clean shutdown, we'd have to wait for
it, slowing down tests. Perhaps alternate ways might be to just kill -9
as it is already now, but introduce:
-) either a command-line option to force lyxerr << flush on every
Am Dienstag, 18. April 2017 um 01:46:46, schrieb Tommaso Cucinotta
> On 18/04/2017 01:04, Kornel Benko wrote:
> >> So, I'd be in favor of using -SIGQUIT immediately on "TestEnd" in
> >> keytest.py, falling back to "kill -9" if LyX doesn't quit within 0.5
> >> secs ?
> >> (without adding th
On 18/04/2017 01:04, Kornel Benko wrote:
So, I'd be in favor of using -SIGQUIT immediately on "TestEnd" in keytest.py, falling
back to "kill -9" if LyX doesn't quit within 0.5 secs ?
(without adding the \Ax work-around in test cases, that should not bee needed
anymore).
It may be too ear
Am Dienstag, 18. April 2017 um 00:03:47, schrieb Tommaso Cucinotta
> On 17/04/2017 23:35, Tommaso Cucinotta wrote:
> > -) or flush lyxerr on signal, and shutdown with that signal.
>
> in the end, it seems to me that the best is to close the application with:
>
>kill -SIGQUIT
>
> So, I remo
Am Montag, 17. April 2017 um 23:35:03, schrieb Tommaso Cucinotta
> On 17/04/2017 21:24, Kornel Benko wrote:
> >> Btw, instead of ending each test with \Ax, what about ending them with \Cq
> >> ? (shortcut for File->Quit) ?
> >
> > Or \Axlyx-quit\[Return], this is language independent. OTOH, mayb
On 17/04/2017 23:35, Tommaso Cucinotta wrote:
-) or flush lyxerr on signal, and shutdown with that signal.
in the end, it seems to me that the best is to close the application with:
kill -SIGQUIT
So, I removed the sleep(0.5) before kill -9, and that way tests fail.
However, turning the sign
On 17/04/2017 21:24, Kornel Benko wrote:
Btw, instead of ending each test with \Ax, what about ending them with \Cq ?
(shortcut for File->Quit) ?
Or \Axlyx-quit\[Return], this is language independent. OTOH, maybe we have to
wait before sending it.
I tried, and lyx often missed some keystrokes
Am Montag, 17. April 2017 um 20:31:07, schrieb Tommaso Cucinotta
> On 17/04/2017 12:50, Kornel Benko wrote:
> > Am Montag, 17. April 2017 um 12:39:26, schrieb Kornel Benko
> >>> Perhaps the issue is just that we terminate LyX with "kill -9" in
> >>> keytest.py [1]. Would you please try replacin
e kill -9 with an attempt of clean exit ? e.g.,
see the attachment.
Thanks,
T.
diff --git a/development/autotests/findadv-03-in.txt b/development/autotests/findadv-03-in.txt
index 640f327a..193a9946 100644
--- a/development/autotests/findadv-03-in.txt
+++ b/development/autotests/findadv-03-
Am Montag, 17. April 2017 um 12:39:26, schrieb Kornel Benko
> > Perhaps the issue is just that we terminate LyX with "kill -9" in
> > keytest.py [1]. Would you please try replacing that "-9" with "-SIGQUIT" or
> > similar, and see what happens ? (after rolling back the \Ax, which, from
> > what
Am Montag, 17. April 2017 um 12:16:18, schrieb Tommaso Cucinotta
> On 17/04/2017 11:59, Kornel Benko wrote:
> > I think that is because of missing flush of stderr. \Ax gives more output
> > and that saves us.
>
> weird: when you << endl, it should auto-flush, but sometimes that behavior is
> d
On 17/04/2017 11:59, Kornel Benko wrote:
I think that is because of missing flush of stderr. \Ax gives more output and
that saves us.
weird: when you << endl, it should auto-flush, but sometimes that behavior is
disabled when redirecting to a file. Also, in such case the standard prescribes
Am Montag, 17. April 2017 um 11:51:57, schrieb Tommaso Cucinotta
> On 17/04/2017 10:37, Kornel Benko wrote:
> >> So I added 'KK: \Ax' as the last command before 'TestEnd' to output mode
> >> debug msgs.
> >> Now this test passes. (See attache
1 - 100 of 210 matches
Mail list logo
