Re: [Cvslog] r20707 - /lyx-devel/trunk/src/PDFOptions.cpp

2007-10-04 Thread Jean-Marc Lasgouttes
I do no know much about hyperref, but these hanges look strange to me. Can someone comment? + // since LyX uses unicode, also set the PDF strings to unicode strings with the + // hyperref option unicode + opt += unicode=true,\n ; What happens when the output is _not_ unicode?

Re: [Cvslog] r20707 - /lyx-devel/trunk/src/PDFOptions.cpp

2007-10-04 Thread Pavel Sanda
I do no know much about hyperref, but these hanges look strange to me. Can someone comment? look on the yeasterday's thread Changeset 20707. i had exactly the same concerns. + // since LyX uses unicode, also set the PDF strings to unicode strings with the + // hyperref option

Re: [Cvslog] r20707 - /lyx-devel/trunk/src/PDFOptions.cpp

2007-10-04 Thread Jean-Marc Lasgouttes
Pavel Sanda [EMAIL PROTECTED] writes: I do no know much about hyperref, but these hanges look strange to me. Can someone comment? look on the yeasterday's thread Changeset 20707. i had exactly the same concerns. Yes, I saw it too late. JMarc

Re: [Cvslog] r20707 - /lyx-devel/trunk/src/PDFOptions.cpp

2007-10-04 Thread José Matos
On Thursday 04 October 2007 08:14:22 Jean-Marc Lasgouttes wrote: Why do this even if the author did not ask for it? Shouldn't it be an additional option? I agree with Jean-Marc here, and I also think that we should set this option to be enabled by default. In general, adding options behind

Re: [Cvslog] r20707 - /lyx-devel/trunk/src/PDFOptions.cpp

2007-10-04 Thread Edwin Leuven
José Matos wrote: In general, adding options behind the user's back looks bad to me. +2

Re: [Cvslog] r20707 - /lyx-devel/trunk/src/PDFOptions.cpp

2007-10-04 Thread Pavel Sanda
On Thursday 04 October 2007 08:14:22 Jean-Marc Lasgouttes wrote: Why do this even if the author did not ask for it? Shouldn't it be an additional option? I agree with Jean-Marc here, and I also think that we should set this option to be enabled by default. it was my original

Re: [Cvslog] r20707 - /lyx-devel/trunk/src/PDFOptions.cpp

2007-10-04 Thread Uwe Stöhr
+ // since LyX uses unicode, also set the PDF strings to unicode strings with the + // hyperref option unicode + opt += unicode=true,\n ; What happens when the output is _not_ unicode? How that? What does this option do exactly? Option pdfencoding The PDF format allows two

Re: [Cvslog] r20707 - /lyx-devel/trunk/src/PDFOptions.cpp

2007-10-04 Thread Pavel Sanda
iT IS SAVE TO USE UNICODE IN ALL CASES. I tested this carefully I think. I hope, because if some trouble bubbles up user has no reasonable way how to get rid of it then. Pavel

Re: [Cvslog] r20707 - /lyx-devel/trunk/src/PDFOptions.cpp

2007-10-04 Thread Jean-Marc Lasgouttes
Uwe Stöhr [EMAIL PROTECTED] writes: + // since LyX uses unicode, also set the PDF strings to unicode strings with the + // hyperref option unicode + opt += unicode=true,\n ; What happens when the output is _not_ unicode? How that? So when a document is in, say, latin2,

Re: [Cvslog] r20707 - /lyx-devel/trunk/src/PDFOptions.cpp

2007-10-04 Thread Uwe Stöhr
Jean-Marc Lasgouttes schrieb: So when a document is in, say, latin2, the pdf strings will be in correct unicode? As far as I tested, yes. iT IS SAVE TO USE UNICODE IN ALL CASES. I tested this carefully I think. And nevertheless, whenever the user uses not latin1 as encoding, unicode must

Re: [Cvslog] r20707 - /lyx-devel/trunk/src/PDFOptions.cpp

2007-10-04 Thread Pavel Sanda
Before people start to add their +1, please read my statement in http://www.mail-archive.com/lyx-devel@lists.lyx.org/msg129100.html I read it, but I still prefer a checkbox, even if it defaults to on. As for the previous option, if it was so great, it would default to true in hyperref. Fine

Re: [Cvslog] r20707 - /lyx-devel/trunk/src/PDFOptions.cpp

2007-10-04 Thread Jean-Marc Lasgouttes
I do no know much about hyperref, but these hanges look strange to me. Can someone comment? > + // since LyX uses unicode, also set the PDF strings to unicode strings > with the > + // hyperref option "unicode" > + opt += "unicode=true,\n "; What happens when the output is _not_

Re: [Cvslog] r20707 - /lyx-devel/trunk/src/PDFOptions.cpp

2007-10-04 Thread Pavel Sanda
> I do no know much about hyperref, but these hanges look strange to me. > Can someone comment? look on the yeasterday's thread Changeset 20707. i had exactly the same concerns. > > + // since LyX uses unicode, also set the PDF strings to unicode strings > > with the > > + // hyperref

Re: [Cvslog] r20707 - /lyx-devel/trunk/src/PDFOptions.cpp

2007-10-04 Thread Jean-Marc Lasgouttes
Pavel Sanda <[EMAIL PROTECTED]> writes: >> I do no know much about hyperref, but these hanges look strange to me. >> Can someone comment? > > look on the yeasterday's thread Changeset 20707. i had exactly the same > concerns. > Yes, I saw it too late. JMarc

Re: [Cvslog] r20707 - /lyx-devel/trunk/src/PDFOptions.cpp

2007-10-04 Thread José Matos
On Thursday 04 October 2007 08:14:22 Jean-Marc Lasgouttes wrote: > Why do this even if the author did not ask for it? Shouldn't it be an > additional option? I agree with Jean-Marc here, and I also think that we should set this option to be enabled by default. > In general, adding options

Re: [Cvslog] r20707 - /lyx-devel/trunk/src/PDFOptions.cpp

2007-10-04 Thread Edwin Leuven
José Matos wrote: In general, adding options behind the user's back looks bad to me. +2

Re: [Cvslog] r20707 - /lyx-devel/trunk/src/PDFOptions.cpp

2007-10-04 Thread Pavel Sanda
> On Thursday 04 October 2007 08:14:22 Jean-Marc Lasgouttes wrote: > > Why do this even if the author did not ask for it? Shouldn't it be an > > additional option? > > I agree with Jean-Marc here, and I also think that we should set this > option > to be enabled by default. it was my

Re: [Cvslog] r20707 - /lyx-devel/trunk/src/PDFOptions.cpp

2007-10-04 Thread Uwe Stöhr
> > + // since LyX uses unicode, also set the PDF strings to unicode strings >> with the >> + // hyperref option "unicode" >> + opt += "unicode=true,\n "; > > What happens when the output is _not_ unicode? How that? > What does this option do exactly? Option pdfencoding The PDF

Re: [Cvslog] r20707 - /lyx-devel/trunk/src/PDFOptions.cpp

2007-10-04 Thread Pavel Sanda
> iT IS SAVE TO USE UNICODE IN ALL CASES. I tested this carefully I think. I hope, because if some trouble bubbles up user has no reasonable way how to get rid of it then. Pavel

Re: [Cvslog] r20707 - /lyx-devel/trunk/src/PDFOptions.cpp

2007-10-04 Thread Jean-Marc Lasgouttes
Uwe Stöhr <[EMAIL PROTECTED]> writes: >> > + // since LyX uses unicode, also set the PDF strings to unicode >> > strings >>> with the >>> + // hyperref option "unicode" >>> + opt += "unicode=true,\n "; >> >> What happens when the output is _not_ unicode? > > How that? So when a

Re: [Cvslog] r20707 - /lyx-devel/trunk/src/PDFOptions.cpp

2007-10-04 Thread Uwe Stöhr
Jean-Marc Lasgouttes schrieb: So when a document is in, say, latin2, the pdf strings will be in correct unicode? As far as I tested, yes. iT IS SAVE TO USE UNICODE IN ALL CASES. I tested this carefully I think. And nevertheless, whenever the user uses not latin1 as encoding, unicode must

Re: [Cvslog] r20707 - /lyx-devel/trunk/src/PDFOptions.cpp

2007-10-04 Thread Pavel Sanda
>>> Before people start to add their "+1", please read my statement in >>> http://www.mail-archive.com/lyx-devel@lists.lyx.org/msg129100.html >> I read it, but I still prefer a checkbox, even if it defaults to on. >> As for the previous option, if it was so great, it would default to >> true in